28611 2009-08-21 04:39:01 -0700 Middle click panning icon is offset by 3 pixels 2009-08-21 12:02:33 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P5 Trivial --- 0 philippe.beauchamp webkit-unassigned aroben bweinstein eric hyatt oldest_to_newest 141859 0 philippe.beauchamp 2009-08-21 04:39:01 -0700 Reproducing the bug: Open any Web page Click on the Middle mouse button to start panning without moving the mouse. Two Panning icons overlap with a 3x3pixels offset. Panning arrows are also offset by 3x3 pixels during panning action. 141861 1 38368 philippe.beauchamp 2009-08-21 05:10:05 -0700 Created attachment 38368 Changed middlePanningCursor icon size constant and hotspot 141883 2 eric 2009-08-21 09:19:01 -0700 I don't think you actually want hyatt here. :) I'm surprised we don't get the dimensions from the icon directly instead of hard-coding them. This looks fine, but I'd like one of the windows folks to say OK. (When they do, they can also mark this commit-queue+ since you're not a committer.) 141899 3 38368 aroben 2009-08-21 09:55:40 -0700 Comment on attachment 38368 Changed middlePanningCursor icon size constant and hotspot Looks fine to me, though I agree it isn't great that we are hard-coding these numbers. 141927 4 38368 eric 2009-08-21 12:02:29 -0700 Comment on attachment 38368 Changed middlePanningCursor icon size constant and hotspot Clearing flags on attachment: 38368 Committed r47636: <http://trac.webkit.org/changeset/47636> 141928 5 eric 2009-08-21 12:02:33 -0700 All reviewed patches have been landed. Closing bug. 38368 2009-08-21 05:10:05 -0700 2009-08-21 12:02:28 -0700 Changed middlePanningCursor icon size constant and hotspot MiddleClickPanningIconOffset.txt text/plain 1719 philippe.beauchamp SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzYyOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDgtMjEgIFBoaWxpcHBlIEJlYXVjaGFtcCAgPHBoaWxpcHBl LmJlYXVjaGFtcEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTWlkZGxlIGNsaWNrIHBhbm5pbmcgaWNvbiBpcyBvZmZzZXQgYnkgMyBw aXhlbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4 NjExCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgcGFuSWNv blNpemVMZW5ndGggaW5pdGlhbGl6ZWQgdG8gMjAgaW5zdGVhZCBvZiAxNiB0byBtYXRjaCBpY29u IGRpbWVuc2lvbiAoMiBwaXhlbHMgb2Zmc2V0KQorICAgICAgICAqIHBsYXRmb3JtL3dpbi9DdXJz b3JXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6bWlkZGxlUGFubmluZ0N1cnNvcik6CisgICAg ICAgIEhvdHNwb3QgaW5pdGlhbGl6ZWQgdG8gKDgsOCkgaW5zdGVhZCBvZiAoNyw3KSAob25lIHBp eGVsIG9mZnNldCkKKyAgICAgICAgCiAyMDA5LTA4LTIxICBBcml5YSBIaWRheWF0ICA8YXJpeWEu aGlkYXlhdEBub2tpYS5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkLCBidWlsZCBmaXggYWZ0 ZXIgcjQ3NTgwLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCShyZXZpc2lvbiA0NzUyOSkK KysrIFdlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3 OCw3ICs0NzgsNyBAQCB2b2lkIFNjcm9sbFZpZXc6OnVwZGF0ZVNjcm9sbGJhcnMoY29uc3QgCiAg ICAgbV9pblVwZGF0ZVNjcm9sbGJhcnMgPSBmYWxzZTsKIH0KIAotY29uc3QgaW50IHBhbkljb25T aXplTGVuZ3RoID0gMjA7Citjb25zdCBpbnQgcGFuSWNvblNpemVMZW5ndGggPSAxNjsKIAogdm9p ZCBTY3JvbGxWaWV3OjpzY3JvbGxDb250ZW50cyhjb25zdCBJbnRTaXplJiBzY3JvbGxEZWx0YSkK IHsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vd2luL0N1cnNvcldpbi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ3Vyc29yV2luLmNwcAkocmV2aXNpb24gNDc1MjkpCisr KyBXZWJDb3JlL3BsYXRmb3JtL3dpbi9DdXJzb3JXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NzksNyArMjc5LDcgQEAgY29uc3QgQ3Vyc29yJiByb3dSZXNpemVDdXJzb3IoKQogCiBjb25zdCBD dXJzb3ImIG1pZGRsZVBhbm5pbmdDdXJzb3IoKQogewotICAgIHN0YXRpYyBjb25zdCBDdXJzb3Ig YyA9IGxvYWRDdXJzb3JCeU5hbWUoInBhbkljb24iLCA3LCA3KTsKKyAgICBzdGF0aWMgY29uc3Qg Q3Vyc29yIGMgPSBsb2FkQ3Vyc29yQnlOYW1lKCJwYW5JY29uIiwgOCwgOCk7CiAgICAgcmV0dXJu IGM7CiB9CiAK