286061 2025-01-16 06:02:20 -0800 [GLib] Remove all GLIB_CHECK_VERSION conditionals 2025-01-23 15:34:15 -0800 1 1 1 Unclassified WebKit Platform Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez bugs-noreply magomez webkit-bug-importer oldest_to_newest 2087740 0 aperez 2025-01-16 06:02:20 -0800 The oldest Linux distribution we need to support in 2025 is Ubuntu 22.04, which ships GLib 2.72.x - and all the GLIB_CHECK_VERSION condiotionals are for previos versions: % rg -tcpp -F '#if GLIB_CHECK_VERSION(' --no-filename Source/{WTF,JavaScriptCore/,Web{Core,Kit}} | sort -u #if GLIB_CHECK_VERSION(2, 59, 0) #if GLIB_CHECK_VERSION(2, 60, 0) #if GLIB_CHECK_VERSION(2, 69, 0) #if GLIB_CHECK_VERSION(2, 69, 1) % rg -tcpp -F '#if GLIB_CHECK_VERSION(' Source/{WTF,JavaScriptCore/,Web{Core,Kit}} | wl -l 24 % This means that we could change Source/cmake/Options{GTK,WPE}.cmake to check for GLib 2.69.1+, and drop all the GLib-version conditional blocks. Dependencies policy: https://docs.webkit.org/Ports/WebKitGTK%20and%20WPE%20WebKit/DependenciesPolicy.html 2087744 1 aperez 2025-01-16 06:22:13 -0800 Pull request: https://github.com/WebKit/WebKit/pull/39129 2089370 2 ews-feeder 2025-01-23 15:33:47 -0800 Committed 289318@main (85b637b69f1c): <https://commits.webkit.org/289318@main> Reviewed commits have been landed. Closing PR #39129 and removing active labels. 2089371 3 webkit-bug-importer 2025-01-23 15:34:15 -0800 <rdar://problem/143526406>