285562 2025-01-07 16:27:50 -0800 Make the baseline of RenderTextControl consistent with or without text 2025-06-26 09:40:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED BrowserCompat, InRadar P2 Normal --- 1 ahmad.saleem792 zalan bfulgham karlcow koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 2085607 0 ahmad.saleem792 2025-01-07 16:27:50 -0800 Hi Team, While going through Blink's commit, I came across failing test case and also difference in Safari / WebKit behavior. Test Case: https://output.jsbin.com/mewiya ^ First input shift when you add text via clicking on button in Safari, while it should not cause layout shift when adding text and match other browsers like Chrome Canary 133 and Firefox Nightly 136. Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/a7c29f036fe5a14424096c7b021285b7faa1799f Just raising, so we can fix it. Thanks! 2087277 1 webkit-bug-importer 2025-01-14 16:28:33 -0800 <rdar://problem/142918746> 2125935 2 475653 zalan 2025-06-25 20:04:40 -0700 Created attachment 475653 [fast-cq]Patch 2125957 3 ews-feeder 2025-06-25 21:33:28 -0700 ### Safer C++ Build [#41632](https://ews-build.webkit.org/#/builders/120/builds/41632) () :x: Found [11 failing files with 16 issues](https://ews-build.s3-us-west-2.amazonaws.com/macOS-Safer-CPP-Checks-EWS/475653-41632/scan-build-output/new-results.html). Please address these issues before landing. See [WebKit Guidelines for Safer C++ Programming](https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines). (cc @rniwa) 2126037 4 ews-feeder 2025-06-26 09:40:18 -0700 Committed 296666@main (7ace4f23eca0): <https://commits.webkit.org/296666@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 475653. 475653 2025-06-25 20:04:40 -0700 2025-06-26 09:40:20 -0700 [fast-cq]Patch bug-285562-20250625200439.patch text/plain 5303 zalan RnJvbSBiYWM3MzkyYTY5NTI0NDkxYzE4NTkzMmIxMzlhMjU3ZTAxZTQ3ZjVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFdlZCwgMjUgSnVuIDIwMjUgMjA6MDE6MjEgLTA3MDAKU3ViamVjdDogW1BBVENIXSBNYWtlIHRo ZSBiYXNlbGluZSBvZiBSZW5kZXJUZXh0Q29udHJvbCBjb25zaXN0ZW50IHdpdGggb3IKIHdpdGhv dXQgdGV4dCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg1NTYyCiA8 cmRhcjovL3Byb2JsZW0vMTQyOTE4NzQ2PgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpG aXJzdCBhbmQgbGFzdCBiYXNlbGluZSBmdW5jdGlvbnMgb24gYmxhbmsgYmxvY2tzIHdpdGggImhh c0xpbmVJZkVtcHR5IiBzaG91bGQgYmVoYXZlIGxpa2UgUmVuZGVyQmxvY2tGbG93OjppbmxpbmVC bG9ja0Jhc2VsaW5lLgoKKFRlc3QgY2FzZSBjcmVkaXQgZ29lcyB0byBodHRwczovL2Nocm9taXVt Lmdvb2dsZXNvdXJjZS5jb20vY2hyb21pdW0vc3JjLmdpdC8rL2E3YzI5ZjAzNmZlNWExNDQyNDA5 NmM3YjAyMTI4NWI3ZmFhMTc5OWYpCgoqIExheW91dFRlc3RzL2Zhc3QvaW5saW5lL21pc21hdGNo aW5nLWlubGluZS1iYXNlbGluZS1hbmQtZW1wdHktY29udGVudC1leHBlY3RlZC5odG1sOiBBZGRl ZC4KKiBMYXlvdXRUZXN0cy9mYXN0L2lubGluZS9taXNtYXRjaGluZy1pbmxpbmUtYmFzZWxpbmUt YW5kLWVtcHR5LWNvbnRlbnQuaHRtbDogQWRkZWQuCiogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrRmxvdy5jcHA6CihXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OmZpcnN0TGlu ZUJhc2VsaW5lIGNvbnN0KToKKFdlYkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6bGFzdExpbmVCYXNl bGluZSBjb25zdCk6Ci0tLQogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxv dy5jcHAgIHwgMTQgKysrKystCiAuLi5lLWJhc2VsaW5lLWFuZC1lbXB0eS1jb250ZW50LWV4cGVj dGVkLmh0bWwgfCA0NyArKysrKysrKysrKysrKysrKysrCiAuLi5pbmctaW5saW5lLWJhc2VsaW5l LWFuZC1lbXB0eS1jb250ZW50Lmh0bWwgfCA0NyArKysrKysrKysrKysrKysrKysrCiAzIGZpbGVz IGNoYW5nZWQsIDEwNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUg MTAwNjQ0IExheW91dFRlc3RzL2Zhc3QvaW5saW5lL21pc21hdGNoaW5nLWlubGluZS1iYXNlbGlu ZS1hbmQtZW1wdHktY29udGVudC1leHBlY3RlZC5odG1sCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5 b3V0VGVzdHMvZmFzdC9pbmxpbmUvbWlzbWF0Y2hpbmctaW5saW5lLWJhc2VsaW5lLWFuZC1lbXB0 eS1jb250ZW50Lmh0bWwKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQmxvY2tGbG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zs b3cuY3BwCmluZGV4IDM5MjVhOWI4ODQzZi4uYjBkZjMxYjM4YzgxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcApAQCAtMzI1NCw4ICszMjU0LDEzIEBA IHN0ZDo6b3B0aW9uYWw8TGF5b3V0VW5pdD4gUmVuZGVyQmxvY2tGbG93OjpmaXJzdExpbmVCYXNl bGluZSgpIGNvbnN0CiAgICAgaWYgKCFjaGlsZHJlbklubGluZSgpKQogICAgICAgICByZXR1cm4g UmVuZGVyQmxvY2s6OmZpcnN0TGluZUJhc2VsaW5lKCk7CiAKLSAgICBpZiAoIWhhc0xpbmVzKCkp CisgICAgaWYgKCFoYXNMaW5lcygpKSB7CisgICAgICAgIGlmIChoYXNMaW5lSWZFbXB0eSgpKSB7 CisgICAgICAgICAgICBhdXRvJiBmb250TWV0cmljcyA9IGZpcnN0TGluZVN0eWxlKCkubWV0cmlj c09mUHJpbWFyeUZvbnQoKTsKKyAgICAgICAgICAgIHJldHVybiB7IExheW91dFVuaXQoYm9yZGVy QW5kUGFkZGluZ0JlZm9yZSgpICsgZm9udE1ldHJpY3MuaW50QXNjZW50KCkgKyAoZmlyc3RMaW5l U3R5bGUoKS5jb21wdXRlZExpbmVIZWlnaHQoKSAtIGZvbnRNZXRyaWNzLmludEhlaWdodCgpKSAv IDIpIH07CisgICAgICAgIH0KICAgICAgICAgcmV0dXJuIHsgfTsKKyAgICB9CiAKICAgICBpZiAo YXV0byogbGluZUxheW91dCA9IHRoaXMtPmlubGluZUxheW91dCgpKQogICAgICAgICByZXR1cm4g TGF5b3V0VW5pdCB7IGZsb29yVG9JbnQobGluZUxheW91dC0+Zmlyc3RMaW5lUGh5c2ljYWxCYXNl bGluZSgpKSB9OwpAQCAtMzI3NSw4ICszMjgwLDEzIEBAIHN0ZDo6b3B0aW9uYWw8TGF5b3V0VW5p dD4gUmVuZGVyQmxvY2tGbG93OjpsYXN0TGluZUJhc2VsaW5lKCkgY29uc3QKICAgICBpZiAoIWNo aWxkcmVuSW5saW5lKCkpCiAgICAgICAgIHJldHVybiBSZW5kZXJCbG9jazo6bGFzdExpbmVCYXNl bGluZSgpOwogCi0gICAgaWYgKCFoYXNMaW5lcygpKQorICAgIGlmICghaGFzTGluZXMoKSkgewor ICAgICAgICBpZiAoaGFzTGluZUlmRW1wdHkoKSkgeworICAgICAgICAgICAgYXV0byYgZm9udE1l dHJpY3MgPSBzdHlsZSgpLm1ldHJpY3NPZlByaW1hcnlGb250KCk7CisgICAgICAgICAgICByZXR1 cm4geyBMYXlvdXRVbml0KGJvcmRlckFuZFBhZGRpbmdCZWZvcmUoKSArIGZvbnRNZXRyaWNzLmlu dEFzY2VudCgpICsgKHN0eWxlKCkuY29tcHV0ZWRMaW5lSGVpZ2h0KCkgLSBmb250TWV0cmljcy5p bnRIZWlnaHQoKSkgLyAyKSB9OworICAgICAgICB9CiAgICAgICAgIHJldHVybiB7IH07CisgICAg fQogCiAgICAgaWYgKGF1dG8qIGxpbmVMYXlvdXQgPSBpbmxpbmVMYXlvdXQoKSkKICAgICAgICAg cmV0dXJuIExheW91dFVuaXQgeyBmbG9vclRvSW50KGxpbmVMYXlvdXQtPmxhc3RMaW5lUGh5c2lj YWxCYXNlbGluZSgpKSB9OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUvbWlz bWF0Y2hpbmctaW5saW5lLWJhc2VsaW5lLWFuZC1lbXB0eS1jb250ZW50LWV4cGVjdGVkLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS9taXNtYXRjaGluZy1pbmxpbmUtYmFzZWxpbmUtYW5k LWVtcHR5LWNvbnRlbnQtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAuLjNhNjM0NzM0Yzk1OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvaW5saW5lL21pc21hdGNoaW5nLWlubGluZS1iYXNlbGluZS1hbmQtZW1wdHktY29udGVu dC1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsNDcgQEAKKzwhRE9DVFlQRSBodG1sPgorPHN0eWxl PgorKiB7CisgIGNvbG9yOiB0cmFuc3BhcmVudDsKK30KKwordHIgeworICB2ZXJ0aWNhbC1hbGln bjogYmFzZWxpbmU7Cit9CisKKy5ibG9jayBpbnB1dCwgLmJsb2NrIHRleHRhcmVhIHsKKyAgZGlz cGxheTpibG9jazsKK30KKzwvc3R5bGU+CisKKzx0YWJsZT4KKzx0cj4KKyAgPHRkPlhZWmdoPC90 ZD4KKyAgPHRkPjxpbnB1dCB2YWx1ZT0iYWJjIj48L3RkPgorICA8dGQ+PGlucHV0IHZhbHVlPSJh YmMiPjwvdGQ+Cis8L3RyPgorPHRyIGNsYXNzPSJibG9jayI+CisgIDx0ZD5YWVpnaDwvdGQ+Cisg IDx0ZD48aW5wdXQgdmFsdWU9ImFiYyI+PC90ZD4KKyAgPHRkPjxpbnB1dCB2YWx1ZT0iYWJjIj48 L3RkPgorPC90cj4KKzx0cj4KKyAgPHRkPlhZWmdoPC90ZD4KKyAgPHRkPjx0ZXh0YXJlYT5hYmM8 L3RleHRhcmVhPjwvdGQ+CisgIDx0ZD48dGV4dGFyZWE+YWJjPC90ZXh0YXJlYT48L3RkPgorPC90 cj4KKzx0ciBjbGFzcz0iYmxvY2siPgorICA8dGQ+WFlaZ2g8L3RkPgorICA8dGQ+PHRleHRhcmVh PmFiYzwvdGV4dGFyZWE+PC90ZD4KKyAgPHRkPjx0ZXh0YXJlYT5hYmM8L3RleHRhcmVhPjwvdGQ+ Cis8L3RyPgorPHRyPgorICA8dGQ+WFlaZ2g8L3RkPgorICA8dGQ+PGlucHV0IHR5cGU9Im51bWJl ciIgdmFsdWU9IjEyMyI+PC90ZD4KKyAgPHRkPjxpbnB1dCB0eXBlPSJudW1iZXIiIHZhbHVlPSIx MjMiPjwvdGQ+Cis8L3RyPgorPHRyIGNsYXNzPSJibG9jayI+CisgIDx0ZD5YWVpnaDwvdGQ+Cisg IDx0ZD48aW5wdXQgdHlwZT0ibnVtYmVyIiB2YWx1ZT0iMTIzIj48L3RkPgorICA8dGQ+PGlucHV0 IHR5cGU9Im51bWJlciIgdmFsdWU9IjEyMyI+PC90ZD4KKzwvdHI+Cis8L3RhYmxlPgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUvbWlzbWF0Y2hpbmctaW5saW5lLWJhc2VsaW5l LWFuZC1lbXB0eS1jb250ZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS9taXNtYXRj aGluZy1pbmxpbmUtYmFzZWxpbmUtYW5kLWVtcHR5LWNvbnRlbnQuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLmNhMjMxYzk4ODBkMQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvaW5saW5lL21pc21hdGNoaW5nLWlubGluZS1iYXNlbGluZS1h bmQtZW1wdHktY29udGVudC5odG1sCkBAIC0wLDAgKzEsNDcgQEAKKzwhRE9DVFlQRSBodG1sPgor PHN0eWxlPgorKiB7CisgIGNvbG9yOiB0cmFuc3BhcmVudDsKK30KKwordHIgeworICB2ZXJ0aWNh bC1hbGlnbjogYmFzZWxpbmU7Cit9CisKKy5ibG9jayBpbnB1dCwgLmJsb2NrIHRleHRhcmVhIHsK KyAgZGlzcGxheTpibG9jazsKK30KKzwvc3R5bGU+CisKKzx0YWJsZT4KKzx0cj4KKyAgPHRkPlhZ WmdoPC90ZD4KKyAgPHRkPjxpbnB1dCB2YWx1ZT0iYWJjIj48L3RkPgorICA8dGQ+PGlucHV0Pjwv dGQ+Cis8L3RyPgorPHRyIGNsYXNzPSJibG9jayI+CisgIDx0ZD5YWVpnaDwvdGQ+CisgIDx0ZD48 aW5wdXQgdmFsdWU9ImFiYyI+PC90ZD4KKyAgPHRkPjxpbnB1dD48L3RkPgorPC90cj4KKzx0cj4K KyAgPHRkPlhZWmdoPC90ZD4KKyAgPHRkPjx0ZXh0YXJlYT5hYmM8L3RleHRhcmVhPjwvdGQ+Cisg IDx0ZD48dGV4dGFyZWE+PC90ZXh0YXJlYT48L3RkPgorPC90cj4KKzx0ciBjbGFzcz0iYmxvY2si PgorICA8dGQ+WFlaZ2g8L3RkPgorICA8dGQ+PHRleHRhcmVhPmFiYzwvdGV4dGFyZWE+PC90ZD4K KyAgPHRkPjx0ZXh0YXJlYT48L3RleHRhcmVhPjwvdGQ+Cis8L3RyPgorPHRyPgorICA8dGQ+WFla Z2g8L3RkPgorICA8dGQ+PGlucHV0IHR5cGU9Im51bWJlciIgdmFsdWU9IjEyMyI+PC90ZD4KKyAg PHRkPjxpbnB1dCB0eXBlPSJudW1iZXIiPjwvdGQ+Cis8L3RyPgorPHRyIGNsYXNzPSJibG9jayI+ CisgIDx0ZD5YWVpnaDwvdGQ+CisgIDx0ZD48aW5wdXQgdHlwZT0ibnVtYmVyIiB2YWx1ZT0iMTIz Ij48L3RkPgorICA8dGQ+PGlucHV0IHR5cGU9Im51bWJlciI+PC90ZD4KKzwvdHI+Cis8L3RhYmxl Pgo=