285496 2025-01-07 00:02:27 -0800 Missing Trailing Code Validation in end Instruction 2025-01-16 01:33:34 -0800 1 1 1 Unclassified WebKit WebAssembly Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tombox1337 yijia_huang d_degazio keith_miller mark.lam webkit-bug-importer ysuzuki oldest_to_newest 2085329 0 473820 tombox1337 2025-01-07 00:02:27 -0800 Created attachment 473820 program.js ### Description WebKit does not enforce the requirement for validating the presence of trailing code after the end instruction in WebAssembly functions. This behavior allows the execution of WebAssembly modules with trailing code without raising errors, violating the expected behavior where an error should occur for trailing code after the function end. ### Environment - OS: Ubuntu 20.04 - CPU: amd64 - WebKit Version: 146fa28a329d220785d2972c1d691555141e6406 (The latest) - Commands: ```bash ./JSCOnly/Debug/bin/jsc ./program.js ``` ### Test Case program.js ### Current State ```plaintext ./JSCOnly/Debug/bin/jsc ./program.js 0 ``` ### Expected Behavior The WebAssembly module should fail validation and report an error similar to: - Like gecko-dev: ```plaintext function body length mismatch ``` - Like v8: ```plaintext trailing code after function end ``` 2086986 1 webkit-bug-importer 2025-01-14 00:03:15 -0800 <rdar://problem/142866140> 2087291 2 yijia_huang 2025-01-14 17:15:10 -0800 Pull request: https://github.com/WebKit/WebKit/pull/39043 2087708 3 ews-feeder 2025-01-16 01:33:31 -0800 Committed 288996@main (5c94b688c7a1): <https://commits.webkit.org/288996@main> Reviewed commits have been landed. Closing PR #39043 and removing active labels. 473820 2025-01-07 00:02:27 -0800 2025-01-07 00:02:27 -0800 program.js program.js application/x-javascript 428 tombox1337 CnZhciB3YXNtX2NvZGUgPSBuZXcgVWludDhBcnJheShbMCw5NywxMTUsMTA5LDEsMCwwLDAsMSw2 LDEsOTYsMSwxMjcsMSwxMjcsMywyLDEsMCw3LDgsMSw0LDEwOSw5NywxMDUsMTEwLDAsMCwxMCwx OCwxLDE2LDAsMzIsMCw2NSwxMCw3NCw0LDEyNyw2NSwxLDUsNjUsMCwxMSwxMSwxMSwwLDI0LDQs MTEwLDk3LDEwOSwxMDEsMSw3LDEsMCw0LDEwOSw5NywxMDUsMTEwLDIsOCwxLDAsMSwwLDMsMTEw LDExNywxMDksXSk7CnZhciB3YXNtX21vZHVsZSA9IG5ldyBXZWJBc3NlbWJseS5Nb2R1bGUod2Fz bV9jb2RlKTsKdmFyIHdhc21faW5zdGFuY2UgPSBuZXcgV2ViQXNzZW1ibHkuSW5zdGFuY2Uod2Fz bV9tb2R1bGUpOwpjb25zdCB7ICdtYWluJzogZnVuYyB9ID0gd2FzbV9pbnN0YW5jZS5leHBvcnRz Owp2YXIgYSA9IGZ1bmMoMSk7CnByaW50KGEpOwo=