<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>284916</bug_id>
          
          <creation_ts>2024-12-18 16:32:13 -0800</creation_ts>
          <short_desc>[Tools][GTK][WPE] MVT test suite: integrate run-mvt-tests with webkitpy facilities and support test expectations</short_desc>
          <delta_ts>2025-01-16 12:35:07 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=273679</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=286089</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Carlos Alberto Lopez Perez">clopez</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>dpino</cc>
    
    <cc>lmoura</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2082837</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2024-12-18 16:32:13 -0800</bug_when>
    <thetext>I have been evaluating the script run-mvt-tests in order to add a new step to the tests bots and run it.

However I found several issues with it that I would like to fix before adding the step:

 - It does not support running with the system libraries (only flatpak) and the JHBuild support is broken, it is not working for me. This is a requirement for running it on the downstream CI and also for the upcoming Flatpak SDK
 - It is manually defining environment variables like WEBKIT_EXEC_PATH or WEBKIT_INJECTED_BUNDLE_PATH instead of relying on webkitpy for that.
 - It does not support WebKitGTK (not a goal, but seems a nice perk to compare results between ports)
 - It does not support running with the WPE MiniBrowser instead of Cog 
 - It does not support running the complete MVT tests in a round (all the test suites). You have to manually specify which test-suite of MVT you want to run
 - It does not support test expectations. So it is not useful to run on the bots as it is because it will be failing always if we don&apos;t have the ability to mark expected failures
 - The logging it does is a bit confusing. It is not clear exactly which tests are failing because it prints the verbose log rather than the name of the tests that fail.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2082875</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2024-12-18 18:33:16 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/38180</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2087039</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-01-14 06:06:24 -0800</bug_when>
    <thetext>Committed 288842@main (566fb370f6b3): &lt;https://commits.webkit.org/288842@main&gt;

Reviewed commits have been landed. Closing PR #38180 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>