284850 2024-12-17 15:23:39 -0800 SkScalar.h:151:50: error: 'a' is an unsafe pointer used for buffer access [-Werror,-Wunsafe-buffer-usage] 2024-12-17 15:35:30 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply mcatanzaro oldest_to_newest 2082505 0 mcatanzaro 2024-12-17 15:23:39 -0800 WebKitGTK build is broken with Clang 19.1.5: In file included from /home/mcatanzaro/Projects/.gnome-builder/projects/WebKit/builds/default-jhbuild-x86_64-eng-Use-UnixFileDescriptor-in-IPC-and-ProcessLauncher/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-33.cpp:1: In file included from /home/mcatanzaro/Projects/WebKit/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp:46: In file included from /home/mcatanzaro/Projects/.gnome-builder/projects/WebKit/builds/default-jhbuild-x86_64-eng-Use-UnixFileDescriptor-in-IPC-and-ProcessLauncher/Skia/Headers/mod/skia/modules/svg/SkSVGOpenTypeSVGDecoder.h:11: In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/skia/include/core/SkColor.h:12: /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/skia/include/core/SkScalar.h:151:50: error: 'a' is an unsafe pointer used for buffer access [-Werror,-Wunsafe-buffer-usage] 151 | static inline bool SkScalarsEqual(const SkScalar a[], const SkScalar b[], int n) { | ~~~~~~~~~~~~~~~^~~ /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/skia/include/core/SkScalar.h:154:13: note: used in buffer access here 154 | if (a[i] != b[i]) { | ^ /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/skia/include/core/SkScalar.h:151:70: error: 'b' is an unsafe pointer used for buffer access [-Werror,-Wunsafe-buffer-usage] 151 | static inline bool SkScalarsEqual(const SkScalar a[], const SkScalar b[], int n) { | ~~~~~~~~~~~~~~~^~~ /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/skia/include/core/SkScalar.h:154:21: note: used in buffer access here 154 | if (a[i] != b[i]) { | ^ 2082508 1 mcatanzaro 2024-12-17 15:25:56 -0800 We probably need to do a comprehensive audit of Skia headers and ignore warnings everywhere, but for now I'll just fix the immediate problem. 2082509 2 mcatanzaro 2024-12-17 15:33:11 -0800 Pull request: https://github.com/WebKit/WebKit/pull/38107 2082511 3 ews-feeder 2024-12-17 15:35:28 -0800 Committed 287970@main (dbf8530502c9): <https://commits.webkit.org/287970@main> Reviewed commits have been landed. Closing PR #38107 and removing active labels.