28483 2009-08-19 23:00:02 -0700 [V8] ScriptController::cleanupScriptObjectsForPlugin should take a Widget* instead of void* 2009-08-20 00:31:48 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 fishd fishd oldest_to_newest 141739 0 fishd 2009-08-19 23:00:02 -0700 [V8] ScriptController::cleanupScriptObjectsForPlugin should take a Widget* instead of void* This function is supposed to be called by the plugin when it goes away. It corresponds to createScriptInstanceForWidget, which takes a Widget*. As is, it is important for callers to cast to Widget* before calling cleanupScriptObjectsForPlugin, which is rather error prone. See http://codereview.chromium.org/174126 for example. 141750 1 35188 fishd 2009-08-20 00:10:01 -0700 Created attachment 35188 v1 patch 141752 2 35188 eric 2009-08-20 00:19:30 -0700 Comment on attachment 35188 v1 patch LGTM. 141754 3 fishd 2009-08-20 00:31:48 -0700 Landed as: http://trac.webkit.org/changeset/47556 35188 2009-08-20 00:10:01 -0700 2009-08-20 00:19:29 -0700 v1 patch sc_1.txt text/plain 2404 fishd SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ3NTUzKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOC0yMCAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODQ4MworICAgICAgICBU aGUgVjggU2NyaXB0Q29udHJvbGxlcidzIGNsZWFudXBTY3JpcHRPYmplY3RzRm9yUGx1Z2luIHNo b3VsZCB0YWtlIGEKKyAgICAgICAgV2lkZ2V0KiBpbnN0ZWFkIG9mIHZvaWQqIHRvIGF2b2lkIHRo ZSBuZWVkIGZvciBtYW51YWwgY2FzdGluZyB0byBXaWRnZXQqCisgICAgICAgIGF0IHRoZSBjYWxs c2l0ZS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U2NyaXB0Q29udHJvbGxlcjo6Y2xlYW51cFNjcmlwdE9iamVjdHNGb3JQ bHVnaW4pOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuaDoKKwogMjAw OS0wOC0xOSAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZCBzcGVjdWxhdGl2ZSBidWlsZCBmaXggZm9yIHF0LgpJbmRleDogV2ViQ29yZS9iaW5k aW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvYmlu ZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDQ3NTQ3KQorKysgV2ViQ29y ZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIw LDcgKzMyMCw3IEBAIFBhc3NTY3JpcHRJbnN0YW5jZSBTY3JpcHRDb250cm9sbGVyOjpjcmUKICAg ICByZXR1cm4gVjhTY3JpcHRJbnN0YW5jZTo6Y3JlYXRlKHdyYXBwZXIpOwogfQogCi12b2lkIFNj cmlwdENvbnRyb2xsZXI6OmNsZWFudXBTY3JpcHRPYmplY3RzRm9yUGx1Z2luKHZvaWQqIG5hdGl2 ZUhhbmRsZSkKK3ZvaWQgU2NyaXB0Q29udHJvbGxlcjo6Y2xlYW51cFNjcmlwdE9iamVjdHNGb3JQ bHVnaW4oV2lkZ2V0KiBuYXRpdmVIYW5kbGUpCiB7CiAgICAgUGx1Z2luT2JqZWN0TWFwOjppdGVy YXRvciBpdCA9IG1fcGx1Z2luT2JqZWN0cy5maW5kKG5hdGl2ZUhhbmRsZSk7CiAgICAgaWYgKGl0 ID09IG1fcGx1Z2luT2JqZWN0cy5lbmQoKSkKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvU2Ny aXB0Q29udHJvbGxlci5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9TY3Jp cHRDb250cm9sbGVyLmgJKHJldmlzaW9uIDQ3NTQ3KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9T Y3JpcHRDb250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0Myw3ICsxNDMsNyBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQgdXBkYXRlU2VjdXJpdHlPcmlnaW4oKTsKICAg ICAgICAgdm9pZCBjbGVhclNjcmlwdE9iamVjdHMoKTsKICAgICAgICAgdm9pZCB1cGRhdGVQbGF0 Zm9ybVNjcmlwdE9iamVjdHMoKTsKLSAgICAgICAgdm9pZCBjbGVhbnVwU2NyaXB0T2JqZWN0c0Zv clBsdWdpbih2b2lkKik7CisgICAgICAgIHZvaWQgY2xlYW51cFNjcmlwdE9iamVjdHNGb3JQbHVn aW4oV2lkZ2V0Kik7CiAKICNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICAgICAg TlBPYmplY3QqIGNyZWF0ZVNjcmlwdE9iamVjdEZvclBsdWdpbkVsZW1lbnQoSFRNTFBsdWdJbkVs ZW1lbnQqKTsKQEAgLTE1OSw3ICsxNTksNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAg ICAgT3duUHRyPFNjcmlwdFN0YXRlPiBtX3NjcmlwdFN0YXRlOwogICAgICAgICBPd25QdHI8VjhQ cm94eT4gbV9wcm94eTsKLSAgICAgICAgdHlwZWRlZiBIYXNoTWFwPHZvaWQqLCBOUE9iamVjdCo+ IFBsdWdpbk9iamVjdE1hcDsKKyAgICAgICAgdHlwZWRlZiBIYXNoTWFwPFdpZGdldCosIE5QT2Jq ZWN0Kj4gUGx1Z2luT2JqZWN0TWFwOwogCiAgICAgICAgIC8vIEEgbWFwcGluZyBiZXR3ZWVuIFdp ZGdldHMgYW5kIHRoZWlyIGNvcnJlc3BvbmRpbmcgc2NyaXB0IG9iamVjdC4KICAgICAgICAgLy8g VGhpcyBsaXN0IGlzIHVzZWQgc28gdGhhdCB3aGVuIHRoZSBwbHVnaW4gZGllcywgd2UgY2FuIGlt bWVkaWF0ZWx5Cg==