28475 2009-08-19 17:09:40 -0700 Chromium: render disabled mute button if audio is not present 2009-08-21 14:46:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Trivial --- 0 scherkus webkit-unassigned eric oldest_to_newest 141647 0 scherkus 2009-08-19 17:09:40 -0700 If hasAudio() returns false or the media is in an error state, display a disabled mute button. 141660 1 35164 scherkus 2009-08-19 17:26:23 -0700 Created attachment 35164 Check for audio 141732 2 35164 levin 2009-08-19 21:38:57 -0700 Comment on attachment 35164 Check for audio Made commit queue- pending Andrew's confirmation that the mediaSoundDisabled resource has been added on the Chromium side. 141733 3 35164 levin 2009-08-19 21:43:17 -0700 Comment on attachment 35164 Check for audio I just found out that the resource is in. 141734 4 35164 eric 2009-08-19 21:56:50 -0700 Comment on attachment 35164 Check for audio Rejecting patch 35164 from commit-queue. This patch will require manual commit. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html 141985 5 eric 2009-08-21 14:46:46 -0700 Looks like this was already landed. 35164 2009-08-19 17:26:23 -0700 2009-08-19 21:56:50 -0700 Check for audio has_audio.patch text/plain 1649 scherkus ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzc3MmIyMC4uY2QwNjY1MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wOC0xOSAgQW5kcmV3IFNjaGVy a3VzICA8c2NoZXJrdXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbmRlciBkaXNhYmxlZCBtdXRlIGJ1dHRvbiBkdXJpbmcg YW4gZXJyb3Igb3IgaWYgbm8gYXVkaW8gaXMgcHJlc2VudC4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg0NzUKKworICAgICAgICBDb3ZlcmVkIGJ5 IGV4aXN0aW5nIGxheW91dCB0ZXN0czoKKyAgICAgICAgbWVkaWEvdmlkZW8tY29udHJvbHMtdmlz aWJsZS1hdWRpby1vbmx5Lmh0bWwKKyAgICAgICAgbWVkaWEvdmlkZW8tbm8tYXVkaW8uaHRtbAor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjpwYWludE1lZGlhTXV0ZUJ1dHRv bik6CisKIDIwMDktMDgtMTkgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRoZW1lQ2hyb21pdW1Ta2lhLmNwcAppbmRleCBjODg3NWRjLi5hMWM1YzM1IDEwMDY0NAotLS0g YS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAKKysrIGIvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCkBAIC02MzMsNiArNjMz LDEwIEBAIGJvb2wgUmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6OnBhaW50TWVkaWFNdXRlQnV0dG9u KFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25zdCBSCiAKICAgICBzdGF0aWMgSW1hZ2UqIHNvdW5k RnVsbCA9IEltYWdlOjpsb2FkUGxhdGZvcm1SZXNvdXJjZSgibWVkaWFTb3VuZEZ1bGwiKS5yZWxl YXNlUmVmKCk7CiAgICAgc3RhdGljIEltYWdlKiBzb3VuZE5vbmUgPSBJbWFnZTo6bG9hZFBsYXRm b3JtUmVzb3VyY2UoIm1lZGlhU291bmROb25lIikucmVsZWFzZVJlZigpOworICAgIHN0YXRpYyBJ bWFnZSogc291bmREaXNhYmxlZCA9IEltYWdlOjpsb2FkUGxhdGZvcm1SZXNvdXJjZSgibWVkaWFT b3VuZERpc2FibGVkIikucmVsZWFzZVJlZigpOworCisgICAgaWYgKG1lZGlhRWxlbWVudC0+bmV0 d29ya1N0YXRlKCkgPT0gSFRNTE1lZGlhRWxlbWVudDo6TkVUV09SS19OT19TT1VSQ0UgfHwgIW1l ZGlhRWxlbWVudC0+aGFzQXVkaW8oKSkKKyAgICAgICAgcmV0dXJuIHBhaW50TWVkaWFCdXR0b25J bnRlcm5hbChwYWludEluZm8uY29udGV4dCwgcmVjdCwgc291bmREaXNhYmxlZCk7CiAKICAgICBy ZXR1cm4gcGFpbnRNZWRpYUJ1dHRvbkludGVybmFsKHBhaW50SW5mby5jb250ZXh0LCByZWN0LCBt ZWRpYUVsZW1lbnQtPm11dGVkKCkgPyBzb3VuZE5vbmU6IHNvdW5kRnVsbCk7CiAjZWxzZQo=