28474 2009-08-19 17:00:38 -0700 REGESSION(r45316), Crash: WebKit crashes in Google Sites when indenting a table 2009-08-20 22:29:34 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC All RESOLVED FIXED Regression P1 Critical --- 1 rniwa rniwa darin ojan oldest_to_newest 141642 0 rniwa 2009-08-19 17:00:38 -0700 What steps will reproduce the problem? 1. Create a table in a Google Sites page. For example, 2x2. I think any size will do. 2. Click next to the right of the table, outside of it. 3. Click in the 'indent right' button. What is the expected result? The table is indented to the right. Chromium bug report: http://code.google.com/p/chromium/issues/detail?id=18284 This could be a regression due to http://trac.webkit.org/changeset/45316. 141715 1 35179 rniwa 2009-08-19 20:13:20 -0700 Created attachment 35179 demo, crashes your WebKit 141720 2 35182 rniwa 2009-08-19 20:23:44 -0700 Created attachment 35182 fixes the bug, one line change. 141736 3 35182 darin 2009-08-19 21:59:30 -0700 Comment on attachment 35182 fixes the bug, one line change. Can endOfCurrentParagraph ever have 0 for a node? r=me assuming the answer is no 141737 4 rniwa 2009-08-19 22:37:42 -0700 (In reply to comment #3) > (From update of attachment 35182 [details]) > Can endOfCurrentParagraph ever have 0 for a node? > > r=me assuming the answer is no It should never be. We could add an ASSERT there but the ending condition of the while loop is that we traverse through nodes until we reach end of selection. So should it ever be null, we fall into an infinite loop. http://trac.webkit.org/browser/trunk/WebCore/editing/IndentOutdentCommand.cpp#L207 141767 5 rniwa 2009-08-20 22:29:34 -0700 Landed in http://trac.webkit.org/changeset/47608. 35179 2009-08-19 20:13:20 -0700 2009-08-19 20:13:20 -0700 demo, crashes your WebKit indent-right-after-table.html text/html 433 rniwa PHA+VGhpcyB0ZXN0cyBjcmFzaCBvbiBpbmRlbnRpbmcgYXQgaW1tZWRpYXRlbHkgcmlnaHQgdG8g YSB0YWJsZS48L3A+CjxkaXYgaWQ9InRlc3QiIGNvbnRlbnRlZGl0YWJsZT0idHJ1ZSI+PHRhYmxl IGJvcmRlcj0xPjx0Ym9keT48dHI+PHRkPmhlbGxvPC90ZD48L3RyPjwvdGJvZHk+PC90YWJsZT48 L2Rpdj4KCjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KCmlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpCiAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cgp2 YXIgZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0Iik7CnZhciBzID0gd2luZG93Lmdl dFNlbGVjdGlvbigpOwpzLnNldFBvc2l0aW9uKGUsIDEpOwpkb2N1bWVudC5leGVjQ29tbWFuZCgi SW5kZW50IiwgZmFsc2UsIG51bGwpOwoKPC9zY3JpcHQ+Cg== 35182 2009-08-19 20:23:44 -0700 2009-08-19 21:59:29 -0700 fixes the bug, one line change. fix28474 text/plain 3960 rniwa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzU0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMTkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUkVH RVNTSU9OKHI0NTMxNiksIENyYXNoOiBXZWJLaXQgY3Jhc2hlcyBpbiBHb29nbGUgU2l0ZXMgd2hl biBpbmRlbnRpbmcgYSB0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjg0NzQKKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIGEgY3Jhc2ggd2hl biBpbmRlbnRpbmcgYXQgcmlnaHQgYWZ0ZXIgYSB0YWJsZS4KKyAgICAgICAgVGhlIGJ1ZyB3YXMg Y2F1c2VkIGJ5IE5vZGUqIGJsb2NrTm9kZSA9IGVuY2xvc2luZ0Jsb2NrKGVuZE9mQ3VycmVudFBh cmFncmFwaC5kZWVwRXF1aXZhbGVudCgpLm5vZGUoKSk7CisgICAgICAgIHdoZXJlIG5vZGUoKSBp cyBlcXVhbCB0byBibG9ja05vZGUuIEJlY2F1c2UgYmxvY2tOb2RlIGlzIHRoZSBlbmNsb3Npbmcg YmxvY2sgbm9kZSwgdGhpcyBwYXRjaCBjaGFuZ2VzIGl0IHRvCisgICAgICAgIGVuY2xvc2luZ0Js b2NrKGVuZE9mQ3VycmVudFBhcmFncmFwaC5kZWVwRXF1aXZhbGVudCgpLm5vZGUoKS0+cGFyZW50 Tm9kZSgpKTsKKworICAgICAgICBUZXN0OiBlZGl0aW5nL2V4ZWNDb21tYW5kL2luZGVudC1yaWdo dC1hZnRlci10YWJsZS5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0luZGVudE91dGRlbnRDb21t YW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluZGVudE91dGRlbnRDb21tYW5kOjppbmRlbnRS ZWdpb24pOiBGaXhlZCBzbyB0aGF0IGJsb2NrTm9kZSAhPSBlbmRPZkN1cnJlbnRQYXJhZ3JhcGgu ZGVlcEVxdWl2YWxlbnQoKS5ub2RlKCkKKwogMjAwOS0wOC0xOSAgUnlvc3VrZSBOaXdhICA8cm5p d2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6 IFdlYkNvcmUvZWRpdGluZy9JbmRlbnRPdXRkZW50Q29tbWFuZC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9lZGl0aW5nL0luZGVudE91dGRlbnRDb21tYW5kLmNwcAkocmV2aXNpb24gNDc1NDQp CisrKyBXZWJDb3JlL2VkaXRpbmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yMTEsNyArMjExLDcgQEAgdm9pZCBJbmRlbnRPdXRkZW50Q29tbWFuZDo6aW5kZW50 UmVnaW9uKAogICAgICAgICAgICAgYmxvY2txdW90ZUZvck5leHRJbmRlbnQgPSAwOwogICAgICAg ICBlbHNlIHsKICAgICAgICAgICAgIFZpc2libGVQb3NpdGlvbiBzdGFydE9mQ3VycmVudFBhcmFn cmFwaCA9IHN0YXJ0T2ZQYXJhZ3JhcGgoZW5kT2ZDdXJyZW50UGFyYWdyYXBoKTsKLSAgICAgICAg ICAgIE5vZGUqIGJsb2NrTm9kZSA9IGVuY2xvc2luZ0Jsb2NrKGVuZE9mQ3VycmVudFBhcmFncmFw aC5kZWVwRXF1aXZhbGVudCgpLm5vZGUoKSk7CisgICAgICAgICAgICBOb2RlKiBibG9ja05vZGUg PSBlbmNsb3NpbmdCbG9jayhlbmRPZkN1cnJlbnRQYXJhZ3JhcGguZGVlcEVxdWl2YWxlbnQoKS5u b2RlKCktPnBhcmVudE5vZGUoKSk7CiAgICAgICAgICAgICAvLyBleHRlbmQgdGhlIHJlZ2lvbiBz byB0aGF0IGl0IGNvbnRhaW5zIGFsbCB0aGUgYW5jZXN0b3IgYmxvY2tzIHdpdGhpbiB0aGUgc2Vs ZWN0aW9uCiAgICAgICAgICAgICBFeGNlcHRpb25Db2RlIGVjOwogICAgICAgICAgICAgRWxlbWVu dCogdW5zcGxpdHRhYmxlTm9kZSA9IHVuc3BsaXR0YWJsZUVsZW1lbnRGb3JQb3NpdGlvbihlbmRP ZkN1cnJlbnRQYXJhZ3JhcGguZGVlcEVxdWl2YWxlbnQoKSk7CkluZGV4OiBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA0 NzU0NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE1IEBACisyMDA5LTA4LTE5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR0VTU0lPTihy NDUzMTYpLCBDcmFzaDogV2ViS2l0IGNyYXNoZXMgaW4gR29vZ2xlIFNpdGVzIHdoZW4gaW5kZW50 aW5nIGEgdGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTI4NDc0CisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGEgdGVzdCB0byBtYWtlIHN1cmUg V2ViS2l0IGRvZXMgbm90IGNyYXNoIHdoZW4gaW5kZW50aW5nIGltbWVkaWF0ZWx5IHJpZ2h0IHRv IGEgdGFibGUuCisKKyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5kL2luZGVudC1yaWdodC1h ZnRlci10YWJsZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvZXhlY0Nv bW1hbmQvaW5kZW50LXJpZ2h0LWFmdGVyLXRhYmxlLmh0bWw6IEFkZGVkLgorCiAyMDA5LTA4LTE5 ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIE5vIHJldmlldy4K SW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5kZW50LXJpZ2h0LWFmdGVy LXRhYmxlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4 ZWNDb21tYW5kL2luZGVudC1yaWdodC1hZnRlci10YWJsZS1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2luZGVudC1yaWdodC1hZnRl ci10YWJsZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAorVGhpcyB0 ZXN0cyBjcmFzaCBvbiBpbmRlbnRpbmcgYXQgaW1tZWRpYXRlbHkgcmlnaHQgdG8gYSB0YWJsZS4K KworaGVsbG8KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5kZW50LXJp Z2h0LWFmdGVyLXRhYmxlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9l eGVjQ29tbWFuZC9pbmRlbnQtcmlnaHQtYWZ0ZXItdGFibGUuaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5kZW50LXJpZ2h0LWFmdGVyLXRhYmxl Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTQgQEAKKzxwPlRoaXMgdGVzdHMgY3Jhc2gg b24gaW5kZW50aW5nIGF0IGltbWVkaWF0ZWx5IHJpZ2h0IHRvIGEgdGFibGUuPC9wPgorPGRpdiBp ZD0idGVzdCIgY29udGVudGVkaXRhYmxlPSJ0cnVlIj48dGFibGUgYm9yZGVyPTE+PHRib2R5Pjx0 cj48dGQ+aGVsbG88L3RkPjwvdHI+PC90Ym9keT48L3RhYmxlPjwvZGl2PgorCis8c2NyaXB0IHR5 cGU9InRleHQvamF2YXNjcmlwdCI+CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCit2YXIgZSA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0Iik7Cit2YXIgcyA9IHdpbmRvdy5nZXRTZWxlY3Rpb24o KTsKK3Muc2V0UG9zaXRpb24oZSwgMSk7Citkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5kZW50Iiwg ZmFsc2UsIG51bGwpOworCis8L3NjcmlwdD4K