28469 2009-08-19 12:52:39 -0700 We probably shouldn't be keeping the AST for eval nodes around forevar. 2009-08-19 13:16:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 141557 0 barraclough 2009-08-19 12:52:39 -0700 The only barrier is the var stack. 141569 1 35135 barraclough 2009-08-19 13:16:37 -0700 Created attachment 35135 The Patch 141570 2 barraclough 2009-08-19 13:16:53 -0700 Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/bytecode/CodeBlock.h Sending JavaScriptCore/bytecompiler/BytecodeGenerator.cpp Sending JavaScriptCore/interpreter/Interpreter.cpp Sending JavaScriptCore/parser/Nodes.h Sending JavaScriptCore/runtime/Executable.cpp Sending JavaScriptCore/runtime/Executable.h Transmitting file data ....... Committed revision 47519. 35135 2009-08-19 13:16:37 -0700 2009-08-19 13:16:37 -0700 The Patch patch.evalScope.txt text/plain 5680 barraclough SW5kZXg6IHJ1bnRpbWUvRXhlY3V0YWJsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcnVudGltZS9FeGVj dXRhYmxlLmNwcAkocmV2aXNpb24gNDc1MTgpCisrKyBydW50aW1lL0V4ZWN1dGFibGUuY3BwCShy ZXZpc2lvbiA0NzUxOSkKQEAgLTU4LDcgKzU4LDcgQEAKICAgICBPd25QdHI8Qnl0ZWNvZGVHZW5l cmF0b3I+IGdlbmVyYXRvcihuZXcgQnl0ZWNvZGVHZW5lcmF0b3IoZXZhbE5vZGUoKSwgZ2xvYmFs T2JqZWN0LT5kZWJ1Z2dlcigpLCBzY29wZUNoYWluLCAmbV9ldmFsQ29kZUJsb2NrLT5zeW1ib2xU YWJsZSgpLCBtX2V2YWxDb2RlQmxvY2spKTsKICAgICBnZW5lcmF0b3ItPmdlbmVyYXRlKCk7CiAg ICAgCi0gICAgZXZhbE5vZGUoKS0+cGFydGlhbERlc3Ryb3lEYXRhKCk7CisgICAgZXZhbE5vZGUo KS0+ZGVzdHJveURhdGEoKTsKIH0KIAogdm9pZCBQcm9ncmFtRXhlY3V0YWJsZTo6Z2VuZXJhdGVC eXRlY29kZShTY29wZUNoYWluTm9kZSogc2NvcGVDaGFpbk5vZGUpCkluZGV4OiBydW50aW1lL0V4 ZWN1dGFibGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBydW50aW1lL0V4ZWN1dGFibGUuaAkocmV2aXNpb24g NDc1MTgpCisrKyBydW50aW1lL0V4ZWN1dGFibGUuaAkocmV2aXNpb24gNDc1MTkpCkBAIC01OSw4 ICs1OSw2IEBACiAKICAgICAgICAgdmlydHVhbCBFeGNlcHRpb25JbmZvKiByZXBhcnNlRXhjZXB0 aW9uSW5mbyhKU0dsb2JhbERhdGEqLCBTY29wZUNoYWluTm9kZSosIENvZGVCbG9jayopID0gMDsK IAotICAgICAgICBTY29wZU5vZGUqIGFzdE5vZGUoKSB7IHJldHVybiBtX25vZGUuZ2V0KCk7IH0K LQogICAgIHByb3RlY3RlZDoKICAgICAgICAgUmVmUHRyPFNjb3BlTm9kZT4gbV9ub2RlOwogICAg ICAgICBTb3VyY2VDb2RlIG1fc291cmNlOwpAQCAtMTA5LDggKzEwNyw2IEBACiAgICAgICAgICAg ICByZXR1cm4gKm1fZXZhbENvZGVCbG9jazsKICAgICAgICAgfQogCi0gICAgICAgIERlY2xhcmF0 aW9uU3RhY2tzOjpWYXJTdGFjayYgdmFyU3RhY2soKSB7IHJldHVybiBtX25vZGUtPnZhclN0YWNr KCk7IH0KLQogICAgICAgICBFeGNlcHRpb25JbmZvKiByZXBhcnNlRXhjZXB0aW9uSW5mbyhKU0ds b2JhbERhdGEqLCBTY29wZUNoYWluTm9kZSosIENvZGVCbG9jayopOwogCiAgICAgcHJpdmF0ZToK SW5kZXg6IGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g Ynl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAkocmV2aXNpb24gNDc1MTgpCisrKyBi eXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCShyZXZpc2lvbiA0NzUxOSkKQEAgLTQw Myw2ICs0MDMsMTQgQEAKICAgICAgICAgbV9jb2RlQmxvY2stPmFkZEZ1bmN0aW9uRGVjbChhZG9w dFJlZihuZXcgRnVuY3Rpb25FeGVjdXRhYmxlKGZ1bmN0aW9uLT5pZGVudCgpLCBmdW5jdGlvbikp KTsKICAgICB9CiAKKyAgICBjb25zdCBEZWNsYXJhdGlvblN0YWNrczo6VmFyU3RhY2smIHZhclN0 YWNrID0gZXZhbE5vZGUtPnZhclN0YWNrKCk7CisgICAgdW5zaWduZWQgbnVtVmFyaWFibGVzID0g dmFyU3RhY2suc2l6ZSgpOworICAgIFZlY3RvcjxJZGVudGlmaWVyPiB2YXJpYWJsZXM7CisgICAg dmFyaWFibGVzLnJlc2VydmVDYXBhY2l0eShudW1WYXJpYWJsZXMpOworICAgIGZvciAoc2l6ZV90 IGkgPSAwOyBpIDwgbnVtVmFyaWFibGVzOyArK2kpCisgICAgICAgIHZhcmlhYmxlcy5hcHBlbmQo dmFyU3RhY2tbaV0uZmlyc3QpOworICAgIGNvZGVCbG9jay0+YWRvcHRWYXJpYWJsZXModmFyaWFi bGVzKTsKKwogICAgIHByZXNlcnZlTGFzdFZhcigpOwogfQogCkluZGV4OiBpbnRlcnByZXRlci9J bnRlcnByZXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3Bw CShyZXZpc2lvbiA0NzUxOCkKKysrIGludGVycHJldGVyL0ludGVycHJldGVyLmNwcAkocmV2aXNp b24gNDc1MTkpCkBAIC04MzYsMTAgKzgzNiw5IEBACiAKICAgICAgICAgQmF0Y2hlZFRyYW5zaXRp b25PcHRpbWl6ZXIgb3B0aW1pemVyKHZhcmlhYmxlT2JqZWN0KTsKIAotICAgICAgICBjb25zdCBE ZWNsYXJhdGlvblN0YWNrczo6VmFyU3RhY2smIHZhclN0YWNrID0gc3RhdGljX2Nhc3Q8RXZhbEV4 ZWN1dGFibGUqPihjb2RlQmxvY2stPm93bmVyRXhlY3V0YWJsZSgpKS0+dmFyU3RhY2soKTsKLSAg ICAgICAgRGVjbGFyYXRpb25TdGFja3M6OlZhclN0YWNrOjpjb25zdF9pdGVyYXRvciB2YXJTdGFj a0VuZCA9IHZhclN0YWNrLmVuZCgpOwotICAgICAgICBmb3IgKERlY2xhcmF0aW9uU3RhY2tzOjpW YXJTdGFjazo6Y29uc3RfaXRlcmF0b3IgaXQgPSB2YXJTdGFjay5iZWdpbigpOyBpdCAhPSB2YXJT dGFja0VuZDsgKytpdCkgewotICAgICAgICAgICAgY29uc3QgSWRlbnRpZmllciYgaWRlbnQgPSAo Kml0KS5maXJzdDsKKyAgICAgICAgdW5zaWduZWQgbnVtVmFyaWFibGVzID0gY29kZUJsb2NrLT5u dW1WYXJpYWJsZXMoKTsKKyAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG51bVZhcmlh YmxlczsgKytpKSB7CisgICAgICAgICAgICBjb25zdCBJZGVudGlmaWVyJiBpZGVudCA9IGNvZGVC bG9jay0+dmFyaWFibGUoaSk7CiAgICAgICAgICAgICBpZiAoIXZhcmlhYmxlT2JqZWN0LT5oYXNQ cm9wZXJ0eShjYWxsRnJhbWUsIGlkZW50KSkgewogICAgICAgICAgICAgICAgIFB1dFByb3BlcnR5 U2xvdCBzbG90OwogICAgICAgICAgICAgICAgIHZhcmlhYmxlT2JqZWN0LT5wdXQoY2FsbEZyYW1l LCBpZGVudCwganNVbmRlZmluZWQoKSwgc2xvdCk7CkluZGV4OiBDaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gQ2hhbmdlTG9nCShyZXZpc2lvbiA0NzUxOCkKKysrIENoYW5nZUxvZwkocmV2aXNpb24g NDc1MTkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMDktMDgtMTkgIEdhdmluIEJhcnJhY2xvdWdoICA8 YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgorCisgICAgICAgICBXZSBwcm9iYWJseSBzaG91bGRuJ3QgYmUga2VlcGluZyB0aGUgQVNUIGZv ciBldmFsIG5vZGVzIGFyb3VuZCBmb3JldmFyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg0NjkKKworICAgICAgICBFdmFsTm9kZXMgZG9uJ3QgZGVz dHJveURhdGEoKSAoZGVsZXRlIHRoZWlyIHBhcnNlciBkYXRhKSBzaW5jZSB0aGV5IG5lZWQgdG8g aG9sZCBvbnRvCisgICAgICAgIHRoZWlyIHZhclN0YWNrLiAgQ29weSBhIGxpc3Qgb2YgdmFyaWFi bGUgb250byBFdmFsQ29kZUJsb2NrLCBhbmQgdGhpcyBjYW4gZ28gYXdheS4KKworICAgICAgICAq IGJ5dGVjb2RlL0NvZGVCbG9jay5oOgorICAgICAgICAoSlNDOjpFdmFsQ29kZUJsb2NrOjp2YXJp YWJsZSk6CisgICAgICAgIChKU0M6OkV2YWxDb2RlQmxvY2s6Om51bVZhcmlhYmxlcyk6CisgICAg ICAgIChKU0M6OkV2YWxDb2RlQmxvY2s6OmFkb3B0VmFyaWFibGVzKToKKyAgICAgICAgKiBieXRl Y29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdl bmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IpOgorICAgICAgICAqIGludGVycHJldGVyL0ludGVy cHJldGVyLmNwcDoKKyAgICAgICAgKEpTQzo6SW50ZXJwcmV0ZXI6OmV4ZWN1dGUpOgorICAgICAg ICAqIHBhcnNlci9Ob2Rlcy5oOgorICAgICAgICAqIHJ1bnRpbWUvRXhlY3V0YWJsZS5jcHA6Cisg ICAgICAgIChKU0M6OkV2YWxFeGVjdXRhYmxlOjpnZW5lcmF0ZUJ5dGVjb2RlKToKKyAgICAgICAg KiBydW50aW1lL0V4ZWN1dGFibGUuaDoKKwogMjAwOS0wOC0xOSAgSnVuZ3NoaWsgU2hpbiAgPGpz aGluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5k ZXg6IHBhcnNlci9Ob2Rlcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhcnNlci9Ob2Rlcy5oCShyZXZpc2lv biA0NzUxOCkKKysrIHBhcnNlci9Ob2Rlcy5oCShyZXZpc2lvbiA0NzUxOSkKQEAgLTE0NjIsMTMg KzE0NjIsNiBAQAogICAgIHB1YmxpYzoKICAgICAgICAgc3RhdGljIFBhc3NSZWZQdHI8RXZhbE5v ZGU+IGNyZWF0ZShKU0dsb2JhbERhdGEqLCBTb3VyY2VFbGVtZW50cyosIFZhclN0YWNrKiwgRnVu Y3Rpb25TdGFjayosIGNvbnN0IFNvdXJjZUNvZGUmLCBDb2RlRmVhdHVyZXMsIGludCBudW1Db25z dGFudHMpOwogCi0gICAgICAgIHZvaWQgcGFydGlhbERlc3Ryb3lEYXRhKCkKLSAgICAgICAgewot ICAgICAgICAgICAgLy8gRXZhbCBjb2RlIG5lZWRzIHRvIGhhbmcgb24gdG8gaXRzIGRlY2xhcmF0 aW9uIHN0YWNrcyB0byBrZWVwIGRlY2xhcmF0aW9uIGluZm8gYWxpdmUgdW50aWwgSW50ZXJwcmV0 ZXI6OmV4ZWN1dGUgdGltZSwKLSAgICAgICAgICAgIC8vIHNvIHRoZSBlbnRpcmUgU2NvcGVOb2Rl RGF0YSBjYW5ub3QgYmUgZGVzdG95ZWQuCi0gICAgICAgICAgICBjaGlsZHJlbigpLmNsZWFyKCk7 Ci0gICAgICAgIH0KLQogICAgIHByaXZhdGU6CiAgICAgICAgIEV2YWxOb2RlKEpTR2xvYmFsRGF0 YSosIFNvdXJjZUVsZW1lbnRzKiwgVmFyU3RhY2sqLCBGdW5jdGlvblN0YWNrKiwgY29uc3QgU291 cmNlQ29kZSYsIENvZGVGZWF0dXJlcywgaW50IG51bUNvbnN0YW50cyk7CiAKSW5kZXg6IGJ5dGVj b2RlL0NvZGVCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGJ5dGVjb2RlL0NvZGVCbG9jay5oCShyZXZp c2lvbiA0NzUxOCkKKysrIGJ5dGVjb2RlL0NvZGVCbG9jay5oCShyZXZpc2lvbiA0NzUxOSkKQEAg LTU5OCw4ICs1OTgsMTcgQEAKIAogICAgICAgICBpbnQgYmFzZVNjb3BlRGVwdGgoKSBjb25zdCB7 IHJldHVybiBtX2Jhc2VTY29wZURlcHRoOyB9CiAKKyAgICAgICAgY29uc3QgSWRlbnRpZmllciYg dmFyaWFibGUodW5zaWduZWQgaW5kZXgpIHsgcmV0dXJuIG1fdmFyaWFibGVzW2luZGV4XTsgfQor ICAgICAgICB1bnNpZ25lZCBudW1WYXJpYWJsZXMoKSB7IHJldHVybiBtX3ZhcmlhYmxlcy5zaXpl KCk7IH0KKyAgICAgICAgdm9pZCBhZG9wdFZhcmlhYmxlcyhWZWN0b3I8SWRlbnRpZmllcj4mIHZh cmlhYmxlcykKKyAgICAgICAgeworICAgICAgICAgICAgQVNTRVJUKG1fdmFyaWFibGVzLmlzRW1w dHkoKSk7CisgICAgICAgICAgICBtX3ZhcmlhYmxlcy5zd2FwKHZhcmlhYmxlcyk7CisgICAgICAg IH0KKwogICAgIHByaXZhdGU6CiAgICAgICAgIGludCBtX2Jhc2VTY29wZURlcHRoOworICAgICAg ICBWZWN0b3I8SWRlbnRpZmllcj4gbV92YXJpYWJsZXM7CiAgICAgfTsKIAogICAgIGNsYXNzIEZ1 bmN0aW9uQ29kZUJsb2NrIDogcHVibGljIENvZGVCbG9jayB7Cg==