28461 2009-08-19 09:55:40 -0700 transitions/change-values-during-transition.html fails intermittently 2010-08-17 16:58:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 37048 1 mrowe cmarrin abecsi cmarrin commit-queue eric mihaip ossy simon.fraser oldest_to_newest 141503 0 mrowe 2009-08-19 09:55:40 -0700 transitions/change-values-during-transition.html has been failing intermittently on the new leaks bot: <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r47504%20(13)/transitions/change-values-during-transition-pretty-diff.html>. This is presumably due to the extra overhead that comes from running with MallocStackLogging enabled. We should make the test more robust so that it doesn't fail in this manner. 151464 1 eric 2009-09-30 23:10:13 -0700 Another one tonight: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r48958%20(1067)/results.html Seems to be a bunch of transition related intermittent failures on the SnowLeopard bot, maybe they all have one root cause? transitions/change-values-during-transition.html: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r48958%20(1067)/results.html transitions/cancel-transition.html: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r48945%20(1056)/results.html I was looking at adding the SnowLeopard bots to the list of bots to block commits from the commit-queue this evening. Looks like they're not quite ready, this bug being one of the blockers. (bugzilla-tool, and thus the commit-queue, will not allow one to commit if the bots are red. Currently the SnowLeopard bots are not in the set of bots it checks, but once they are stable green I would like them to be.) 265790 2 64641 mihaip 2010-08-17 15:09:19 -0700 Created attachment 64641 Patch 265792 3 mihaip 2010-08-17 15:10:14 -0700 I just ran into this while trying to land 44086 via the commit queue. The attached patch should hopefully make it less flaky. 265799 4 64641 cmarrin 2010-08-17 15:25:45 -0700 Comment on attachment 64641 Patch r=me. This is a good technique for many of these transition/animation tests. We might want to use it elsewhere, or even put it into one of the JS helpers. 265821 5 64641 commit-queue 2010-08-17 16:06:21 -0700 Comment on attachment 64641 Patch Rejecting patch 64641 from review queue. cmarrin@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights. 265837 6 64641 dglazkov 2010-08-17 16:31:47 -0700 Comment on attachment 64641 Patch Chris, you need to teach commit-queue a lesson! :P 265848 7 64641 commit-queue 2010-08-17 16:58:15 -0700 Comment on attachment 64641 Patch Clearing flags on attachment: 64641 Committed r65575: <http://trac.webkit.org/changeset/65575> 265849 8 commit-queue 2010-08-17 16:58:20 -0700 All reviewed patches have been landed. Closing bug. 64641 2010-08-17 15:09:19 -0700 2010-08-17 16:58:15 -0700 Patch bug-28461-20100817150917.patch text/plain 3936 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhM2RiZDU1YzYwYjk2ZjI1ODAzNTM2NjIxMjdkYTEzNmFlYzc3YzQ5Li44MjkyYzcy OGRiZjVmZjE3MTJkYTJmOGFjZTc5MzZhZTg1OTIwYTA2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMDgtMTcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdHJhbnNpdGlvbnMv Y2hhbmdlLXZhbHVlcy1kdXJpbmctdHJhbnNpdGlvbi5odG1sIGZhaWxzIGludGVybWl0dGVudGx5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODQ2MQor CisgICAgICAgIE1ha2UgdGVzdCBsZXNzIGZsYWt5IGR1cmluZyBoaWdoIENQVSB1c2FnZSBieSBj aGFuZ2luZyB0aGUgZXhwZWN0YXRpb24KKyAgICAgICAgZnJvbSBhIGhhcmRjb2RlZCB2YWx1ZSB0 byBhbiBpbnRlcnBvbGF0ZWQgb25lIGJhc2VkIG9uIHdoZW4gdGhlIHRpbWVvdXQKKyAgICAgICAg YWN0dWFsbHkgZmlyZXMuIE1hZGUgdGhlIHRlc3QgbXVjaCBtb3JlIHJlbGlhYmxlIHdoZW4gcnVu bmluZyB3aXRoCisgICAgICAgIC0taXRlcmF0aW9ucz0xMDAgd2hpbGUgbWF4aW5nIG91dCB0aGUg Q1BVIG9uIG15IG1hY2hpbmUgd2l0aCBhIAorICAgICAgICBiYWNrZ3JvdW5kIHByb2Nlc3MuCisK KyAgICAgICAgKiB0cmFuc2l0aW9ucy9jaGFuZ2UtdmFsdWVzLWR1cmluZy10cmFuc2l0aW9uLmh0 bWw6CisKIDIwMTAtMDgtMTcgIEZhZHkgU2FtdWVsICA8ZnNhbXVlbEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgSHlhdHQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy90cmFuc2l0aW9ucy9jaGFuZ2UtdmFsdWVzLWR1cmluZy10cmFuc2l0aW9uLmh0bWwgYi9MYXlv dXRUZXN0cy90cmFuc2l0aW9ucy9jaGFuZ2UtdmFsdWVzLWR1cmluZy10cmFuc2l0aW9uLmh0bWwK aW5kZXggZGYwMDM4ZjYzNmRjNGUxODE2OWI5M2EzM2NiNzFkZDUwNTZlYTIxYy4uODYxYjA4OGEy NTBmMmM1N2JmNGUxN2I5ZjIzMzU3ZjFkNmQwNDFlZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv dHJhbnNpdGlvbnMvY2hhbmdlLXZhbHVlcy1kdXJpbmctdHJhbnNpdGlvbi5odG1sCisrKyBiL0xh eW91dFRlc3RzL3RyYW5zaXRpb25zL2NoYW5nZS12YWx1ZXMtZHVyaW5nLXRyYW5zaXRpb24uaHRt bApAQCAtMSw1ICsxLDQgQEAKLTwhRE9DVFlQRSBodG1sIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRN TCA0LjAxIFRyYW5zaXRpb25hbC8vRU4iCi0gICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQv bG9vc2UuZHRkIj4KKzwhRE9DVFlQRSBodG1sPgogCiA8aHRtbCBsYW5nPSJlbiI+CiA8aGVhZD4K QEAgLTIzLDYgKzIyLDcgQEAKICAgICAKICAgICB2YXIgcmVzdWx0ID0gIlBBU1MiOwogICAgIGNv bnN0IGRlZmF1bHRUb2xlcmFuY2UgPSAxMDsKKyAgICB2YXIgdHJhbnNpdGlvblN0YXJ0VGltZTsK ICAgICAKICAgICBmdW5jdGlvbiBpc0Nsb3NlRW5vdWdoKGFjdHVhbCwgZGVzaXJlZCkKICAgICB7 CkBAIC00NCwxOSArNDQsMjkgQEAKICAgICAgICAgcmV0dXJuIHRbNF07CiAgICAgfQogICAgIAot ICAgIGZ1bmN0aW9uIGNoZWNrMSgpCisgICAgZnVuY3Rpb24gY2hlY2tJbnRlcm1lZGlhdGVWYWx1 ZSgpCiAgICAgewotICAgICAgICB2YXIgeFBvcyA9IGdldFhQb3NpdGlvbigpOwotICAgICAgICBp ZiAoIWlzQ2xvc2VFbm91Z2goeFBvcywgNTApKQotICAgICAgICAgICAgcmVzdWx0ID0gIkZBSUwo d2FzOiIreFBvcysiLCBzL2I6NTApIjsKKyAgICAgICAgLy8gV2Ugc2hvdWxkIGJlIHJvdWdobHkg aGFsZndheSBpbiB0aGUgdHJhbnNpdGlvbiBmcm9tIDAgdG8gMTAwLCBidXQgdGhlCisgICAgICAg IC8vIHRpbWVvdXQgbWF5IG5vdCBmaXJlIGV4YWN0bHkgdGhlbi4gRmlndXJlIG91dCB3aGVyZSB3 ZSBzaG91bGQgYmUgCisgICAgICAgIC8vIGJhc2VkIG9uIGEgbGluZWFyIGludGVycG9sYXRpb24g b2YgdGltZXN0YW1wcy4KKyAgICAgICAgdmFyIGFjdHVhbFhQb3MgPSBnZXRYUG9zaXRpb24oKTsK KyAgICAgICAgdmFyIGV4cGVjdGVkWFBvcyA9IChuZXcgRGF0ZSgpLmdldFRpbWUoKSAtIHRyYW5z aXRpb25TdGFydFRpbWUpLzEwMDAgKiAxMDA7CisgICAgICAgIGlmICghaXNDbG9zZUVub3VnaChh Y3R1YWxYUG9zLCBleHBlY3RlZFhQb3MpKQorICAgICAgICAgICAgcmVzdWx0ID0gJ0ZBSUwgZm9y IGludGVybWVkaWF0ZSB2YWx1ZSAod2FzOiAnICsgYWN0dWFsWFBvcyArICcsIGV4cGVjdGVkOiAn ICsgZXhwZWN0ZWRYUG9zICsgJyknOwogICAgIH0KIAotICAgIGZ1bmN0aW9uIGNoZWNrMigpCisg ICAgZnVuY3Rpb24gY2hlY2tGaW5hbFZhbHVlKCkKICAgICB7Ci0gICAgICAgIHZhciB4UG9zID0g Z2V0WFBvc2l0aW9uKCk7Ci0gICAgICAgIGlmICghaXNDbG9zZUVub3VnaCh4UG9zLCAwKSkKLSAg ICAgICAgICAgIHJlc3VsdCArPSAiRkFJTCh3YXM6Iit4UG9zKyIsIHMvYjowKSI7Ci0gICAgICAg ICAgICAKKyAgICAgICAgdmFyIGFjdHVhbFhQb3MgPSBnZXRYUG9zaXRpb24oKTsKKyAgICAgICAg dmFyIHRyYW5zaXRpb25GcmFjdGlvbiA9IChuZXcgRGF0ZSgpLmdldFRpbWUoKSAtIHRyYW5zaXRp b25TdGFydFRpbWUpLzEwMDsKKyAgICAgICAgdmFyIGV4cGVjdGVkWFBvcyA9IDEwMCAtIE1hdGgu bWluKHRyYW5zaXRpb25GcmFjdGlvbiwgMSkgKiAxMDA7CisgCisgICAgICAgIGlmICghaXNDbG9z ZUVub3VnaChhY3R1YWxYUG9zLCBleHBlY3RlZFhQb3MpKSB7CisgICAgICAgICAgICBpZiAocmVz dWx0ID09ICdQQVNTJykKKyAgICAgICAgICAgICAgICByZXN1bHQgPSAnJzsKKyAgICAgICAgICAg IHJlc3VsdCArPSAnRkFJTCBmb3IgZmluYWwgdmFsdWUgKHdhczogJyArIGFjdHVhbFhQb3MgKyAn LCBleHBlY3RlZDogJyArIGV4cGVjdGVkWFBvcyArICcpJzsKKyAgICAgICAgfQorICAgICAgICAK ICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jlc3VsdCcpLmlubmVyVGV4dCA9IHJl c3VsdDsKICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAg ICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKQEAgLTY2LDE1ICs3NiwxNyBA QAogICAgIHsKICAgICAgICAgdmFyIGJveCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdib3gn KTsKICAgICAgICAgYm94LnN0eWxlLndlYmtpdFRyYW5zZm9ybSA9ICd0cmFuc2xhdGVYKDApJzsK KyAgICAgICAgdHJhbnNpdGlvblN0YXJ0VGltZSA9IG5ldyBEYXRlKCkuZ2V0VGltZSgpOwogICAg IH0KIAogICAgIGZ1bmN0aW9uIHN0YXJ0KCkKICAgICB7CiAgICAgICAgIHZhciBib3ggPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnYm94Jyk7Ci0gICAgICAgIHNldFRpbWVvdXQoImNoYW5nZVZh bHVlcygpIiwgMTAwKTsKLSAgICAgICAgc2V0VGltZW91dCgiY2hlY2sxKCkiLCA1MDApOwotICAg ICAgICBzZXRUaW1lb3V0KCJjaGVjazIoKSIsIDEzMDApOworICAgICAgICBzZXRUaW1lb3V0KGNo YW5nZVZhbHVlcywgMTAwKTsKKyAgICAgICAgc2V0VGltZW91dChjaGVja0ludGVybWVkaWF0ZVZh bHVlLCA1MDApOworICAgICAgICBzZXRUaW1lb3V0KGNoZWNrRmluYWxWYWx1ZSwgMTMwMCk7CiAg ICAgICAgIGJveC5zdHlsZS53ZWJraXRUcmFuc2Zvcm0gPSAndHJhbnNsYXRlWCgxMDBweCknOwor ICAgICAgICB0cmFuc2l0aW9uU3RhcnRUaW1lID0gbmV3IERhdGUoKS5nZXRUaW1lKCk7CiAgICAg fQogICAgIAogICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgc3RhcnQsIGZhbHNl KTsK