28457 2009-08-19 08:53:06 -0700 PrettyPatch tries to show images for deleted files 2011-04-19 12:40:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth aroben cmarcelo commit-queue eric webkit.review.bot oldest_to_newest 141485 0 eric 2009-08-19 08:53:06 -0700 PrettyPatch tries to show images for deleted files https://bugs.webkit.org/attachment.cgi?id=35114&action=prettypatch PrettyPatch should recognize that it's a file deletion and not try to show an image. 374974 1 87254 cmarcelo 2011-03-28 20:58:39 -0700 Created attachment 87254 patch 374982 2 87254 eric 2011-03-28 21:25:19 -0700 Comment on attachment 87254 patch SGTM. Should this use a helper function? 375017 3 cmarcelo 2011-03-28 22:43:02 -0700 For the HTML generation part you mean? If so, I'm not sure if it worth adding a function for this case. Seems to me that other cases deserve more a function/method instead of this one. 388520 4 90204 cmarcelo 2011-04-19 08:33:12 -0700 Created attachment 90204 patch v2, rebased and with helper function 388552 5 90204 aroben 2011-04-19 09:50:16 -0700 Comment on attachment 90204 patch v2, rebased and with helper function View in context: https://bugs.webkit.org/attachment.cgi?id=90204&action=review > Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:558 > + def image_to_html > + str = "" > + if @image_url then > if @image_checksum then > str += "<p>" + @image_checksum + "</p>" > end > str += "<img class='image' src='" + @image_url + "' />" > + else > + str += "<span class='text'>Image file removed</span>" > + end > + str > + end Instead of appending to an empty string and then returning it at the end, how about just 'return "this is the string we want"' in each case? 388566 6 90213 cmarcelo 2011-04-19 10:11:39 -0700 Created attachment 90213 patch v3, reduce nesting in helper function 388612 7 90213 commit-queue 2011-04-19 11:08:27 -0700 Comment on attachment 90213 patch v3, reduce nesting in helper function Clearing flags on attachment: 90213 Committed r84266: <http://trac.webkit.org/changeset/84266> 388613 8 commit-queue 2011-04-19 11:08:33 -0700 All reviewed patches have been landed. Closing bug. 388707 9 webkit.review.bot 2011-04-19 12:40:29 -0700 http://trac.webkit.org/changeset/84266 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: plugins/mouse-click-iframe-to-plugin.html 87254 2011-03-28 20:58:39 -0700 2011-04-19 08:33:12 -0700 patch 0001-PrettyPatch-tries-to-show-images-for-deleted-files.patch text/plain 2644 cmarcelo RnJvbSBkZTc0NjI5MWRlZWM4NjdhZjgzMWRkMmEwMWQzNDM3MjZkY2UyMjFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gPGNhaW8u b2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KRGF0ZTogVHVlLCAyOSBNYXIgMjAxMSAwMDo1ODoyMSAt MDMwMApTdWJqZWN0OiBbUEFUQ0hdIFByZXR0eVBhdGNoIHRyaWVzIHRvIHNob3cgaW1hZ2VzIGZv ciBkZWxldGVkIGZpbGVzCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjg0NTcKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKV2hlbiB0aGUgaW1hZ2UgZGF0YSBp cyBlbXB0eSwgaW5zdGVhZCBvZiBnZW5lcmF0aW5nIGFuIDxpbWc+IHRhZywgZ2VuZXJhdGUKYSB0 ZXh0IHRvIGluZGljYXRlIHRoZSBpbWFnZSB3YXMgZGVsZXRlZC4KCiogUHJldHR5UGF0Y2gvUHJl dHR5UGF0Y2gucmI6Ci0tLQogV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2J1Z3Mud2Via2l0Lm9yZy9QcmV0 dHlQYXRjaC9QcmV0dHlQYXRjaC5yYiAgICAgfCAgICA4ICsrKysrKy0tCiAyIGZpbGVzIGNoYW5n ZWQsIDE4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2Vic2l0 ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9D aGFuZ2VMb2cKaW5kZXggOTg1OGExYy4uMjIwYmJlOSAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvYnVn cy53ZWJraXQub3JnL0NoYW5nZUxvZworKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDMtMjggIENhaW8gTWFyY2VsbyBkZSBPbGl2 ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV0dHlQYXRjaCB0cmllcyB0byBz aG93IGltYWdlcyBmb3IgZGVsZXRlZCBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg0NTcKKworICAgICAgICBXaGVuIHRoZSBpbWFnZSBkYXRh IGlzIGVtcHR5LCBpbnN0ZWFkIG9mIGdlbmVyYXRpbmcgYW4gPGltZz4gdGFnLCBnZW5lcmF0ZQor ICAgICAgICBhIHRleHQgdG8gaW5kaWNhdGUgdGhlIGltYWdlIHdhcyBkZWxldGVkLgorCisgICAg ICAgICogUHJldHR5UGF0Y2gvUHJldHR5UGF0Y2gucmI6CisKIDIwMTEtMDMtMTUgIERhdmlkIExl dmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFy dGguCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJl dHR5UGF0Y2gucmIgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJldHR5 UGF0Y2gucmIKaW5kZXggOGY5NjBhOS4uZTA0ZTg3MyAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvYnVn cy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCisrKyBiL1dlYnNpdGVzL2J1 Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgpAQCAtNTE0LDcgKzUxNCw3 IEBAIEVPRgogICAgICAgICAgICAgZW5kCiAgICAgICAgICAgICBsaW5lc193aXRoX2NvbnRlbnRz ID0gbGluZXNbc3RhcnRPZlNlY3Rpb25zLi4ubGluZXMubGVuZ3RoXQogICAgICAgICAgICAgQHNl Y3Rpb25zID0gRGlmZlNlY3Rpb24ucGFyc2UobGluZXNfd2l0aF9jb250ZW50cykgdW5sZXNzIEBi aW5hcnkKLSAgICAgICAgICAgIGlmIEBpbWFnZQorICAgICAgICAgICAgaWYgQGltYWdlIGFuZCBu b3QgbGluZXNfd2l0aF9jb250ZW50cy5lbXB0eT8KICAgICAgICAgICAgICAgICBAaW1hZ2VfdXJs ID0gImRhdGE6aW1hZ2UvcG5nO2Jhc2U2NCwiICsgbGluZXNfd2l0aF9jb250ZW50cy5qb2luCiAg ICAgICAgICAgICBlbHNpZiBAZ2l0X2ltYWdlCiAgICAgICAgICAgICAgICAgYmVnaW4KQEAgLTU0 NCw3ICs1NDQsMTEgQEAgRU9GCiAgICAgICAgICAgICBzdHIgPSAiPGRpdiBjbGFzcz0nRmlsZURp ZmYnPlxuIgogICAgICAgICAgICAgc3RyICs9ICI8aDE+I3tQcmV0dHlQYXRjaC5saW5raWZ5Rmls ZW5hbWUoQGZpbGVuYW1lKX08L2gxPlxuIgogICAgICAgICAgICAgaWYgQGltYWdlIHRoZW4KLSAg ICAgICAgICAgICAgICBzdHIgKz0gIjxpbWcgY2xhc3M9J2ltYWdlJyBzcmM9JyIgKyBAaW1hZ2Vf dXJsICsgIicgLz4iCisgICAgICAgICAgICAgICAgaWYgQGltYWdlX3VybCB0aGVuCisgICAgICAg ICAgICAgICAgICAgIHN0ciArPSAiPGltZyBjbGFzcz0naW1hZ2UnIHNyYz0nIiArIEBpbWFnZV91 cmwgKyAiJyAvPiIKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgIHN0 ciArPSAiPHNwYW4gY2xhc3M9J3RleHQnPkltYWdlIGZpbGUgcmVtb3ZlZDwvc3Bhbj4iCisgICAg ICAgICAgICAgICAgZW5kCiAgICAgICAgICAgICBlbHNpZiBAZ2l0X2ltYWdlIHRoZW4KICAgICAg ICAgICAgICAgICBpZiBAaW1hZ2VfZXJyb3IKICAgICAgICAgICAgICAgICAgICAgc3RyICs9IEBp bWFnZV9lcnJvcgotLSAKMS43LjQKCg== 90204 2011-04-19 08:33:12 -0700 2011-04-19 10:11:39 -0700 patch v2, rebased and with helper function 0001-PrettyPatch-tries-to-show-images-for-deleted-files.patch text/plain 3121 cmarcelo RnJvbSA5NGYyZTJlYTdmYjE4MzdiNzFlYzA1ZWZjMmUwODNmM2ZhNTliNGQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gPGNhaW8u b2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KRGF0ZTogVHVlLCAxOSBBcHIgMjAxMSAxMjoyOToyNCAt MDMwMApTdWJqZWN0OiBbUEFUQ0hdIFByZXR0eVBhdGNoIHRyaWVzIHRvIHNob3cgaW1hZ2VzIGZv ciBkZWxldGVkIGZpbGVzCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjg0NTcKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKV2hlbiB0aGUgaW1hZ2UgZGF0YSBp cyBlbXB0eSwgaW5zdGVhZCBvZiBnZW5lcmF0aW5nIGFuIDxpbWc+IHRhZywgZ2VuZXJhdGUKYSB0 ZXh0IHRvIGluZGljYXRlIHRoZSBpbWFnZSB3YXMgZGVsZXRlZC4KCiogUHJldHR5UGF0Y2gvUHJl dHR5UGF0Y2gucmI6Ci0tLQogV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2J1Z3Mud2Via2l0Lm9yZy9QcmV0 dHlQYXRjaC9QcmV0dHlQYXRjaC5yYiAgICAgfCAgIDIwICsrKysrKysrKysrKysrKy0tLS0tCiAy IGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9DaGFuZ2VMb2cKaW5kZXggMWVlN2ZmMi4uY2YzNmE1OSAxMDA2NDQKLS0tIGEv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZworKysgYi9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMTkgIENhaW8gTWFy Y2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmV0dHlQYXRj aCB0cmllcyB0byBzaG93IGltYWdlcyBmb3IgZGVsZXRlZCBmaWxlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg0NTcKKworICAgICAgICBXaGVuIHRo ZSBpbWFnZSBkYXRhIGlzIGVtcHR5LCBpbnN0ZWFkIG9mIGdlbmVyYXRpbmcgYW4gPGltZz4gdGFn LCBnZW5lcmF0ZQorICAgICAgICBhIHRleHQgdG8gaW5kaWNhdGUgdGhlIGltYWdlIHdhcyBkZWxl dGVkLgorCisgICAgICAgICogUHJldHR5UGF0Y2gvUHJldHR5UGF0Y2gucmI6CisKIDIwMTEtMDQt MTQgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBZGFtIFJvYmVuLgpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0 eVBhdGNoL1ByZXR0eVBhdGNoLnJiIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBh dGNoL1ByZXR0eVBhdGNoLnJiCmluZGV4IGE0ZTM4OTMuLjM0ZjU0YWIgMTAwNjQ0Ci0tLSBhL1dl YnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgorKysgYi9X ZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJldHR5UGF0Y2gucmIKQEAgLTUx NCw3ICs1MTQsNyBAQCBFT0YKICAgICAgICAgICAgIGVuZAogICAgICAgICAgICAgbGluZXNfd2l0 aF9jb250ZW50cyA9IGxpbmVzW3N0YXJ0T2ZTZWN0aW9ucy4uLmxpbmVzLmxlbmd0aF0KICAgICAg ICAgICAgIEBzZWN0aW9ucyA9IERpZmZTZWN0aW9uLnBhcnNlKGxpbmVzX3dpdGhfY29udGVudHMp IHVubGVzcyBAYmluYXJ5Ci0gICAgICAgICAgICBpZiBAaW1hZ2UKKyAgICAgICAgICAgIGlmIEBp bWFnZSBhbmQgbm90IGxpbmVzX3dpdGhfY29udGVudHMuZW1wdHk/CiAgICAgICAgICAgICAgICAg QGltYWdlX3VybCA9ICJkYXRhOmltYWdlL3BuZztiYXNlNjQsIiArIGxpbmVzX3dpdGhfY29udGVu dHMuam9pbgogICAgICAgICAgICAgICAgIEBpbWFnZV9jaGVja3N1bSA9IEZpbGVEaWZmLnJlYWRf Y2hlY2tzdW1fZnJvbV9wbmcobGluZXNfd2l0aF9jb250ZW50cy5qb2luLnVucGFjaygibSIpLmpv aW4pCiAgICAgICAgICAgICBlbHNpZiBAZ2l0X2ltYWdlCkBAIC01NDQsMTQgKzU0NCwyNCBAQCBF T0YKICAgICAgICAgICAgIG5pbAogICAgICAgICBlbmQKIAotICAgICAgICBkZWYgdG9faHRtbAot ICAgICAgICAgICAgc3RyID0gIjxkaXYgY2xhc3M9J0ZpbGVEaWZmJz5cbiIKLSAgICAgICAgICAg IHN0ciArPSAiPGgxPiN7UHJldHR5UGF0Y2gubGlua2lmeUZpbGVuYW1lKEBmaWxlbmFtZSl9PC9o MT5cbiIKLSAgICAgICAgICAgIGlmIEBpbWFnZSB0aGVuCisgICAgICAgIGRlZiBpbWFnZV90b19o dG1sCisgICAgICAgICAgICBzdHIgPSAiIgorICAgICAgICAgICAgaWYgQGltYWdlX3VybCB0aGVu CiAgICAgICAgICAgICAgICAgaWYgQGltYWdlX2NoZWNrc3VtIHRoZW4KICAgICAgICAgICAgICAg ICAgICAgc3RyICs9ICI8cD4iICsgQGltYWdlX2NoZWNrc3VtICsgIjwvcD4iCiAgICAgICAgICAg ICAgICAgZW5kCiAgICAgICAgICAgICAgICAgc3RyICs9ICI8aW1nIGNsYXNzPSdpbWFnZScgc3Jj PSciICsgQGltYWdlX3VybCArICInIC8+IgorICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAg ICAgIHN0ciArPSAiPHNwYW4gY2xhc3M9J3RleHQnPkltYWdlIGZpbGUgcmVtb3ZlZDwvc3Bhbj4i CisgICAgICAgICAgICBlbmQKKyAgICAgICAgICAgIHN0cgorICAgICAgICBlbmQKKworICAgICAg ICBkZWYgdG9faHRtbAorICAgICAgICAgICAgc3RyID0gIjxkaXYgY2xhc3M9J0ZpbGVEaWZmJz5c biIKKyAgICAgICAgICAgIHN0ciArPSAiPGgxPiN7UHJldHR5UGF0Y2gubGlua2lmeUZpbGVuYW1l KEBmaWxlbmFtZSl9PC9oMT5cbiIKKyAgICAgICAgICAgIGlmIEBpbWFnZSB0aGVuCisgICAgICAg ICAgICAgICAgc3RyICs9IHNlbGYuaW1hZ2VfdG9faHRtbAogICAgICAgICAgICAgZWxzaWYgQGdp dF9pbWFnZSB0aGVuCiAgICAgICAgICAgICAgICAgaWYgQGltYWdlX2Vycm9yCiAgICAgICAgICAg ICAgICAgICAgIHN0ciArPSBAaW1hZ2VfZXJyb3IKLS0gCjEuNy40LjQKCg== 90213 2011-04-19 10:11:39 -0700 2011-04-19 11:08:27 -0700 patch v3, reduce nesting in helper function 0001-PrettyPatch-tries-to-show-images-for-deleted-files.patch text/plain 3139 cmarcelo RnJvbSA3MjU4ZDdmZWM0YjJkMzZhYWU3M2JiZmM1ZmQwYmRhMjliN2IzMzBkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gPGNhaW8u b2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KRGF0ZTogVHVlLCAxOSBBcHIgMjAxMSAxMjoyOToyNCAt MDMwMApTdWJqZWN0OiBbUEFUQ0hdIFByZXR0eVBhdGNoIHRyaWVzIHRvIHNob3cgaW1hZ2VzIGZv ciBkZWxldGVkIGZpbGVzCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjg0NTcKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKV2hlbiB0aGUgaW1hZ2UgZGF0YSBp cyBlbXB0eSwgaW5zdGVhZCBvZiBnZW5lcmF0aW5nIGFuIDxpbWc+IHRhZywgZ2VuZXJhdGUKYSB0 ZXh0IHRvIGluZGljYXRlIHRoZSBpbWFnZSB3YXMgZGVsZXRlZC4KCiogUHJldHR5UGF0Y2gvUHJl dHR5UGF0Y2gucmI6Ci0tLQogV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2J1Z3Mud2Via2l0Lm9yZy9QcmV0 dHlQYXRjaC9QcmV0dHlQYXRjaC5yYiAgICAgfCAgIDE4ICsrKysrKysrKysrKystLS0tLQogMiBm aWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDFlZTdmZjIuLmNmMzZhNTkgMTAwNjQ0Ci0tLSBhL1dl YnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJr aXQub3JnL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA0LTE5ICBDYWlvIE1hcmNl bG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJldHR5UGF0Y2gg dHJpZXMgdG8gc2hvdyBpbWFnZXMgZm9yIGRlbGV0ZWQgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4NDU3CisKKyAgICAgICAgV2hlbiB0aGUg aW1hZ2UgZGF0YSBpcyBlbXB0eSwgaW5zdGVhZCBvZiBnZW5lcmF0aW5nIGFuIDxpbWc+IHRhZywg Z2VuZXJhdGUKKyAgICAgICAgYSB0ZXh0IHRvIGluZGljYXRlIHRoZSBpbWFnZSB3YXMgZGVsZXRl ZC4KKworICAgICAgICAqIFByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiOgorCiAyMDExLTA0LTE0 ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QWRhbSBSb2Jlbi4KZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQ YXRjaC9QcmV0dHlQYXRjaC5yYiBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRj aC9QcmV0dHlQYXRjaC5yYgppbmRleCBhNGUzODkzLi5lNTU2YjFkIDEwMDY0NAotLS0gYS9XZWJz aXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJldHR5UGF0Y2gucmIKKysrIGIvV2Vi c2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCkBAIC01MTQs NyArNTE0LDcgQEAgRU9GCiAgICAgICAgICAgICBlbmQKICAgICAgICAgICAgIGxpbmVzX3dpdGhf Y29udGVudHMgPSBsaW5lc1tzdGFydE9mU2VjdGlvbnMuLi5saW5lcy5sZW5ndGhdCiAgICAgICAg ICAgICBAc2VjdGlvbnMgPSBEaWZmU2VjdGlvbi5wYXJzZShsaW5lc193aXRoX2NvbnRlbnRzKSB1 bmxlc3MgQGJpbmFyeQotICAgICAgICAgICAgaWYgQGltYWdlCisgICAgICAgICAgICBpZiBAaW1h Z2UgYW5kIG5vdCBsaW5lc193aXRoX2NvbnRlbnRzLmVtcHR5PwogICAgICAgICAgICAgICAgIEBp bWFnZV91cmwgPSAiZGF0YTppbWFnZS9wbmc7YmFzZTY0LCIgKyBsaW5lc193aXRoX2NvbnRlbnRz LmpvaW4KICAgICAgICAgICAgICAgICBAaW1hZ2VfY2hlY2tzdW0gPSBGaWxlRGlmZi5yZWFkX2No ZWNrc3VtX2Zyb21fcG5nKGxpbmVzX3dpdGhfY29udGVudHMuam9pbi51bnBhY2soIm0iKS5qb2lu KQogICAgICAgICAgICAgZWxzaWYgQGdpdF9pbWFnZQpAQCAtNTQ0LDE0ICs1NDQsMjIgQEAgRU9G CiAgICAgICAgICAgICBuaWwKICAgICAgICAgZW5kCiAKKyAgICAgICAgZGVmIGltYWdlX3RvX2h0 bWwKKyAgICAgICAgICAgIGlmIG5vdCBAaW1hZ2VfdXJsIHRoZW4KKyAgICAgICAgICAgICAgICBy ZXR1cm4gIjxzcGFuIGNsYXNzPSd0ZXh0Jz5JbWFnZSBmaWxlIHJlbW92ZWQ8L3NwYW4+IgorICAg ICAgICAgICAgZW5kCisgICAgICAgICAgICBpbWFnZV9zbmlwcGV0ID0gIjxpbWcgY2xhc3M9J2lt YWdlJyBzcmM9JyIgKyBAaW1hZ2VfdXJsICsgIicgLz4iCisgICAgICAgICAgICBpZiBub3QgQGlt YWdlX2NoZWNrc3VtIHRoZW4KKyAgICAgICAgICAgICAgICByZXR1cm4gaW1hZ2Vfc25pcHBldAor ICAgICAgICAgICAgZW5kCisgICAgICAgICAgICByZXR1cm4gIjxwPiIgKyBAaW1hZ2VfY2hlY2tz dW0gKyAiPC9wPiIgKyBpbWFnZV9zbmlwcGV0CisgICAgICAgIGVuZAorCiAgICAgICAgIGRlZiB0 b19odG1sCiAgICAgICAgICAgICBzdHIgPSAiPGRpdiBjbGFzcz0nRmlsZURpZmYnPlxuIgogICAg ICAgICAgICAgc3RyICs9ICI8aDE+I3tQcmV0dHlQYXRjaC5saW5raWZ5RmlsZW5hbWUoQGZpbGVu YW1lKX08L2gxPlxuIgogICAgICAgICAgICAgaWYgQGltYWdlIHRoZW4KLSAgICAgICAgICAgICAg ICBpZiBAaW1hZ2VfY2hlY2tzdW0gdGhlbgotICAgICAgICAgICAgICAgICAgICBzdHIgKz0gIjxw PiIgKyBAaW1hZ2VfY2hlY2tzdW0gKyAiPC9wPiIKLSAgICAgICAgICAgICAgICBlbmQKLSAgICAg ICAgICAgICAgICBzdHIgKz0gIjxpbWcgY2xhc3M9J2ltYWdlJyBzcmM9JyIgKyBAaW1hZ2VfdXJs ICsgIicgLz4iCisgICAgICAgICAgICAgICAgc3RyICs9IHNlbGYuaW1hZ2VfdG9faHRtbAogICAg ICAgICAgICAgZWxzaWYgQGdpdF9pbWFnZSB0aGVuCiAgICAgICAgICAgICAgICAgaWYgQGltYWdl X2Vycm9yCiAgICAgICAgICAgICAgICAgICAgIHN0ciArPSBAaW1hZ2VfZXJyb3IKLS0gCjEuNy40 LjQKCg==