<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>284470</bug_id>
          
          <creation_ts>2024-12-11 09:35:49 -0800</creation_ts>
          <short_desc>Web Automation: modernize callback thunks for async protocol commands</short_desc>
          <delta_ts>2025-03-06 09:41:51 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebDriver</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>289259</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Blaze Burg">bburg</reporter>
          <assigned_to name="Blaze Burg">bburg</assigned_to>
          <cc>bburg</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2080868</commentid>
    <comment_count>0</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2024-12-11 09:35:49 -0800</bug_when>
    <thetext>We need to be able to connect async WebAutomationSession/WebAutomationBidiProcessor methods to each other. Right now these callbacks are all BackendDispatcher::CallbackBase subclasses, which does not have a standalone constructor. So, we cannot easily pass a lambda that chains completion handlers.

In order to chain callbacks, switch from using CallbackBase subclasses to using Function&lt;&gt; with proper type parameters.

NB. We may consider using CompletionHandlers in some places, but for now the types are expressed using the less strict Function template.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2080875</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-12-11 09:52:44 -0800</bug_when>
    <thetext>&lt;rdar://problem/141291944&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2096761</commentid>
    <comment_count>2</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2025-02-21 10:48:03 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/41067</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2099047</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-02-27 18:03:26 -0800</bug_when>
    <thetext>Committed 291284@main (9e1b4bc5f110): &lt;https://commits.webkit.org/291284@main&gt;

Reviewed commits have been landed. Closing PR #41067 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>