28445 2009-08-18 22:33:40 -0700 webkit-patch post can post partial diffs from SVN checkouts. 2010-06-10 20:31:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 REOPENED P2 Normal --- 28436 1 eric webkit-unassigned abarth mjs oldest_to_newest 141393 0 eric 2009-08-18 22:33:40 -0700 https://bugs.webkit.org/attachment.cgi?id=35096&action=edit is an example. We need to chdir to the root of the repository before calling out to svn-create-patch. Either by passing a working directory to svn-create-patch, or doing a chdir to the root first, or whatever. 141672 1 35168 eric 2009-08-19 17:55:18 -0700 Created attachment 35168 easy fix, will write test once bug 28436 lands 141673 2 eric 2009-08-19 17:55:45 -0700 I want to use some of the testing infrastructure I added in bug 28436 when writing this test. 141827 3 abarth 2009-08-20 23:08:16 -0700 Committed r47598: <http://trac.webkit.org/changeset/47598> 148384 4 eric 2009-09-18 14:13:03 -0700 This change was requested by Maciej after confusion: https://bugs.webkit.org/show_bug.cgi?id=27937#c5 148520 5 eric 2009-09-19 11:18:32 -0700 After discussion via email, the consensus is that we should roll out this change. When we do so, we should add some unit tests to scm_unittest.py to document the intentionally different post-diff behavior between svn and git (which matches how their various diff commands operate). 182515 6 eric 2010-01-19 16:43:31 -0800 I'm not a svn user. I'm not sure if this is still an issue. 35168 2009-08-19 17:55:18 -0700 2010-06-10 20:31:39 -0700 easy fix, will write test once bug 28436 lands bug-28445-20090819175517.patch text/plain 523 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zY20ucHkgYi9XZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvc2NtLnB5CmluZGV4IDEwYjc5OWEuLjQ0ODMwNjUgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zY20ucHkKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5weQpAQCAtMjc0LDcgKzI3NCw3IEBAIGNsYXNzIFNWTihT Q00pOgogICAgICAgICByZXR1cm4gInN2biIKIAogICAgIGRlZiBjcmVhdGVfcGF0Y2goc2VsZik6 Ci0gICAgICAgIHJldHVybiBzZWxmLnJ1bl9jb21tYW5kKHNlbGYuc2NyaXB0X3BhdGgoInN2bi1j cmVhdGUtcGF0Y2giKSkKKyAgICAgICAgcmV0dXJuIHNlbGYucnVuX2NvbW1hbmQoc2VsZi5zY3Jp cHRfcGF0aCgic3ZuLWNyZWF0ZS1wYXRjaCIpLCBjd2Q9c2VsZi5jaGVja291dF9yb290KQogCiAg ICAgZGVmIGNvbW1pdF93aXRoX21lc3NhZ2Uoc2VsZiwgbWVzc2FnZSk6CiAgICAgICAgIGlmIHNl bGYuZHJ5cnVuOg==