28443 2009-08-18 20:50:53 -0700 Build break with gtk 2.10 2009-08-18 23:49:56 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ukai webkit-unassigned eric oldest_to_newest 141384 0 ukai 2009-08-18 20:50:53 -0700 WebKit requires gtk 2.10, but WebKit/gtk/WebCoreSupport/DragClientGtk.cpp requires gtk_widget_get_window that is introduced in gtk 2.14. ../WebKit/gtk/WebCoreSupport/DragClientGtk.cpp: In member function ‘virtual void WebKit::DragClient::startDrag(GdkPixbuf*, const WebCore::IntPoint&, const WebCore::IntPoint&, WebCore::Clipboard*, WebCore::Frame*, bool)’: ../WebKit/gtk/WebCoreSupport/DragClientGtk.cpp:92: error: ‘gtk_widget_get_window’ was not declared in this scope make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-DragClientGtk.lo] Error 1 141385 1 35100 ukai 2009-08-18 21:00:10 -0700 Created attachment 35100 fix build break with gtk_widget_get_window --- 2 files changed, 17 insertions(+), 1 deletions(-) 141411 2 35100 eric 2009-08-18 23:35:10 -0700 Comment on attachment 35100 fix build break with gtk_widget_get_window Looks sane enough. 141417 3 35100 eric 2009-08-18 23:49:52 -0700 Comment on attachment 35100 fix build break with gtk_widget_get_window Clearing flags on attachment: 35100 Committed r47496: <http://trac.webkit.org/changeset/47496> 141418 4 eric 2009-08-18 23:49:56 -0700 All reviewed patches have been landed. Closing bug. 35100 2009-08-18 21:00:10 -0700 2009-08-18 23:49:52 -0700 fix build break with gtk_widget_get_window bug-28443-20090819130008.patch text/plain 1262 ukai ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggMjFkOWRlMC4uMTRhMWRkNyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOC0xOCAg RnVtaXRvc2hpIFVrYWkgIDx1a2FpQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjg0NDMKKyAgICAgICAgRml4IGJ1aWxkIGJyZWFrIHdpdGggZ3RrIG9sZGVy IHRoYW4gMi4xNC4KKworICAgICAgICBXZWJLaXQgZ3RrIHBvcnQgcmVxdWlyZXMgZ3RrIDIuMTAg b3IgbGF0ZXIsIGJ1dCBEcmFnQ2xpZW50R3RrLmNwcAorICAgICAgICB1c2VzIGd0a193aWRnZXRf Z2V0X3dpbmRvdyB0aGF0IGlzIGludHJvZHVjZWQgaW4gMi4xNC4KKworICAgICAgICAqIFdlYkNv cmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuY3BwOgorICAgICAgICAgZGVmaW5lIGd0a193aWRnZXRf Z2V0X3dpbmRvdyBmb3IgZ3RrIG9sZGVyIHRoYW4gMi4xNC4KKwogMjAwOS0wOC0xOCAgR3VzdGF2 byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAg ICAgICBSZXZpZXdlZCBieSBKYW4gQWxvbnpvLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJD b3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrLmNwcCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQv RHJhZ0NsaWVudEd0ay5jcHAKaW5kZXggMTE5YmU3Ny4uODRjYWY0MyAxMDA2NDQKLS0tIGEvV2Vi S2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3Rr L1dlYkNvcmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuY3BwCkBAIC0yNSw2ICsyNSwxMCBAQAogI2lu Y2x1ZGUgIndlYmtpdHdlYnZpZXcuaCIKIAogI2luY2x1ZGUgPGd0ay9ndGsuaD4KKyNpbmNsdWRl IDxndGsvZ3RrdmVyc2lvbi5oPgorI2lmICFHVEtfQ0hFQ0tfVkVSU0lPTigyLCAxNCwgMCkKKyNk ZWZpbmUgZ3RrX3dpZGdldF9nZXRfd2luZG93KHdpZGdldCkgKHdpZGdldCktPndpbmRvdworI2Vu ZGlmCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC0xMTUsNCArMTE5LDMgQEAgdm9p ZCBEcmFnQ2xpZW50OjpkcmFnQ29udHJvbGxlckRlc3Ryb3llZCgpCiAgICAgZGVsZXRlIHRoaXM7 CiB9CiB9Ci0=