28441 icu42 2009-08-18 17:15:01 -0700 build error with ICU 4.2.x on Windows + Visual studio 2009-08-19 11:39:25 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 jshin jshin aroben darin eric mrowe pkasting oldest_to_newest 141329 0 jshin 2009-08-18 17:15:01 -0700 When I tried to build Chromium with ICU 4.2.x on Windows, I came across exactly the same error as Peter encountered a couple of month ago ( http://paste.lisp.org/display/81781 ) except that I'm getting it in wtf/unicode/icu/CollatorICU.cpp. He fixed the problem by using Vector<char> instead of std::string. ( http://trac.webkit.org/changeset/44643 ). In this case, I'm afraid that's not an option because unicode/ucol.h pulls in unicode/unistr.h, which in turn pulls in unicode/std_string.h and <string>. On Windows, <string> pulls in <xlocale> with tolower, toupper, etc. They're all replaced with WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h leading to compile errors (multiple declarations). One work around the problem is to append "_foo" to WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h for 'foo' #defined in DisallowCType.h So, they'll look like: #define tolower WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h_tolower #define toupper WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h_toupper 141332 1 jshin 2009-08-18 17:19:36 -0700 Oops. I forgot to mention that ICU 4.2.x began to use std::string where it's supported. Chromium has used ICU 3.8 and I'm about to upgrade it to ICU 4.2.1. I guess Safari will eventually move to ICU 4.2.x or later (Win Safari uses ICU 4.0, right?) even on OS X (it's almost certain that Mac OS 10.7 - after snow leopard - will have at least ICU 4.2.x). If the approach mentioned in the previous comment is acceptable, I'll make a patch. 141504 2 35126 jshin 2009-08-19 10:02:24 -0700 Created attachment 35126 patch : prepend WTF_...ASCIIType_h with 'isXXX' / 'toXXX' 141523 3 eric 2009-08-19 10:40:38 -0700 I'm totally confused by this fix. Why? 141531 4 jshin 2009-08-19 10:55:58 -0700 Let me try to clarify. CollatorICU.cpp (in Javascript/wtf/unicode/icu) includes ICU's i18n/unicode/ucol.h. Beginning with ICU 4.2, ucol.h pulls in C++ standard <string> (not directly but via a chain of includes). <string> in turn pulls in <xlocale> (again indirectly). <xlocale> in Visual Studio has the following at line 1386 _Elem __CLR_OR_THIS_CALL toupper(_Elem _Ch) const { // convert element to upper case return (do_toupper(_Ch)); } At line 1375, it has _Elem __CLR_OR_THIS_CALL tolower(_Elem _Ch) const { // convert element to upper case return (do_toupper(_Ch)); } Because DisallowCType.h defines tolower and toupper (and other ctype macros/functions) to WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h, the above two end up being identical and leading to the errors in http://paste.lisp.org/display/81781 toupper and tolower show up multiple times in <xlocale> (in "Microsoft Visual Studio 8\VC\include") so that there are multiple errors as shown in http://paste.lisp.org/display/81781 141534 5 jshin 2009-08-19 10:57:55 -0700 (In reply to comment #4) > At line 1375, it has > > _Elem __CLR_OR_THIS_CALL tolower(_Elem _Ch) const > { // convert element to upper case > return (do_toupper(_Ch)); > } Ooops. The above should read _Elem __CLR_OR_THIS_CALL tolower(_Elem _Ch) const { // convert element to lower case return (do_tolower(_Ch)); } 141537 6 35126 darin 2009-08-19 11:13:04 -0700 Comment on attachment 35126 patch : prepend WTF_...ASCIIType_h with 'isXXX' / 'toXXX' This seems like an OK way to sidestep the build failure. Not a great solution, but something that will do no harm. r=me 141540 7 jshin 2009-08-19 11:39:25 -0700 Thank you for r+. Just checked in ( http://trac.webkit.org/changeset/47516 ) 35126 2009-08-19 10:02:24 -0700 2009-08-19 11:13:04 -0700 patch : prepend WTF_...ASCIIType_h with 'isXXX' / 'toXXX' 28441.patch text/plain 4074 jshin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ3NTA2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDgtMTkgIEp1bmdzaGlr IFNoaW4gIDxqc2hpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mjg0NDEKKworICAgICAgICBGaXggYSBidWlsZCBpc3N1ZSB3aXRoIElDVSA0LjIgb3IgbGF0 ZXIgb24gV2luZG93cyB3aXRoIFZpc3VhbCBDKysuIAorICAgICAgICBJbnN0ZWFkIG9mIGRlZmlu aW5nIGFsbCBpc1hYWCBhbmQgdG91cHBlci90b2xvd2VyIGFzIAorICAgICAgICAgIFdURl9QbGVh c2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNU eXBlX2gsCisgICAgICAgICNkZWZpbmUgdGhlbSB0byBiZSBkaWZmZXJlbnQgYnkgcHJlcGVuZGlu ZyAnV1RGXy4uLkFTQ0lJVHlwZV9oJyB3aXRoCisgICAgICAgIHRoZSBvcmlnaW5pYWwgbmFtZXMg bGlrZSAndG91cHBlcl9XVEZfLi4uQVNDSUlUeXBlX2gnLiAKKworICAgICAgICAqIHd0Zi9EaXNh bGxvd0NUeXBlLmg6CisKIDIwMDktMDgtMTggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KSW5kZXg6IEphdmFT Y3JpcHRDb3JlL3d0Zi9EaXNhbGxvd0NUeXBlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENv cmUvd3RmL0Rpc2FsbG93Q1R5cGUuaAkocmV2aXNpb24gNDc1MDMpCisrKyBKYXZhU2NyaXB0Q29y ZS93dGYvRGlzYWxsb3dDVHlwZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01NCwyMSArNTQsMjEgQEAK ICN1bmRlZiB0b2xvd2VyCiAjdW5kZWYgdG91cHBlcgogCi0jZGVmaW5lIGlzYWxudW0gV1RGX1Bs ZWFzZV91c2VfQVNDSUlDVHlwZV9pbnN0ZWFkX29mX2N0eXBlX3NlZV9jb21tZW50X2luX0FTQ0lJ Q1R5cGVfaAotI2RlZmluZSBpc2FscGhhIFdURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVh ZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gKLSNkZWZpbmUgaXNhc2NpaSBX VEZfUGxlYXNlX3VzZV9BU0NJSUNUeXBlX2luc3RlYWRfb2ZfY3R5cGVfc2VlX2NvbW1lbnRfaW5f QVNDSUlDVHlwZV9oCi0jZGVmaW5lIGlzYmxhbmsgV1RGX1BsZWFzZV91c2VfQVNDSUlDVHlwZV9p bnN0ZWFkX29mX2N0eXBlX3NlZV9jb21tZW50X2luX0FTQ0lJQ1R5cGVfaAotI2RlZmluZSBpc2Nu dHJsIFdURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVfY29tbWVu dF9pbl9BU0NJSUNUeXBlX2gKLSNkZWZpbmUgaXNkaWdpdCBXVEZfUGxlYXNlX3VzZV9BU0NJSUNU eXBlX2luc3RlYWRfb2ZfY3R5cGVfc2VlX2NvbW1lbnRfaW5fQVNDSUlDVHlwZV9oCi0jZGVmaW5l IGlzZ3JhcGggV1RGX1BsZWFzZV91c2VfQVNDSUlDVHlwZV9pbnN0ZWFkX29mX2N0eXBlX3NlZV9j b21tZW50X2luX0FTQ0lJQ1R5cGVfaAotI2RlZmluZSBpc2xvd2VyIFdURl9QbGVhc2VfdXNlX0FT Q0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gKLSNk ZWZpbmUgaXNwcmludCBXVEZfUGxlYXNlX3VzZV9BU0NJSUNUeXBlX2luc3RlYWRfb2ZfY3R5cGVf c2VlX2NvbW1lbnRfaW5fQVNDSUlDVHlwZV9oCi0jZGVmaW5lIGlzcHVuY3QgV1RGX1BsZWFzZV91 c2VfQVNDSUlDVHlwZV9pbnN0ZWFkX29mX2N0eXBlX3NlZV9jb21tZW50X2luX0FTQ0lJQ1R5cGVf aAotI2RlZmluZSBpc3NwYWNlIFdURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9j dHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gKLSNkZWZpbmUgaXN1cHBlciBXVEZfUGxl YXNlX3VzZV9BU0NJSUNUeXBlX2luc3RlYWRfb2ZfY3R5cGVfc2VlX2NvbW1lbnRfaW5fQVNDSUlD VHlwZV9oCi0jZGVmaW5lIGlzeGRpZ2l0IFdURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVh ZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gKLSNkZWZpbmUgdG9hc2NpaSBX VEZfUGxlYXNlX3VzZV9BU0NJSUNUeXBlX2luc3RlYWRfb2ZfY3R5cGVfc2VlX2NvbW1lbnRfaW5f QVNDSUlDVHlwZV9oCi0jZGVmaW5lIHRvbG93ZXIgV1RGX1BsZWFzZV91c2VfQVNDSUlDVHlwZV9p bnN0ZWFkX29mX2N0eXBlX3NlZV9jb21tZW50X2luX0FTQ0lJQ1R5cGVfaAotI2RlZmluZSB0b3Vw cGVyIFdURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVfY29tbWVu dF9pbl9BU0NJSUNUeXBlX2gKKyNkZWZpbmUgaXNhbG51bSBpc2FsbnVtX1dURl9QbGVhc2VfdXNl X0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gK KyNkZWZpbmUgaXNhbHBoYSBpc2FscGhhX1dURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVh ZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gKKyNkZWZpbmUgaXNhc2NpaSBp c2FzY2lpX1dURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVfY29t bWVudF9pbl9BU0NJSUNUeXBlX2gKKyNkZWZpbmUgaXNibGFuayBpc2JsYW5rX1dURl9QbGVhc2Vf dXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBl X2gKKyNkZWZpbmUgaXNjbnRybCBpc2NudHJsX1dURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5z dGVhZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gKKyNkZWZpbmUgaXNkaWdp dCBpc2RpZ2l0X1dURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVf Y29tbWVudF9pbl9BU0NJSUNUeXBlX2gKKyNkZWZpbmUgaXNncmFwaCBpc2dyYXBoX1dURl9QbGVh c2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNU eXBlX2gKKyNkZWZpbmUgaXNsb3dlciBpc2xvd2VyX1dURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVf aW5zdGVhZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gKKyNkZWZpbmUgaXNw cmludCBpc3ByaW50X1dURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9z ZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gKKyNkZWZpbmUgaXNwdW5jdCBpc3B1bmN0X1dURl9Q bGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJ SUNUeXBlX2gKKyNkZWZpbmUgaXNzcGFjZSBpc3NwYWNlX1dURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5 cGVfaW5zdGVhZF9vZl9jdHlwZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gKKyNkZWZpbmUg aXN1cHBlciBpc3VwcGVyX1dURl9QbGVhc2VfdXNlX0FTQ0lJQ1R5cGVfaW5zdGVhZF9vZl9jdHlw ZV9zZWVfY29tbWVudF9pbl9BU0NJSUNUeXBlX2gKKyNkZWZpbmUgaXN4ZGlnaXQgaXN4ZGlnaXRf V1RGX1BsZWFzZV91c2VfQVNDSUlDVHlwZV9pbnN0ZWFkX29mX2N0eXBlX3NlZV9jb21tZW50X2lu X0FTQ0lJQ1R5cGVfaAorI2RlZmluZSB0b2FzY2lpIHRvYXNjaWlfV1RGX1BsZWFzZV91c2VfQVND SUlDVHlwZV9pbnN0ZWFkX29mX2N0eXBlX3NlZV9jb21tZW50X2luX0FTQ0lJQ1R5cGVfaAorI2Rl ZmluZSB0b2xvd2VyIHRvbG93ZXJfV1RGX1BsZWFzZV91c2VfQVNDSUlDVHlwZV9pbnN0ZWFkX29m X2N0eXBlX3NlZV9jb21tZW50X2luX0FTQ0lJQ1R5cGVfaAorI2RlZmluZSB0b3VwcGVyIHRvdXBw ZXJfV1RGX1BsZWFzZV91c2VfQVNDSUlDVHlwZV9pbnN0ZWFkX29mX2N0eXBlX3NlZV9jb21tZW50 X2luX0FTQ0lJQ1R5cGVfaAogCiAjZW5kaWYK