28432 2009-08-18 10:46:58 -0700 String::createCFString() returns a non-retained empty string 2009-08-18 13:02:40 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P4 Minor --- 1 ap ap oldest_to_newest 141128 0 ap 2009-08-18 10:46:58 -0700 If String is null, createCFString() returns CFSTR(""). According to CFString.h, 'CFSTR(), not being a "Copy" or "Create" function, does not return a new reference for you. So, you should not release the return value.' I am not aware of any practical issues caused by this, but we should probably comply. 141129 1 35051 ap 2009-08-18 10:49:02 -0700 Created attachment 35051 proposed patch 141133 2 35051 mrowe 2009-08-18 11:01:46 -0700 Comment on attachment 35051 proposed patch > + * platform/text/cf/StringCF.cpp: (WebCore::String::createCFString): Rather than retain > + CFSTR result, we can just return a new string, this doesn't seem to be a hot code path Even though it's not a hot code path it seems like we should avoid the extra memory allocation that CFStringCreateWithCharacters does compared to CFSTR. 141134 3 35051 darin 2009-08-18 11:01:55 -0700 Comment on attachment 35051 proposed patch If either solution is fine speed-wise, then why not call CFRetain to save memory in case a lot of these strings are kept around? 141177 4 ap 2009-08-18 13:02:40 -0700 Committed revision 47449. > If either solution is fine speed-wise, then why not call CFRetain to save > memory in case a lot of these strings are kept around? OK, changed. /me doesn't like to share objects across threads. 35051 2009-08-18 10:49:02 -0700 2009-08-18 11:01:55 -0700 proposed patch EmptyString.txt text/plain 1210 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzQzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDgtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4NDMyCisgICAgICAgIFN0 cmluZzo6Y3JlYXRlQ0ZTdHJpbmcoKSByZXR1cm5zIGEgbm9uLXJldGFpbmVkIGVtcHR5IHN0cmlu ZworCisgICAgICAgIE5vIGtub3duIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LCBzbyBubyB0ZXN0 LgorCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9jZi9TdHJpbmdDRi5jcHA6IChXZWJDb3JlOjpT dHJpbmc6OmNyZWF0ZUNGU3RyaW5nKTogUmF0aGVyIHRoYW4gcmV0YWluCisgICAgICAgIENGU1RS IHJlc3VsdCwgd2UgY2FuIGp1c3QgcmV0dXJuIGEgbmV3IHN0cmluZywgdGhpcyBkb2Vzbid0IHNl ZW0gdG8gYmUgYSBob3QgY29kZSBwYXRoLgorCiAyMDA5LTA4LTE4ICBQZXRlciBLYXN0aW5nICA8 cGthc3RpbmdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4K SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9jZi9TdHJpbmdDRi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2NmL1N0cmluZ0NGLmNwcAkocmV2aXNpb24gNDc0Mjgp CisrKyBXZWJDb3JlL3BsYXRmb3JtL3RleHQvY2YvU3RyaW5nQ0YuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00NSw3ICs0NSw3IEBAIFN0cmluZzo6U3RyaW5nKENGU3RyaW5nUmVmIHN0cikKIENGU3Ry aW5nUmVmIFN0cmluZzo6Y3JlYXRlQ0ZTdHJpbmcoKSBjb25zdAogewogICAgIGlmICghbV9pbXBs KQotICAgICAgICByZXR1cm4gQ0ZTVFIoIiIpOworICAgICAgICByZXR1cm4gQ0ZTdHJpbmdDcmVh dGVXaXRoQ2hhcmFjdGVycygwLCAwLCAwKTsKIAogICAgIHJldHVybiBtX2ltcGwtPmNyZWF0ZUNG U3RyaW5nKCk7CiB9Cg==