28431 2009-08-18 10:18:05 -0700 Application Cache doesn't work with HTTP authentication 2009-08-18 12:04:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 141117 0 ap 2009-08-18 10:18:05 -0700 When updating an application cache, the user is not asked for credentials, which makes sense. However, credentials that already exist in credential storage also aren't used. I'm not sure if it makes huge sense to cache authenticated resources - once they are cached, they become available to anyone who asks, even after browser restart. Also, there is no way to make appcache store several versions of content that depends on user identity (cookies have the same problem). But if web developers want to, we probably shouldn't stop them. This works in Firefox, FWIW. 141120 1 35048 ap 2009-08-18 10:27:18 -0700 Created attachment 35048 proposed fix 141121 2 35048 darin 2009-08-18 10:29:42 -0700 Comment on attachment 35048 proposed fix > + // For normal resource loading, WebKit client is asked about each resource individually. Since application cache does not belong to any particular document, > + // the existing client callback cannot be used, and just assume that any client that enables application cache also wants it to use credential storage. Should say "so assume" rather than "and just assume". r=me 141156 3 ap 2009-08-18 12:04:04 -0700 Committed revision 47439. 35048 2009-08-18 10:27:18 -0700 2009-08-18 10:29:41 -0700 proposed fix AppcacheAuth.txt text/plain 7287 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzQyOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDgtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4NDMxCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83MTM3NjEwPiBBcHBsaWNhdGlvbiBDYWNoZSBkb2Vzbid0IHdvcmsgd2l0 aCBIVFRQIGF1dGhlbnRpY2F0aW9uCisKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0cy9hcHBjYWNo ZS9hdXRoLmh0bWwKKworICAgICAgICAqIGxvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hl R3JvdXAuaDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGxpY2F0aW9uQ2FjaGVHcm91cDo6c2hvdWxk VXNlQ3JlZGVudGlhbFN0b3JhZ2UpOiBJZiBhcHBjYWNoZSBpcyBlbmFibGVkLAorICAgICAgICBh bHdheXMgYWxsb3cgaXQgdG8gdXNlIHN0b3JlZCBjcmVkZW50aWFscyAod2UgY2FuJ3QgYXNrIFdl YktpdCBjbGllbnQsIGFuZCBtYXliZSB3ZQorICAgICAgICBzaG91bGRuJ3QgYXNrIGl0LCBiZWNh dXNlIGl0J3Mgbm90IGEgZG9jdW1lbnQgdGhhdCdzIGxvYWRpbmcgdGhlc2UgcmVzb3VyY2VzKS4K KwogMjAwOS0wOC0xOCAgQXJpeWEgSGlkYXlhdCAgPGFyaXlhLmhpZGF5YXRAbm9raWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIGJ1aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL2Fw cGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91cC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9h ZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91cC5oCShyZXZpc2lvbiA0NzQyOCkKKysr IFdlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVHcm91cC5oCSh3b3JraW5n IGNvcHkpCkBAIC05Nyw2ICs5NywxMCBAQCBwcml2YXRlOgogCiAgICAgUGFzc1JlZlB0cjxSZXNv dXJjZUhhbmRsZT4gY3JlYXRlUmVzb3VyY2VIYW5kbGUoY29uc3QgS1VSTCYsIEFwcGxpY2F0aW9u Q2FjaGVSZXNvdXJjZSogbmV3ZXN0Q2FjaGVkUmVzb3VyY2UpOwogCisgICAgLy8gRm9yIG5vcm1h bCByZXNvdXJjZSBsb2FkaW5nLCBXZWJLaXQgY2xpZW50IGlzIGFza2VkIGFib3V0IGVhY2ggcmVz b3VyY2UgaW5kaXZpZHVhbGx5LiBTaW5jZSBhcHBsaWNhdGlvbiBjYWNoZSBkb2VzIG5vdCBiZWxv bmcgdG8gYW55IHBhcnRpY3VsYXIgZG9jdW1lbnQsCisgICAgLy8gdGhlIGV4aXN0aW5nIGNsaWVu dCBjYWxsYmFjayBjYW5ub3QgYmUgdXNlZCwgYW5kIGp1c3QgYXNzdW1lIHRoYXQgYW55IGNsaWVu dCB0aGF0IGVuYWJsZXMgYXBwbGljYXRpb24gY2FjaGUgYWxzbyB3YW50cyBpdCB0byB1c2UgY3Jl ZGVudGlhbCBzdG9yYWdlLgorICAgIHZpcnR1YWwgYm9vbCBzaG91bGRVc2VDcmVkZW50aWFsU3Rv cmFnZShSZXNvdXJjZUhhbmRsZSopIHsgcmV0dXJuIHRydWU7IH0KKwogICAgIHZpcnR1YWwgdm9p ZCBkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBSZXNvdXJjZVJlc3Bv bnNlJik7CiAgICAgdmlydHVhbCB2b2lkIGRpZFJlY2VpdmVEYXRhKFJlc291cmNlSGFuZGxlKiwg Y29uc3QgY2hhciosIGludCwgaW50IGxlbmd0aFJlY2VpdmVkKTsKICAgICB2aXJ0dWFsIHZvaWQg ZGlkRmluaXNoTG9hZGluZyhSZXNvdXJjZUhhbmRsZSopOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDc0 MjgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx OCBAQAorMjAwOS0wOC0xOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg0MzEKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzcxMzc2MTA+IEFwcGxpY2F0aW9uIENhY2hlIGRvZXNuJ3Qgd29yayB3aXRoIEhUVFAgYXV0 aGVudGljYXRpb24KKworICAgICAgICAqIGh0dHAvdGVzdHMvYXBwY2FjaGUvYXV0aC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvYXBwY2FjaGUvYXV0aC5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy9hdXRoOiBBZGRl ZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy9hdXRoL2lmcmFtZS5w aHA6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2VzL2F1dGgv bWFuaWZlc3QucGhwOiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291 cmNlcy9hdXRoL3NldHVwLnBocDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9hcHBjYWNo ZS9yZXNvdXJjZXMvYXV0aC9zdWJyZXNvdXJjZS5waHA6IEFkZGVkLgorCiAyMDA5LTA4LTE4ICBB bmRyYXMgQmVjc2kgIDxiZWNzaS5hbmRyYXNAc3R1ZC51LXN6ZWdlZC5odT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBcml5YSBIaWRheWF0LgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9h cHBjYWNoZS9hdXRoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2FwcGNhY2hlL2F1dGgtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9hdXRoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSw1IEBACitUZXN0IHRoYXQgYXBwY2FjaGUgd29ya3Mgd2l0aCBhdXRoZW50aWNh dGlvbi4gU2hvdWxkIHNheSBTVUNDRVNTOgorCitTVUNDRVNTCisKKwoKUHJvcGVydHkgY2hhbmdl cyBvbjogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9hdXRoLWV4cGVjdGVkLnR4dApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L3BsYWluCk5hbWU6IHN2bjpl b2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNh Y2hlL2F1dGguaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNh Y2hlL2F1dGguaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBw Y2FjaGUvYXV0aC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI4IEBACis8Ym9keT4KKzxw PlRlc3QgdGhhdCBhcHBjYWNoZSB3b3JrcyB3aXRoIGF1dGhlbnRpY2F0aW9uLiBTaG91bGQgc2F5 IFNVQ0NFU1M6PC9wPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp IHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorCisvLyBTdG9yZSBhdXRoZW50aWNhdGlv biBjcmVkZW50aWFscy4KK3ZhciByZXEgPSBuZXcgWE1MSHR0cFJlcXVlc3Q7CityZXEub3Blbigi R0VUIiwgInJlc291cmNlcy9hdXRoL3NldHVwLnBocCIsIGZhbHNlLCAibG9naW4iLCAicGFzd29y ZCIpOworcmVxLnNlbmQoKTsKKwordmFyIGlmciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlm cmFtZSIpOworaWZyLnNldEF0dHJpYnV0ZSgic3JjIiwgInJlc291cmNlcy9hdXRoL2lmcmFtZS5w aHAiKTsKK2RvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoaWZyKTsKKworZnVuY3Rpb24gc3VjY2Vz cygpCit7CisgICAgdmFyIHRleHQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJwIik7CisgICAg dGV4dC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgiU1VDQ0VTUyIpKTsKKyAg ICBkb2N1bWVudC5ib2R5LnJlcGxhY2VDaGlsZCh0ZXh0LCBkb2N1bWVudC5nZXRFbGVtZW50c0J5 VGFnTmFtZSgiaWZyYW1lIilbMF0pOworCisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworfQorPC9z Y3JpcHQ+Cis8L2JvZHk+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2FwcGNhY2hlL2F1dGguaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAg KyB0ZXh0L2h0bWwKCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291 cmNlcy9hdXRoL2lmcmFtZS5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9hcHBjYWNoZS9yZXNvdXJjZXMvYXV0aC9pZnJhbWUucGhwCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9yZXNvdXJjZXMvYXV0aC9pZnJhbWUucGhwCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE2IEBACis8P3BocAorICBpZiAoIWlzc2V0KCRfU0VSVkVS WydQSFBfQVVUSF9VU0VSJ10pKSB7CisgICBoZWFkZXIoJ1dXVy1BdXRoZW50aWNhdGU6IEJhc2lj IHJlYWxtPSJXZWJLaXQgQXBwQ2FjaGUgVGVzdCBSZWFsbSInKTsKKyAgIGhlYWRlcignSFRUUC8x LjAgNDAxIFVuYXV0aG9yaXplZCcpOworICAgZWNobyAnQXV0aGVudGljYXRpb24gY2FuY2VsZWQn OworICAgZXhpdDsKKyAgfSBlbHNlIHsKKyAgIGVjaG8gIjxodG1sIG1hbmlmZXN0PSdtYW5pZmVz dC5waHAnPlxuIjsKKyAgIGVjaG8gIjxwPlN1YmZyYW1lLCBzaG91bGQgZGlzYXBwZWFyLjwvcD5c biI7CisgICBlY2hvICI8c2NyaXB0PlxuIjsKKyAgIGVjaG8gIiAgICBhcHBsaWNhdGlvbkNhY2hl Lm9uY2FjaGVkID0gcGFyZW50LnN1Y2Nlc3M7XG4iOworICAgZWNobyAiICAgIGFwcGxpY2F0aW9u Q2FjaGUub25ub3VwZGF0ZSA9IHBhcmVudC5zdWNjZXNzO1xuIjsKKyAgIGVjaG8gIjwvc2NyaXB0 PlxuIjsKKyAgIGVjaG8gIjwvaHRtbD5cbiI7CisgIH0KKz8+CkluZGV4OiBMYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy9hdXRoL21hbmlmZXN0LnBocAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy9hdXRoL21hbmlm ZXN0LnBocAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUv cmVzb3VyY2VzL2F1dGgvbWFuaWZlc3QucGhwCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEyIEBA Cis8P3BocAorICBpZiAoIWlzc2V0KCRfU0VSVkVSWydQSFBfQVVUSF9VU0VSJ10pKSB7CisgICBo ZWFkZXIoJ1dXVy1BdXRoZW50aWNhdGU6IEJhc2ljIHJlYWxtPSJXZWJLaXQgQXBwQ2FjaGUgVGVz dCBSZWFsbSInKTsKKyAgIGhlYWRlcignSFRUUC8xLjAgNDAxIFVuYXV0aG9yaXplZCcpOworICAg ZWNobyAnQXV0aGVudGljYXRpb24gY2FuY2VsZWQnOworICAgZXhpdDsKKyAgfSBlbHNlIHsKKyAg IGhlYWRlcigiQ29udGVudC1UeXBlOiB0ZXh0L2NhY2hlLW1hbmlmZXN0Iik7CisgICBlY2hvICJD QUNIRSBNQU5JRkVTVFxuIjsKKyAgIGVjaG8gInN1YnJlc291cmNlLnBocFxuIjsKKyAgfQorPz4K SW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2VzL2F1dGgvc2V0 dXAucGhwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvcmVz b3VyY2VzL2F1dGgvc2V0dXAucGhwCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9hcHBjYWNoZS9yZXNvdXJjZXMvYXV0aC9zZXR1cC5waHAJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMTAgQEAKKzw/cGhwCisgIGlmICghaXNzZXQoJF9TRVJWRVJbJ1BIUF9BVVRIX1VTRVIn XSkpIHsKKyAgIGhlYWRlcignV1dXLUF1dGhlbnRpY2F0ZTogQmFzaWMgcmVhbG09IldlYktpdCBB cHBDYWNoZSBUZXN0IFJlYWxtIicpOworICAgaGVhZGVyKCdIVFRQLzEuMCA0MDEgVW5hdXRob3Jp emVkJyk7CisgICBlY2hvICdBdXRoZW50aWNhdGlvbiBjYW5jZWxlZCc7CisgICBleGl0OworICB9 IGVsc2UgeworICAgZWNobyAiT0tcbiI7CisgIH0KKz8+CkluZGV4OiBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy9hdXRoL3N1YnJlc291cmNlLnBocAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy9hdXRoL3N1YnJl c291cmNlLnBocAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2Fj aGUvcmVzb3VyY2VzL2F1dGgvc3VicmVzb3VyY2UucGhwCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDEwIEBACis8P3BocAorICBpZiAoIWlzc2V0KCRfU0VSVkVSWydQSFBfQVVUSF9VU0VSJ10pKSB7 CisgICBoZWFkZXIoJ1dXVy1BdXRoZW50aWNhdGU6IEJhc2ljIHJlYWxtPSJXZWJLaXQgQXBwQ2Fj aGUgVGVzdCBSZWFsbSInKTsKKyAgIGhlYWRlcignSFRUUC8xLjAgNDAxIFVuYXV0aG9yaXplZCcp OworICAgZWNobyAnQXV0aGVudGljYXRpb24gY2FuY2VsZWQnOworICAgZXhpdDsKKyAgfSBlbHNl IHsKKyAgIGVjaG8gIi8qIEVtcHR5IHN1YnJlc291cmNlICovIjsKKyAgfQorPz4K