28427 2009-08-18 07:29:02 -0700 WebInspector: Fix array formatter 2009-08-18 14:09:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman timothy oldest_to_newest 141081 0 pfeldman 2009-08-18 07:29:02 -0700 1. open WebInspector 2. open Console 3. type in "[1,2,3]" Expected: [1,2,3] in console Actual: [] in console 141095 1 35043 pfeldman 2009-08-18 08:57:24 -0700 Created attachment 35043 patch 141172 2 pfeldman 2009-08-18 12:47:29 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/InjectedScript.js Committed r47443 141205 3 35069 pfeldman 2009-08-18 13:58:38 -0700 Created attachment 35069 patch No need to unwrap node objects. 141215 4 pfeldman 2009-08-18 14:09:13 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js Committed r47455 35043 2009-08-18 08:57:24 -0700 2009-08-18 10:35:29 -0700 patch array_format text/plain 5705 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2ZjYzAwNi4uZDNjMmMxMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wOC0xOCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBGaXggYXJyYXkgZm9ybWF0dGVyLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODQyNwor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5Db25zb2xlVmlldy5wcm90b3R5cGUuX2Zvcm1hdGFycmF5KToKKwogMjAw OS0wOC0xNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nv bnNvbGVWaWV3LmpzCmluZGV4IGQ0NjkzYjcuLjU1OTc3NTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKQEAgLTM4NCwxMSArMzg0LDE5IEBAIFdlYkluc3Bl Y3Rvci5Db25zb2xlVmlldy5wcm90b3R5cGUgPSB7CiAKICAgICBfZm9ybWF0OiBmdW5jdGlvbihv dXRwdXQsIGZvcmNlT2JqZWN0Rm9ybWF0KQogICAgIHsKKyAgICAgICAgdmFyIGlzUHJveHkgPSB0 eXBlb2Ygb3V0cHV0ID09PSAib2JqZWN0IjsKKwogICAgICAgICBpZiAoZm9yY2VPYmplY3RGb3Jt YXQpCiAgICAgICAgICAgICB2YXIgdHlwZSA9ICJvYmplY3QiOwogICAgICAgICBlbHNlCiAgICAg ICAgICAgICB2YXIgdHlwZSA9IE9iamVjdC5wcm94eVR5cGUob3V0cHV0KTsKIAorICAgICAgICBp ZiAoaXNQcm94eSAmJiB0eXBlICE9PSAib2JqZWN0IiAmJiB0eXBlICE9PSAiZnVuY3Rpb24iICYg dHlwZSAhPT0gImFycmF5IikgeworICAgICAgICAgICAgLy8gVW53cmFwIHByaW1pdGl2ZSB2YWx1 ZSwgc2tpcCBkZWNvcmF0aW9uLgorICAgICAgICAgICAgb3V0cHV0ID0gb3V0cHV0LmRlc2NyaXB0 aW9uOworICAgICAgICAgICAgdHlwZSA9ICJ1bmRlY29yYXRlZCIKKyAgICAgICAgfQorCiAgICAg ICAgIC8vIFdlIGRvbid0IHBlcmZvcm0gYW55IHNwZWNpYWwgZm9ybWF0dGluZyBvbiB0aGVzZSB0 eXBlcywgc28gd2UganVzdAogICAgICAgICAvLyBwYXNzIHRoZW0gdGhyb3VnaCB0aGUgc2ltcGxl IF9mb3JtYXR2YWx1ZSBmdW5jdGlvbi4KICAgICAgICAgdmFyIHVuZGVjb3JhdGVkVHlwZXMgPSB7 CkBAIC0zOTYsNiArNDA0LDcgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgICJudWxsIjogMSwKICAgICAgICAgICAgICJib29sZWFuIjogMSwKICAg ICAgICAgICAgICJudW1iZXIiOiAxLAorICAgICAgICAgICAgInVuZGVjb3JhdGVkIjogMQogICAg ICAgICB9OwogCiAgICAgICAgIHZhciBmb3JtYXR0ZXI7CkBAIC00MjksNyArNDM4LDcgQEAgV2Vi SW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZSA9IHsKIAogICAgIF9mb3JtYXRkYXRlOiBm dW5jdGlvbihkYXRlLCBlbGVtKQogICAgIHsKLSAgICAgICAgZWxlbS5hcHBlbmRDaGlsZChkb2N1 bWVudC5jcmVhdGVUZXh0Tm9kZShkYXRlLmRlc2NyaXB0aW9uKSk7CisgICAgICAgIGVsZW0uYXBw ZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoZGF0ZSkpOwogICAgIH0sCiAKICAgICBf Zm9ybWF0c3RyaW5nOiBmdW5jdGlvbihzdHIsIGVsZW0pCkBAIC00NDUsMTMgKzQ1NCwyMSBAQCBX ZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogCiAgICAgX2Zvcm1hdGFycmF5 OiBmdW5jdGlvbihhcnIsIGVsZW0pCiAgICAgewotICAgICAgICBlbGVtLmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZVRleHROb2RlKCJbIikpOwotICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8 IGFyci5sZW5ndGg7ICsraSkgewotICAgICAgICAgICAgZWxlbS5hcHBlbmRDaGlsZCh0aGlzLl9m b3JtYXQoYXJyW2ldKSk7Ci0gICAgICAgICAgICBpZiAoaSA8IGFyci5sZW5ndGggLSAxKQotICAg ICAgICAgICAgICAgIGVsZW0uYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoIiwg IikpOworICAgICAgICB2YXIgc2VsZiA9IHRoaXM7CisgICAgICAgIGZ1bmN0aW9uIHByaW50UmVz dWx0KHByb3BlcnRpZXMpCisgICAgICAgIHsKKyAgICAgICAgICAgIGlmICghcHJvcGVydGllcykK KyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICBlbGVtLmFwcGVuZENoaWxkKGRv Y3VtZW50LmNyZWF0ZVRleHROb2RlKCJbIikpOworICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7 IGkgPCBwcm9wZXJ0aWVzLmxlbmd0aDsgKytpKSB7CisgICAgICAgICAgICAgICAgdmFyIHByb3Bl cnR5ID0gcHJvcGVydGllc1tpXS52YWx1ZTsKKyAgICAgICAgICAgICAgICBlbGVtLmFwcGVuZENo aWxkKHNlbGYuX2Zvcm1hdChwcm9wZXJ0eSkpOworICAgICAgICAgICAgICAgIGlmIChpIDwgcHJv cGVydGllcy5sZW5ndGggLSAxKQorICAgICAgICAgICAgICAgICAgICBlbGVtLmFwcGVuZENoaWxk KGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCIsICIpKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAg ICAgIGVsZW0uYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoIl0iKSk7CiAgICAg ICAgIH0KLSAgICAgICAgZWxlbS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgi XSIpKTsKKyAgICAgICAgSW5zcGVjdG9yQ29udHJvbGxlci5nZXRQcm9wZXJ0aWVzKGFyciwgdHJ1 ZSwgcHJpbnRSZXN1bHQpOwogICAgIH0sCiAKICAgICBfZm9ybWF0bm9kZTogZnVuY3Rpb24ob2Jq ZWN0LCBlbGVtKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVj dGVkU2NyaXB0LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0 LmpzCmluZGV4IDQxNDQ4MjYuLmQwNTg2NmMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKQEAgLTQzNCwzMyArNDM0LDE3IEBAIEluamVjdGVkU2Ny aXB0LmdldFByb3BlcnRpZXMgPSBmdW5jdGlvbihvYmplY3RQcm94eSwgaWdub3JlSGFzT3duUHJv cGVydHkpCiAgICAgICAgIGlmICghaWdub3JlSGFzT3duUHJvcGVydHkgJiYgImhhc093blByb3Bl cnR5IiBpbiBvYmplY3QgJiYgIW9iamVjdC5oYXNPd25Qcm9wZXJ0eShwcm9wZXJ0eU5hbWUpKQog ICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgLy9UT0RPOiByZW1vdmUgdGhpcyBvbmNl IG9iamVjdCBiZWNvbWVzIHJlYWxseSByZW1vdGUuCi0gICAgICAgIGlmIChwcm9wZXJ0eU5hbWUg PT09ICJfX3RyZWVFbGVtZW50SWRlbnRpZmllciIpCi0gICAgICAgICAgICBjb250aW51ZTsKICAg ICAgICAgdmFyIHByb3BlcnR5ID0ge307CiAgICAgICAgIHByb3BlcnR5Lm5hbWUgPSBwcm9wZXJ0 eU5hbWU7CiAgICAgICAgIHByb3BlcnR5LnBhcmVudE9iamVjdFByb3h5ID0gb2JqZWN0UHJveHk7 CiAgICAgICAgIHZhciBpc0dldHRlciA9IG9iamVjdFsiX19sb29rdXBHZXR0ZXJfXyJdICYmIG9i amVjdC5fX2xvb2t1cEdldHRlcl9fKHByb3BlcnR5TmFtZSk7CiAgICAgICAgIGlmICghcHJvcGVy dHkuaXNHZXR0ZXIpIHsKICAgICAgICAgICAgIHZhciBjaGlsZE9iamVjdCA9IG9iamVjdFtwcm9w ZXJ0eU5hbWVdOwotICAgICAgICAgICAgdmFyIGNoaWxkT2JqZWN0UHJveHkgPSB7fTsKLSAgICAg ICAgICAgIGNoaWxkT2JqZWN0UHJveHkub2JqZWN0SWQgPSBvYmplY3RQcm94eS5vYmplY3RJZDsK KyAgICAgICAgICAgIHZhciBjaGlsZE9iamVjdFByb3h5ID0gbmV3IEluamVjdGVkU2NyaXB0LmNy ZWF0ZVByb3h5T2JqZWN0KGNoaWxkT2JqZWN0LCBvYmplY3RQcm94eS5vYmplY3RJZCk7CiAgICAg ICAgICAgICBjaGlsZE9iamVjdFByb3h5LnBhdGggPSBvYmplY3RQcm94eS5wYXRoID8gb2JqZWN0 UHJveHkucGF0aC5zbGljZSgpIDogW107CiAgICAgICAgICAgICBjaGlsZE9iamVjdFByb3h5LnBh dGgucHVzaChwcm9wZXJ0eU5hbWUpOwotCiAgICAgICAgICAgICBjaGlsZE9iamVjdFByb3h5LnBy b3RvRGVwdGggPSBvYmplY3RQcm94eS5wcm90b0RlcHRoIHx8IDA7Ci0gICAgICAgICAgICBjaGls ZE9iamVjdFByb3h5LmRlc2NyaXB0aW9uID0gT2JqZWN0LmRlc2NyaWJlKGNoaWxkT2JqZWN0LCB0 cnVlKTsKICAgICAgICAgICAgIHByb3BlcnR5LnZhbHVlID0gY2hpbGRPYmplY3RQcm94eTsKLQot ICAgICAgICAgICAgdmFyIHR5cGUgPSB0eXBlb2YgY2hpbGRPYmplY3Q7Ci0gICAgICAgICAgICBp ZiAodHlwZSA9PT0gIm9iamVjdCIgfHwgdHlwZSA9PT0gImZ1bmN0aW9uIikgewotICAgICAgICAg ICAgICAgIGZvciAodmFyIHN1YlByb3BlcnR5TmFtZSBpbiBjaGlsZE9iamVjdCkgewotICAgICAg ICAgICAgICAgICAgICBpZiAocHJvcGVydHlOYW1lID09PSAiX190cmVlRWxlbWVudElkZW50aWZp ZXIiKQotICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICAgICAg ICAgIGNoaWxkT2JqZWN0UHJveHkuaGFzQ2hpbGRyZW4gPSB0cnVlOwotICAgICAgICAgICAgICAg ICAgICBicmVhazsKLSAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICB9CiAgICAgICAgIH0g ZWxzZSB7CiAgICAgICAgICAgICAvLyBGSVhNRTogdGhpcyBzaG91bGQgc2hvdyBzb21ldGhpbmcg bGlrZSAiZ2V0dGVyIiAoYnVnIDE2NzM0KS4KICAgICAgICAgICAgIHByb3BlcnR5LnZhbHVlID0g eyBkZXNjcmlwdGlvbjogIlx1MjAxNCIgfTsgLy8gZW0gZGFzaApAQCAtODg3LDYgKzg3MSwxNCBA QCBJbmplY3RlZFNjcmlwdC5jcmVhdGVQcm94eU9iamVjdCA9IGZ1bmN0aW9uKG9iamVjdCwgb2Jq ZWN0SWQpCiAgICAgcmVzdWx0LnR5cGUgPSBPYmplY3QudHlwZShvYmplY3QsIEluamVjdGVkU2Ny aXB0Ll93aW5kb3coKSk7CiAgICAgaWYgKHJlc3VsdC50eXBlID09PSAibm9kZSIpCiAgICAgICAg IHJlc3VsdC5ub2RlSWQgPSBJbnNwZWN0b3JDb250cm9sbGVyLnB1c2hOb2RlUGF0aFRvRnJvbnRl bmQob2JqZWN0LCBmYWxzZSk7CisKKyAgICB2YXIgdHlwZSA9IHR5cGVvZiBvYmplY3Q7CisgICAg aWYgKHR5cGUgPT09ICJvYmplY3QiIHx8IHR5cGUgPT09ICJmdW5jdGlvbiIpIHsKKyAgICAgICAg Zm9yICh2YXIgc3ViUHJvcGVydHlOYW1lIGluIG9iamVjdCkgeworICAgICAgICAgICAgcmVzdWx0 Lmhhc0NoaWxkcmVuID0gdHJ1ZTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAg fQogICAgIHRyeSB7CiAgICAgICAgIHJlc3VsdC5kZXNjcmlwdGlvbiA9IE9iamVjdC5kZXNjcmli ZShvYmplY3QsIHRydWUsIEluamVjdGVkU2NyaXB0Ll93aW5kb3coKSk7CiAgICAgfSBjYXRjaCAo ZSkgewo= 35069 2009-08-18 13:58:38 -0700 2009-08-18 14:01:14 -0700 patch node_formatter text/plain 1298 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGY5NWI1Mi4uYTA0YzQzOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxNyBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IFRp bW90aHkgSGF0Y2hlci4KIAorICAgICAgICBXZWJJbnNwZWN0b3I6IEZpeCBhcnJheSBmb3JtYXR0 ZXIgZm9sbG93dXA6IG5vZGUgZm9ybWF0dGVyLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODQyNworCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9Db25zb2xlVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xlVmlldy5w cm90b3R5cGUuX2Zvcm1hdCk6CisKKzIwMDktMDgtMTggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h bkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgor CiAgICAgICAgIFdlYkluc3BlY3RvcjogTWV0cmljcyBzaWRlYmFyIGJyb2tlbgogCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODQzNApkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzIGIvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCmluZGV4IDU1OTc3NTUuLjMyODdkZWIg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwor KysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKQEAgLTM5MSw3 ICszOTEsNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogICAgICAg ICBlbHNlCiAgICAgICAgICAgICB2YXIgdHlwZSA9IE9iamVjdC5wcm94eVR5cGUob3V0cHV0KTsK IAotICAgICAgICBpZiAoaXNQcm94eSAmJiB0eXBlICE9PSAib2JqZWN0IiAmJiB0eXBlICE9PSAi ZnVuY3Rpb24iICYgdHlwZSAhPT0gImFycmF5IikgeworICAgICAgICBpZiAoaXNQcm94eSAmJiB0 eXBlICE9PSAib2JqZWN0IiAmJiB0eXBlICE9PSAiZnVuY3Rpb24iICYmIHR5cGUgIT09ICJhcnJh eSIgJiYgdHlwZSAhPT0gIm5vZGUiKSB7CiAgICAgICAgICAgICAvLyBVbndyYXAgcHJpbWl0aXZl IHZhbHVlLCBza2lwIGRlY29yYXRpb24uCiAgICAgICAgICAgICBvdXRwdXQgPSBvdXRwdXQuZGVz Y3JpcHRpb247CiAgICAgICAgICAgICB0eXBlID0gInVuZGVjb3JhdGVkIgo=