284216 2024-12-06 20:39:51 -0800 Create WebKitWebExtensionMatchPattern API for WebKitGTK 2025-01-31 08:03:41 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=286813 P2 Normal --- 1 jmurphy philn bugs-noreply dpino philn oldest_to_newest 2079853 0 jmurphy 2024-12-06 20:39:51 -0800 This API exposes WebExtensionMatchPattern support to WebKitGtk, which can then be used by future implementations of WebExtension and WebExtensionContext. 2079854 1 jmurphy 2024-12-06 20:42:05 -0800 Pull request: https://github.com/WebKit/WebKit/pull/37582 2084816 2 ews-feeder 2025-01-03 16:45:11 -0800 Committed 288424@main (b2a4be47a0aa): <https://commits.webkit.org/288424@main> Reviewed commits have been landed. Closing PR #37582 and removing active labels. 2084850 3 dpino 2025-01-04 03:17:24 -0800 After this patch, the 'GTK-Linux-64-bit-Release-Debian-Stable-Build' bot is failing with the following error: https://build.webkit.org/#/builders/46/builds/46081 ``` /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:641:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE’ was not declared in this scope; did you mean ‘WEBKIT_TYPE_WEB_EXTENSION_MATCH_PATTERN_OPTIONS’? 641 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE", "none" }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | WEBKIT_TYPE_WEB_EXTENSION_MATCH_PATTERN_OPTIONS /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:642:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES’ was not declared in this scope; did you mean ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_SCHEME’? 642 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES", "ignore-schemes" }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_SCHEME /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:643:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS’ was not declared in this scope; did you mean ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_PATH’? 643 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS", "ignore-paths" }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_PATH /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:644:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY’ was not declared in this scope 644 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY", "match-bidirectionally" }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` 2084851 4 dpino 2025-01-04 03:17:55 -0800 Re-opening for pull request https://github.com/webkit/webkit/pull/38530 2084853 5 ews-feeder 2025-01-04 03:51:16 -0800 Committed 288434@main (1ddcb1544050): <https://commits.webkit.org/288434@main> Reviewed commits have been landed. Closing PR #38530 and removing active labels. 2084856 6 dpino 2025-01-04 05:14:26 -0800 After landing the patch before, there was another build error reported by 'GTK-Linux-64-bit-Release-Ubuntu-LTS-Build': https://build.webkit.org/#/builders/68/builds/39352 ``` /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/Source/WebKit/UIProcess/API/glib/WebKitWebExtensionMatchPattern.cpp:393:12: error: return-statement with a value, in function returning ‘void’ [-fpermissive] 393 | return nullptr; | ^~~~~~~ ``` 2084857 7 dpino 2025-01-04 05:15:08 -0800 Re-opening for pull request https://github.com/webkit/webkit/pull/38531 2084858 8 ews-feeder 2025-01-04 05:24:59 -0800 Committed 288435@main (d812f50c13b6): <https://commits.webkit.org/288435@main> Reviewed commits have been landed. Closing PR #38531 and removing active labels. 2084899 9 philn 2025-01-05 03:34:39 -0800 (In reply to Diego Pino from comment #3) > After this patch, the 'GTK-Linux-64-bit-Release-Debian-Stable-Build' bot is > failing with the following error: > > https://build.webkit.org/#/builders/46/builds/46081 > > ``` > /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/ > WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp: > 641:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE’ was not > declared in this scope; did you mean > ‘WEBKIT_TYPE_WEB_EXTENSION_MATCH_PATTERN_OPTIONS’? > 641 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE, > "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE", "none" }, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | WEBKIT_TYPE_WEB_EXTENSION_MATCH_PATTERN_OPTIONS > /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/ > WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp: > 642:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES’ > was not declared in this scope; did you mean > ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_SCHEME’? > 642 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES, > "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES", > "ignore-schemes" }, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_SCHEME > /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/ > WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp: > 643:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS’ was > not declared in this scope; did you mean > ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_PATH’? > 643 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS, > "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS", "ignore-paths" }, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_PATH > /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/ > WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp: > 644:11: error: > ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY’ was not > declared in this scope > 644 | { > WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY, > "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY", > "match-bidirectionally" }, > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ``` That happens because there's a spurious WK_WEB_EXTENSIONS ifdef in Source/WebKit/UIProcess/API/glib/webkit.h.in... 2084900 10 philn 2025-01-05 03:35:35 -0800 Re-opening for another PR. 2084901 11 philn 2025-01-05 03:38:38 -0800 Pull request: https://github.com/WebKit/WebKit/pull/38541 2084902 12 ews-feeder 2025-01-05 03:40:54 -0800 Committed 288441@main (2df70530c94c): <https://commits.webkit.org/288441@main> Reviewed commits have been landed. Closing PR #38541 and removing active labels. 2084903 13 philn 2025-01-05 03:55:55 -0800 WebKitWebExtensionMatchPattern.h is GTK-specific, shouldn't be included in WPE's webkit.h. Re-opening for follow-up. 2084904 14 philn 2025-01-05 04:00:02 -0800 Pull request: https://github.com/WebKit/WebKit/pull/38542 2084905 15 ews-feeder 2025-01-05 04:02:25 -0800 Committed 288442@main (42a7911be14f): <https://commits.webkit.org/288442@main> Reviewed commits have been landed. Closing PR #38542 and removing active labels.