28417 2009-08-17 17:55:28 -0700 openDatabase() with empty version sets db version up incorrectly 2009-10-30 13:20:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ian benm abarth beidson benm commit-queue ddkilzer michaeln sam oldest_to_newest 140942 0 ian 2009-08-17 17:55:28 -0700 The following code should throw an exception on the second openDatabase() call, but doesn't: var n = 'test ' + new Date(); var db1 = openDatabase(n, '', '', 0); var db2 = openDatabase(n, 'test', '', 0); STEPS TO REPRODUCE 1. Open http://software.hixie.ch/utilities/js/js-eval-window/ 2. Paste the code above 3. Click the button EXPECTED RESULTS It should say "Error: INVALID_STATE_ERR: DOM Exception 11". ACTUAL RESULTS It says "undefined". It works fine if the first openDatabase() call's second argument is not the empty string. This may be due to some confusion about the empty string argument to openDatabase() -- per spec, the empty string sets the version to the empty string if the database doesn't exist, but otherwise just accepts whatever version is there. 154367 1 benm 2009-10-13 10:06:48 -0700 I have a fix and layout test for this bug, will send the patch shortly. I've run the layout tests on Windows and Mac (debug) and with the patch all the old tests continue to pass. 154369 2 41112 benm 2009-10-13 10:10:44 -0700 Created attachment 41112 Proposed patch 158325 3 benm 2009-10-27 13:02:42 -0700 ping... 159320 4 michaeln 2009-10-30 09:13:32 -0700 fwiw, lgtm 159325 5 benm 2009-10-30 09:27:24 -0700 (In reply to comment #4) > fwiw, lgtm Thanks Michael. cc'ing ddkilzer who reviewed the last DB patch I sent. David, would you mind looking at this? Thanks! 159372 6 abarth 2009-10-30 11:12:08 -0700 The code looks fine, but I don't know which is the proper behavior. 159406 7 ddkilzer 2009-10-30 12:44:00 -0700 (In reply to comment #6) > The code looks fine, but I don't know which is the proper behavior. Considering that the bug was filed by the author of HTML5, I think the correct behavior is as stated in Comment #0. 159413 8 41112 ddkilzer 2009-10-30 13:03:24 -0700 Comment on attachment 41112 Proposed patch > Index: LayoutTests/storage/open-database-set-empty-version.html > =================================================================== > --- LayoutTests/storage/open-database-set-empty-version.html (revision 0) > +++ LayoutTests/storage/open-database-set-empty-version.html (revision 0) > @@ -0,0 +1,26 @@ > +<html> > +<head> > +<script> > +function runTest() { > + if (window.layoutTestController) { > + layoutTestController.dumpAsText(); > + layoutTestController.clearAllDatabases(); > + } > + > + try { > + var db = openDatabase('28417Test', '', 'Test for bug 28417: openDatabase() with empty version sets db version up incorrectly', 0); > + // The next openDatabase call should fail because the database version was set to '' by the call above, and now we are expecting a different version. > + var db2 = openDatabase('28417Test', 'test', 'Test for bug 28417: openDatabase() with empty version sets db version up incorrectly', 0); > + } catch (e) { > + document.getElementById('result').innerHTML = 'SUCCESS, an exception was thrown. ' + e; > + } The "var db = ..." statement could be moved outside the try{} block in case it generates an exception (although I suppose it's somewhat unlikely that it would generate the same exception and make the test pass when it shouldn't). Might be nice to close the databases when you're done with them, too, but not necessary. r=me 159419 9 41112 commit-queue 2009-10-30 13:20:41 -0700 Comment on attachment 41112 Proposed patch Clearing flags on attachment: 41112 Committed r50350: <http://trac.webkit.org/changeset/50350> 159420 10 commit-queue 2009-10-30 13:20:47 -0700 All reviewed patches have been landed. Closing bug. 41112 2009-10-13 10:10:44 -0700 2009-10-30 13:20:41 -0700 Proposed patch 28417.txt text/plain 5547 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTUwMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTAtMTMgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG9wZW5E YXRhYmFzZSgpIHdpdGggZW1wdHkgdmVyc2lvbiBzZXRzIGRiIHZlcnNpb24gdXAgaW5jb3JyZWN0 bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4NDE3 CisKKyAgICAgICAgVGVzdDogc3RvcmFnZS9vcGVuLWRhdGFiYXNlLXNldC1lbXB0eS12ZXJzaW9u Lmh0bWwKKworICAgICAgICAqIHN0b3JhZ2UvRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RGF0YWJhc2U6OnBlcmZvcm1PcGVuQW5kVmVyaWZ5KTogUmFpc2UgYW4gZXhjZXB0aW9uIGlm IHRoZSBjdXJyZW50IGRhdGFiYXNlIHZlcnNpb24gZG9lcyBub3QgbWF0Y2ggdGhlIGV4cGVjdGVk IHZlcnNpb24gd2hlbiB0aGUgY3VycmVudCB2ZXJzaW9uIGlzIHRoZSBlbXB0eSBzdHJpbmcuCisK IDIwMDktMTAtMTMgIEdpcmlzaCBSYW1ha3Jpc2huYW4gIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJDb3JlL3N0 b3JhZ2UvRGF0YWJhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFz ZS5jcHAJKHJldmlzaW9uIDQ5NTAxKQorKysgV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNTA3LDE1ICs1MDcsMTMgQEAgYm9vbCBEYXRhYmFzZTo6cGVyZm9y bU9wZW5BbmRWZXJpZnkoRXhjZQogICAgICAgICBjdXJyZW50VmVyc2lvbiA9ICIiOwogICAgIH0K IAotICAgIC8vIEZJWE1FOiBGb3Igbm93LCB0aGUgc3BlYyBzYXlzIHRoYXQgaWYgdGhlIGRhdGFi YXNlIGhhcyBubyB2ZXJzaW9uLCBpdCBpcyB2YWxpZCBmb3IgYW55ICJFeHBlY3RlZCB2ZXJzaW9u IiBzdHJpbmcuICBUaGF0IHNlZW1zIHNpbGx5IGFuZCBJIHRoaW5rIGl0IHNob3VsZCBiZQotICAg IC8vIGNoYW5nZWQsIGFuZCBoZXJlJ3Mgd2hlcmUgd2Ugd291bGQgY2hhbmdlIGl0Ci0gICAgaWYg KG1fZXhwZWN0ZWRWZXJzaW9uLmxlbmd0aCgpKSB7Ci0gICAgICAgIGlmIChjdXJyZW50VmVyc2lv bi5sZW5ndGgoKSAmJiBtX2V4cGVjdGVkVmVyc2lvbiAhPSBjdXJyZW50VmVyc2lvbikgewotICAg ICAgICAgICAgTE9HKFN0b3JhZ2VBUEksICJwYWdlIGV4cGVjdHMgdmVyc2lvbiAlcyBmcm9tIGRh dGFiYXNlICVzLCB3aGljaCBhY3R1YWxseSBoYXMgdmVyc2lvbiBuYW1lICVzIC0gb3BlbkRhdGFi YXNlKCkgY2FsbCB3aWxsIGZhaWwiLCBtX2V4cGVjdGVkVmVyc2lvbi5hc2NpaSgpLmRhdGEoKSwK LSAgICAgICAgICAgICAgICBkYXRhYmFzZURlYnVnTmFtZSgpLmFzY2lpKCkuZGF0YSgpLCBjdXJy ZW50VmVyc2lvbi5hc2NpaSgpLmRhdGEoKSk7Ci0gICAgICAgICAgICBlID0gSU5WQUxJRF9TVEFU RV9FUlI7Ci0gICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIH0KKyAgICAvLyBJZiB0 aGUgZXhwZWN0ZWQgdmVyc2lvbiBpc24ndCB0aGUgZW1wdHkgc3RyaW5nLCBlbnN1cmUgdGhhdCB0 aGUgY3VycmVudCBkYXRhYmFzZSB2ZXJzaW9uIHdlIGhhdmUgbWF0Y2hlcyB0aGF0IHZlcnNpb24u IE90aGVyd2lzZSwgc2V0IGFuIGV4Y2VwdGlvbi4KKyAgICAvLyBJZiB0aGUgZXhwZWN0ZWQgdmVy c2lvbiBpcyB0aGUgZW1wdHkgc3RyaW5nLCB0aGVuIHdlIGFsd2F5cyByZXR1cm4gd2l0aCB3aGF0 ZXZlciB2ZXJzaW9uIG9mIHRoZSBkYXRhYmFzZSB3ZSBoYXZlLgorICAgIGlmIChtX2V4cGVjdGVk VmVyc2lvbi5sZW5ndGgoKSAmJiBtX2V4cGVjdGVkVmVyc2lvbiAhPSBjdXJyZW50VmVyc2lvbikg eworICAgICAgICBMT0coU3RvcmFnZUFQSSwgInBhZ2UgZXhwZWN0cyB2ZXJzaW9uICVzIGZyb20g ZGF0YWJhc2UgJXMsIHdoaWNoIGFjdHVhbGx5IGhhcyB2ZXJzaW9uIG5hbWUgJXMgLSBvcGVuRGF0 YWJhc2UoKSBjYWxsIHdpbGwgZmFpbCIsIG1fZXhwZWN0ZWRWZXJzaW9uLmFzY2lpKCkuZGF0YSgp LAorICAgICAgICAgICAgZGF0YWJhc2VEZWJ1Z05hbWUoKS5hc2NpaSgpLmRhdGEoKSwgY3VycmVu dFZlcnNpb24uYXNjaWkoKS5kYXRhKCkpOworICAgICAgICBlID0gSU5WQUxJRF9TVEFURV9FUlI7 CisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKICAgICByZXR1cm4gdHJ1ZTsKSW5kZXg6 IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ5NTAyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMTMgIEJlbiBNdXJkb2NoICA8YmVubUBnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IG9wZW5EYXRhYmFzZSgpIHdpdGggZW1wdHkgdmVyc2lvbiBzZXRzIGRiIHZlcnNpb24gdXAgaW5j b3JyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI4NDE3CisKKyAgICAgICAgKiBzdG9yYWdlL29wZW4tZGF0YWJhc2Utc2V0LWVtcHR5LXZlcnNp b24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdG9yYWdlL29wZW4tZGF0YWJhc2Ut c2V0LWVtcHR5LXZlcnNpb24uaHRtbDogQWRkZWQuCisKIDIwMDktMTAtMTMgIFBhdmVsIEZlbGRt YW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTGF5b3V0IHRlc3QgZml4LCBy ZXZlcnRpbmcgcHJldmlvdXMgY2hhbmdlLgpJbmRleDogTGF5b3V0VGVzdHMvc3RvcmFnZS9vcGVu LWRhdGFiYXNlLXNldC1lbXB0eS12ZXJzaW9uLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9zdG9yYWdlL29wZW4tZGF0YWJhc2Utc2V0LWVtcHR5LXZlcnNpb24tZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9vcGVuLWRhdGFiYXNl LXNldC1lbXB0eS12ZXJzaW9uLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwy IEBACitUaGlzIHRlc3RzIHRoYXQgY2FsbGluZyBvcGVuRGF0YWJhc2Ugd2l0aCBhbiBlbXB0eSB2 ZXJzaW9uIHN0cmluZyBzZXRzIHRoZSBjdXJyZW50IHZlcnNpb24gb2YgdGhhdCBkYXRhYmFzZSB0 byB0aGUgZW1wdHkgc3RyaW5nIGFuZCBzdWJzZXF1ZW50IGF0dGVtcHRzIHRvIG9wZW4gdGhlIGRh dGFiYXNlIHdpdGggYSBkaWZmZXJlbnQgZXhwZWN0ZWQgdmVyc2lvbiB0aHJvdyBhbiBleGNlcHRp b24uCitTVUNDRVNTLCBhbiBleGNlcHRpb24gd2FzIHRocm93bi4gRXJyb3I6IElOVkFMSURfU1RB VEVfRVJSOiBET00gRXhjZXB0aW9uIDExCgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0 cy9zdG9yYWdlL29wZW4tZGF0YWJhc2Utc2V0LWVtcHR5LXZlcnNpb24tZXhwZWN0ZWQudHh0Cl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRU ZXN0cy9zdG9yYWdlL29wZW4tZGF0YWJhc2Utc2V0LWVtcHR5LXZlcnNpb24uaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL29wZW4tZGF0YWJhc2Utc2V0LWVtcHR5LXZlcnNp b24uaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3N0b3JhZ2Uvb3Blbi1kYXRhYmFz ZS1zZXQtZW1wdHktdmVyc2lvbi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI2IEBACis8 aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmNsZWFyQWxsRGF0 YWJhc2VzKCk7CisgICAgfQorICAgIAorICAgIHRyeSB7ICAgIAorICAgICAgICB2YXIgZGIgPSBv cGVuRGF0YWJhc2UoJzI4NDE3VGVzdCcsICcnLCAnVGVzdCBmb3IgYnVnIDI4NDE3OiBvcGVuRGF0 YWJhc2UoKSB3aXRoIGVtcHR5IHZlcnNpb24gc2V0cyBkYiB2ZXJzaW9uIHVwIGluY29ycmVjdGx5 JywgMCk7CisgICAgICAgIC8vIFRoZSBuZXh0IG9wZW5EYXRhYmFzZSBjYWxsIHNob3VsZCBmYWls IGJlY2F1c2UgdGhlIGRhdGFiYXNlIHZlcnNpb24gd2FzIHNldCB0byAnJyBieSB0aGUgY2FsbCBh Ym92ZSwgYW5kIG5vdyB3ZSBhcmUgZXhwZWN0aW5nIGEgZGlmZmVyZW50IHZlcnNpb24uCisgICAg ICAgIHZhciBkYjIgPSBvcGVuRGF0YWJhc2UoJzI4NDE3VGVzdCcsICd0ZXN0JywgJ1Rlc3QgZm9y IGJ1ZyAyODQxNzogb3BlbkRhdGFiYXNlKCkgd2l0aCBlbXB0eSB2ZXJzaW9uIHNldHMgZGIgdmVy c2lvbiB1cCBpbmNvcnJlY3RseScsIDApOworICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jlc3VsdCcpLmlubmVySFRNTCA9ICdTVUNDRVNTLCBhbiBl eGNlcHRpb24gd2FzIHRocm93bi4gJyArIGU7CisgICAgfQorfQorPC9zY3JpcHQ+Cis8L2hlYWQ+ Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8ZGl2PlRoaXMgdGVzdHMgdGhhdCBjYWxsaW5n IG9wZW5EYXRhYmFzZSB3aXRoIGFuIGVtcHR5IHZlcnNpb24gc3RyaW5nIHNldHMgdGhlIGN1cnJl bnQgdmVyc2lvbiBvZiB0aGF0IGRhdGFiYXNlIHRvIHRoZSBlbXB0eSBzdHJpbmcgYW5kIHN1YnNl cXVlbnQgYXR0ZW1wdHMgdG8gb3BlbiB0aGUgZGF0YWJhc2Ugd2l0aCBhIGRpZmZlcmVudCBleHBl Y3RlZCB2ZXJzaW9uIHRocm93IGFuIGV4Y2VwdGlvbi48L2Rpdj4KKzxkaXYgaWQ9InJlc3VsdCI+ CitGQUlMVVJFIC0gYW4gZXhjZXB0aW9uIHdhcyBleHBlY3RlZC4KKzwvZGl2PgorPC9ib2R5Pgor PC9odG1sPgoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvc3RvcmFnZS9vcGVuLWRh dGFiYXNlLXNldC1lbXB0eS12ZXJzaW9uLmh0bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRlZDogc3ZuOmVvbC1z dHlsZQogICArIG5hdGl2ZQoK