<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>28415</bug_id>
          
          <creation_ts>2009-08-17 17:45:00 -0700</creation_ts>
          <short_desc>Set svn:eol-style CRLF on *.sln, *.vcproj</short_desc>
          <delta_ts>2009-08-18 10:44:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Peter Kasting">pkasting</reporter>
          <assigned_to name="Peter Kasting">pkasting</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>140928</commentid>
    <comment_count>0</comment_count>
      <attachid>35003</attachid>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2009-08-17 17:45:00 -0700</bug_when>
    <thetext>Created attachment 35003
patch

Most of the .sln and .vcproj files in the tree already have svn:eol-style set to CRLF, but a few don&apos;t.  This makes life harder on people creating patches to these files (line endings can get out of sync).

Patch attached.  Note that prepare-ChangeLog does not detect svn-property-only changes, and so did not create any ChangeLog entries for this.  I can add some manually if required.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140933</commentid>
    <comment_count>1</comment_count>
      <attachid>35003</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-17 17:48:26 -0700</bug_when>
    <thetext>Comment on attachment 35003
patch

Yes, please add a manual ChangeLog.

Seems we need a pre-commit hook for this eventually.  Or some sort of script to validate these sorts of rules for the whole repository.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141126</commentid>
    <comment_count>2</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2009-08-18 10:44:29 -0700</bug_when>
    <thetext>Fixed in r47430.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>35003</attachid>
            <date>2009-08-17 17:45:00 -0700</date>
            <delta_ts>2009-08-17 17:48:26 -0700</delta_ts>
            <desc>patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>1821</size>
            <attacher name="Peter Kasting">pkasting</attacher>
            
              <data encoding="base64">DQpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBKYXZhU2NyaXB0Q29yZVxKYXZhU2NyaXB0Q29yZS52Y3By
b2pcSmF2YVNjcmlwdENvcmVcSmF2YVNjcmlwdENvcmVHZW5lcmF0ZWQudmNwcm9qDQpfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fDQpBZGRlZDogc3ZuOmVvbC1zdHlsZQ0KICAgKyBDUkxGDQoNCg0KUHJvcGVydHkgY2hhbmdl
cyBvbjogSmF2YVNjcmlwdENvcmVcSmF2YVNjcmlwdENvcmUudmNwcm9qXHRlc3RhcGlcdGVzdGFw
aS52Y3Byb2oNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18NCkFkZGVkOiBzdm46ZW9sLXN0eWxlDQogICArIENSTEYNCg0K
DQpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBXZWJDb3JlXFdlYkNvcmUudmNwcm9qXFFUTW92aWVXaW4u
dmNwcm9qDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fDQpBZGRlZDogc3ZuOmVvbC1zdHlsZQ0KICAgKyBDUkxGDQoNCg0K
UHJvcGVydHkgY2hhbmdlcyBvbjogV2ViQ29yZVxXZWJDb3JlLnZjcHJvalxXZWJDb3JlR2VuZXJh
dGVkLnZjcHJvag0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXw0KQWRkZWQ6IHN2bjplb2wtc3R5bGUNCiAgICsgQ1JMRg0K
DQoNClByb3BlcnR5IGNoYW5nZXMgb246IFdlYktpdFRvb2xzXER1bXBSZW5kZXJUcmVlXHdpblxJ
bWFnZURpZmYudmNwcm9qDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fDQpBZGRlZDogc3ZuOmVvbC1zdHlsZQ0KICAgKyBD
UkxGDQoNCg0KUHJvcGVydHkgY2hhbmdlcyBvbjogV2ViS2l0VG9vbHNcRmluZFNhZmFyaVxGaW5k
U2FmYXJpLnZjcHJvag0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fXw0KQWRkZWQ6IHN2bjplb2wtc3R5bGUNCiAgICsgQ1JM
Rg0KDQoNClByb3BlcnR5IGNoYW5nZXMgb246IFdlYktpdFRvb2xzXFdlYktpdExhdW5jaGVyV2lu
XFdlYktpdExhdW5jaGVyV2luLnZjcHJvag0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KTW9kaWZpZWQ6IHN2bjplb2wt
c3R5bGUNCiAgIC0gbmF0aXZlDQogICArIENSTEYNCg0KDQpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBX
ZWJLaXRUb29sc1xXaW5MYXVuY2hlclxXaW5MYXVuY2hlci52Y3Byb2oNCl9fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCkFk
ZGVkOiBzdm46ZW9sLXN0eWxlDQogICArIENSTEYNCg0KDQpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBX
ZWJLaXRUb29sc1xyZWNvcmQtbWVtb3J5LXdpblxyZWNvcmQtbWVtb3J5LXdpbi52Y3Byb2oNCl9f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX18NCkFkZGVkOiBzdm46ZW9sLXN0eWxlDQogICArIENSTEYNCg0KDQpQcm9wZXJ0eSBj
aGFuZ2VzIG9uOiBXZWJLaXRcd2luXFdlYktpdC52Y3Byb2pcSW50ZXJmYWNlc0dlbmVyYXRlZC52
Y3Byb2oNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18NCkFkZGVkOiBzdm46ZW9sLXN0eWxlDQogICArIENSTEYNCg0K
</data>
<flag name="review"
          id="19187"
          type_id="1"
          status="+"
          setter="eric"
    />
    <flag name="commit-queue"
          id="19188"
          type_id="3"
          status="-"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>