28412 2009-08-17 16:26:26 -0700 Leak of WebCore::XMLHttpRequest object during layout tests 2009-08-18 21:35:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 mrowe aa aa ap beidson oldest_to_newest 140868 0 35001 mrowe 2009-08-17 16:26:26 -0700 Created attachment 35001 Make XHR leak more obvious While looking at the output of 'run-webkit-tests --leaks' over the last few days I've occasionally noticed instances of WebCore::XMLHttpRequest being leaked. I wrote a simple patch that uses RefCountedLeakCounter to make it more obvious when this sort of leak is occurring, and narrowed the leaks down to two tests that are run in sequence. The following command leaks a single XMLHttpRequest instance every time: ./WebKitTools/Scripts/run-webkit-tests --leaks LayoutTests/http/tests/xmlhttprequest/{xhr-onunload,xml-encoding}.html With the attached patch applied you'll see: LEAK: 1 XMLHttpRequest in the output. 140871 1 mrowe 2009-08-17 16:28:55 -0700 I poked at this briefly and it seemed that the XHR instance gained an extra ref during a call to setPendingActivity which was never balanced out. 140972 2 mrowe 2009-08-17 19:11:34 -0700 <rdar://problem/7149500> 141199 3 ap 2009-08-18 13:41:57 -0700 This regressed in <http://trac.webkit.org/changeset/47291>, where a call to setPendingActivity() was moved to before ThreadableLoader::create(). Even worse, nonCacheRequestInFlight() call was lost in the refactoring. 141204 4 aa 2009-08-18 13:49:15 -0700 Whoops, I will this. 141211 5 35073 ap 2009-08-18 14:03:45 -0700 Created attachment 35073 Unfinished fix OK, here's what I already have - unfinished and untested. This also fixed a check before setReportUploadProgress() (which is only used by Chromium afaik). 141355 6 35095 aa 2009-08-18 19:01:07 -0700 Created attachment 35095 Combination of previous two patches, plus ChangeLogs I verified this fixes the leak. Also, reran all LayoutTests, no regressions. And it looks correct, so not sure what else I can add. 141360 7 35095 mjs 2009-08-18 19:05:44 -0700 Comment on attachment 35095 Combination of previous two patches, plus ChangeLogs r=me 141372 8 mrowe 2009-08-18 20:01:27 -0700 Landed in r47478. 141375 9 35095 eric 2009-08-18 20:03:59 -0700 Comment on attachment 35095 Combination of previous two patches, plus ChangeLogs Rejecting patch 35095 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=35095 from bug 28412 failed to download and apply. 141387 10 ap 2009-08-18 21:35:32 -0700 + // For now we should only balance the nonCached request count for main-thread XHRs and not + // Worker XHRs, as the Cache is not thread-safe. + // This will become irrelevant after https://bugs.webkit.org/show_bug.cgi?id=27165 is resolved. By the way, it seems that moving this and related code to DocumentThreadableLoader could be a nice improvement while we wait for bug 27165. 35001 2009-08-17 16:26:26 -0700 2009-08-18 19:01:18 -0700 Make XHR leak more obvious XHR-RefCountedLeakCounter.patch text/plain 1471 mrowe ZGlmZiAtLWdpdCBhL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcCBiL1dlYkNvcmUveG1s L1hNTEh0dHBSZXF1ZXN0LmNwcAppbmRleCAwYjJmYWJiLi45Zjg3ODU5IDEwMDY0NAotLS0gYS9X ZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKKysrIGIvV2ViQ29yZS94bWwvWE1MSHR0cFJl cXVlc3QuY3BwCkBAIC00NCw2ICs0NCw5IEBACiAjaW5jbHVkZSAiWE1MSHR0cFJlcXVlc3RVcGxv YWQuaCIKICNpbmNsdWRlICJtYXJrdXAuaCIKICNpbmNsdWRlIDx3dGYvU3RkTGliRXh0cmFzLmg+ CisjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWRMZWFrQ291bnRlci5oPgorCitzdGF0aWMgV1RGOjpS ZWZDb3VudGVkTGVha0NvdW50ZXIgeG1sSHR0cFJlcXVlc3RDb3VudGVyKCJYTUxIdHRwUmVxdWVz dCIpOwogCiAjaWYgVVNFKEpTQykKICNpbmNsdWRlICJKU0RPTVdpbmRvdy5oIgpAQCAtMTUwLDYg KzE1Myw3IEBAIFhNTEh0dHBSZXF1ZXN0OjpYTUxIdHRwUmVxdWVzdChTY3JpcHRFeGVjdXRpb25D b250ZXh0KiBjb250ZXh0KQogICAgICwgbV9sYXN0U2VuZExpbmVOdW1iZXIoMCkKICAgICAsIG1f ZXhjZXB0aW9uQ29kZSgwKQogeworICAgIHhtbEh0dHBSZXF1ZXN0Q291bnRlci5pbmNyZW1lbnQo KTsKICAgICBpbml0aWFsaXplWE1MSHR0cFJlcXVlc3RTdGF0aWNEYXRhKCk7CiB9CiAKQEAgLTE2 MSw2ICsxNjUsOCBAQCBYTUxIdHRwUmVxdWVzdDo6flhNTEh0dHBSZXF1ZXN0KCkKICAgICB9CiAg ICAgaWYgKG1fdXBsb2FkKQogICAgICAgICBtX3VwbG9hZC0+ZGlzY29ubmVjdFhNTEh0dHBSZXF1 ZXN0KCk7CisKKyAgICB4bWxIdHRwUmVxdWVzdENvdW50ZXIuZGVjcmVtZW50KCk7CiB9CiAKIERv Y3VtZW50KiBYTUxIdHRwUmVxdWVzdDo6ZG9jdW1lbnQoKSBjb25zdApkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy9jaGVjay1mb3ItZ2xvYmFsLWluaXRpYWxpemVycyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvY2hlY2stZm9yLWdsb2JhbC1pbml0aWFsaXplcnMKaW5kZXggZTZjMWE2OS4u NWI5MWMzMCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9jaGVjay1mb3ItZ2xvYmFs LWluaXRpYWxpemVycworKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL2NoZWNrLWZvci1nbG9iYWwt aW5pdGlhbGl6ZXJzCkBAIC0xMTEsNiArMTExLDcgQEAgZm9yIG15ICRmaWxlIChzb3J0IEBmaWxl cykgewogICAgICAgICAgICAgICAgIG5leHQgaWYgJHNob3J0TmFtZSBlcSAiUmVuZGVyT2JqZWN0 Lm8iOwogICAgICAgICAgICAgICAgIG5leHQgaWYgJHNob3J0TmFtZSBlcSAiU3VicmVzb3VyY2VM b2FkZXIubyI7CiAgICAgICAgICAgICAgICAgbmV4dCBpZiAkc2hvcnROYW1lIGVxICJTVkdFbGVt ZW50SW5zdGFuY2UubyI7CisgICAgICAgICAgICAgICAgbmV4dCBpZiAkc2hvcnROYW1lIGVxICJY TUxIdHRwUmVxdWVzdC5vIjsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCg== 35073 2009-08-18 14:03:45 -0700 2009-08-18 19:01:26 -0700 Unfinished fix XHRLeak.txt text/plain 1950 ap SW5kZXg6IFdlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAJKHJldmlzaW9uIDQ3NDQ4KQorKysgV2ViQ29yZS94 bWwvWE1MSHR0cFJlcXVlc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MDMsOSArNTAzLDMwIEBA IHZvaWQgWE1MSHR0cFJlcXVlc3Q6OmNyZWF0ZVJlcXVlc3QoRXhjZXAKICAgICBtX2Vycm9yID0g ZmFsc2U7CiAKICAgICBpZiAobV9hc3luYykgewotICAgICAgICByZXF1ZXN0LnNldFJlcG9ydFVw bG9hZFByb2dyZXNzKHRydWUpOwotICAgICAgICBzZXRQZW5kaW5nQWN0aXZpdHkodGhpcyk7Cisg ICAgICAgIGlmIChtX3VwbG9hZCkKKyAgICAgICAgICAgIHJlcXVlc3Quc2V0UmVwb3J0VXBsb2Fk UHJvZ3Jlc3ModHJ1ZSk7CisKKyAgICAgICAgLy8gVGhyZWFkYWJsZUxvYWRlcjo6Y3JlYXRlIGNh biByZXR1cm4gbnVsbCBoZXJlLCBmb3IgZXhhbXBsZSBpZiB3ZSdyZSBubyBsb25nZXIgYXR0YWNo ZWQgdG8gYSBwYWdlLgorICAgICAgICAvLyBUaGlzIGlzIHRydWUgd2hpbGUgcnVubmluZyBvbnVu bG9hZCBoYW5kbGVycy4KKyAgICAgICAgLy8gRklYTUU6IE1heWJlIHdlIG5lZWQgdG8gYmUgYWJs ZSB0byBzZW5kIFhNTEh0dHBSZXF1ZXN0cyBmcm9tIG9udW5sb2FkLCA8aHR0cDovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MDQ+LgorICAgICAgICAvLyBGSVhNRTogTWF5YmUg Y3JlYXRlKCkgY2FuIHJldHVybiBudWxsIGZvciBvdGhlciByZWFzb25zIHRvbz8KICAgICAgICAg bV9sb2FkZXIgPSBUaHJlYWRhYmxlTG9hZGVyOjpjcmVhdGUoc2NyaXB0RXhlY3V0aW9uQ29udGV4 dCgpLCB0aGlzLCByZXF1ZXN0LCBvcHRpb25zKTsKKyAgICAgICAgaWYgKG1fbG9hZGVyKSB7Cisg ICAgICAgICAgICAvLyBOZWl0aGVyIHRoaXMgb2JqZWN0IG5vciB0aGUgSmF2YVNjcmlwdCB3cmFw cGVyIHNob3VsZCBiZSBkZWxldGVkIHdoaWxlCisgICAgICAgICAgICAvLyBhIHJlcXVlc3QgaXMg aW4gcHJvZ3Jlc3MgYmVjYXVzZSB3ZSBuZWVkIHRvIGtlZXAgdGhlIGxpc3RlbmVycyBhbGl2ZSwK KyAgICAgICAgICAgIC8vIGFuZCB0aGV5IGFyZSByZWZlcmVuY2VkIGJ5IHRoZSBKYXZhU2NyaXB0 IHdyYXBwZXIuCisgICAgICAgICAgICBzZXRQZW5kaW5nQWN0aXZpdHkodGhpcyk7CisKKyAgICAg ICAgICAgIC8vIEZvciBub3cgd2Ugc2hvdWxkIG9ubHkgYmFsYW5jZSB0aGUgbm9uQ2FjaGVkIHJl cXVlc3QgY291bnQgZm9yIG1haW4tdGhyZWFkIFhIUnMgYW5kIG5vdAorICAgICAgICAgICAgLy8g V29ya2VyIFhIUnMsIGFzIHRoZSBDYWNoZSBpcyBub3QgdGhyZWFkLXNhZmUuCisgICAgICAgICAg ICAvLyBUaGlzIHdpbGwgYmVjb21lIGlycmVsZXZhbnQgYWZ0ZXIgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MTY1IGlzIHJlc29sdmVkLgorICAgICAgICAgICAgaWYg KCFzY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPmlzV29ya2VyQ29udGV4dCgpKSB7CisgICAgICAg ICAgICAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKKyAgICAgICAgICAgICAgICBBU1NFUlQo IW1fZGlkVGVsbExvYWRlckFib3V0UmVxdWVzdCk7CisgICAgICAgICAgICAgICAgY2FjaGUoKS0+ bG9hZGVyKCktPm5vbkNhY2hlUmVxdWVzdEluRmxpZ2h0KG1fdXJsKTsKKyAgICAgICAgICAgICAg ICBtX2RpZFRlbGxMb2FkZXJBYm91dFJlcXVlc3QgPSB0cnVlOworICAgICAgICAgICAgfQorICAg ICAgICB9CiAgICAgfSBlbHNlCiAgICAgICAgIFRocmVhZGFibGVMb2FkZXI6OmxvYWRSZXNvdXJj ZVN5bmNocm9ub3VzbHkoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLCByZXF1ZXN0LCAqdGhpcywg b3B0aW9ucyk7CiAK 35095 2009-08-18 19:01:07 -0700 2009-08-18 20:03:59 -0700 Combination of previous two patches, plus ChangeLogs patch.txt text/plain 4765 aa ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTE3NTA4OS4uODRhZTcxOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wOC0xOCAgQWFyb24gQm9vZG1h biAgPGFhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg0 MTI6IExlYWsgb2YgV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Qgb2JqZWN0IGR1cmluZyBsYXlvdXQg dGVzdHMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOiBBbHJlYWR5IGNvdmVyZWQgYnkgZXhpc3Rp bmcgdGVzdHMuCisKKyAgICAgICAgKiB4bWwvWE1MSHR0cFJlcXVlc3QuY3BwOgorICAgICAgICAo V2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OlhNTEh0dHBSZXF1ZXN0KTogQWRkIGluc3RydW1lbnRh dGlvbiBmb3IgdGhpcyBraW5kIG9mIGxlYWsuCisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVx dWVzdDo6flhNTEh0dHBSZXF1ZXN0KTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRw UmVxdWVzdDo6Y3JlYXRlUmVxdWVzdCk6IE9ubHkgc2V0UGVuZGluZ0FjdGl2aXR5KCkgaWYgd2Ug YWN0dWFsbHkgc3RhcnRlZCBhIHJlcXVlc3QuIEFsc28sCisgICAgICAgIHJlc3RvcmUgYSBjYWxs IHRvIG5vbkNhY2hlUmVxdWVzdEluRmxpZ2h0KCkgdGhhdCBnb3QgbG9zdCBpbiBhIHJlY2VudCBy ZWZhY3Rvci4KKwogMjAwOS0wOC0xOCAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3htbC9YTUxIdHRwUmVxdWVzdC5jcHAgYi9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAK aW5kZXggMGIyZmFiYi4uNzg0NWEzYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS94bWwvWE1MSHR0cFJl cXVlc3QuY3BwCisrKyBiL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcApAQCAtNDQsNiAr NDQsOSBAQAogI2luY2x1ZGUgIlhNTEh0dHBSZXF1ZXN0VXBsb2FkLmgiCiAjaW5jbHVkZSAibWFy a3VwLmgiCiAjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgorI2luY2x1ZGUgPHd0Zi9SZWZD b3VudGVkTGVha0NvdW50ZXIuaD4KKworc3RhdGljIFdURjo6UmVmQ291bnRlZExlYWtDb3VudGVy IHhtbEh0dHBSZXF1ZXN0Q291bnRlcigiWE1MSHR0cFJlcXVlc3QiKTsKIAogI2lmIFVTRShKU0Mp CiAjaW5jbHVkZSAiSlNET01XaW5kb3cuaCIKQEAgLTE1MCw2ICsxNTMsNyBAQCBYTUxIdHRwUmVx dWVzdDo6WE1MSHR0cFJlcXVlc3QoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCkKICAg ICAsIG1fbGFzdFNlbmRMaW5lTnVtYmVyKDApCiAgICAgLCBtX2V4Y2VwdGlvbkNvZGUoMCkKIHsK KyAgICB4bWxIdHRwUmVxdWVzdENvdW50ZXIuaW5jcmVtZW50KCk7CiAgICAgaW5pdGlhbGl6ZVhN TEh0dHBSZXF1ZXN0U3RhdGljRGF0YSgpOwogfQogCkBAIC0xNjEsNiArMTY1LDggQEAgWE1MSHR0 cFJlcXVlc3Q6On5YTUxIdHRwUmVxdWVzdCgpCiAgICAgfQogICAgIGlmIChtX3VwbG9hZCkKICAg ICAgICAgbV91cGxvYWQtPmRpc2Nvbm5lY3RYTUxIdHRwUmVxdWVzdCgpOworCisgICAgeG1sSHR0 cFJlcXVlc3RDb3VudGVyLmRlY3JlbWVudCgpOwogfQogCiBEb2N1bWVudCogWE1MSHR0cFJlcXVl c3Q6OmRvY3VtZW50KCkgY29uc3QKQEAgLTUwMyw5ICs1MDksMzAgQEAgdm9pZCBYTUxIdHRwUmVx dWVzdDo6Y3JlYXRlUmVxdWVzdChFeGNlcHRpb25Db2RlJiBlYykKICAgICBtX2Vycm9yID0gZmFs c2U7CiAKICAgICBpZiAobV9hc3luYykgewotICAgICAgICByZXF1ZXN0LnNldFJlcG9ydFVwbG9h ZFByb2dyZXNzKHRydWUpOwotICAgICAgICBzZXRQZW5kaW5nQWN0aXZpdHkodGhpcyk7CisgICAg ICAgIGlmIChtX3VwbG9hZCkKKyAgICAgICAgICAgIHJlcXVlc3Quc2V0UmVwb3J0VXBsb2FkUHJv Z3Jlc3ModHJ1ZSk7CisKKyAgICAgICAgLy8gVGhyZWFkYWJsZUxvYWRlcjo6Y3JlYXRlIGNhbiBy ZXR1cm4gbnVsbCBoZXJlLCBmb3IgZXhhbXBsZSBpZiB3ZSdyZSBubyBsb25nZXIgYXR0YWNoZWQg dG8gYSBwYWdlLgorICAgICAgICAvLyBUaGlzIGlzIHRydWUgd2hpbGUgcnVubmluZyBvbnVubG9h ZCBoYW5kbGVycy4KKyAgICAgICAgLy8gRklYTUU6IE1heWJlIHdlIG5lZWQgdG8gYmUgYWJsZSB0 byBzZW5kIFhNTEh0dHBSZXF1ZXN0cyBmcm9tIG9udW5sb2FkLCA8aHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MDQ+LgorICAgICAgICAvLyBGSVhNRTogTWF5YmUgY3Jl YXRlKCkgY2FuIHJldHVybiBudWxsIGZvciBvdGhlciByZWFzb25zIHRvbz8KICAgICAgICAgbV9s b2FkZXIgPSBUaHJlYWRhYmxlTG9hZGVyOjpjcmVhdGUoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgp LCB0aGlzLCByZXF1ZXN0LCBvcHRpb25zKTsKKyAgICAgICAgaWYgKG1fbG9hZGVyKSB7CisgICAg ICAgICAgICAvLyBOZWl0aGVyIHRoaXMgb2JqZWN0IG5vciB0aGUgSmF2YVNjcmlwdCB3cmFwcGVy IHNob3VsZCBiZSBkZWxldGVkIHdoaWxlCisgICAgICAgICAgICAvLyBhIHJlcXVlc3QgaXMgaW4g cHJvZ3Jlc3MgYmVjYXVzZSB3ZSBuZWVkIHRvIGtlZXAgdGhlIGxpc3RlbmVycyBhbGl2ZSwKKyAg ICAgICAgICAgIC8vIGFuZCB0aGV5IGFyZSByZWZlcmVuY2VkIGJ5IHRoZSBKYXZhU2NyaXB0IHdy YXBwZXIuCisgICAgICAgICAgICBzZXRQZW5kaW5nQWN0aXZpdHkodGhpcyk7CisKKyAgICAgICAg ICAgIC8vIEZvciBub3cgd2Ugc2hvdWxkIG9ubHkgYmFsYW5jZSB0aGUgbm9uQ2FjaGVkIHJlcXVl c3QgY291bnQgZm9yIG1haW4tdGhyZWFkIFhIUnMgYW5kIG5vdAorICAgICAgICAgICAgLy8gV29y a2VyIFhIUnMsIGFzIHRoZSBDYWNoZSBpcyBub3QgdGhyZWFkLXNhZmUuCisgICAgICAgICAgICAv LyBUaGlzIHdpbGwgYmVjb21lIGlycmVsZXZhbnQgYWZ0ZXIgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI3MTY1IGlzIHJlc29sdmVkLgorICAgICAgICAgICAgaWYgKCFz Y3JpcHRFeGVjdXRpb25Db250ZXh0KCktPmlzV29ya2VyQ29udGV4dCgpKSB7CisgICAgICAgICAg ICAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKKyAgICAgICAgICAgICAgICBBU1NFUlQoIW1f ZGlkVGVsbExvYWRlckFib3V0UmVxdWVzdCk7CisgICAgICAgICAgICAgICAgY2FjaGUoKS0+bG9h ZGVyKCktPm5vbkNhY2hlUmVxdWVzdEluRmxpZ2h0KG1fdXJsKTsKKyAgICAgICAgICAgICAgICBt X2RpZFRlbGxMb2FkZXJBYm91dFJlcXVlc3QgPSB0cnVlOworICAgICAgICAgICAgfQorICAgICAg ICB9CiAgICAgfSBlbHNlCiAgICAgICAgIFRocmVhZGFibGVMb2FkZXI6OmxvYWRSZXNvdXJjZVN5 bmNocm9ub3VzbHkoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLCByZXF1ZXN0LCAqdGhpcywgb3B0 aW9ucyk7CiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xz L0NoYW5nZUxvZwppbmRleCBkN2YxZTgzLi40YTM4ZDQ5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMDktMDgtMTggIEFhcm9uIEJvb2RtYW4gIDxhYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI4NDEyOiBMZWFrIG9mIFdlYkNvcmU6OlhNTEh0dHBSZXF1 ZXN0IG9iamVjdCBkdXJpbmcgbGF5b3V0IHRlc3RzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czog QWxyZWFkeSBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogU2NyaXB0cy9j aGVjay1mb3ItZ2xvYmFsLWluaXRpYWxpemVyczogQWxsb3cgZ2xvYmFsIGluaXRpYWxpemF0aW9u IG9mIFdURjo6UmVmQ291bnRlZExlYWtDb3VudGVyIGZvciBYTUxIdHRwUmVxdWVzdC4KKwogMjAw OS0wOC0xNyAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy9jaGVjay1mb3ItZ2xvYmFsLWluaXRpYWxpemVycyBiL1dlYktpdFRvb2xzL1NjcmlwdHMv Y2hlY2stZm9yLWdsb2JhbC1pbml0aWFsaXplcnMKaW5kZXggZTZjMWE2OS4uNWI5MWMzMCAxMDA3 NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9jaGVjay1mb3ItZ2xvYmFsLWluaXRpYWxpemVy cworKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL2NoZWNrLWZvci1nbG9iYWwtaW5pdGlhbGl6ZXJz CkBAIC0xMTEsNiArMTExLDcgQEAgZm9yIG15ICRmaWxlIChzb3J0IEBmaWxlcykgewogICAgICAg ICAgICAgICAgIG5leHQgaWYgJHNob3J0TmFtZSBlcSAiUmVuZGVyT2JqZWN0Lm8iOwogICAgICAg ICAgICAgICAgIG5leHQgaWYgJHNob3J0TmFtZSBlcSAiU3VicmVzb3VyY2VMb2FkZXIubyI7CiAg ICAgICAgICAgICAgICAgbmV4dCBpZiAkc2hvcnROYW1lIGVxICJTVkdFbGVtZW50SW5zdGFuY2Uu byI7CisgICAgICAgICAgICAgICAgbmV4dCBpZiAkc2hvcnROYW1lIGVxICJYTUxIdHRwUmVxdWVz dC5vIjsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCg==