28406 2009-08-17 12:37:13 -0700 [Qt] QtLauncher crashes on exit if the web inspector is used during the session 2009-09-08 09:06:31 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gwright webkit-unassigned ariya.hidayat eric oldest_to_newest 140795 0 gwright 2009-08-17 12:37:13 -0700 If the web inspector is used during a QtLauncher session, when the program is closed it always results in a segfault: zsh: segmentation fault ./bin/QtLauncher 141369 1 35099 ben 2009-08-18 19:35:09 -0700 Created attachment 35099 patch to fix segfault 143044 2 abarth 2009-08-26 21:55:18 -0700 Is this possible to test? 144426 3 ariya.hidayat 2009-09-03 01:27:49 -0700 Would it be possible to test this by creating InspectorController and watching the signal when it gets closed? 144429 4 35099 eric 2009-09-03 01:35:30 -0700 Comment on attachment 35099 patch to fix segfault I'm no Qt expert, but this looks sane to me. 144430 5 35099 eric 2009-09-03 01:36:53 -0700 Comment on attachment 35099 patch to fix segfault Hum... removing cq+ now that Qt folks are commenting here too. :) A qt committer can set it again if they're comfortable with this, or if the bug goes stale I'll set it later this week. 144497 6 35099 eric 2009-09-03 06:37:19 -0700 Comment on attachment 35099 patch to fix segfault Rejecting patch 35099 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 144616 7 35099 eric 2009-09-03 15:57:07 -0700 Comment on attachment 35099 patch to fix segfault Sorry, you were yet another victim of bug 28845! It's a bad regression which is causing flakey media tests. :( media/controls-after-reload.html -> crashed 144625 8 35099 eric 2009-09-03 16:03:27 -0700 Comment on attachment 35099 patch to fix segfault Rejecting patch 35099 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/build-webkit failed with exit code 1 144700 9 35099 eric 2009-09-03 23:59:43 -0700 Comment on attachment 35099 patch to fix segfault I think the build was broken for other reasons and the bots had not yet rolled red. 144706 10 35099 eric 2009-09-04 00:07:54 -0700 Comment on attachment 35099 patch to fix segfault Clearing flags on attachment: 35099 Committed r48039: <http://trac.webkit.org/changeset/48039> 144707 11 eric 2009-09-04 00:07:58 -0700 All reviewed patches have been landed. Closing bug. 145378 12 eric 2009-09-08 09:06:31 -0700 (In reply to comment #7) > (From update of attachment 35099 [details]) > Sorry, you were yet another victim of bug 28845! It's a bad regression which > is causing flakey media tests. :( > media/controls-after-reload.html -> crashed Actually, I was wrong, the stack trace looks different. I've filed bug 29037. 35099 2009-08-18 19:35:09 -0700 2009-09-04 00:07:54 -0700 patch to fix segfault 0001-2009-08-18-Benjamin-C-Meyer-benjamin.meyer-torchm.patch text/plain 4872 ben RnJvbSAzMDk0ZGFkNmIxMDM5Njc4YjQwY2JlMzllYjc2YzIzMDNjN2ZkODllIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxiZW5qYW1pbi5tZXllckB0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IFR1ZSwgMTggQXVnIDIwMDkgMjI6MTg6MDIgLTA0MDAKU3ViamVj dDogMjAwOS0wOC0xOCAgQmVuamFtaW4gQyBNZXllciAgPGJlbmphbWluLm1leWVyQHRvcmNobW9i aWxlLmNvbT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEFu eSBRdFdlYktpdCBhcHBsaWNhdGlvbiBjcmFzaGVzIG9uIGV4aXQgaWYgdGhlIGluc3BlY3RvciBp cwogICAgICAgIHVzZWQgZHVyaW5nIHRoZSBzZXNzaW9uIHJhdGhlciB0aGVuIGV4aXRpbmcuCgog ICAgICAgIElmIGEgUVdlYlZpZXcgaGFzIGEgUVdlYlBhZ2UgdGhhdCBpcyBkZXN0cm95ZWQgdGhl IFFXZWJWaWV3CiAgICAgICAgZG9lcyBub3QgdXBkYXRlIGl0cyBwb2ludGVyIGFuZCB3aWxsIGNy YXNoIHRoZSBuZXh0IHRpbWUKICAgICAgICBpdCBhY2Nlc3MgdGhlIHBhZ2UgcG9pbnRlcnMgKHN1 Y2ggYXMgaW4gaXRzIGRlc3RydWN0b3IpLgoKICAgICAgICBJbnNwZWN0b3JDbGllbnRWaWV3IHNo b3VsZCBub3QgY2FsbCBkZWxldGVMYXRlciB3aGVuIHRoZSBwYWdlCiAgICAgICAgaXMgZGVzdHJv eWVkIGJlY2F1c2UgaXQgZG9lcyBub3QgaGF2ZSBhIHBhcmVudCBhbmQgaXMgYSB0b3AKICAgICAg ICBsZXZlbCB3aWRnZXQuICBjbG9zZSgpIG5lZWRzIHRvIGJlIGNhbGxlZCBzbyB0aGF0IFFBcHBs aWNhdGlvbgogICAgICAgIGNhbiBleGl0IHRoZSBhcHBsaWNhdGlvbiBpZiBxdWl0T25MYXN0V2lu ZG93Q2xvc2VkIGlzIHNldAogICAgICAgIGFuZCBhIEluc3BlY3RvckNsaWVudFZpZXcgaXMgdGhl IGxhc3Qgd2luZG93LCBvdGhlcndpc2UKICAgICAgICB0aGUgYXBwbGljYXRpb24gd2lsbCBuZXZl ciBleGl0LgoKICAgICAgICAqIEFwaS9xd2Vidmlldy5jcHA6CiAgICAgICAgKFFXZWJWaWV3UHJp dmF0ZTo6X3FfcGFnZURlc3Ryb3llZCk6CiAgICAgICAgKFFXZWJWaWV3OjpzZXRQYWdlKToKICAg ICAgICAqIEFwaS9xd2Vidmlldy5oOgogICAgICAgICogV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9y Q2xpZW50UXQuY3BwOgogICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDbGllbnRWaWV3OjpJbnNw ZWN0b3JDbGllbnRWaWV3KToKLS0tCiBXZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmNwcCAgICAgICAg ICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysKIFdlYktpdC9xdC9BcGkvcXdlYnZpZXcu aCAgICAgICAgICAgICAgICAgICAgICAgfCAgICAxICsKIFdlYktpdC9xdC9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDI1ICsrKysrKysrKysrKysrKysrKysrKysrKwog V2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFF0LmNwcCB8ICAgIDQgKyst CiA0IGZpbGVzIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvV2ViS2l0L3F0L0FwaS9xd2Vidmlldy5jcHAgYi9XZWJLaXQvcXQvQXBpL3F3ZWJ2 aWV3LmNwcAppbmRleCBlMWEwYzk4Li5lMGUwNzNlIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBp L3F3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmNwcApAQCAtNDIsNiAr NDIsOCBAQCBwdWJsaWM6CiAjZW5kaWYKICAgICB7fQogCisgICAgdm9pZCBfcV9wYWdlRGVzdHJv eWVkKCk7CisKICAgICBRV2ViVmlldyAqdmlldzsKICAgICBRV2ViUGFnZSAqcGFnZTsKIApAQCAt NzAsNiArNzIsMTIgQEAgcHVibGljOgogI2VuZGlmCiB9OwogCit2b2lkIFFXZWJWaWV3UHJpdmF0 ZTo6X3FfcGFnZURlc3Ryb3llZCgpCit7CisgICAgcGFnZSA9IDA7CisgICAgdmlldy0+c2V0UGFn ZSgwKTsKK30KKwogLyohCiAgICAgXGNsYXNzIFFXZWJWaWV3CiAgICAgXHNpbmNlIDQuNApAQCAt MjQyLDYgKzI1MCw4IEBAIHZvaWQgUVdlYlZpZXc6OnNldFBhZ2UoUVdlYlBhZ2UqIHBhZ2UpCiAK ICAgICAgICAgY29ubmVjdChkLT5wYWdlLCBTSUdOQUwobWljcm9Gb2N1c0NoYW5nZWQoKSksCiAg ICAgICAgICAgICAgICAgdGhpcywgU0xPVCh1cGRhdGVNaWNyb0ZvY3VzKCkpKTsKKyAgICAgICAg Y29ubmVjdChkLT5wYWdlLCBTSUdOQUwoZGVzdHJveWVkKCkpLAorICAgICAgICAgICAgICAgIHRo aXMsIFNMT1QoX3FfcGFnZURlc3Ryb3llZCgpKSk7CiAgICAgfQogICAgIHNldEF0dHJpYnV0ZShR dDo6V0FfT3BhcXVlUGFpbnRFdmVudCwgZC0+cGFnZSk7CiAgICAgdXBkYXRlKCk7CkBAIC0xMDk0 LDMgKzExMDQsNiBAQCB2b2lkIFFXZWJWaWV3OjpjaGFuZ2VFdmVudChRRXZlbnQgKmUpCiAKICAg ICBcc2EgUVdlYlBhZ2U6OmxpbmtEZWxlZ2F0aW9uUG9saWN5KCkKICovCisKKyNpbmNsdWRlICJt b2NfcXdlYnZpZXcuY3BwIgorCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3Lmgg Yi9XZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmgKaW5kZXggYzk5Mjk5ZS4uMGYyNjQ5ZCAxMDA2NDQK LS0tIGEvV2ViS2l0L3F0L0FwaS9xd2Vidmlldy5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnZp ZXcuaApAQCAtMTY4LDYgKzE2OCw3IEBAIHByb3RlY3RlZDoKIHByaXZhdGU6CiAgICAgZnJpZW5k IGNsYXNzIFFXZWJQYWdlOwogICAgIFFXZWJWaWV3UHJpdmF0ZSogZDsKKyAgICBRX1BSSVZBVEVf U0xPVChkLCB2b2lkIF9xX3BhZ2VEZXN0cm95ZWQoKSkKIH07CiAKICNlbmRpZiAvLyBRV0VCVklF V19ICmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxv ZwppbmRleCBkNzc3NmU2Li5hZmZhM2UzIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9n CisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAwOS0wOC0xOCAg QmVuamFtaW4gQyBNZXllciAgPGJlbmphbWluLm1leWVyQHRvcmNobW9iaWxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEFueSBR dFdlYktpdCBhcHBsaWNhdGlvbiBjcmFzaGVzIG9uIGV4aXQgaWYgdGhlIGluc3BlY3RvciBpcwor ICAgICAgICB1c2VkIGR1cmluZyB0aGUgc2Vzc2lvbiByYXRoZXIgdGhlbiBleGl0aW5nLgorICAg ICAgICAKKyAgICAgICAgSWYgYSBRV2ViVmlldyBoYXMgYSBRV2ViUGFnZSB0aGF0IGlzIGRlc3Ry b3llZCB0aGUgUVdlYlZpZXcKKyAgICAgICAgZG9lcyBub3QgdXBkYXRlIGl0cyBwb2ludGVyIGFu ZCB3aWxsIGNyYXNoIHRoZSBuZXh0IHRpbWUKKyAgICAgICAgaXQgYWNjZXNzIHRoZSBwYWdlIHBv aW50ZXJzIChzdWNoIGFzIGluIGl0cyBkZXN0cnVjdG9yKS4KKyAgICAgICAgCisgICAgICAgIElu c3BlY3RvckNsaWVudFZpZXcgc2hvdWxkIG5vdCBjYWxsIGRlbGV0ZUxhdGVyIHdoZW4gdGhlIHBh Z2UKKyAgICAgICAgaXMgZGVzdHJveWVkIGJlY2F1c2UgaXQgZG9lcyBub3QgaGF2ZSBhIHBhcmVu dCBhbmQgaXMgYSB0b3AKKyAgICAgICAgbGV2ZWwgd2lkZ2V0LiAgY2xvc2UoKSBuZWVkcyB0byBi ZSBjYWxsZWQgc28gdGhhdCBRQXBwbGljYXRpb24KKyAgICAgICAgY2FuIGV4aXQgdGhlIGFwcGxp Y2F0aW9uIGlmIHF1aXRPbkxhc3RXaW5kb3dDbG9zZWQgaXMgc2V0CisgICAgICAgIGFuZCBhIElu c3BlY3RvckNsaWVudFZpZXcgaXMgdGhlIGxhc3Qgd2luZG93LCBvdGhlcndpc2UKKyAgICAgICAg dGhlIGFwcGxpY2F0aW9uIHdpbGwgbmV2ZXIgZXhpdC4KKyAgICAgICAgCisgICAgICAgICogQXBp L3F3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKFFXZWJWaWV3UHJpdmF0ZTo6X3FfcGFnZURlc3Ryb3ll ZCk6CisgICAgICAgIChRV2ViVmlldzo6c2V0UGFnZSk6CisgICAgICAgICogQXBpL3F3ZWJ2aWV3 Lmg6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50UXQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ2xpZW50Vmlldzo6SW5zcGVjdG9yQ2xpZW50Vmlldyk6 CisKIDIwMDktMDgtMTQgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuLnpoYW5nQG5va2lhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYktp dC9xdC9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRRdC5jcHAgYi9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50UXQuY3BwCmluZGV4IGQ3ZjAzZDEuLjU2ZjYxMDEg MTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRRdC5j cHAKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFF0LmNwcApA QCAtNjUsMTMgKzY1LDE1IEBAIFFfU0lHTkFMUzoKIAogCiBjbGFzcyBJbnNwZWN0b3JDbGllbnRW aWV3IDogcHVibGljIFFXZWJWaWV3IHsKKwogcHVibGljOgogICAgIEluc3BlY3RvckNsaWVudFZp ZXcoSW5zcGVjdG9yQ29udHJvbGxlciogY29udHJvbGxlcikKICAgICAgICAgOiBRV2ViVmlldygw KQogICAgICAgICAsIG1fY29udHJvbGxlcihjb250cm9sbGVyKQogICAgIHsKKyAgICAgICAgc2V0 QXR0cmlidXRlKFF0OjpXQV9EZWxldGVPbkNsb3NlLCB0cnVlKTsKICAgICAgICAgc2V0UGFnZShu ZXcgSW5zcGVjdG9yQ2xpZW50V2ViUGFnZSk7Ci0gICAgICAgIGNvbm5lY3QocGFnZSgpLCBTSUdO QUwoZGVzdHJveWVkKCkpLCBTTE9UKGRlbGV0ZUxhdGVyKCkpKTsKKyAgICAgICAgY29ubmVjdChw YWdlKCksIFNJR05BTChkZXN0cm95ZWQoKSksIHRoaXMsIFNMT1QoY2xvc2UoKSkpOwogICAgIH0K IAogcHJvdGVjdGVkOgotLSAKMS42LjAuNAoK