28393 2009-08-17 10:20:40 -0700 check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN() 2010-03-25 01:34:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ddkilzer webkit-unassigned abarth levin oldest_to_newest 140743 0 ddkilzer 2009-08-17 10:20:40 -0700 * SUMMARY The std::max() and std::min() template methods should be preferred over the MAX()/MIN() macros since they're typesafe and since they may be used to automatically static_cast<>() their arguments using the std::max<type>() and std::min<type>() variants. * NOTES See Bug 28355. 140796 1 34986 ddkilzer 2009-08-17 12:39:00 -0700 Created attachment 34986 Patch v1 140815 2 ddkilzer 2009-08-17 13:33:44 -0700 Committed r47385: <http://trac.webkit.org/changeset/47385> 140816 3 ddkilzer 2009-08-17 13:33:48 -0700 All reviewed patches have been landed. Closing bug. 203901 4 abarth 2010-03-25 01:34:26 -0700 Committed r56510: <http://trac.webkit.org/changeset/56510> 34986 2009-08-17 12:39:00 -0700 2009-08-17 12:52:33 -0700 Patch v1 bug-28393-20090817123859.patch text/plain 5022 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxYjQ2NmY2Li5kMGNjOTRkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDgt MTcgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICA8aHR0cDov L3dlYmtpdC5vcmcvYi8yODM5Mz4gY2hlY2std2Via2l0LXN0eWxlOiBhZGQgY2hlY2sgZm9yIHVz ZSBvZiBzdGQ6Om1heCgpL3N0ZDo6bWluKCkgaW5zdGVhZCBvZiBNQVgoKS9NSU4oKQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9tb2R1 bGVzL2NwcF9zdHlsZS5weToKKyAgICAgICAgKF9FUlJPUl9DQVRFR09SSUVTKTogQWRkZWQgJ3J1 bnRpbWUvbWF4X21pbl9tYWNyb3MnLgorICAgICAgICAoY2hlY2tfbWF4X21pbl9tYWNyb3MpOiBB ZGRlZC4gIFJldHVybnMgbGV2ZWwgNCBlcnJvciB3aGVuIE1BWCgpCisgICAgICAgIGFuZCBNSU4o KSBtYWNyb3MgYXJlIHVzZWQgaW4gaGVhZGVyIGZpbGVzIGFuZCBDKysgc291cmNlIGZpbGVzLgor ICAgICAgICAoY2hlY2tfc3R5bGUpOiBBZGRlZCBjYWxsIHRvIGNoZWNrX21heF9taW5fbWFjcm9z KCkuCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVzdC5weTogQWRk ZWQgdW5pdCB0ZXN0cy4KKyAgICAgICAgKHRlc3RfbWF4X21hY3JvKTogQWRkZWQuCisgICAgICAg ICh0ZXN0X21pbl9tYWNybyk6IEFkZGVkLgorCiAyMDA5LTA4LTE2ICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMjgzNzA+ IGNoZWNrLXdlYmtpdC1zdHlsZTogYWRkIGNoZWNrIGZvciAndXNpbmcgc3RkOjpmb287JyBzdGF0 ZW1lbnRzCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxl LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weQppbmRleCBkMDY5 NmZlLi41NjlhMDI1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3Bw X3N0eWxlLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkK QEAgLTE0MCw2ICsxNDAsNyBAQCBfRVJST1JfQ0FURUdPUklFUyA9ICcnJ1wKICAgICBydW50aW1l L2ludAogICAgIHJ1bnRpbWUvaW5pdAogICAgIHJ1bnRpbWUvaW52YWxpZF9pbmNyZW1lbnQKKyAg ICBydW50aW1lL21heF9taW5fbWFjcm9zCiAgICAgcnVudGltZS9tZW1zZXQKICAgICBydW50aW1l L3ByaW50ZgogICAgIHJ1bnRpbWUvcHJpbnRmX2Zvcm1hdApAQCAtMTc2OCw2ICsxNzY5LDMzIEBA IGRlZiBjaGVja191c2luZ19zdGQoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwg ZXJyb3IpOgogICAgICAgICAgICJVc2UgJ3VzaW5nIG5hbWVzcGFjZSBzdGQ7JyBpbnN0ZWFkIG9m ICd1c2luZyBzdGQ6OiVzOycuIiAlIG1ldGhvZF9uYW1lKQogCiAKK2RlZiBjaGVja19tYXhfbWlu X21hY3JvcyhmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CisgICAg IiIiTG9va3MgdXNlIG9mIE1BWCgpIGFuZCBNSU4oKSBtYWNyb3MgdGhhdCBzaG91bGQgYmUgcmVw bGFjZWQgd2l0aCBzdGQ6Om1heCgpIGFuZCBzdGQ6Om1pbigpLgorCisgICAgQXJnczoKKyAgICAg IGZpbGVuYW1lOiBUaGUgbmFtZSBvZiB0aGUgY3VycmVudCBmaWxlLgorICAgICAgY2xlYW5fbGlu ZXM6IEEgQ2xlYW5zZWRMaW5lcyBpbnN0YW5jZSBjb250YWluaW5nIHRoZSBmaWxlLgorICAgICAg bGluZV9udW1iZXI6IFRoZSBudW1iZXIgb2YgdGhlIGxpbmUgdG8gY2hlY2suCisgICAgICBlcnJv cjogVGhlIGZ1bmN0aW9uIHRvIGNhbGwgd2l0aCBhbnkgZXJyb3JzIGZvdW5kLgorICAgICIiIgor CisgICAgIyBUaGlzIGNoZWNrIGRvZXNuJ3QgYXBwbHkgdG8gQyBvciBPYmplY3RpdmUtQyBpbXBs ZW1lbnRhdGlvbiBmaWxlcy4KKyAgICBpZiBmaWxlbmFtZS5lbmRzd2l0aCgnLmMnKSBvciBmaWxl bmFtZS5lbmRzd2l0aCgnLm0nKToKKyAgICAgICAgcmV0dXJuCisKKyAgICBsaW5lID0gY2xlYW5f bGluZXMuZWxpZGVkW2xpbmVfbnVtYmVyXSAjIEdldCByaWQgb2YgY29tbWVudHMgYW5kIHN0cmlu Z3MuCisKKyAgICBtYXhfbWluX21hY3Jvc19zZWFyY2ggPSBzZWFyY2gocidcYig/UDxtYXhfbWlu X21hY3JvPihNQVh8TUlOKSlccypcKCcsIGxpbmUpCisgICAgaWYgbm90IG1heF9taW5fbWFjcm9z X3NlYXJjaDoKKyAgICAgICAgcmV0dXJuCisKKyAgICBtYXhfbWluX21hY3JvID0gbWF4X21pbl9t YWNyb3Nfc2VhcmNoLmdyb3VwKCdtYXhfbWluX21hY3JvJykKKyAgICBtYXhfbWluX21hY3JvX2xv d2VyID0gbWF4X21pbl9tYWNyby5sb3dlcigpCisgICAgZXJyb3IoZmlsZW5hbWUsIGxpbmVfbnVt YmVyLCAncnVudGltZS9tYXhfbWluX21hY3JvcycsIDQsCisgICAgICAgICAgJ1VzZSBzdGQ6OiVz KCkgb3Igc3RkOjolczx0eXBlPigpIGluc3RlYWQgb2YgdGhlICVzKCkgbWFjcm8uJworICAgICAg ICAgICUgKG1heF9taW5fbWFjcm9fbG93ZXIsIG1heF9taW5fbWFjcm9fbG93ZXIsIG1heF9taW5f bWFjcm8pKQorCisKIGRlZiBjaGVja19zd2l0Y2hfaW5kZW50YXRpb24oZmlsZW5hbWUsIGNsZWFu X2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICIiIkxvb2tzIGZvciBpbmRlbnRhdGlv biBlcnJvcnMgaW5zaWRlIG9mIHN3aXRjaCBzdGF0ZW1lbnRzLgogCkBAIC0yMjAyLDYgKzIyMzAs NyBAQCBkZWYgY2hlY2tfc3R5bGUoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwg ZmlsZV9leHRlbnNpb24sIGVycm9yKToKICAgICAjIFNvbWUgbW9yZSBzdHlsZSBjaGVja3MKICAg ICBjaGVja19uYW1lc3BhY2VfaW5kZW50YXRpb24oZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5l X251bWJlciwgZmlsZV9leHRlbnNpb24sIGVycm9yKQogICAgIGNoZWNrX3VzaW5nX3N0ZChmaWxl bmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcikKKyAgICBjaGVja19tYXhfbWlu X21hY3JvcyhmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcikKICAgICBj aGVja19zd2l0Y2hfaW5kZW50YXRpb24oZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJl ciwgZXJyb3IpCiAgICAgY2hlY2tfYnJhY2VzKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9u dW1iZXIsIGVycm9yKQogICAgIGNoZWNrX2V4aXRfc3RhdGVtZW50X3NpbXBsaWZpY2F0aW9ucyhm aWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcikKZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkgYi9XZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CmluZGV4IDljMTI5YTEu LjI0OThiMzkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5 bGVfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHls ZV91bml0dGVzdC5weQpAQCAtMzQzMyw2ICszNDMzLDQyIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVz dChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICIgIFtidWlsZC91c2luZ19zdGRdIFs0 XSIsCiAgICAgICAgICAgICAnZm9vLmNwcCcpCiAKKyAgICBkZWYgdGVzdF9tYXhfbWFjcm8oc2Vs Zik6CisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnaW50IGkgPSBNQVgo MCwgMSk7JywKKyAgICAgICAgICAgICcnLAorICAgICAgICAgICAgJ2Zvby5jJykKKworICAgICAg ICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJ2ludCBpID0gTUFYKDAsIDEpOycsCisg ICAgICAgICAgICAnVXNlIHN0ZDo6bWF4KCkgb3Igc3RkOjptYXg8dHlwZT4oKSBpbnN0ZWFkIG9m IHRoZSBNQVgoKSBtYWNyby4nCisgICAgICAgICAgICAnICBbcnVudGltZS9tYXhfbWluX21hY3Jv c10gWzRdJywKKyAgICAgICAgICAgICdmb28uY3BwJykKKworICAgICAgICBzZWxmLmFzc2VydF9s aW50KAorICAgICAgICAgICAgJ2lubGluZSBpbnQgZm9vKCkgeyByZXR1cm4gTUFYKDAsIDEpOyB9 JywKKyAgICAgICAgICAgICdVc2Ugc3RkOjptYXgoKSBvciBzdGQ6Om1heDx0eXBlPigpIGluc3Rl YWQgb2YgdGhlIE1BWCgpIG1hY3JvLicKKyAgICAgICAgICAgICcgIFtydW50aW1lL21heF9taW5f bWFjcm9zXSBbNF0nLAorICAgICAgICAgICAgJ2Zvby5oJykKKworICAgIGRlZiB0ZXN0X21pbl9t YWNybyhzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICdpbnQg aSA9IE1JTigwLCAxKTsnLAorICAgICAgICAgICAgJycsCisgICAgICAgICAgICAnZm9vLmMnKQor CisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnaW50IGkgPSBNSU4oMCwg MSk7JywKKyAgICAgICAgICAgICdVc2Ugc3RkOjptaW4oKSBvciBzdGQ6Om1pbjx0eXBlPigpIGlu c3RlYWQgb2YgdGhlIE1JTigpIG1hY3JvLicKKyAgICAgICAgICAgICcgIFtydW50aW1lL21heF9t aW5fbWFjcm9zXSBbNF0nLAorICAgICAgICAgICAgJ2Zvby5jcHAnKQorCisgICAgICAgIHNlbGYu YXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnaW5saW5lIGludCBmb28oKSB7IHJldHVybiBNSU4o MCwgMSk7IH0nLAorICAgICAgICAgICAgJ1VzZSBzdGQ6Om1pbigpIG9yIHN0ZDo6bWluPHR5cGU+ KCkgaW5zdGVhZCBvZiB0aGUgTUlOKCkgbWFjcm8uJworICAgICAgICAgICAgJyAgW3J1bnRpbWUv bWF4X21pbl9tYWNyb3NdIFs0XScsCisgICAgICAgICAgICAnZm9vLmgnKQorCiAgICAgZGVmIHRl c3RfbmFtZXMoc2VsZik6CiAgICAgICAgICMgRklYTUU6IEltcGxlbWVudCB0aGlzLgogICAgICAg ICBwYXNz