<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>28387</bug_id>
          
          <creation_ts>2009-08-17 04:14:16 -0700</creation_ts>
          <short_desc>Regression test for RegExp bug in v8</short_desc>
          <delta_ts>2009-08-21 15:58:01 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Christian Plesner Hansen">christian.plesner.hansen</reporter>
          <assigned_to name="Eric Seidel (no email)">eric</assigned_to>
          <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>140699</commentid>
    <comment_count>0</comment_count>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-17 04:14:16 -0700</bug_when>
    <thetext>Regression test for bug fixed in http://codereview.chromium.org/171039.  Regexps created in one frame were not callable outside that frame.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140700</commentid>
    <comment_count>1</comment_count>
      <attachid>34966</attachid>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-17 04:18:44 -0700</bug_when>
    <thetext>Created attachment 34966
Initial version</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140864</commentid>
    <comment_count>2</comment_count>
      <attachid>34966</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-17 16:24:45 -0700</bug_when>
    <thetext>Comment on attachment 34966
Initial version

AFAIK, CPH is not a committer, adding cq+</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140897</commentid>
    <comment_count>3</comment_count>
      <attachid>34966</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-17 17:16:50 -0700</bug_when>
    <thetext>Comment on attachment 34966
Initial version

Clearing flags on attachment: 34966

Committed r47399: &lt;http://trac.webkit.org/changeset/47399&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140898</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-17 17:16:53 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140983</commentid>
    <comment_count>5</comment_count>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-17 20:44:56 -0700</bug_when>
    <thetext>Sorry, I accidentally made this patch relative to LayoutTests rather than WebKit so it has landed one level too far out, creating trunk/fast/...  It will have to be rolled back.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140997</commentid>
    <comment_count>6</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2009-08-17 22:13:25 -0700</bug_when>
    <thetext>Rolled out in &lt;https://trac.webkit.org/changeset/47411&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141000</commentid>
    <comment_count>7</comment_count>
      <attachid>35015</attachid>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-17 22:32:53 -0700</bug_when>
    <thetext>Created attachment 35015
Relative to WebKit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141010</commentid>
    <comment_count>8</comment_count>
      <attachid>35015</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-17 22:55:08 -0700</bug_when>
    <thetext>Comment on attachment 35015
Relative to WebKit

WebKit indent is 4 spaces.

If you want this reviewed, you&apos;ll need to mark it r=?

Also, official webkit style has { on a new line for function declarations.

Also, LayoutTests/fast/regex/regexp-cross-frame-callable.html should just be a standard JS test, which uses make-script-test-wrappers to generate the wrapper .html file from the TEMPLATE.html

You just write fast/regexp/resources/regexp-cross-frame-callable.js and let make-script-test-wrappers do its thing for you.

If this was marked r=? I woudl mark it r-.  Since it&apos;s not, I&apos;m assuming this is just a work-in progress. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141012</commentid>
    <comment_count>9</comment_count>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-17 23:02:18 -0700</bug_when>
    <thetext>&gt; You just write fast/regexp/resources/regexp-cross-frame-callable.js and let
&gt; make-script-test-wrappers do its thing for you.

I need at least two html pages to exercise the cross-frame aspect.  How would I do that?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141014</commentid>
    <comment_count>10</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-17 23:04:49 -0700</bug_when>
    <thetext>You can easily do:
var iframe = document.createElement(&apos;iframe&apos;);
iframe.src = &quot;my_amazing_test_file_with_lazer_eyes.html&quot;;
document.body.appendChild(iframe);

Your current test uses body.onload, which I think won&apos;t even wait for the iframe load.  I&apos;m not certain.

You mgiht have to use iframe.onload = doTest() anyway.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141029</commentid>
    <comment_count>11</comment_count>
      <attachid>35021</attachid>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-17 23:35:25 -0700</bug_when>
    <thetext>Created attachment 35021
Let&apos;s try that again</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141031</commentid>
    <comment_count>12</comment_count>
      <attachid>35021</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-17 23:46:30 -0700</bug_when>
    <thetext>Comment on attachment 35021
Let&apos;s try that again

So this looks fine.

It could be one step better though.

Notice how the expected results are out of order:
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS re(&apos;a&apos;) is [&apos;a&apos;]

This is because the script in the subframe is executing after the main frame finishes parsing.  Sadly, one ilmitation of the script-test testing framework is that we don&apos;t have a nice clean way to handle tests which need to delay completion.

I expect you could get around this pretty easily this way:

var iframe = document.createElement(&apos;iframe&apos;);
document.body.appendChild(iframe);
iframe.document.body.innerHTML = &quot;&lt;script&gt;top.doTest(/a/)&lt;/script&gt;&quot;;

I would expect the script to execute synchronously from the innerHTML.

If not, certainly this should:
iframe.document.write(&quot;&lt;script&gt;top.doTest(/a/)&lt;/script&gt;&quot;);

I&apos;m OK committing this as-is, but I think we could improve it one step further if you&apos;re willing.  Either of the above should remove the need for a second file altogether.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141035</commentid>
    <comment_count>13</comment_count>
      <attachid>35023</attachid>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-17 23:56:06 -0700</bug_when>
    <thetext>Created attachment 35023
Results ordering</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141036</commentid>
    <comment_count>14</comment_count>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-17 23:57:40 -0700</bug_when>
    <thetext>&gt; I would expect the script to execute synchronously from the innerHTML.
&gt; 
&gt; If not, certainly this should:
&gt; iframe.document.write(&quot;&lt;script&gt;top.doTest(/a/)&lt;/script&gt;&quot;);

That&apos;s also a lot better since it removes the need for a separate file for the child frame.  I&apos;ve fixed it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141037</commentid>
    <comment_count>15</comment_count>
      <attachid>35023</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-17 23:59:38 -0700</bug_when>
    <thetext>Comment on attachment 35023
Results ordering

Glorious!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141038</commentid>
    <comment_count>16</comment_count>
      <attachid>35023</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-18 00:03:50 -0700</bug_when>
    <thetext>Comment on attachment 35023
Results ordering

Rejecting patch 35023 from commit-queue.  This patch will require manual commit.

[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--quiet&apos;, &apos;--exit-after-n-failures=1&apos;] failed with exit code 1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141044</commentid>
    <comment_count>17</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-18 00:20:48 -0700</bug_when>
    <thetext>Testing 11088 test cases.
fast/regex/cross-frame-callable.html -&gt; failed

Exiting early after 1 failures.  7420 tests run.
131.57s total testing time

I did not look at the diffs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141051</commentid>
    <comment_count>18</comment_count>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-18 00:46:17 -0700</bug_when>
    <thetext>Where does this failure happen?  As far as I can tell it passes on safari and chrome with webkit latest and v8 latest.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141094</commentid>
    <comment_count>19</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-18 08:47:14 -0700</bug_when>
    <thetext>It happened when the commit-queue applied your patch, built (release) and ran the tests.  I didn&apos;t look at the diffs, but if you&apos;re not seeing this locally I can dig them up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141130</commentid>
    <comment_count>20</comment_count>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-18 10:52:38 -0700</bug_when>
    <thetext>(In reply to comment #19)
&gt; It happened when the commit-queue applied your patch, built (release) and ran
&gt; the tests.  I didn&apos;t look at the diffs, but if you&apos;re not seeing this locally I
&gt; can dig them up.

Is there a way for me to run the tests in the same setup as the commit-queue?

I ran the test in safari on mac and there was no problem so if the diff is available somewhere that would be really helpful.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141232</commentid>
    <comment_count>21</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-18 14:24:55 -0700</bug_when>
    <thetext>The commit queue just runs &quot;run-webkit-tests&quot; which uses DumpRenderTree to run your test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141469</commentid>
    <comment_count>22</comment_count>
      <attachid>35119</attachid>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-19 07:38:04 -0700</bug_when>
    <thetext>Created attachment 35119
Added trailing newline

The problem is that there has to be an empty line at the end of the expectation file.  In my workspace the line is there but between creating and applying the patch it disappears.  This patch includes an extra newline but I&apos;m not sure it works -- when I tried applying the patch the newline still disappeared.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141834</commentid>
    <comment_count>23</comment_count>
      <attachid>38363</attachid>
    <who name="Christian Plesner Hansen">christian.plesner.hansen</who>
    <bug_when>2009-08-20 23:32:33 -0700</bug_when>
    <thetext>Created attachment 38363
Fixed trailing newline issue

Removing the iframe doesn&apos;t make any difference, there&apos;s still a trailing newline.  Only workaround I could come up with was to write DONE after the test was over, that seems to work.  If it turns out not to work for some reason I&apos;m ready to just drop this CL altogether.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141998</commentid>
    <comment_count>24</comment_count>
      <attachid>38363</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-21 14:59:21 -0700</bug_when>
    <thetext>Comment on attachment 38363
Fixed trailing newline issue

I&apos;m not sure I know what&apos;s going on here, why &quot;done&quot; would be needed.  But I also think this is fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>142031</commentid>
    <comment_count>25</comment_count>
      <attachid>38363</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-21 15:57:58 -0700</bug_when>
    <thetext>Comment on attachment 38363
Fixed trailing newline issue

Clearing flags on attachment: 38363

Committed r47647: &lt;http://trac.webkit.org/changeset/47647&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>142032</commentid>
    <comment_count>26</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-21 15:58:01 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34966</attachid>
            <date>2009-08-17 04:18:44 -0700</date>
            <delta_ts>2009-08-17 22:32:53 -0700</delta_ts>
            <desc>Initial version</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>2459</size>
            <attacher name="Christian Plesner Hansen">christian.plesner.hansen</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ3MzU3
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDgt
MTcgIENocmlzdGlhbiBQbGVzbmVyIEhhbnNlbiAgPGNocmlzdGlhbi5wbGVzbmVyLmhhbnNlbkBn
bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgUmVncmVzc2lvbiB0ZXN0IGZvciBidWcgZml4ZWQgaW4KKyAgICAgICAgaHR0cDovL2NvZGVy
ZXZpZXcuY2hyb21pdW0ub3JnLzE3MTAzOS4gIFJlZ2V4cHMgY3JlYXRlZCBpbiBvbmUKKyAgICAg
ICAgZnJhbWUgd2VyZSBub3QgY2FsbGFibGUgb3V0c2lkZSB0aGF0IGZyYW1lLgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgzODcKKworICAgICAgICAq
IGZhc3QvcmVnZXgvcmVnZXhwLWNyb3NzLWZyYW1lLWNhbGxhYmxlLWV4cGVjdGVkLnR4dDogQWRk
ZWQuCisgICAgICAgICogZmFzdC9yZWdleC9yZWdleHAtY3Jvc3MtZnJhbWUtY2FsbGFibGUuaHRt
bDogQWRkZWQuCisgICAgICAgICogZmFzdC9yZWdleC9yZXNvdXJjZXMvcmVnZXhwLWNyb3NzLWZy
YW1lLWNhbGxhYmxlLWNoaWxkLmh0bWw6IEFkZGVkLgorCiAyMDA5LTA4LTE2ICBEYXJpbiBBZGxl
ciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWlu
LgpJbmRleDogZmFzdC9yZWdleC9yZWdleHAtY3Jvc3MtZnJhbWUtY2FsbGFibGUtZXhwZWN0ZWQu
dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIGZhc3QvcmVnZXgvcmVnZXhwLWNyb3NzLWZyYW1lLWNhbGxhYmxl
LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIGZhc3QvcmVnZXgvcmVnZXhwLWNyb3NzLWZy
YW1lLWNhbGxhYmxlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0IEBACitQ
QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKK1BBU1MgcmUo
J2EnKSBpcyBbJ2EnXQpJbmRleDogZmFzdC9yZWdleC9yZWdleHAtY3Jvc3MtZnJhbWUtY2FsbGFi
bGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBmYXN0L3JlZ2V4L3JlZ2V4cC1jcm9zcy1mcmFtZS1jYWxs
YWJsZS5odG1sCShyZXZpc2lvbiAwKQorKysgZmFzdC9yZWdleC9yZWdleHAtY3Jvc3MtZnJhbWUt
Y2FsbGFibGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyNCBAQAorPCFET0NUWVBFIEhU
TUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5r
IHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3Nz
Ij4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0
PgorPC9oZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisg
ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCitmdW5jdGlvbiBkb1Rlc3Qo
KSB7CisgIHJlID0gZnJhbWVzWzBdLmdldFJlZ0V4cCgpOworICBzaG91bGRCZSgicmUoJ2EnKSIs
ICJbJ2EnXSIpOworfQorCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0
PgorPGJvZHkgb25Mb2FkPSJkb1Rlc3QoKSI+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxk
aXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPGlmcmFtZSBzcmM9InJlc291cmNlcy9yZWdleHAtY3Jv
c3MtZnJhbWUtY2FsbGFibGUtY2hpbGQuaHRtbCI+PC9pZnJhbWU+Cis8c2NyaXB0IHNyYz0iLi4v
anMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+
CkluZGV4OiBmYXN0L3JlZ2V4L3Jlc291cmNlcy9yZWdleHAtY3Jvc3MtZnJhbWUtY2FsbGFibGUt
Y2hpbGQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBmYXN0L3JlZ2V4L3Jlc291cmNlcy9yZWdleHAtY3Jv
c3MtZnJhbWUtY2FsbGFibGUtY2hpbGQuaHRtbAkocmV2aXNpb24gMCkKKysrIGZhc3QvcmVnZXgv
cmVzb3VyY2VzL3JlZ2V4cC1jcm9zcy1mcmFtZS1jYWxsYWJsZS1jaGlsZC5odG1sCShyZXZpc2lv
biAwKQpAQCAtMCwwICsxLDkgQEAKKzxodG1sPgorPGJvZHk+CisgIDxzY3JpcHQ+CitmdW5jdGlv
biBnZXRSZWdFeHAoKSB7CisgIHJldHVybiAvYS87Cit9CisgIDwvc2NyaXB0PgorPC9ib2R5Pgor
PC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>35015</attachid>
            <date>2009-08-17 22:32:53 -0700</date>
            <delta_ts>2009-08-17 23:06:43 -0700</delta_ts>
            <desc>Relative to WebKit</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>2603</size>
            <attacher name="Christian Plesner Hansen">christian.plesner.hansen</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDQ3MzU3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDgtMTcgIENocmlzdGlhbiBQbGVzbmVy
IEhhbnNlbiAgPGNocmlzdGlhbi5wbGVzbmVyLmhhbnNlbkBnbWFpbC5jb20+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVncmVzc2lvbiB0ZXN0IGZv
ciBidWcgZml4ZWQgaW4KKyAgICAgICAgaHR0cDovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzE3
MTAzOS4gIFJlZ2V4cHMgY3JlYXRlZCBpbiBvbmUKKyAgICAgICAgZnJhbWUgd2VyZSBub3QgY2Fs
bGFibGUgb3V0c2lkZSB0aGF0IGZyYW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjgzODcKKworICAgICAgICAqIGZhc3QvcmVnZXgvcmVnZXhwLWNy
b3NzLWZyYW1lLWNhbGxhYmxlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9y
ZWdleC9yZWdleHAtY3Jvc3MtZnJhbWUtY2FsbGFibGUuaHRtbDogQWRkZWQuCisgICAgICAgICog
ZmFzdC9yZWdleC9yZXNvdXJjZXMvcmVnZXhwLWNyb3NzLWZyYW1lLWNhbGxhYmxlLWNoaWxkLmh0
bWw6IEFkZGVkLgorCiAyMDA5LTA4LTE2ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4K
IAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogTGF5b3V0VGVzdHMv
ZmFzdC9yZWdleC9yZWdleHAtY3Jvc3MtZnJhbWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0Cj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcmVnZXgvcmVnZXhwLWNyb3NzLWZyYW1lLWNhbGxh
YmxlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvcmVnZXgv
cmVnZXhwLWNyb3NzLWZyYW1lLWNhbGxhYmxlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAg
LTAsMCArMSw0IEBACitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09N
UExFVEUKK1BBU1MgcmUoJ2EnKSBpcyBbJ2EnXQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9yZWdl
eC9yZWdleHAtY3Jvc3MtZnJhbWUtY2FsbGFibGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU
ZXN0cy9mYXN0L3JlZ2V4L3JlZ2V4cC1jcm9zcy1mcmFtZS1jYWxsYWJsZS5odG1sCShyZXZpc2lv
biAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9yZWdleHAtY3Jvc3MtZnJhbWUtY2FsbGFi
bGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyNCBAQAorPCFET0NUWVBFIEhUTUwgUFVC
TElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0i
c3R5bGVzaGVldCIgaHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxz
Y3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9o
ZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5
b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCitmdW5jdGlvbiBkb1Rlc3QoKSB7Cisg
IHJlID0gZnJhbWVzWzBdLmdldFJlZ0V4cCgpOworICBzaG91bGRCZSgicmUoJ2EnKSIsICJbJ2En
XSIpOworfQorCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorPGJv
ZHkgb25Mb2FkPSJkb1Rlc3QoKSI+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9
ImNvbnNvbGUiPjwvZGl2PgorPGlmcmFtZSBzcmM9InJlc291cmNlcy9yZWdleHAtY3Jvc3MtZnJh
bWUtY2FsbGFibGUtY2hpbGQuaHRtbCI+PC9pZnJhbWU+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVz
b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4
OiBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3Jlc291cmNlcy9yZWdleHAtY3Jvc3MtZnJhbWUtY2Fs
bGFibGUtY2hpbGQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3Jl
c291cmNlcy9yZWdleHAtY3Jvc3MtZnJhbWUtY2FsbGFibGUtY2hpbGQuaHRtbAkocmV2aXNpb24g
MCkKKysrIExheW91dFRlc3RzL2Zhc3QvcmVnZXgvcmVzb3VyY2VzL3JlZ2V4cC1jcm9zcy1mcmFt
ZS1jYWxsYWJsZS1jaGlsZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDkgQEAKKzxodG1s
PgorPGJvZHk+CisgIDxzY3JpcHQ+CitmdW5jdGlvbiBnZXRSZWdFeHAoKSB7CisgIHJldHVybiAv
YS87Cit9CisgIDwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>35021</attachid>
            <date>2009-08-17 23:35:25 -0700</date>
            <delta_ts>2009-08-17 23:56:06 -0700</delta_ts>
            <desc>Let&apos;s try that again</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>2900</size>
            <attacher name="Christian Plesner Hansen">christian.plesner.hansen</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDQ3NDE4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDgtMTcgIENocmlzdGlhbiBQbGVzbmVy
IEhhbnNlbiAgPGNocmlzdGlhbi5wbGVzbmVyLmhhbnNlbkBnbWFpbC5jb20+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVncmVzc2lvbiB0ZXN0IGZv
ciBidWcgZml4ZWQgaW4KKyAgICAgICAgaHR0cDovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzE3
MTAzOS4gIFJlZ2V4cHMgY3JlYXRlZCBpbiBvbmUKKyAgICAgICAgZnJhbWUgd2VyZSBub3QgY2Fs
bGFibGUgb3V0c2lkZSB0aGF0IGZyYW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjgzODcKKworICAgICAgICAqIGZhc3QvcmVnZXgvY3Jvc3MtZnJh
bWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3JlZ2V4L2Ny
b3NzLWZyYW1lLWNhbGxhYmxlLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcmVnZXgvcmVz
b3VyY2VzL2Nyb3NzLWZyYW1lLWNhbGxhYmxlLWNoaWxkLmh0bWw6IEFkZGVkLgorICAgICAgICAq
IGZhc3QvcmVnZXgvcmVzb3VyY2VzL2Nyb3NzLWZyYW1lLWNhbGxhYmxlLmpzOiBBZGRlZC4KKyAg
ICAgICAgKGRvVGVzdCk6CisKIDIwMDktMDgtMTcgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWpp
QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6
IExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY3Jvc3MtZnJhbWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY3Jvc3MtZnJhbWUtY2FsbGFi
bGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9j
cm9zcy1mcmFtZS1jYWxsYWJsZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs
NCBAQAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCitQ
QVNTIHJlKCdhJykgaXMgWydhJ10KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY3Jvc3Mt
ZnJhbWUtY2FsbGFibGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4
L2Nyb3NzLWZyYW1lLWNhbGxhYmxlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m
YXN0L3JlZ2V4L2Nyb3NzLWZyYW1lLWNhbGxhYmxlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg
KzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4K
KzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291
cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pz
LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0
aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJj
ZXMvY3Jvc3MtZnJhbWUtY2FsbGFibGUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pz
L3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJ
bmRleDogTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9yZXNvdXJjZXMvY3Jvc3MtZnJhbWUtY2FsbGFi
bGUtY2hpbGQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3Jlc291
cmNlcy9jcm9zcy1mcmFtZS1jYWxsYWJsZS1jaGlsZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5
b3V0VGVzdHMvZmFzdC9yZWdleC9yZXNvdXJjZXMvY3Jvc3MtZnJhbWUtY2FsbGFibGUtY2hpbGQu
aHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw3IEBACis8aHRtbD4KKzxib2R5PgorPHNjcmlw
dD4KK3RvcC5kb1Rlc3QoL2EvKTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDog
TGF5b3V0VGVzdHMvZmFzdC9yZWdleC9yZXNvdXJjZXMvY3Jvc3MtZnJhbWUtY2FsbGFibGUuanMK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9yZXNvdXJjZXMvY3Jvc3MtZnJh
bWUtY2FsbGFibGUuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3Jl
c291cmNlcy9jcm9zcy1mcmFtZS1jYWxsYWJsZS5qcwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwx
MSBAQAorZnVuY3Rpb24gZG9UZXN0KGNoaWxkUmVnRXhwKQoreworICAgIHJlID0gY2hpbGRSZWdF
eHA7CisgICAgc2hvdWxkQmUoInJlKCdhJykiLCAiWydhJ10iKTsKK30KKwordmFyIGlmcmFtZSA9
IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lmcmFtZScpOworaWZyYW1lLnNyYyA9ICJyZXNvdXJj
ZXMvY3Jvc3MtZnJhbWUtY2FsbGFibGUtY2hpbGQuaHRtbCI7Citkb2N1bWVudC5ib2R5LmFwcGVu
ZENoaWxkKGlmcmFtZSk7CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwo=
</data>
<flag name="review"
          id="19204"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>35023</attachid>
            <date>2009-08-17 23:56:06 -0700</date>
            <delta_ts>2009-08-19 07:38:04 -0700</delta_ts>
            <desc>Results ordering</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>2443</size>
            <attacher name="Christian Plesner Hansen">christian.plesner.hansen</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDQ3NDE5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDgtMTcgIENocmlzdGlhbiBQbGVzbmVy
IEhhbnNlbiAgPGNocmlzdGlhbi5wbGVzbmVyLmhhbnNlbkBnbWFpbC5jb20+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVncmVzc2lvbiB0ZXN0IGZv
ciBidWcgZml4ZWQgaW4KKyAgICAgICAgaHR0cDovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzE3
MTAzOS4gIFJlZ2V4cHMgY3JlYXRlZCBpbiBvbmUKKyAgICAgICAgZnJhbWUgd2VyZSBub3QgY2Fs
bGFibGUgb3V0c2lkZSB0aGF0IGZyYW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjgzODcKKworICAgICAgICAqIGZhc3QvcmVnZXgvY3Jvc3MtZnJh
bWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3JlZ2V4L2Ny
b3NzLWZyYW1lLWNhbGxhYmxlLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcmVnZXgvcmVz
b3VyY2VzL2Nyb3NzLWZyYW1lLWNhbGxhYmxlLmpzOiBBZGRlZC4KKyAgICAgICAgKGRvVGVzdCk6
CisKIDIwMDktMDgtMTcgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4K
IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL2Zh
c3QvcmVnZXgvY3Jvc3MtZnJhbWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY3Jvc3MtZnJhbWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0
CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9jcm9zcy1mcmFtZS1jYWxs
YWJsZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorUEFTUyByZSgn
YScpIGlzIFsnYSddCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09N
UExFVEUKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY3Jvc3MtZnJhbWUtY2FsbGFibGUu
aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L2Nyb3NzLWZyYW1lLWNh
bGxhYmxlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L2Nyb3Nz
LWZyYW1lLWNhbGxhYmxlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9D
VFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+
Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0
eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48
L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2
IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvY3Jvc3MtZnJhbWUt
Y2FsbGFibGUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10
ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVz
dHMvZmFzdC9yZWdleC9yZXNvdXJjZXMvY3Jvc3MtZnJhbWUtY2FsbGFibGUuanMKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9yZXNvdXJjZXMvY3Jvc3MtZnJhbWUtY2FsbGFi
bGUuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3Jlc291cmNlcy9j
cm9zcy1mcmFtZS1jYWxsYWJsZS5qcwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAorZnVu
Y3Rpb24gZG9UZXN0KGNoaWxkUmVnRXhwKQoreworICAgIHJlID0gY2hpbGRSZWdFeHA7CisgICAg
c2hvdWxkQmUoInJlKCdhJykiLCAiWydhJ10iKTsKK30KKwordmFyIGlmcmFtZSA9IGRvY3VtZW50
LmNyZWF0ZUVsZW1lbnQoJ2lmcmFtZScpOworZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChpZnJh
bWUpOworaWZyYW1lLmNvbnRlbnREb2N1bWVudC53cml0ZSgnPHNjcmlwdD50b3AuZG9UZXN0KC9h
Lyk8L3NjcmlwdD4nKTsKKwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==
</data>
<flag name="review"
          id="19207"
          type_id="1"
          status="+"
          setter="eric"
    />
    <flag name="commit-queue"
          id="19208"
          type_id="3"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>35119</attachid>
            <date>2009-08-19 07:38:04 -0700</date>
            <delta_ts>2009-08-20 23:32:33 -0700</delta_ts>
            <desc>Added trailing newline</desc>
            <filename>testpatch</filename>
            <type>text/plain</type>
            <size>2445</size>
            <attacher name="Christian Plesner Hansen">christian.plesner.hansen</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDQ3NDE5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDgtMTcgIENocmlzdGlhbiBQbGVzbmVy
IEhhbnNlbiAgPGNocmlzdGlhbi5wbGVzbmVyLmhhbnNlbkBnbWFpbC5jb20+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVncmVzc2lvbiB0ZXN0IGZv
ciBidWcgZml4ZWQgaW4KKyAgICAgICAgaHR0cDovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzE3
MTAzOS4gIFJlZ2V4cHMgY3JlYXRlZCBpbiBvbmUKKyAgICAgICAgZnJhbWUgd2VyZSBub3QgY2Fs
bGFibGUgb3V0c2lkZSB0aGF0IGZyYW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjgzODcKKworICAgICAgICAqIGZhc3QvcmVnZXgvY3Jvc3MtZnJh
bWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3JlZ2V4L2Ny
b3NzLWZyYW1lLWNhbGxhYmxlLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcmVnZXgvcmVz
b3VyY2VzL2Nyb3NzLWZyYW1lLWNhbGxhYmxlLmpzOiBBZGRlZC4KKyAgICAgICAgKGRvVGVzdCk6
CisKIDIwMDktMDgtMTcgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4K
IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL2Zh
c3QvcmVnZXgvY3Jvc3MtZnJhbWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY3Jvc3MtZnJhbWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0
CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9jcm9zcy1mcmFtZS1jYWxs
YWJsZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorUEFTUyByZSgn
YScpIGlzIFsnYSddCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09N
UExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9jcm9zcy1mcmFtZS1jYWxsYWJs
ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY3Jvc3MtZnJhbWUt
Y2FsbGFibGUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY3Jv
c3MtZnJhbWUtY2FsbGFibGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPCFE
T0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVh
ZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qt
c3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMi
Pjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxk
aXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9jcm9zcy1mcmFt
ZS1jYWxsYWJsZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pz
LXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRU
ZXN0cy9mYXN0L3JlZ2V4L3Jlc291cmNlcy9jcm9zcy1mcmFtZS1jYWxsYWJsZS5qcwo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3Jlc291cmNlcy9jcm9zcy1mcmFtZS1jYWxs
YWJsZS5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvcmVnZXgvcmVzb3VyY2Vz
L2Nyb3NzLWZyYW1lLWNhbGxhYmxlLmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDExIEBACitm
dW5jdGlvbiBkb1Rlc3QoY2hpbGRSZWdFeHApCit7CisgICAgcmUgPSBjaGlsZFJlZ0V4cDsKKyAg
ICBzaG91bGRCZSgicmUoJ2EnKSIsICJbJ2EnXSIpOworfQorCit2YXIgaWZyYW1lID0gZG9jdW1l
bnQuY3JlYXRlRWxlbWVudCgnaWZyYW1lJyk7Citkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlm
cmFtZSk7CitpZnJhbWUuY29udGVudERvY3VtZW50LndyaXRlKCc8c2NyaXB0PnRvcC5kb1Rlc3Qo
L2EvKTwvc2NyaXB0PicpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>38363</attachid>
            <date>2009-08-20 23:32:33 -0700</date>
            <delta_ts>2009-08-21 15:57:58 -0700</delta_ts>
            <desc>Fixed trailing newline issue</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>2474</size>
            <attacher name="Christian Plesner Hansen">christian.plesner.hansen</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDQ3NDE5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDgtMTcgIENocmlzdGlhbiBQbGVzbmVy
IEhhbnNlbiAgPGNocmlzdGlhbi5wbGVzbmVyLmhhbnNlbkBnbWFpbC5jb20+CisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVncmVzc2lvbiB0ZXN0IGZv
ciBidWcgZml4ZWQgaW4KKyAgICAgICAgaHR0cDovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzE3
MTAzOS4gIFJlZ2V4cHMgY3JlYXRlZCBpbiBvbmUKKyAgICAgICAgZnJhbWUgd2VyZSBub3QgY2Fs
bGFibGUgb3V0c2lkZSB0aGF0IGZyYW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjgzODcKKworICAgICAgICAqIGZhc3QvcmVnZXgvY3Jvc3MtZnJh
bWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3JlZ2V4L2Ny
b3NzLWZyYW1lLWNhbGxhYmxlLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcmVnZXgvcmVz
b3VyY2VzL2Nyb3NzLWZyYW1lLWNhbGxhYmxlLmpzOiBBZGRlZC4KKyAgICAgICAgKGRvVGVzdCk6
CisKIDIwMDktMDgtMTcgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4K
IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL2Zh
c3QvcmVnZXgvY3Jvc3MtZnJhbWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY3Jvc3MtZnJhbWUtY2FsbGFibGUtZXhwZWN0ZWQudHh0
CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9jcm9zcy1mcmFtZS1jYWxs
YWJsZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNSBAQAorUEFTUyByZSgn
YScpIGlzIFsnYSddCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09N
UExFVEUKK0RPTkUKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcmVnZXgvY3Jvc3MtZnJhbWUtY2Fs
bGFibGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L2Nyb3NzLWZy
YW1lLWNhbGxhYmxlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4
L2Nyb3NzLWZyYW1lLWNhbGxhYmxlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAK
KzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgor
PGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10
ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJl
LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+
Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvY3Jvc3Mt
ZnJhbWUtY2FsbGFibGUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNl
cy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5
b3V0VGVzdHMvZmFzdC9yZWdleC9yZXNvdXJjZXMvY3Jvc3MtZnJhbWUtY2FsbGFibGUuanMKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9yZXNvdXJjZXMvY3Jvc3MtZnJhbWUt
Y2FsbGFibGUuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3Jlc291
cmNlcy9jcm9zcy1mcmFtZS1jYWxsYWJsZS5qcwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMiBA
QAorZnVuY3Rpb24gZG9UZXN0KGNoaWxkUmVnRXhwKQoreworICAgIHJlID0gY2hpbGRSZWdFeHA7
CisgICAgc2hvdWxkQmUoInJlKCdhJykiLCAiWydhJ10iKTsKK30KKwordmFyIGlmcmFtZSA9IGRv
Y3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lmcmFtZScpOworZG9jdW1lbnQuYm9keS5hcHBlbmRDaGls
ZChpZnJhbWUpOworaWZyYW1lLmNvbnRlbnREb2N1bWVudC53cml0ZSgnPHNjcmlwdD50b3AuZG9U
ZXN0KC9hLyk8L3NjcmlwdD4nKTsKK2RvY3VtZW50LndyaXRlKCdET05FJyk7CisKK3ZhciBzdWNj
ZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>