28385 2009-08-17 00:27:34 -0700 Tweak HTMLFrameElementBase so that m_URL can be private 2009-08-17 00:35:17 -0700 1 1 1 Unclassified WebKit Frames 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin oldest_to_newest 140686 0 darin 2009-08-17 00:27:34 -0700 HTMLFrameElementBase has a function, isURLAllowed, that takes an AtomicString argument. But it is always called with the value from m_URL, and it should use that directly rather than taking an argument so we can make m_URL private. 140687 1 34962 darin 2009-08-17 00:30:21 -0700 Created attachment 34962 patch 140690 2 darin 2009-08-17 00:35:17 -0700 http://trac.webkit.org/changeset/47354 34962 2009-08-17 00:30:21 -0700 2009-08-17 00:32:59 -0700 patch PrivateURLPatch.txt text/plain 4974 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzM1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMTcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR3ZWFr IEhUTUxGcmFtZUVsZW1lbnRCYXNlIHNvIHRoYXQgbV9VUkwgY2FuIGJlIHByaXZhdGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4Mzg1CisKKyAgICAg ICAgKiBodG1sL0hUTUxGcmFtZUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZy YW1lRWxlbWVudDo6cmVuZGVyZXJJc05lZWRlZCk6IFJlbW92ZWQgbV9VUkwgYXJndW1lbnQuCisg ICAgICAgICogaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MRnJhbWVFbGVtZW50QmFzZTo6aXNVUkxBbGxvd2VkKTogVXNlIG1fVVJMIGluc3RlYWQg b2YKKyAgICAgICAgdGFraW5nIGFuIGFyZ3VtZW50LgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZy YW1lRWxlbWVudEJhc2U6Om9wZW5VUkwpOiBSZW1vdmVkIG1fVVJMIGFyZ3VtZW50LgorICAgICAg ICAqIGh0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuaDogUmVtb3ZlZCBhcmd1bWVudCBmcm9tIGlz VVJMQWxsb3dlZCBmdW5jdGlvbi4KKyAgICAgICAgKiBodG1sL0hUTUxJRnJhbWVFbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJRnJhbWVFbGVtZW50OjpyZW5kZXJlcklzTmVlZGVk KTogUmVtb3ZlZCBtX1VSTCBhcmd1bWVudC4KKwogMjAwOS0wOC0xNyAgRGFyaW4gQWRsZXIgIDxk YXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5k ZXg6IFdlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudC5jcHAJKHJldmlzaW9uIDQ3MzEyKQorKysgV2ViQ29y ZS9odG1sL0hUTUxGcmFtZUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDkgKzEsOSBA QAotLyoqCisvKgogICogQ29weXJpZ2h0IChDKSAxOTk5IExhcnMgS25vbGwgKGtub2xsQGtkZS5v cmcpCiAgKiAgICAgICAgICAgKEMpIDE5OTkgQW50dGkgS29pdmlzdG8gKGtvaXZpc3RvQGtkZS5v cmcpCiAgKiAgICAgICAgICAgKEMpIDIwMDAgU2ltb24gSGF1c21hbm4gKGhhdXNtYW5uQGtkZS5v cmcpCiAgKiAgICAgICAgICAgKEMpIDIwMDEgRGlyayBNdWVsbGVyIChtdWVsbGVyQGtkZS5vcmcp Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMDQsIDIwMDYgQXBwbGUgQ29tcHV0ZXIsIEluYy4KKyAqIENv cHlyaWdodCAoQykgMjAwNCwgMjAwNiwgMjAwOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0 cmlidXRlIGl0IGFuZC9vcgogICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05V IExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTQ1LDcgKzQ1LDcgQEAgSFRNTEZyYW1lRWxlbWVu dDo6SFRNTEZyYW1lRWxlbWVudChjb25zdAogYm9vbCBIVE1MRnJhbWVFbGVtZW50OjpyZW5kZXJl cklzTmVlZGVkKFJlbmRlclN0eWxlKikKIHsKICAgICAvLyBGb3IgY29tcGF0aWJpbGl0eSwgZnJh bWVzIHJlbmRlciBldmVuIHdoZW4gZGlzcGxheTogbm9uZSBpcyBzZXQuCi0gICAgcmV0dXJuIGlz VVJMQWxsb3dlZChtX1VSTCk7CisgICAgcmV0dXJuIGlzVVJMQWxsb3dlZCgpOwogfQogCiBSZW5k ZXJPYmplY3QqIEhUTUxGcmFtZUVsZW1lbnQ6OmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hKiBh cmVuYSwgUmVuZGVyU3R5bGUqKQpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxGcmFtZUVsZW1lbnRC YXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2Uu Y3BwCShyZXZpc2lvbiA0NzMxMikKKysrIFdlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFz ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2LDEyICs1NiwxMiBAQCBIVE1MRnJhbWVFbGVtZW50 QmFzZTo6SFRNTEZyYW1lRWxlbWVudEJhCiB7CiB9CiAKLWJvb2wgSFRNTEZyYW1lRWxlbWVudEJh c2U6OmlzVVJMQWxsb3dlZChjb25zdCBBdG9taWNTdHJpbmcmIFVSTFN0cmluZykgY29uc3QKK2Jv b2wgSFRNTEZyYW1lRWxlbWVudEJhc2U6OmlzVVJMQWxsb3dlZCgpIGNvbnN0CiB7Ci0gICAgaWYg KFVSTFN0cmluZy5pc0VtcHR5KCkpCisgICAgaWYgKG1fVVJMLmlzRW1wdHkoKSkKICAgICAgICAg cmV0dXJuIHRydWU7CiAKLSAgICBjb25zdCBLVVJMJiBjb21wbGV0ZVVSTCA9IGRvY3VtZW50KCkt PmNvbXBsZXRlVVJMKFVSTFN0cmluZyk7CisgICAgY29uc3QgS1VSTCYgY29tcGxldGVVUkwgPSBk b2N1bWVudCgpLT5jb21wbGV0ZVVSTChtX1VSTCk7CiAKICAgICAvLyBEb24ndCBhbGxvdyBtb3Jl IHRoYW4gMjAwIHRvdGFsIGZyYW1lcyBpbiBhIHNldC4gVGhpcyBzZWVtcwogICAgIC8vIGxpa2Ug YSByZWFzb25hYmxlIHVwcGVyIGJvdW5kLCBhbmQgb3RoZXJ3aXNlIG11dHVhbGx5IHJlY3Vyc2l2 ZQpAQCAtOTMsNyArOTMsNyBAQCB2b2lkIEhUTUxGcmFtZUVsZW1lbnRCYXNlOjpvcGVuVVJMKCkK IHsKICAgICBBU1NFUlQoIW1fZnJhbWVOYW1lLmlzRW1wdHkoKSk7CiAKLSAgICBpZiAoIWlzVVJM QWxsb3dlZChtX1VSTCkpCisgICAgaWYgKCFpc1VSTEFsbG93ZWQoKSkKICAgICAgICAgcmV0dXJu OwogCiAgICAgaWYgKG1fVVJMLmlzRW1wdHkoKSkKSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MRnJh bWVFbGVtZW50QmFzZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVt ZW50QmFzZS5oCShyZXZpc2lvbiA0NzMxMikKKysrIFdlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVt ZW50QmFzZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yLDcgKzIsNyBAQAogICogQ29weXJpZ2h0IChD KSAxOTk5IExhcnMgS25vbGwgKGtub2xsQGtkZS5vcmcpCiAgKiAgICAgICAgICAgKEMpIDE5OTkg QW50dGkgS29pdmlzdG8gKGtvaXZpc3RvQGtkZS5vcmcpCiAgKiAgICAgICAgICAgKEMpIDIwMDAg U2ltb24gSGF1c21hbm4gPGhhdXNtYW5uQGtkZS5vcmc+Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMDQs IDIwMDYsIDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0 IChDKSAyMDA0LCAyMDA2LCAyMDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KICAqCiAgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3Ry aWJ1dGUgaXQgYW5kL29yCiAgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUg TGlicmFyeSBHZW5lcmFsIFB1YmxpYwpAQCAtODQsNyArODQsNyBAQCBwdWJsaWM6CiBwcm90ZWN0 ZWQ6CiAgICAgSFRNTEZyYW1lRWxlbWVudEJhc2UoY29uc3QgUXVhbGlmaWVkTmFtZSYsIERvY3Vt ZW50Kik7CiAKLSAgICBib29sIGlzVVJMQWxsb3dlZChjb25zdCBBdG9taWNTdHJpbmcmKSBjb25z dDsKKyAgICBib29sIGlzVVJMQWxsb3dlZCgpIGNvbnN0OwogICAgIHZvaWQgc2V0TmFtZUFuZE9w ZW5VUkwoKTsKICAgICB2b2lkIG9wZW5VUkwoKTsKIApJbmRleDogV2ViQ29yZS9odG1sL0hUTUxJ RnJhbWVFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTElGcmFtZUVs ZW1lbnQuY3BwCShyZXZpc2lvbiA0NzMxMikKKysrIFdlYkNvcmUvaHRtbC9IVE1MSUZyYW1lRWxl bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMsNyArMyw3IEBACiAgKiAgICAgICAgICAgKEMp IDE5OTkgQW50dGkgS29pdmlzdG8gKGtvaXZpc3RvQGtkZS5vcmcpCiAgKiAgICAgICAgICAgKEMp IDIwMDAgU2ltb24gSGF1c21hbm4gKGhhdXNtYW5uQGtkZS5vcmcpCiAgKiAgICAgICAgICAgKEMp IDIwMDEgRGlyayBNdWVsbGVyIChtdWVsbGVyQGtkZS5vcmcpCi0gKiBDb3B5cmlnaHQgKEMpIDIw MDQsIDIwMDYsIDIwMDggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJp Z2h0IChDKSAyMDA0LCAyMDA2LCAyMDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KICAqCiAgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRp c3RyaWJ1dGUgaXQgYW5kL29yCiAgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBH TlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwpAQCAtODksNyArODksNyBAQCB2b2lkIEhUTUxJRnJh bWVFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpCiAKIGJvb2wgSFRNTElGcmFtZUVsZW1lbnQ6OnJl bmRlcmVySXNOZWVkZWQoUmVuZGVyU3R5bGUqIHN0eWxlKQogewotICAgIHJldHVybiBpc1VSTEFs bG93ZWQobV9VUkwpICYmIHN0eWxlLT5kaXNwbGF5KCkgIT0gTk9ORTsKKyAgICByZXR1cm4gaXNV UkxBbGxvd2VkKCkgJiYgc3R5bGUtPmRpc3BsYXkoKSAhPSBOT05FOwogfQogCiBSZW5kZXJPYmpl Y3QqIEhUTUxJRnJhbWVFbGVtZW50OjpjcmVhdGVSZW5kZXJlcihSZW5kZXJBcmVuYSogYXJlbmEs IFJlbmRlclN0eWxlKikK