283824 2024-11-29 05:55:43 -0800 [webkitpy] git-webkit revert --no-pr --no-bug fails with "Please verify that the issue exists" 2024-12-11 00:44:07 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez webkit-unassigned ben_schwartz bfan2 gsnedders jbedard webkit-bug-importer oldest_to_newest 2078162 0 aperez 2024-11-29 05:55:43 -0800 Trying to use “./Scripts/Tools/git-webkit revert --no-pr --no-bug <commit>” produces a traceback (note that I left the bug URL/title empty because I did not want to create a bug in this case): % ./Tools/Scripts/git-webkit revert --no-pr --no-bug cdbaf316924a9586fe251b1006041b334d0c7fac This issue will track the revert and should not be the issue of the commit(s) to be reverted. Enter issue URL or title of new issue (reason for the revert): Traceback (most recent call last): File "/home/aperez/devel/WebKit-2.46/./Tools/Scripts/git-webkit", line 63, in <module> sys.exit(program.main( ^^^^^^^^^^^^^ File "/home/aperez/devel/WebKit-2.46/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 185, in main return parsed.main( ^^^^^^^^^^^^ File "/home/aperez/devel/WebKit-2.46/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py", line 286, in main issue = cls.get_issue_info(args, repository, commit_objects, commit_issues, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/aperez/devel/WebKit-2.46/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py", line 139, in get_issue_info sys.stderr.write('Could not fetch {} from link. Please verify that the issue exists.\n'.format(issue.tracker.NAME)) ^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'tracker' % 2079626 1 webkit-bug-importer 2024-12-06 05:56:12 -0800 <rdar://problem/141044493> 2079694 2 bfan2 2024-12-06 11:34:31 -0800 Pull request: https://github.com/WebKit/WebKit/pull/37553 2079707 3 bfan2 2024-12-06 12:20:26 -0800 Example of new behavior: ```bfan@mac-422505 OpenSource % ../../OpenSource/Tools/Scripts/git-webkit revert ecd3a7a716062c31212fa77d43e71416fba41f66 --no-issue --no-pr Enter a reason for the revert: Testing revert without issue Switched to a new branch 'eng/Testing-revert-without-issue' Created the local development branch 'eng/Testing-revert-without-issue' Running status to find changed, added, or removed files. Reviewing diff to determine which lines changed. Extracting affected function names from source files. Change author: Brianna Fan <bfan2@apple.com>. [eng/Testing-revert-without-issue 71fd4549d416] Unreviewed, reverting 287415@main (ecd3a7a71606) Include a Bugzilla link (OOPS!). Include a Radar link (OOPS!). Date: Fri Dec 6 12:03:26 2024 -0800 1 file changed, 2 insertions(+) ``` 2080225 4 ews-feeder 2024-12-09 09:44:05 -0800 Committed 287555@main (dec8a5a19822): <https://commits.webkit.org/287555@main> Reviewed commits have been landed. Closing PR #37553 and removing active labels. 2080772 5 aperez 2024-12-11 00:44:07 -0800 (In reply to Brianna Fan from comment #3) > Example of new behavior: > > ```bfan@mac-422505 OpenSource % ../../OpenSource/Tools/Scripts/git-webkit > revert ecd3a7a716062c31212fa77d43e71416fba41f66 --no-issue --no-pr > Enter a reason for the revert: Testing revert without issue > Switched to a new branch 'eng/Testing-revert-without-issue' > Created the local development branch 'eng/Testing-revert-without-issue' > Running status to find changed, added, or removed files. > Reviewing diff to determine which lines changed. > Extracting affected function names from source files. > Change author: Brianna Fan <bfan2@apple.com>. > [eng/Testing-revert-without-issue 71fd4549d416] Unreviewed, reverting > 287415@main (ecd3a7a71606) Include a Bugzilla link (OOPS!). Include a Radar > link (OOPS!). > Date: Fri Dec 6 12:03:26 2024 -0800 > 1 file changed, 2 insertions(+) > ``` Lovely, thanks a lot for looking into this ✨