28375 2009-08-16 21:54:57 -0700 execCommand("InsertHorizontalRule") inserts a broken <hr> element 2009-08-16 22:25:44 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin oldest_to_newest 140650 0 darin 2009-08-16 21:54:57 -0700 The code in executeInsertHorizontalRule creates an <hr> element of the wrong internal class. This makes it serialize incorrectly and has a number of other minor bad effects. 140651 1 34946 darin 2009-08-16 21:59:01 -0700 Created attachment 34946 patch 140663 2 darin 2009-08-16 22:25:44 -0700 http://trac.webkit.org/changeset/47349 34946 2009-08-16 21:59:01 -0700 2009-08-16 22:01:40 -0700 patch HRPatch.txt text/plain 6359 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzM0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDgtMTYgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGV4ZWND b21tYW5kKCJJbnNlcnRIb3Jpem9udGFsUnVsZSIpIGluc2VydHMgYSBicm9rZW4gPGhyPiBlbGVt ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODM3 NQorCisgICAgICAgICogZWRpdGluZy9FZGl0b3JDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OmV4ZWN1dGVJbnNlcnRIb3Jpem9udGFsUnVsZSk6IENyZWF0ZSBhbiBIVE1MSFJFbGVtZW50 CisgICAgICAgIGluc3RlYWQgb2YganVzdCBhbiBIVE1MRWxlbWVudC4KKwogMjAwOS0wOC0xNiAg Tmlrb2xhcyBaaW1tZXJtYW5uICA8bmlrb2xhcy56aW1tZXJtYW5uQHRvcmNobW9iaWxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KSW5kZXg6IFdlYkNvcmUvZWRp dGluZy9FZGl0b3JDb21tYW5kLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcvRWRp dG9yQ29tbWFuZC5jcHAJKHJldmlzaW9uIDQ3MzEzKQorKysgV2ViQ29yZS9lZGl0aW5nL0VkaXRv ckNvbW1hbmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBACiAjaW5jbHVkZSAi Rm9ybWF0QmxvY2tDb21tYW5kLmgiCiAjaW5jbHVkZSAiRnJhbWUuaCIKICNpbmNsdWRlICJIVE1M Rm9udEVsZW1lbnQuaCIKKyNpbmNsdWRlICJIVE1MSFJFbGVtZW50LmgiCiAjaW5jbHVkZSAiSFRN TEltYWdlRWxlbWVudC5oIgogI2luY2x1ZGUgIkluZGVudE91dGRlbnRDb21tYW5kLmgiCiAjaW5j bHVkZSAiSW5zZXJ0TGlzdENvbW1hbmQuaCIKQEAgLTQ2Nyw3ICs0NjgsNyBAQCBzdGF0aWMgYm9v bCBleGVjdXRlSW5zZXJ0QmFja3RhYihGcmFtZSogCiAKIHN0YXRpYyBib29sIGV4ZWN1dGVJbnNl cnRIb3Jpem9udGFsUnVsZShGcmFtZSogZnJhbWUsIEV2ZW50KiwgRWRpdG9yQ29tbWFuZFNvdXJj ZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSkKIHsKLSAgICBSZWZQdHI8SFRNTEVsZW1lbnQ+IGhyID0g bmV3IEhUTUxFbGVtZW50KGhyVGFnLCBmcmFtZS0+ZG9jdW1lbnQoKSk7CisgICAgUmVmUHRyPEhU TUxIUkVsZW1lbnQ+IGhyID0gbmV3IEhUTUxIUkVsZW1lbnQoaHJUYWcsIGZyYW1lLT5kb2N1bWVu dCgpKTsKICAgICBpZiAoIXZhbHVlLmlzRW1wdHkoKSkKICAgICAgICAgaHItPnNldElkKHZhbHVl KTsKICAgICByZXR1cm4gZXhlY3V0ZUluc2VydE5vZGUoZnJhbWUsIGhyLnJlbGVhc2UoKSk7Cklu ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCShyZXZpc2lvbiA0NzM0NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDA5LTA4LTE2ICBEYXJpbiBBZGxlciAgPGRhcmlu QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBleGVjQ29tbWFuZCgiSW5zZXJ0SG9yaXpvbnRhbFJ1bGUiKSBpbnNlcnRzIGEgYnJva2Vu IDxocj4gZWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjgzNzUKKworICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvYXJndW1lbnRzLWNv bWJpbmF0aW9ucy1leHBlY3RlZC50eHQ6IFVwZGF0ZWQuCisgICAgICAgICogZWRpdGluZy9leGVj Q29tbWFuZC9hcmd1bWVudHMtY29tYmluYXRpb25zLmh0bWw6IFVwZGF0ZWQgdG8gZXhwZWN0Cisg ICAgICAgIHRoZSA8aHI+IGVsZW1lbnQgdG8gYmUgc2VsZi1jbG9zaW5nIHJhdGhlciB0aGFuIGhh dmluZyBhIHNlcGFyYXRlCisgICAgICAgIDwvaHI+IGluIHRoZSBtYXJrdXAuCisKIDIwMDktMDgt MTYgIE5pa29sYXMgWmltbWVybWFubiAgPG5pa29sYXMuemltbWVybWFubkB0b3JjaG1vYmlsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvcmdlIFN0YWlrb3MuCkluZGV4OiBMYXlvdXRU ZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2FyZ3VtZW50cy1jb21iaW5hdGlvbnMtZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvYXJndW1l bnRzLWNvbWJpbmF0aW9ucy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDQ3MzEyKQorKysgTGF5b3V0 VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9hcmd1bWVudHMtY29tYmluYXRpb25zLWV4cGVjdGVk LnR4dAkod29ya2luZyBjb3B5KQpAQCAtMiwxMyArMiwxMyBAQCBUaGVzZSBhcmUgdGVzdHMgZm9y IHRlc3RpbmcgdGhlIGhvdyBleGVjCiAKIENPTlNPTEUKIAotUEFTUyA8aHI+PC9ocj4gaXMgPGhy PjwvaHI+Ci1QQVNTIDxocj48L2hyPiBpcyA8aHI+PC9ocj4KLVBBU1MgPGhyIGlkPSJmb28iPjwv aHI+IGlzIDxociBpZD0iZm9vIj48L2hyPgotUEFTUyA8aHIgaWQ9ImZvbyI+PC9ocj4gaXMgPGhy IGlkPSJmb28iPjwvaHI+Ci1QQVNTIDxocj48L2hyPiBpcyA8aHI+PC9ocj4KLVBBU1MgPGhyPjwv aHI+IGlzIDxocj48L2hyPgotUEFTUyA8aHI+PC9ocj4gaXMgPGhyPjwvaHI+Ci1QQVNTIDxociBp ZD0iMCI+PC9ocj4gaXMgPGhyIGlkPSIwIj48L2hyPgotUEFTUyA8aHI+PC9ocj4gaXMgPGhyPjwv aHI+CitQQVNTIDxocj4gaXMgPGhyPgorUEFTUyA8aHI+IGlzIDxocj4KK1BBU1MgPGhyIGlkPSJm b28iPiBpcyA8aHIgaWQ9ImZvbyI+CitQQVNTIDxociBpZD0iZm9vIj4gaXMgPGhyIGlkPSJmb28i PgorUEFTUyA8aHI+IGlzIDxocj4KK1BBU1MgPGhyPiBpcyA8aHI+CitQQVNTIDxocj4gaXMgPGhy PgorUEFTUyA8aHIgaWQ9IjAiPiBpcyA8aHIgaWQ9IjAiPgorUEFTUyA8aHI+IGlzIDxocj4KIApJ bmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9hcmd1bWVudHMtY29tYmluYXRp b25zLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9h cmd1bWVudHMtY29tYmluYXRpb25zLmh0bWwJKHJldmlzaW9uIDQ3MzEyKQorKysgTGF5b3V0VGVz dHMvZWRpdGluZy9leGVjQ29tbWFuZC9hcmd1bWVudHMtY29tYmluYXRpb25zLmh0bWwJKHdvcmtp bmcgY29weSkKQEAgLTU1LDMxICs1NSwzMSBAQAogICAgICAgICAgICAgICAgICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogCiAgICAgICAgICAgICAgICAgLy8gVGVzdCB3 aXRoIDEgYXJndW1lbnQuCi0gICAgICAgICAgICAgICAgdGVzdCgnZG9jdW1lbnQuZXhlY0NvbW1h bmQoIkluc2VydEhvcml6b250YWxSdWxlIiknLCAnPGhyPjwvaHI+Jyk7CisgICAgICAgICAgICAg ICAgdGVzdCgnZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydEhvcml6b250YWxSdWxlIiknLCAn PGhyPicpOwogCiAgICAgICAgICAgICAgICAgLy8gVGVzdCB3aXRoIDIgYXJndW1lbnRzLgotICAg ICAgICAgICAgICAgIHRlc3QoJ2RvY3VtZW50LmV4ZWNDb21tYW5kKCJJbnNlcnRIb3Jpem9udGFs UnVsZSIsIGZhbHNlKScsICc8aHI+PC9ocj4nKTsKKyAgICAgICAgICAgICAgICB0ZXN0KCdkb2N1 bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0SG9yaXpvbnRhbFJ1bGUiLCBmYWxzZSknLCAnPGhyPicp OwogCiAgICAgICAgICAgICAgICAgLy8gVGVzdCB3aXRoIDMgYXJndW1lbnRzLgotICAgICAgICAg ICAgICAgIHRlc3QoJ2RvY3VtZW50LmV4ZWNDb21tYW5kKCJJbnNlcnRIb3Jpem9udGFsUnVsZSIs IGZhbHNlLCAiZm9vIiknLCAnPGhyIGlkPSJmb28iPjwvaHI+Jyk7CisgICAgICAgICAgICAgICAg dGVzdCgnZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydEhvcml6b250YWxSdWxlIiwgZmFsc2Us ICJmb28iKScsICc8aHIgaWQ9ImZvbyI+Jyk7CiAKICAgICAgICAgICAgICAgICAvLyBUZXN0IHdp dGggNCBhcmd1bWVudHMuIChzaG91bGQgaWdub3JlIHRoZSBmb3VydGggYXJndW1lbnQgc2lsZW50 bHkpCi0gICAgICAgICAgICAgICAgdGVzdCgnZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydEhv cml6b250YWxSdWxlIiwgZmFsc2UsICJmb28iLCAiYmFyIiknLCAnPGhyIGlkPSJmb28iPjwvaHI+ Jyk7CisgICAgICAgICAgICAgICAgdGVzdCgnZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydEhv cml6b250YWxSdWxlIiwgZmFsc2UsICJmb28iLCAiYmFyIiknLCAnPGhyIGlkPSJmb28iPicpOwog CiAgICAgICAgICAgICAgICAgLy8gVGVzdCBlbXB0eSBTdHJpbmcgM3JkIHBhcmFtZXRlci4gKHNo b3VsZCBub3QgYWRkIGFuIGVtcHR5IGlkIHZhbHVlKQotICAgICAgICAgICAgICAgIHRlc3QoJ2Rv Y3VtZW50LmV4ZWNDb21tYW5kKCJJbnNlcnRIb3Jpem9udGFsUnVsZSIsIGZhbHNlLCAiIiknLCAn PGhyPjwvaHI+Jyk7CisgICAgICAgICAgICAgICAgdGVzdCgnZG9jdW1lbnQuZXhlY0NvbW1hbmQo Ikluc2VydEhvcml6b250YWxSdWxlIiwgZmFsc2UsICIiKScsICc8aHI+Jyk7CiAKICAgICAgICAg ICAgICAgICAvLyBUZXN0IG51bGwgM3JkIHBhcmFtZXRlci4gKHNob3VsZCB0cmVhdCBhcyBpZiBv bmx5IHR3byBhcmd1bWVudHMgd2VyZSBwYXNzZWQsIHNhbWUgYXMgdW5kZWZpbmVkKQotICAgICAg ICAgICAgICAgIHRlc3QoJ2RvY3VtZW50LmV4ZWNDb21tYW5kKCJJbnNlcnRIb3Jpem9udGFsUnVs ZSIsIGZhbHNlLCBudWxsKScsICc8aHI+PC9ocj4nKTsKKyAgICAgICAgICAgICAgICB0ZXN0KCdk b2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0SG9yaXpvbnRhbFJ1bGUiLCBmYWxzZSwgbnVsbCkn LCAnPGhyPicpOwogCiAgICAgICAgICAgICAgICAgLy8gVGVzdCB1bmRlZmluZWQgM3JkIHBhcmFt ZXRlci4gKHNob3VsZCB0cmVhdCBhcyBpZiBvbmx5IHR3byBhcmd1bWVudHMgd2VyZSBwYXNzZWQs IHNhbWUgYXMgbnVsbCkKLSAgICAgICAgICAgICAgICB0ZXN0KCdkb2N1bWVudC5leGVjQ29tbWFu ZCgiSW5zZXJ0SG9yaXpvbnRhbFJ1bGUiLCBmYWxzZSwgdW5kZWZpbmVkKScsICc8aHI+PC9ocj4n KTsKKyAgICAgICAgICAgICAgICB0ZXN0KCdkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0SG9y aXpvbnRhbFJ1bGUiLCBmYWxzZSwgdW5kZWZpbmVkKScsICc8aHI+Jyk7CiAKICAgICAgICAgICAg ICAgICAvLyBUZXN0IDAgZm9yIDNyZCBwYXJhbWV0ZXIuIChub3RoaW5nIHNwZWNpYWwsIGlkIHZh bHVlIHNob3VsZCBlcXVhbCB0aGUgc3RyaW5nIDApCi0gICAgICAgICAgICAgICAgdGVzdCgnZG9j dW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydEhvcml6b250YWxSdWxlIiwgZmFsc2UsIDApJywgJzxo ciBpZD0iMCI+PC9ocj4nKTsKKyAgICAgICAgICAgICAgICB0ZXN0KCdkb2N1bWVudC5leGVjQ29t bWFuZCgiSW5zZXJ0SG9yaXpvbnRhbFJ1bGUiLCBmYWxzZSwgMCknLCAnPGhyIGlkPSIwIj4nKTsK IAogICAgICAgICAgICAgICAgIC8vIFRlc3QgdW5kZWZpbmVkIDNyZCBwYXJhbWV0ZXIgaW1wbGlj aXRseSB1c2luZyBoZWxwZXIgZnVuY3Rpb24uIChzaG91bGQgdHJlYXQgYXMgaWYgb25seSB0d28g YXJndW1lbnRzIHdlcmUgcGFzc2VkLCBzYW1lIGFzIG51bGwpCi0gICAgICAgICAgICAgICAgdGVz dCgnZnVuY3Rpb24gRXhlY0NvbW1hbmQoY29tbWFuZCwgY29tbWFuZFBhcmFtKSB7IGRvY3VtZW50 LmV4ZWNDb21tYW5kKGNvbW1hbmQsIGZhbHNlLCBjb21tYW5kUGFyYW0pOyB9IEV4ZWNDb21tYW5k KCJJbnNlcnRIb3Jpem9udGFsUnVsZSIpOycsICc8aHI+PC9ocj4nKTsKKyAgICAgICAgICAgICAg ICB0ZXN0KCdmdW5jdGlvbiBFeGVjQ29tbWFuZChjb21tYW5kLCBjb21tYW5kUGFyYW0pIHsgZG9j dW1lbnQuZXhlY0NvbW1hbmQoY29tbWFuZCwgZmFsc2UsIGNvbW1hbmRQYXJhbSk7IH0gRXhlY0Nv bW1hbmQoIkluc2VydEhvcml6b250YWxSdWxlIik7JywgJzxocj4nKTsKICAgICAgICAgICAgIH0K ICAgICAgICAgPC9zY3JpcHQ+CiAgICAgPC9oZWFkPgo=