28367 2009-08-16 15:16:03 -0700 bugzilla.py: replace ScriptError class with BugzillaError class 2009-08-16 17:34:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer webkit-unassigned aroben eric levin oldest_to_newest 140606 0 34938 ddkilzer 2009-08-16 15:16:03 -0700 Created attachment 34938 Patch v1 Reviewed by NOBODY (OOPS!). The ScriptError class doesn't exist in bugzilla.py, so any errors print error messages about ScriptError instead of the actual error: NameError: global name 'ScriptError' is not defined * Scripts/modules/bugzilla.py: (BugzillaError): Added class. Modeled after ScriptError class in scm.py. (Bugzilla.authenticate): Changed to use BugzillaError instead of ScriptError. (Bugzilla._check_create_bug_response): Ditto. --- 2 files changed, 26 insertions(+), 2 deletions(-) 140630 1 ddkilzer 2009-08-16 17:31:05 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/scm.py Committed r47343 M WebKitTools/Scripts/modules/scm.py M WebKitTools/Scripts/bugzilla-tool r47343 = 8671504eb06eb7308d006942678f0366b79d8c74 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk WebKitTools/ChangeLog: locally modified WebKitTools/Scripts/modules/bugzilla.py: locally modified M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py Committed r47344 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py r47344 = a9ed6e27ed13e67d584fa8d64413109318bdfcda (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47343 140631 2 ddkilzer 2009-08-16 17:31:10 -0700 All reviewed patches have been landed. Closing bug. 140632 3 ddkilzer 2009-08-16 17:34:11 -0700 (In reply to comment #1) > Committing to http://svn.webkit.org/repository/webkit/trunk ... > M WebKitTools/Scripts/bugzilla-tool > M WebKitTools/Scripts/modules/scm.py > Committed r47343 > M WebKitTools/Scripts/modules/scm.py > M WebKitTools/Scripts/bugzilla-tool > r47343 = 8671504eb06eb7308d006942678f0366b79d8c74 (trunk) > No changes between current HEAD and refs/remotes/trunk > Resetting to the latest refs/remotes/trunk This was a mistake. Backed out in r47345 again. <http://trac.webkit.org/changeset/47343> <http://trac.webkit.org/changeset/47345> > WebKitTools/ChangeLog: locally modified > WebKitTools/Scripts/modules/bugzilla.py: locally modified > M WebKitTools/ChangeLog > M WebKitTools/Scripts/modules/bugzilla.py > Committed r47344 > M WebKitTools/ChangeLog > M WebKitTools/Scripts/modules/bugzilla.py > r47344 = a9ed6e27ed13e67d584fa8d64413109318bdfcda (trunk) > No changes between current HEAD and refs/remotes/trunk > Resetting to the latest refs/remotes/trunk <http://trac.webkit.org/changeset/47344> 34938 2009-08-16 15:16:03 -0700 2009-08-16 16:26:09 -0700 Patch v1 20090816151602.patch text/plain 2485 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhMzRhNGRiLi5jNjYwZmJhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDktMDgt MTYgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBidWd6aWxs YS5weTogcmVwbGFjZSBTY3JpcHRFcnJvciBjbGFzcyB3aXRoIEJ1Z3ppbGxhRXJyb3IgY2xhc3MK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgU2Ny aXB0RXJyb3IgY2xhc3MgZG9lc24ndCBleGlzdCBpbiBidWd6aWxsYS5weSwgc28gYW55CisgICAg ICAgIGVycm9ycyBwcmludCBlcnJvciBtZXNzYWdlcyBhYm91dCBTY3JpcHRFcnJvciBpbnN0ZWFk IG9mIHRoZQorICAgICAgICBhY3R1YWwgZXJyb3I6CisKKyAgICAgICAgICAgIE5hbWVFcnJvcjog Z2xvYmFsIG5hbWUgJ1NjcmlwdEVycm9yJyBpcyBub3QgZGVmaW5lZAorCisgICAgICAgICogU2Ny aXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5OgorICAgICAgICAoQnVnemlsbGFFcnJvcik6IEFkZGVk IGNsYXNzLiAgTW9kZWxlZCBhZnRlciBTY3JpcHRFcnJvciBjbGFzcworICAgICAgICBpbiBzY20u cHkuCisgICAgICAgIChCdWd6aWxsYS5hdXRoZW50aWNhdGUpOiBDaGFuZ2VkIHRvIHVzZSBCdWd6 aWxsYUVycm9yIGluc3RlYWQgb2YKKyAgICAgICAgU2NyaXB0RXJyb3IuCisgICAgICAgIChCdWd6 aWxsYS5fY2hlY2tfY3JlYXRlX2J1Z19yZXNwb25zZSk6IERpdHRvLgorCiAyMDA5LTA4LTE0ICBB ZGFtIEJlcmdrdmlzdCAgPGFkYW0uYmVyZ2t2aXN0QGVyaWNzc29uLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9t b2R1bGVzL2J1Z3ppbGxhLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxh LnB5CmluZGV4IDg5NmQ3YWEuLjBjZGIxMzAgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Njcmlw dHMvbW9kdWxlcy9idWd6aWxsYS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMv YnVnemlsbGEucHkKQEAgLTExOSw2ICsxMTksMTEgQEAgZGVmIHJlYWRfY3JlZGVudGlhbHMoKToK IGRlZiB0aW1lc3RhbXAoKToKICAgICByZXR1cm4gZGF0ZXRpbWUubm93KCkuc3RyZnRpbWUoIiVZ JW0lZCVIJU0lUyIpCiAKKworY2xhc3MgQnVnemlsbGFFcnJvcihFeGNlcHRpb24pOgorICAgIHBh c3MKKworCiBjbGFzcyBCdWd6aWxsYToKICAgICBkZWYgX19pbml0X18oc2VsZiwgZHJ5cnVuPUZh bHNlLCBjb21taXR0ZXJzPUNvbW1pdHRlckxpc3QoKSk6CiAgICAgICAgIHNlbGYuZHJ5cnVuID0g ZHJ5cnVuCkBAIC0yNDUsNyArMjUwLDcgQEAgY2xhc3MgQnVnemlsbGE6CiAgICAgICAgICMgSWYg dGhlIHJlc3VsdGluZyBwYWdlIGhhcyBhIHRpdGxlLCBhbmQgaXQgY29udGFpbnMgdGhlIHdvcmQg ImludmFsaWQiIGFzc3VtZSBpdCdzIHRoZSBsb2dpbiBmYWlsdXJlIHBhZ2UuCiAgICAgICAgIGlm IG1hdGNoIGFuZCByZS5zZWFyY2goIkludmFsaWQiLCBtYXRjaC5ncm91cCgxKSwgcmUuSUdOT1JF Q0FTRSk6CiAgICAgICAgICAgICAjIEZJWE1FOiBXZSBjb3VsZCBhZGQgdGhlIGFiaWxpdHkgdG8g dHJ5IGFnYWluIG9uIGZhaWx1cmUuCi0gICAgICAgICAgICByYWlzZSBTY3JpcHRFcnJvcigiQnVn emlsbGEgbG9naW4gZmFpbGVkOiAlcyIgJSBtYXRjaC5ncm91cCgxKSkKKyAgICAgICAgICAgIHJh aXNlIEJ1Z3ppbGxhRXJyb3IoIkJ1Z3ppbGxhIGxvZ2luIGZhaWxlZDogJXMiICUgbWF0Y2guZ3Jv dXAoMSkpCiAKICAgICAgICAgc2VsZi5hdXRoZW50aWNhdGVkID0gVHJ1ZQogCkBAIC0yODcsNyAr MjkyLDcgQEAgY2xhc3MgQnVnemlsbGE6CiAgICAgICAgIGlmIG1hdGNoOgogICAgICAgICAgICAg dGV4dF9saW5lcyA9IEJlYXV0aWZ1bFNvdXAobWF0Y2guZ3JvdXAoJ2Vycm9yX21lc3NhZ2UnKSku ZmluZEFsbCh0ZXh0PVRydWUpCiAgICAgICAgICAgICBlcnJvcl9tZXNzYWdlID0gIlxuIiArICdc bicuam9pbihbIiAgIiArIGxpbmUuc3RyaXAoKSBmb3IgbGluZSBpbiB0ZXh0X2xpbmVzIGlmIGxp bmUuc3RyaXAoKV0pCi0gICAgICAgIHJhaXNlIFNjcmlwdEVycm9yKCJCdWcgbm90IGNyZWF0ZWQ6 ICVzIiAlIGVycm9yX21lc3NhZ2UpCisgICAgICAgIHJhaXNlIEJ1Z3ppbGxhRXJyb3IoIkJ1ZyBu b3QgY3JlYXRlZDogJXMiICUgZXJyb3JfbWVzc2FnZSkKIAogICAgIGRlZiBjcmVhdGVfYnVnX3dp dGhfcGF0Y2goc2VsZiwgYnVnX3RpdGxlLCBidWdfZGVzY3JpcHRpb24sIGNvbXBvbmVudCwgcGF0 Y2hfZmlsZV9vYmplY3QsIHBhdGNoX2Rlc2NyaXB0aW9uLCBjYywgbWFya19mb3JfcmV2aWV3PUZh bHNlKToKICAgICAgICAgc2VsZi5hdXRoZW50aWNhdGUoKQ==