28359 2009-08-16 10:31:34 -0700 Cleanup: Undo some accidental changes around DOMApplicationCache 2009-09-07 09:29:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 michaeln webkit-unassigned ap eric oldest_to_newest 140573 0 michaeln 2009-08-16 10:31:34 -0700 Two recent revision made two inavdertent changes around DOMApplicationCache. Those changes should be undone. r46609 made it a programming error to construct a DOMApplicationCache instance with a null frame ptr. r47018 made a change to return 'null' for window.applicationCache when the feature is disabled in the preferences. 140577 1 34928 michaeln 2009-08-16 10:39:35 -0700 Created attachment 34928 simple cleanup 140896 2 34928 eric 2009-08-17 17:15:14 -0700 Comment on attachment 34928 simple cleanup The DOMWindow change needs a test. It's possible to test preference changes in DumpRenderTree these days. 140936 3 michaeln 2009-08-17 17:49:26 -0700 (In reply to comment #2) > It's possible to test preference changes in DumpRenderTree these days. What does that mean? 141006 4 eric 2009-08-17 22:46:55 -0700 You can use things like: layoutTestController.overridePreference("WebKitDefaultFontSize", "24"); to override preferences for the duration of a single test. Thus you can test that toggling this preference no longer affects the visibility of window.applicaitonCache. Since we can test it, a test is required. :) 144679 5 39035 michaeln 2009-09-03 20:25:45 -0700 Created attachment 39035 cleanup with layout test 144912 6 39035 ap 2009-09-04 13:42:31 -0700 Comment on attachment 39035 cleanup with layout test r=me For the record, the rationale behind this behavior is: - it's slightly more consistent for a frameless window to be able to construct a DOMApplicaitonCache, because window.applicationCache would be non-null if constructed before detaching; - it's unlikely that any browser will have ApplicationCache compiled in, but disabled; run-time disabling is needed for clients like Dashboard. So, knowing that it's non-null can simplify code a little, and will do no harm. Neither is particularly important, just minor cleanup. + layoutTestController.overridePreference("WebKitOfflineWebApplicationCacheEnabled", false); Does this really work on all platforms? You may need to add this new test to Skipped list for some (or maybe the platforms that don't have it already skip all tests http/tests/in appcache?) 144916 7 michaeln 2009-09-04 13:58:42 -0700 > layoutTestController.overridePreference("WebKitOfflineWebApplicationCacheEnabled", > false); > > Does this really work on all platforms? You may need to add this new test to > Skipped list for some (or maybe the platforms that don't have it already skip > all tests http/tests/in appcache?) I'm not able to run the tests on all other platforms. layoutTestController seems to be very platform specific. For example, this particular preference name was not being respected in chrome's test_shell for example. I have a seperate CL to add support for this key in chrome land. The others impls I looked at did seem to support this pref name in their overridePreference method. Worth pointing out that the test does not confirm if the pref is actually disabled by the overridePreference call, nor does passage depend on the pref actually being disabled. The test will PASS even if a feature is still enabled. 145018 8 eric 2009-09-05 15:44:35 -0700 Exception: Unknown committer: michaeln@google.com Sigh. I need to fix the commit queue to not wedge itself when a non-committer sets commit-queue+. :( 145096 9 39035 eric 2009-09-06 22:14:58 -0700 Comment on attachment 39035 cleanup with layout test Rejecting patch 39035 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 145109 10 39035 eric 2009-09-07 00:17:02 -0700 Comment on attachment 39035 cleanup with layout test media/video-played-ranges-1.html -> failed Looks like yet another flakey media test. :( 145111 11 39035 eric 2009-09-07 00:28:30 -0700 Comment on attachment 39035 cleanup with layout test Clearing flags on attachment: 39035 Committed r48108: <http://trac.webkit.org/changeset/48108> 145112 12 eric 2009-09-07 00:28:34 -0700 All reviewed patches have been landed. Closing bug. 145180 13 michaeln 2009-09-07 09:29:22 -0700 (In reply to comment #12) > All reviewed patches have been landed. Closing bug. Thank you Eric! 34928 2009-08-16 10:39:35 -0700 2009-09-03 20:25:45 -0700 simple cleanup cleanup.txt text/plain 2684 michaeln SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzMzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMDgtMTYgIE1pY2hhZWwgTm9yZG1hbiAgPG1pY2hhZWxuQGdv b2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MzU5CisgICAgICAg IENsZWFudXA6IFVuZG8gc29tZSBhY2NpZGVudGFsIGNoYW5nZXMgYXJvdW5kIERPTUFwcGxpY2F0 aW9uQ2FjaGUuCisgICAgICAgIC0gUmVzdG9yZSBzdXBwb3J0IGZvciBjb25zdHJ1Y3RpbmcgYSBE T01BcHBsaWNhdGlvbkNhY2hlIG9iamVjdCB3aXRoIGEgbnVsbCBmcmFtZSBwdHIuCisgICAgICAg IC0gUmV0dXJuIGEgbm9uLW51bGwgb2JqZWN0IGZvciB3aW5kb3cuYXBwbGljYXRpb25DYWNoZSB3 aGVuIHRoZSBmZWF0dXJlIGlzIGRpc2FibGVkCisgICAgICAgICAgaW4gcHJlZmVyZW5jZXMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiBFeGlzdGluZyB0ZXN0cyBhbGwgcGFzcy4KKworICAgICAg ICAqIGxvYWRlci9hcHBjYWNoZS9ET01BcHBsaWNhdGlvbkNhY2hlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkRPTUFwcGxpY2F0aW9uQ2FjaGU6OkRPTUFwcGxpY2F0aW9uQ2FjaGUpOgorICAgICAg ICAoV2ViQ29yZTo6RE9NQXBwbGljYXRpb25DYWNoZTo6c2NyaXB0RXhlY3V0aW9uQ29udGV4dCk6 CisgICAgICAgICogcGFnZS9ET01XaW5kb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9NV2lu ZG93OjphcHBsaWNhdGlvbkNhY2hlKToKKwogMjAwOS0wOC0xNiAgUGF2ZWwgRmVsZG1hbiAgPHBm ZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNo ZXIuCkluZGV4OiBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9ET01BcHBsaWNhdGlvbkNhY2hlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9ET01BcHBsaWNhdGlvbkNh Y2hlLmNwcAkocmV2aXNpb24gNDczMzgpCisrKyBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9ET01B cHBsaWNhdGlvbkNhY2hlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIsOCArNDIsOSBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiBET01BcHBsaWNhdGlvbkNhY2hlOjpET01BcHBsaWNhdGlvbkNhY2hl KEZyYW1lKiBmcmFtZSkKICAgICA6IG1fZnJhbWUoZnJhbWUpCiB7Ci0gICAgQVNTRVJUKGFwcGxp Y2F0aW9uQ2FjaGVIb3N0KCkpOwotICAgIGFwcGxpY2F0aW9uQ2FjaGVIb3N0KCktPnNldERPTUFw cGxpY2F0aW9uQ2FjaGUodGhpcyk7CisgICAgQVNTRVJUKCFtX2ZyYW1lIHx8IGFwcGxpY2F0aW9u Q2FjaGVIb3N0KCkpOworICAgIGlmIChtX2ZyYW1lKQorICAgICAgICBhcHBsaWNhdGlvbkNhY2hl SG9zdCgpLT5zZXRET01BcHBsaWNhdGlvbkNhY2hlKHRoaXMpOwogfQogCiB2b2lkIERPTUFwcGxp Y2F0aW9uQ2FjaGU6OmRpc2Nvbm5lY3RGcmFtZSgpCkBAIC05Miw2ICs5Myw3IEBAIHZvaWQgRE9N QXBwbGljYXRpb25DYWNoZTo6c3dhcENhY2hlKEV4Y2UKIAogU2NyaXB0RXhlY3V0aW9uQ29udGV4 dCogRE9NQXBwbGljYXRpb25DYWNoZTo6c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpIGNvbnN0CiB7 CisgICAgQVNTRVJUKG1fZnJhbWUpOwogICAgIHJldHVybiBtX2ZyYW1lLT5kb2N1bWVudCgpOwog fQogCkBAIC0yMDksNyArMjExLDYgQEAgQXBwbGljYXRpb25DYWNoZUhvc3Q6OkV2ZW50SUQgRE9N QXBwbGljYQogICAgIHJldHVybiBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6RVJST1JfRVZFTlQ7CiB9 CiAKLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5BQkxFKE9GRkxJTkVf V0VCX0FQUExJQ0FUSU9OUykKSW5kZXg6IFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCShyZXZpc2lvbiA0NzMzOCkKKysr IFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MzAsNyArNTMw LDcgQEAgQ29uc29sZSogRE9NV2luZG93Ojpjb25zb2xlKCkgY29uc3QKICNpZiBFTkFCTEUoT0ZG TElORV9XRUJfQVBQTElDQVRJT05TKQogRE9NQXBwbGljYXRpb25DYWNoZSogRE9NV2luZG93Ojph cHBsaWNhdGlvbkNhY2hlKCkgY29uc3QKIHsKLSAgICBpZiAoIW1fYXBwbGljYXRpb25DYWNoZSAm JiBtX2ZyYW1lICYmIG1fZnJhbWUtPnNldHRpbmdzKCkgJiYgbV9mcmFtZS0+c2V0dGluZ3MoKS0+ b2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKCkpCisgICAgaWYgKCFtX2FwcGxpY2F0 aW9uQ2FjaGUpCiAgICAgICAgIG1fYXBwbGljYXRpb25DYWNoZSA9IERPTUFwcGxpY2F0aW9uQ2Fj aGU6OmNyZWF0ZShtX2ZyYW1lKTsKICAgICByZXR1cm4gbV9hcHBsaWNhdGlvbkNhY2hlLmdldCgp OwogfQo= 39035 2009-09-03 20:25:45 -0700 2009-09-07 00:28:29 -0700 cleanup with layout test cleanup2.txt text/plain 6436 michaeln SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODAzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDktMDktMDMgIE1pY2hhZWwgTm9yZG1hbiAgPG1pY2hhZWxuQGdv b2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MzU5CisgICAgICAg IENsZWFudXA6IFVuZG8gc29tZSBhY2NpZGVudGFsIGNoYW5nZXMgYXJvdW5kIERPTUFwcGxpY2F0 aW9uQ2FjaGUuCisgICAgICAgIC0gUmVzdG9yZSBzdXBwb3J0IGZvciBjb25zdHJ1Y3RpbmcgYSBE T01BcHBsaWNhdGlvbkNhY2hlIG9iamVjdCB3aXRoIGEgbnVsbCBmcmFtZSBwdHIuCisgICAgICAg IC0gUmV0dXJuIGEgbm9uLW51bGwgb2JqZWN0IGZvciB3aW5kb3cuYXBwbGljYXRpb25DYWNoZSB3 aGVuIHRoZSBmZWF0dXJlIGlzIGRpc2FibGVkLgorICAgICAgICAtIFNpbXBsaWZ5IHRoZSBzd2Fw Q2FjaGUgbWV0aG9kLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMvYXBwY2FjaGUvZGlzYWJs ZWQuaHRtbAorCisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0RPTUFwcGxpY2F0aW9uQ2FjaGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9NQXBwbGljYXRpb25DYWNoZTo6RE9NQXBwbGljYXRp b25DYWNoZSk6CisgICAgICAgIChXZWJDb3JlOjpET01BcHBsaWNhdGlvbkNhY2hlOjpzd2FwQ2Fj aGUpOgorICAgICAgICAoV2ViQ29yZTo6RE9NQXBwbGljYXRpb25DYWNoZTo6c2NyaXB0RXhlY3V0 aW9uQ29udGV4dCk6CisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0RPTUFwcGxpY2F0aW9uQ2Fj aGUuaDoKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE T01XaW5kb3c6OmFwcGxpY2F0aW9uQ2FjaGUpOgorCiAyMDA5LTA5LTAzICBBbGV4ZXkgUHJvc2t1 cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpJbmRleDogV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvRE9NQXBwbGljYXRpb25DYWNoZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvRE9NQXBwbGljYXRpb25DYWNo ZS5jcHAJKHJldmlzaW9uIDQ4MDM3KQorKysgV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvRE9NQXBw bGljYXRpb25DYWNoZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyLDggKzQyLDEwIEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIERPTUFwcGxpY2F0aW9uQ2FjaGU6OkRPTUFwcGxpY2F0aW9uQ2FjaGUo RnJhbWUqIGZyYW1lKQogICAgIDogbV9mcmFtZShmcmFtZSkKIHsKLSAgICBBU1NFUlQoYXBwbGlj YXRpb25DYWNoZUhvc3QoKSk7Ci0gICAgYXBwbGljYXRpb25DYWNoZUhvc3QoKS0+c2V0RE9NQXBw bGljYXRpb25DYWNoZSh0aGlzKTsKKyAgICBBU1NFUlQoIW1fZnJhbWUgfHwgYXBwbGljYXRpb25D YWNoZUhvc3QoKSk7CisgICAgQXBwbGljYXRpb25DYWNoZUhvc3QqIGNhY2hlSG9zdCA9IGFwcGxp Y2F0aW9uQ2FjaGVIb3N0KCk7CisgICAgaWYgKGNhY2hlSG9zdCkKKyAgICAgICAgY2FjaGVIb3N0 LT5zZXRET01BcHBsaWNhdGlvbkNhY2hlKHRoaXMpOwogfQogCiB2b2lkIERPTUFwcGxpY2F0aW9u Q2FjaGU6OmRpc2Nvbm5lY3RGcmFtZSgpCkBAIC03NiwyMiArNzgsMTYgQEAgdm9pZCBET01BcHBs aWNhdGlvbkNhY2hlOjp1cGRhdGUoRXhjZXB0aQogICAgICAgICBlYyA9IElOVkFMSURfU1RBVEVf RVJSOwogfQogCi1ib29sIERPTUFwcGxpY2F0aW9uQ2FjaGU6OnN3YXBDYWNoZSgpCi17Ci0gICAg QXBwbGljYXRpb25DYWNoZUhvc3QqIGNhY2hlSG9zdCA9IGFwcGxpY2F0aW9uQ2FjaGVIb3N0KCk7 Ci0gICAgaWYgKCFjYWNoZUhvc3QpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4g Y2FjaGVIb3N0LT5zd2FwQ2FjaGUoKTsKLX0KLSAgICAKIHZvaWQgRE9NQXBwbGljYXRpb25DYWNo ZTo6c3dhcENhY2hlKEV4Y2VwdGlvbkNvZGUmIGVjKQogewotICAgIGlmICghc3dhcENhY2hlKCkp CisgICAgQXBwbGljYXRpb25DYWNoZUhvc3QqIGNhY2hlSG9zdCA9IGFwcGxpY2F0aW9uQ2FjaGVI b3N0KCk7CisgICAgaWYgKCFjYWNoZUhvc3QgfHwgIWNhY2hlSG9zdC0+c3dhcENhY2hlKCkpCiAg ICAgICAgIGVjID0gSU5WQUxJRF9TVEFURV9FUlI7CiB9CiAKIFNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQqIERPTUFwcGxpY2F0aW9uQ2FjaGU6OnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBjb25zdAog eworICAgIEFTU0VSVChtX2ZyYW1lKTsKICAgICByZXR1cm4gbV9mcmFtZS0+ZG9jdW1lbnQoKTsK IH0KIApAQCAtMjA5LDcgKzIwNSw2IEBAIEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjpFdmVudElEIERP TUFwcGxpY2EKICAgICByZXR1cm4gQXBwbGljYXRpb25DYWNoZUhvc3Q6OkVSUk9SX0VWRU5UOwog fQogCi0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIEVOQUJMRShPRkZMSU5F X1dFQl9BUFBMSUNBVElPTlMpCkluZGV4OiBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9ET01BcHBs aWNhdGlvbkNhY2hlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvRE9N QXBwbGljYXRpb25DYWNoZS5oCShyZXZpc2lvbiA0ODAzNykKKysrIFdlYkNvcmUvbG9hZGVyL2Fw cGNhY2hlL0RPTUFwcGxpY2F0aW9uQ2FjaGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTE1LDcgKzEx NSw2IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGRlcmVmRXZlbnRUYXJnZXQoKSB7IGRl cmVmKCk7IH0KIAogICAgIEFwcGxpY2F0aW9uQ2FjaGVIb3N0KiBhcHBsaWNhdGlvbkNhY2hlSG9z dCgpIGNvbnN0OwotICAgIGJvb2wgc3dhcENhY2hlKCk7CiAgICAgCiAgICAgUmVmUHRyPEV2ZW50 TGlzdGVuZXI+IG1fYXR0cmlidXRlRXZlbnRMaXN0ZW5lcnNbQXBwbGljYXRpb25DYWNoZUhvc3Q6 Ok9CU09MRVRFX0VWRU5UICsgMV07CiAKSW5kZXg6IFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCShyZXZpc2lvbiA0ODAz NykKKysrIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Mjgs NyArNTI4LDcgQEAgQ29uc29sZSogRE9NV2luZG93Ojpjb25zb2xlKCkgY29uc3QKICNpZiBFTkFC TEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQogRE9NQXBwbGljYXRpb25DYWNoZSogRE9NV2lu ZG93OjphcHBsaWNhdGlvbkNhY2hlKCkgY29uc3QKIHsKLSAgICBpZiAoIW1fYXBwbGljYXRpb25D YWNoZSAmJiBtX2ZyYW1lICYmIG1fZnJhbWUtPnNldHRpbmdzKCkgJiYgbV9mcmFtZS0+c2V0dGlu Z3MoKS0+b2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKCkpCisgICAgaWYgKCFtX2Fw cGxpY2F0aW9uQ2FjaGUpCiAgICAgICAgIG1fYXBwbGljYXRpb25DYWNoZSA9IERPTUFwcGxpY2F0 aW9uQ2FjaGU6OmNyZWF0ZShtX2ZyYW1lKTsKICAgICByZXR1cm4gbV9hcHBsaWNhdGlvbkNhY2hl LmdldCgpOwogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDgwMzcpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wOS0wMyAgTWljaGFl bCBOb3JkbWFuICA8bWljaGFlbG5AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjgzNTkKKyAgICAgICAgVGVzdCB0byBlbnN1cmUgdGhlIHRoZSB3aW5kb3cuYXBw bGljYXRpb25DYWNoZSBhdHRyaWJ1dGUgaXMgZGVmaW5lZCBidXQgbm9uLWZ1bmN0aW9uYWwKKyAg ICAgICAgd2l0aCB0aGUgZmVhdHVyZSBkaXNhYmxlZC4KKworICAgICAgICAqIGh0dHAvdGVzdHMv YXBwY2FjaGUvZGlzYWJsZWQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rl c3RzL2FwcGNhY2hlL2Rpc2FibGVkLmh0bWw6IEFkZGVkLgorCiAyMDA5LTA5LTAzICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9kaXNhYmxlZC1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNo ZS9kaXNhYmxlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2FwcGNhY2hlL2Rpc2FibGVkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSw0IEBACitUZXN0IHRvIGVuc3VyZSB0aGUgdGhlIHdpbmRvdy5hcHBsaWNhdGlvbkNhY2hl IGF0dHJpYnV0ZSBpcyBkZWZpbmVkIGJ1dCBub24tZnVuY3Rpb25hbCB3aXRoIHRoZSBmZWF0dXJl IGRpc2FibGVkLgorCitTVUNDRVNTCisKSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBw Y2FjaGUvZGlzYWJsZWQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L2FwcGNhY2hlL2Rpc2FibGVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2FwcGNhY2hlL2Rpc2FibGVkLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNTEg QEAKKzxodG1sPgorPGJvZHk+Cis8cD5UZXN0IHRvIGVuc3VyZSB0aGUgdGhlIHdpbmRvdy5hcHBs aWNhdGlvbkNhY2hlIGF0dHJpYnV0ZSBpcyBkZWZpbmVkIGJ1dCBub24tZnVuY3Rpb25hbCB3aXRo IHRoZSBmZWF0dXJlIGRpc2FibGVkLjwvcD4KKzxkaXYgaWQ9cmVzdWx0PjwvZGl2PgorPHNjcmlw dD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLm92ZXJyaWRlUHJlZmVyZW5jZSgiV2ViS2l0T2ZmbGluZVdlYkFwcGxp Y2F0aW9uQ2FjaGVFbmFibGVkIiwgZmFsc2UpOworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gbG9nKG1lc3NhZ2UpCisgICAg eworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MICs9 IG1lc3NhZ2UgKyAiPGJyPiI7CisgICAgfQorCisgICAgZnVuY3Rpb24gaXNEZWZpbmVkKCkgewor ICAgICAgICBpZiAod2luZG93LmFwcGxpY2F0aW9uQ2FjaGUpCisgICAgICAgICAgICByZXR1cm4g dHJ1ZTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKwor ICAgIGZ1bmN0aW9uIHN0YXR1c0lzVW5jYWNoZWQoKSB7CisgICAgICAgIHJldHVybiBhcHBsaWNh dGlvbkNhY2hlLnN0YXR1cyA9PSAwOworICAgIH0KKworICAgIGZ1bmN0aW9uIHN3YXBUaHJvd3Mo KSB7CisgICAgICAgIHRyeSB7CisgICAgICAgICAgICBhcHBsaWNhdGlvbkNhY2hlLnN3YXBDYWNo ZSgpOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9IGNhdGNoKGUpIHsKKyAg ICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAgICB9CisgICAgfQorCisgICAgZnVuY3Rpb24g dXBkYXRlVGhyb3dzKCkgeworICAgICAgICB0cnkgeworICAgICAgICAgICAgYXBwbGljYXRpb25D YWNoZS5zd2FwQ2FjaGUoKTsKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfSBj YXRjaChlKSB7CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQorICAgIH0KKwor ICAgIGlmIChpc0RlZmluZWQoKSAmJiBzdGF0dXNJc1VuY2FjaGVkKCkgJiYgc3dhcFRocm93cygp ICYmIHVwZGF0ZVRocm93cygpKQorICAgICAgICBsb2coIlNVQ0NFU1MiKTsKKyAgICBlbHNlCisg ICAgICAgIGxvZygiRkFJTFVSRSIpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==