28358 2009-08-16 10:13:49 -0700 [WML] Cleanup WMLIntrinsicEventHandling code 2009-08-16 10:35:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 20393 1 zimmermann zimmermann staikos oldest_to_newest 140570 0 zimmermann 2009-08-16 10:13:49 -0700 WMLIntrinsicEventHandling code passes around Events by pointers, which are not needed anywhere. 140572 1 34927 zimmermann 2009-08-16 10:15:48 -0700 Created attachment 34927 Initial patch 140575 2 zimmermann 2009-08-16 10:35:47 -0700 Sending WebCore/ChangeLog Sending WebCore/wml/WMLAnchorElement.cpp Sending WebCore/wml/WMLDoElement.cpp Sending WebCore/wml/WMLGoElement.cpp Sending WebCore/wml/WMLGoElement.h Sending WebCore/wml/WMLIntrinsicEventHandler.cpp Sending WebCore/wml/WMLPrevElement.cpp Sending WebCore/wml/WMLPrevElement.h Sending WebCore/wml/WMLRefreshElement.cpp Sending WebCore/wml/WMLRefreshElement.h Sending WebCore/wml/WMLTaskElement.h Transmitting file data ........... Committed revision 47340. http://trac.webkit.org/changeset/47340 34927 2009-08-16 10:15:48 -0700 2009-08-16 10:23:49 -0700 Initial patch bug-28358-20090816191545.patch text/plain 6291 zimmermann SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzMzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjkgQEAKKzIwMDktMDgtMTYgIE5pa29sYXMgWmltbWVybWFubiAgPG5pa29sYXMu emltbWVybWFubkB0b3JjaG1vYmlsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1dNTF0gQ2xlYW51cCBXTUxJbnRyaW5zaWNFdmVudEhhbmRs aW5nIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI4MzU4CisKKyAgICAgICAgUmVtb3ZlIHN1cGVyZmxvdXMgIkV2ZW50KiBldnQiIHBhcmFtZXRl ciBmcm9tIGV4ZWN1dGVUYXNrKCkgbWV0aG9kcy4gSXQncyBhIGxlZnRvdmVyIGZyb20gdGhlIGlu aXRpYWwgV01MIG1lcmdlLgorCisgICAgICAgICogd21sL1dNTEFuY2hvckVsZW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6V01MQW5jaG9yRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6 CisgICAgICAgICogd21sL1dNTERvRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXTUxE b0VsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorICAgICAgICAqIHdtbC9XTUxHb0VsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V01MR29FbGVtZW50OjpleGVjdXRlVGFzayk6Cisg ICAgICAgICogd21sL1dNTEdvRWxlbWVudC5oOgorICAgICAgICAqIHdtbC9XTUxJbnRyaW5zaWNF dmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V01MSW50cmluc2ljRXZlbnRIYW5k bGVyOjp0cmlnZ2VySW50cmluc2ljRXZlbnQpOgorICAgICAgICAqIHdtbC9XTUxQcmV2RWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXTUxQcmV2RWxlbWVudDo6ZXhlY3V0ZVRhc2spOgor ICAgICAgICAqIHdtbC9XTUxQcmV2RWxlbWVudC5oOgorICAgICAgICAqIHdtbC9XTUxSZWZyZXNo RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXTUxSZWZyZXNoRWxlbWVudDo6ZXhlY3V0 ZVRhc2spOgorICAgICAgICAqIHdtbC9XTUxSZWZyZXNoRWxlbWVudC5oOgorICAgICAgICAqIHdt bC9XTUxUYXNrRWxlbWVudC5oOgorCiAyMDA5LTA4LTE2ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRt YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4K SW5kZXg6IFdlYkNvcmUvd21sL1dNTEFuY2hvckVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvd21sL1dNTEFuY2hvckVsZW1lbnQuY3BwCShyZXZpc2lvbiA0NzMzMikKKysrIFdlYkNv cmUvd21sL1dNTEFuY2hvckVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NCw3ICs1NCw3 IEBAIHZvaWQgV01MQW5jaG9yRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGwKICAgICAgICAgc2hv dWxkSGFuZGxlID0gc3RhdGljX2Nhc3Q8S2V5Ym9hcmRFdmVudCo+KGV2ZW50KS0+a2V5SWRlbnRp ZmllcigpID09ICJFbnRlciI7CiAKICAgICBpZiAoc2hvdWxkSGFuZGxlICYmIG1fdGFzaykgewot ICAgICAgICBtX3Rhc2stPmV4ZWN1dGVUYXNrKGV2ZW50KTsKKyAgICAgICAgbV90YXNrLT5leGVj dXRlVGFzaygpOwogICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRsZWQoKTsKICAgICAgICAg cmV0dXJuOwogICAgIH0KSW5kZXg6IFdlYkNvcmUvd21sL1dNTERvRWxlbWVudC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS93bWwvV01MRG9FbGVtZW50LmNwcAkocmV2aXNpb24gNDczMzIpCisr KyBXZWJDb3JlL3dtbC9XTUxEb0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MCw3ICs3 MCw3IEBAIHZvaWQgV01MRG9FbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEUKIAogICAgIGlm IChtX3R5cGUgPT0gImFjY2VwdCIgfHwgbV90eXBlID09ICJvcHRpb25zIikgewogICAgICAgICBp ZiAobV90YXNrKQotICAgICAgICAgICAgbV90YXNrLT5leGVjdXRlVGFzayhldmVudCk7CisgICAg ICAgICAgICBtX3Rhc2stPmV4ZWN1dGVUYXNrKCk7CiAgICAgfSBlbHNlIGlmIChtX3R5cGUgPT0g InByZXYiKSB7CiAgICAgICAgIEFTU0VSVChkb2N1bWVudCgpLT5pc1dNTERvY3VtZW50KCkpOwog ICAgICAgICBXTUxEb2N1bWVudCogZG9jdW1lbnQgPSBzdGF0aWNfY2FzdDxXTUxEb2N1bWVudCo+ KHRoaXMtPmRvY3VtZW50KCkpOwpJbmRleDogV2ViQ29yZS93bWwvV01MR29FbGVtZW50LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxHb0VsZW1lbnQuY3BwCShyZXZpc2lvbiA0NzMz MikKKysrIFdlYkNvcmUvd21sL1dNTEdvRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcz LDcgKzczLDcgQEAgdm9pZCBXTUxHb0VsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKAogICAg ICAgICBXTUxUYXNrRWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1dGUoYXR0cik7CiB9CiAKLXZv aWQgV01MR29FbGVtZW50OjpleGVjdXRlVGFzayhFdmVudCopCit2b2lkIFdNTEdvRWxlbWVudDo6 ZXhlY3V0ZVRhc2soKQogewogICAgIEFTU0VSVChkb2N1bWVudCgpLT5pc1dNTERvY3VtZW50KCkp OwogICAgIFdNTERvY3VtZW50KiBkb2N1bWVudCA9IHN0YXRpY19jYXN0PFdNTERvY3VtZW50Kj4o dGhpcy0+ZG9jdW1lbnQoKSk7CkluZGV4OiBXZWJDb3JlL3dtbC9XTUxHb0VsZW1lbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxHb0VsZW1lbnQuaAkocmV2aXNpb24gNDczMzIpCisr KyBXZWJDb3JlL3dtbC9XTUxHb0VsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzksNyArMzks NyBAQCBwdWJsaWM6CiAgICAgdm9pZCBkZXJlZ2lzdGVyUG9zdGZpZWxkRWxlbWVudChXTUxQb3N0 ZmllbGRFbGVtZW50Kik7CiAKICAgICB2aXJ0dWFsIHZvaWQgcGFyc2VNYXBwZWRBdHRyaWJ1dGUo TWFwcGVkQXR0cmlidXRlKik7Ci0gICAgdmlydHVhbCB2b2lkIGV4ZWN1dGVUYXNrKEV2ZW50Kik7 CisgICAgdmlydHVhbCB2b2lkIGV4ZWN1dGVUYXNrKCk7CiAKIHByaXZhdGU6CiAgICAgdm9pZCBw cmVwYXJlUE9TVFJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0JiwgYm9vbCBpblNhbWVEZWNrLCBjb25z dCBTdHJpbmcmIGNhY2hlQ29udHJvbCk7CkluZGV4OiBXZWJDb3JlL3dtbC9XTUxJbnRyaW5zaWNF dmVudEhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dNTEludHJpbnNpY0V2 ZW50SGFuZGxlci5jcHAJKHJldmlzaW9uIDQ3MzMyKQorKysgV2ViQ29yZS93bWwvV01MSW50cmlu c2ljRXZlbnRIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDgsNyArNDgsNyBAQCB2b2lk IFdNTEludHJpbnNpY0V2ZW50SGFuZGxlcjo6dHJpZ2dlckluCiB7CiAgICAgUmVmUHRyPFdNTElu dHJpbnNpY0V2ZW50PiBldmVudCA9IG1fZXZlbnRzLmdldCh0eXBlKTsKICAgICBBU1NFUlQoZXZl bnQtPnRhc2tFbGVtZW50KCkpOwotICAgIGV2ZW50LT50YXNrRWxlbWVudCgpLT5leGVjdXRlVGFz aygwKTsKKyAgICBldmVudC0+dGFza0VsZW1lbnQoKS0+ZXhlY3V0ZVRhc2soKTsKIH0KIAogYm9v bCBXTUxJbnRyaW5zaWNFdmVudEhhbmRsZXI6Omhhc0ludHJpbnNpY0V2ZW50KFdNTEludHJpbnNp Y0V2ZW50VHlwZSB0eXBlKSBjb25zdApJbmRleDogV2ViQ29yZS93bWwvV01MUHJldkVsZW1lbnQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dNTFByZXZFbGVtZW50LmNwcAkocmV2aXNp b24gNDczMzIpCisrKyBXZWJDb3JlL3dtbC9XTUxQcmV2RWxlbWVudC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQwLDcgKzQwLDcgQEAgV01MUHJldkVsZW1lbnQ6On5XTUxQcmV2RWxlbWVudCgpCiB7 CiB9CiAKLXZvaWQgV01MUHJldkVsZW1lbnQ6OmV4ZWN1dGVUYXNrKEV2ZW50KikKK3ZvaWQgV01M UHJldkVsZW1lbnQ6OmV4ZWN1dGVUYXNrKCkKIHsKICAgICBBU1NFUlQoZG9jdW1lbnQoKS0+aXNX TUxEb2N1bWVudCgpKTsKICAgICBXTUxEb2N1bWVudCogZG9jdW1lbnQgPSBzdGF0aWNfY2FzdDxX TUxEb2N1bWVudCo+KHRoaXMtPmRvY3VtZW50KCkpOwpJbmRleDogV2ViQ29yZS93bWwvV01MUHJl dkVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxQcmV2RWxlbWVudC5oCShy ZXZpc2lvbiA0NzMzMikKKysrIFdlYkNvcmUvd21sL1dNTFByZXZFbGVtZW50LmgJKHdvcmtpbmcg Y29weSkKQEAgLTMxLDcgKzMxLDcgQEAgcHVibGljOgogICAgIFdNTFByZXZFbGVtZW50KGNvbnN0 IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50Kik7CiAgICAgdmlydHVhbCB+V01MUHJl dkVsZW1lbnQoKTsKIAotICAgIHZpcnR1YWwgdm9pZCBleGVjdXRlVGFzayhFdmVudCopOworICAg IHZpcnR1YWwgdm9pZCBleGVjdXRlVGFzaygpOwogfTsKIAogfQpJbmRleDogV2ViQ29yZS93bWwv V01MUmVmcmVzaEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dNTFJlZnJl c2hFbGVtZW50LmNwcAkocmV2aXNpb24gNDczMzIpCisrKyBXZWJDb3JlL3dtbC9XTUxSZWZyZXNo RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxLDcgKzQxLDcgQEAgV01MUmVmcmVzaEVs ZW1lbnQ6On5XTUxSZWZyZXNoRWxlbWVudCgpCiB7CiB9CiAKLXZvaWQgV01MUmVmcmVzaEVsZW1l bnQ6OmV4ZWN1dGVUYXNrKEV2ZW50KikKK3ZvaWQgV01MUmVmcmVzaEVsZW1lbnQ6OmV4ZWN1dGVU YXNrKCkKIHsKICAgICBBU1NFUlQoZG9jdW1lbnQoKS0+aXNXTUxEb2N1bWVudCgpKTsKICAgICBX TUxEb2N1bWVudCogZG9jdW1lbnQgPSBzdGF0aWNfY2FzdDxXTUxEb2N1bWVudCo+KHRoaXMtPmRv Y3VtZW50KCkpOwpJbmRleDogV2ViQ29yZS93bWwvV01MUmVmcmVzaEVsZW1lbnQuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxSZWZyZXNoRWxlbWVudC5oCShyZXZpc2lvbiA0NzMzMikK KysrIFdlYkNvcmUvd21sL1dNTFJlZnJlc2hFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTMx LDcgKzMxLDcgQEAgcHVibGljOgogICAgIFdNTFJlZnJlc2hFbGVtZW50KGNvbnN0IFF1YWxpZmll ZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50Kik7CiAgICAgdmlydHVhbCB+V01MUmVmcmVzaEVsZW1l bnQoKTsKIAotICAgIHZpcnR1YWwgdm9pZCBleGVjdXRlVGFzayhFdmVudCopOworICAgIHZpcnR1 YWwgdm9pZCBleGVjdXRlVGFzaygpOwogfTsKIAogfQpJbmRleDogV2ViQ29yZS93bWwvV01MVGFz a0VsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxUYXNrRWxlbWVudC5oCShy ZXZpc2lvbiA0NzMzMikKKysrIFdlYkNvcmUvd21sL1dNTFRhc2tFbGVtZW50LmgJKHdvcmtpbmcg Y29weSkKQEAgLTQwLDcgKzQwLDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB2b2lkIGluc2Vy dGVkSW50b0RvY3VtZW50KCk7CiAgICAgdmlydHVhbCB2b2lkIHJlbW92ZWRGcm9tRG9jdW1lbnQo KTsKLSAgICB2aXJ0dWFsIHZvaWQgZXhlY3V0ZVRhc2soRXZlbnQqKSA9IDA7CisgICAgdmlydHVh bCB2b2lkIGV4ZWN1dGVUYXNrKCkgPSAwOwogCiAgICAgdm9pZCByZWdpc3RlclZhcmlhYmxlU2V0 dGVyKFdNTFNldHZhckVsZW1lbnQqKTsKICAgICB2b2lkIGRlcmVnaXN0ZXJWYXJpYWJsZVNldHRl cihXTUxTZXR2YXJFbGVtZW50Kik7