283576 2024-11-22 10:07:00 -0800 REGRESSION: WebGL shader linking error with Metal backend when mixing scalar with vector 2024-12-11 13:14:32 -0800 1 1 1 Unclassified WebKit WebGL Safari 18 Mac (Apple Silicon) macOS 15 RESOLVED FIXED BrowserCompat, InRadar P2 Normal --- 1 edmund tzagallo benzakhar.manashirov djg karlcow kbr kkinnunen webkit-bug-importer oldest_to_newest 2077066 0 473341 edmund 2024-11-22 10:07:00 -0800 Created attachment 473341 A webpage that reproduces the issue When subtracting a vector from a scalar in a GLSL shader, the Metal backend throws the following error during the linking stage: WebGL: INVALID_OPERATION: Error: 0x00000502, in /AppleInternal/Library/BuildRoots/f00160a0-8d47-11ef-b394-4a83e32a47e1/Library/Caches/com.apple.xbs/Sources/ANGLE/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramExecutableMtl.mm, CreateMslShaderLib:381. Internal error compiling shader with Metal backend. program_source:36:12: error: as_type cast from vector 'metal::make_unsigned_t<int __attribute__((ext_vector_type(4)))>' (aka 'metal::_make_unsigned_impl<int __attribute__((ext_vector_type(4)))>::type') to scalar 'int' of different size return as_type<X>(as_type<metal::make_unsigned_t<X>>(x) - as_type<metal::make_unsigned_t<Y>>(y)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ program_source:128:24: note: in instantiation of function template specialization 'ANGLE_isub<int, int __attribute__((ext_vector_type(4)))>' requested here metal::int4 _uorig = ANGLE_isub(1, _usource); This error was triggered by the following GLSL code: ivec4 source = ivec4(0); ivec4 orig = 1 - source; In GLSL, it is allowed for addition/subtraction to apply between a scalar and a vector. However, it seems that when it converts the GLSL code into Metal, it doesn't automatically convert the scalar into a vector which causes the above error in Metal. This error is reproducible on Safari 18.1 on both iOS and macOS, and did not happen in older versions of Safari (such as Safari 17.x). However, it's unclear which version of Safari this issue was first introduced. The issue also doesn't happen on other browsers (such as Chrome). Please see the attachment for an HTML file that reproduces the error. To reproduce: 1. Open the HTML file in Safari 18.1 on macOS or iOS 2. Open the developer console to see the shader compilation result. It should trigger the above error. 2077566 1 webkit-bug-importer 2024-11-25 10:06:08 -0800 <rdar://problem/140546518> 2077710 2 kkinnunen 2024-11-26 04:20:10 -0800 Thanks for the report, I can reproduce the issue. Until we ship a fix, you should be able to workaround the issue by using "ivec4(1) - source" 2080346 3 tzagallo 2024-12-09 15:33:13 -0800 Pull request: https://github.com/WebKit/WebKit/pull/37668 2080422 4 ews-feeder 2024-12-09 22:25:22 -0800 Committed 287588@main (11b5279aec61): <https://commits.webkit.org/287588@main> Reviewed commits have been landed. Closing PR #37668 and removing active labels. 2080929 5 ews-feeder 2024-12-11 13:14:32 -0800 Committed 283286.583@safari-7620-branch (f936712e6292): <https://commits.webkit.org/283286.583@safari-7620-branch> Reviewed commits have been landed. Closing PR #2399 and removing active labels. 473341 2024-11-22 10:07:00 -0800 2024-11-22 10:07:00 -0800 A webpage that reproduces the issue test2.html text/html 1756 edmund PGh0bWw+CjxoZWFkPgo8c2NyaXB0IHR5cGU9Ingtc2hhZGVyL3gtdmVydGV4IiBpZD0idmVydGV4 LXNoYWRlciI+I3ZlcnNpb24gMzAwIGVzCnByZWNpc2lvbiBoaWdocCBmbG9hdDsKdm9pZCBtYWlu KCkgewogIGdsX1Bvc2l0aW9uID0gdmVjNCgwLjApOwp9Cjwvc2NyaXB0Pgo8c2NyaXB0IHR5cGU9 Ingtc2hhZGVyL3gtZnJhZ21lbnQiIGlkPSJmcmFnbWVudC1zaGFkZXIiPiN2ZXJzaW9uIDMwMCBl cwogICAgcHJlY2lzaW9uIGhpZ2hwIGZsb2F0OwogICAgcHJlY2lzaW9uIGhpZ2hwIGludDsKCiAg ICB2b2lkIG1haW4oKSB7ICAgICAgICAgICAgICAKICAgICAgaXZlYzQgc291cmNlID0gaXZlYzQo MCk7CiAgICAgIGl2ZWM0IG9yaWcgPSAxIC0gc291cmNlOwoKICAgICAgLy8gSnVzdCBzbyB0aGUg cmVzdWx0IG9mIG9yaWcgaXMgdXNlZAogICAgICBzb3VyY2UgPSBvcmlnICogc291cmNlOwogICAg fQo8L3NjcmlwdD4KPHNjcmlwdD4KY29uc3QgY2FudmFzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgnY2FudmFzJyk7CmNvbnN0IGdsID0gY2FudmFzLmdldENvbnRleHQoJ3dlYmdsMicpOwoKbGV0 IHNvdXJjZSA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoIiN2ZXJ0ZXgtc2hhZGVyIikuaW5uZXJI VE1MOwpjb25zdCB2ZXJ0ZXhTaGFkZXIgPSBnbC5jcmVhdGVTaGFkZXIoZ2wuVkVSVEVYX1NIQURF Uik7CmdsLnNoYWRlclNvdXJjZSh2ZXJ0ZXhTaGFkZXIsIHNvdXJjZSk7CmdsLmNvbXBpbGVTaGFk ZXIodmVydGV4U2hhZGVyKTsKCmNvbnNvbGUubG9nKCdTaGFkZXIgY29tcGlsZWQgc3VjY2Vzc2Z1 bGx5OiAnICsgZ2wuZ2V0U2hhZGVyUGFyYW1ldGVyKHZlcnRleFNoYWRlciwgZ2wuQ09NUElMRV9T VEFUVVMpKTsKY29uc29sZS5sb2coJ1NoYWRlciBjb21waWxlciBsb2c6ICcgKyBnbC5nZXRTaGFk ZXJJbmZvTG9nKHZlcnRleFNoYWRlcikpOwoKc291cmNlID0gZG9jdW1lbnQucXVlcnlTZWxlY3Rv cigiI2ZyYWdtZW50LXNoYWRlciIpLmlubmVySFRNTDsKY29uc3QgZnJhZ21lbnRTaGFkZXIgPSBn bC5jcmVhdGVTaGFkZXIoZ2wuRlJBR01FTlRfU0hBREVSKTsKZ2wuc2hhZGVyU291cmNlKGZyYWdt ZW50U2hhZGVyLCBzb3VyY2UpOwpnbC5jb21waWxlU2hhZGVyKGZyYWdtZW50U2hhZGVyKTsKCmNv bnNvbGUubG9nKCdTaGFkZXIgY29tcGlsZWQgc3VjY2Vzc2Z1bGx5OiAnICsgZ2wuZ2V0U2hhZGVy UGFyYW1ldGVyKGZyYWdtZW50U2hhZGVyLCBnbC5DT01QSUxFX1NUQVRVUykpOwpjb25zb2xlLmxv ZygnU2hhZGVyIGNvbXBpbGVyIGxvZzogJyArIGdsLmdldFNoYWRlckluZm9Mb2coZnJhZ21lbnRT aGFkZXIpKTsKCmNvbnN0IHByb2dyYW0gPSBnbC5jcmVhdGVQcm9ncmFtKCk7CmdsLmF0dGFjaFNo YWRlcihwcm9ncmFtLCB2ZXJ0ZXhTaGFkZXIpOwpnbC5hdHRhY2hTaGFkZXIocHJvZ3JhbSwgZnJh Z21lbnRTaGFkZXIpOwpnbC5saW5rUHJvZ3JhbShwcm9ncmFtKTsKCmlmICghZ2wuZ2V0UHJvZ3Jh bVBhcmFtZXRlcihwcm9ncmFtLCBnbC5MSU5LX1NUQVRVUykpIHsKICAgIGNvbnN0IGxpbmtFcnJM b2cgPSBnbC5nZXRQcm9ncmFtSW5mb0xvZyhwcm9ncmFtKTsKICAgIGNvbnNvbGUubG9nKGBTaGFk ZXIgcHJvZ3JhbSBkaWQgbm90IGxpbmsgc3VjY2Vzc2Z1bGx5LiBFcnJvciBsb2c6ICR7bGlua0Vy ckxvZ31gKTsKfQplbHNlIHsKICAgIGNvbnNvbGUubG9nKCdMaW5raW5nIHdhcyBzdWNjZXNzZnVs Jyk7Cn0KPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CjwvYm9keT4KPC9odG1sPg==