283507 2024-11-21 11:32:50 -0800 Pack CSS::PrimitiveNumeric 2024-11-22 12:50:15 -0800 1 1 1 Unclassified WebKit New Bugs Safari 18 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam webkit-bug-importer oldest_to_newest 2076761 0 sam 2024-11-21 11:32:50 -0800 Pack CSS::PrimitiveNumeric by replacing std::variant with a union, and using the CSSUnitType to determine the correct alternative. An alternative we may want to explore in the future when we no longer have the old CSSValue system around is creating a type per unit (e.g. Px { double value; }; Em { double value; }; ...) and using a std::variant with them, but since we still need to utilize CSSUnitTypes for the moment, that would be less efficient. 2076770 1 sam 2024-11-21 11:56:21 -0800 Pull request: https://github.com/WebKit/WebKit/pull/36966 2077111 2 ews-feeder 2024-11-22 12:49:49 -0800 Committed 286978@main (2ba07c2f90a7): <https://commits.webkit.org/286978@main> Reviewed commits have been landed. Closing PR #36966 and removing active labels. 2077112 3 webkit-bug-importer 2024-11-22 12:50:15 -0800 <rdar://problem/140435621>