283450 2024-11-20 17:12:44 -0800 [WebDriver] Debug assertion in willDestroyGlobalObjectInCachedFrame in both selenium and W3C back tests 2025-04-08 13:27:24 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lmoura lmoura bburg bugs-noreply webkit-bug-importer oldest_to_newest 2076555 0 lmoura 2024-11-20 17:12:44 -0800 Running tests that go back and forth in history in a Debug build (after disabling the assertion from bug276266), an assertion is triggered when a CachedPage gets deleted from the BackForwardCache. This happens both for selenium and W3c tests: imported/w3c/webdriver/tests/classic/back/back.py imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py The minimal set of test cases I managed to get to trigger the issue was running the following in the same run: imported/w3c/webdriver/tests/classic/back/back.py::test_no_browsing_context imported/w3c/webdriver/tests/classic/back/back.py::test_no_browsing_history imported/w3c/webdriver/tests/classic/back/back.py::test_data_urls imported/w3c/webdriver/tests/classic/back/back.py::test_dismissed_beforeunload Strangely, these tests pass, so looks like it could be something in the teardown of the WebProcess, after the individual tests returns. This should also explain why the assertion is triggered when another test (test_seen_nodes) from `back.py` fails and triggers the assertion _running alongside these_, but not when running in isolation. Command line: ./Tools/Scripts/run-webdriver-tests --debug --wpe --display-server=headless --verbose "imported/w3c/webdriver/tests/classic/back/back.py::test_no_browsing_context" "imported/w3c/webdriver/tests/classic/back/back.py::test_no_browsing_history" "imported/w3c/webdriver/tests/classic/back/back.py::test_data_urls" "imported/w3c/webdriver/tests/classic/back/back.py::test_dismissed_beforeunload" Trace: (gdb) bt [0/96660] #0 0x00007b8168ca1e69 in WTFCrash () at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WTF/wtf/Assertions.cpp:365 #1 0x00007b816465d32b in WTFCrashWithInfo () at WTF/Headers/wtf/Assertions.h:913 #2 0x00007b8165f5155c in WebKit::WebAutomationDOMWindowObserver::willDestroyGlobalObjectInCachedFrame (this=0x7b814a892e80) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebKit/WebProcess/Automation/WebAutomationDOMWindowObserver.cpp:53 #3 0x00007b816d47825a in WebCore::LocalDOMWindow::willDestroyCachedFrame()::$_0::operator()<WebCore::LocalDOMWindowObserver>(WebCore::LocalDOMWindowObserver&) const (this=0x7b814a2424f8, observer=...) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/page/LocalDOMWindow.cpp:512 #4 0x00007b816d4781f1 in WTF::Detail::CallableWrapper<WebCore::LocalDOMWindow::willDestroyCachedFrame()::$_0, void, WebCore::LocalDOMWindowObserver&>::call(WebCore::LocalDOMWindowObserver&) (this=0x7b814a2424f0, in=...) at WTF/Headers/wtf/Function.h:53 #5 0x00007b816d4772cf in WTF::Function<void (WebCore::LocalDOMWindowObserver&)>::operator()(WebCore::LocalDOMWindowObserver&) const (this=0x7ffcdb2db830, in=...) at WTF/Headers/wtf/Function.h:82 #6 0x00007b816d4508e2 in WTF::WeakHashSet<WebCore::LocalDOMWindowObserver, WTF::DefaultWeakPtrImpl, (WTF::EnableWeakPtrThreadingAssertions)1>::forEach(WTF::Function<void (WebCore::LocalDOMWindowObserver&)> const&) (this=0x7b814a6e8308, callback=...) at WTF/Headers/wtf/WeakHashSet.h:191 #7 0x00007b816d450404 in WebCore::LocalDOMWindow::willDestroyCachedFrame (this=0x7b814a6e8280) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/page/LocalDOMWindow.cpp:511 #8 0x00007b816cab5340 in WebCore::CachedFrame::destroy (this=0x7b814a66d780) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/history/CachedFrame.cpp:289 #9 0x00007b816cab5462 in WebCore::CachedFrame::destroy (this=0x7b814a66d600) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/history/CachedFrame.cpp:299 #10 0x00007b816cab5baf in WebCore::CachedPage::~CachedPage (this=0x7b814a81fa60) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/history/CachedPage.cpp:85 #11 0x00007b816656567d in WebCore::CachedPage::operator delete (object=0x7b814a81fa60, size=72) at WebCore/PrivateHeaders/WebCore/CachedPage.h:42 #12 0x00007b81665654e0 in std::default_delete<WebCore::CachedPage>::operator() (this=0x7b814a444e00, __ptr=0x7b814a81fa60) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:93 #13 0x00007b81665335a3 in std::unique_ptr<WebCore::CachedPage, std::default_delete<WebCore::CachedPage> >::~unique_ptr (this=0x7b814a444e00) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:398 #14 0x00007b816cab0a75 in WTF::UniqueRef<WebCore::CachedPage>::~UniqueRef (this=0x7b814a444e00) at WTF/Headers/wtf/UniqueRef.h:65 #15 0x00007b816cabbf25 in std::destroy_at<WTF::UniqueRef<WebCore::CachedPage> > (__location=0x7b814a444e00) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:88 #16 0x00007b816cabbf05 in std::_Destroy<WTF::UniqueRef<WebCore::CachedPage> > (__pointer=0x7b814a444e00) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:149 #17 0x00007b816cabbee9 in std::__detail::__variant::_Variant_storage<false, WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::_M_reset()::{lambda(auto:1&&)#1}::operator()<WTF::UniqueRef<WebCore::CachedPage>&>(WTF::UniqueRef<WebCore::CachedPage>&) (this=0x7ffcdb2dbb57, __this_mem=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/variant:498 #18 0x00007b816cabbebd in std::__invoke_impl<void, std::__detail::__variant::_Variant_storage<false, WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::_M_reset()::{lambda(auto:1&&)#1}, WTF::UniqueRef<WebCore::CachedPage>&>(std::__invoke_other, std::__detail::__variant::_Variant_storage<false, We bCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::_M_reset()::{lambda(auto:1&&)#1}&&, WTF::UniqueRef<WebCore::CachedPage>&) (__f=..., __args=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:61 #19 0x00007b816cabbe8d in std::__invoke_r<void, std::__detail::__variant::_Variant_storage<false, WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::_M_reset()::{lambda(auto:1&&)#1}, WTF::UniqueRef<WebCore::CachedPage>&>(std::__detail::__variant::_Variant_storage<false, WebCore::PruningReason, WT F::UniqueRef<WebCore::CachedPage> >::_M_reset()::{lambda(auto:1&&)#1}&&, WTF::UniqueRef<WebCore::CachedPage>&) (__fn=..., __args=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:111 #20 0x00007b816cabbdad in std::__detail::__variant::__gen_vtable_impl<std::__detail::__variant::_Multi_array<void (*)(std::__detail::__variant::_Variant_storage<false, WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::_M_reset()::{lambda(auto:1&&)#1}&&, std::variant<WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >&)>, std::integer_sequence<unsigned long, 1ul> >::__visit_invoke(std::__detail::__variant::_Variant_storage<false, WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::_M_reset()::{lambda(auto:1&&)#1}&&, std::variant<WebCore::PruningReason, WTF::UniqueRef<WebCore::Ca chedPage> >&) (__visitor=..., __vars=std::variant [index 1] = {...}) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/variant:1064 #21 0x00007b816cabbcf6 in std::__do_visit<void, std::__detail::__variant::_Variant_storage<false, WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::_M_reset()::{lambda(auto:1&&)#1}, std::variant<WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >&>(std::__detail::__variant::_Variant_storage<false, WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::_M_reset()::{lambda(auto:1&&)#1}&&, std::variant<WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >&) (__visitor=..., __variants=std::variant [index 1] = {...}) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/variant:1820 #22 0x00007b816cabbc6b in std::__detail::__variant::_Variant_storage<false, WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::_M_reset (this=0x7b814a444e00) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/variant:496 #23 0x00007b816cac61b9 in std::__detail::__variant::__emplace<0ul, false, WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage>, WebCore::PruningReason&> (__v=..., __args=@0x7ffcdb2dbd54: WebCore::PruningReason::ReachedMaxSize) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/variant:565 #24 0x00007b816cac6191 in std::variant<WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::emplace<0ul, WebCore::PruningReason&> (this=0x7b814a444e00, __args=@0x7ffcdb2dbd54: WebCore::PruningReason::ReachedMaxSize) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/variant:1552 #25 0x00007b816cac5bd8 in std::variant<WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >::operator=<WebCore::PruningReason&> (this=0x7b814a444e00, __rhs=@0x7ffcdb2dbd54: WebCore::PruningReason::ReachedMaxSize) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/variant:1510 #26 0x00007b816cac5ae7 in WTF::HashMap<WebCore::ProcessQualified<WTF::ObjectIdentifierGeneric<WebCore::BackForwardItemIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long>, unsigned long> >, std::variant<WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >, WTF::DefaultHash<WebC ore::ProcessQualified<WTF::ObjectIdentifierGeneric<WebCore::BackForwardItemIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long>, unsigned long> > >, WTF::HashTraits<WebCore::ProcessQualified<WTF::ObjectIdentifierGeneric<WebCore::BackForwardItemIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long>, unsigned long> > >, WTF::HashTraits<std::variant<WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> > >, WTF::HashTableTraits, (WTF::ShouldValidateKey)1>::inlineSet<WebCore::ProcessQualified<WTF::ObjectIdentifierGeneric<WebCore::BackForwardItemIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long>, unsigned long> > const&, WebCore::PruningReason&> (this=0x7b8170598110 <WebCore::BackForwardCache::singleton()::globalBackForwardCache>, key=..., value=@0x7ffcdb2dbd54: WebCore::PruningReason::ReachedMaxSize) at WTF/Headers/wtf/HashMap.h:420 #27 0x00007b816cab1dd0 in WTF::HashMap<WebCore::ProcessQualified<WTF::ObjectIdentifierGeneric<WebCore::BackForwardItemIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long>, unsigned long> >, std::variant<WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> >, WTF::DefaultHash<WebC ore::ProcessQualified<WTF::ObjectIdentifierGeneric<WebCore::BackForwardItemIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long>, unsigned long> > >, WTF::HashTraits<WebCore::ProcessQualified<WTF::ObjectIdentifierGeneric<WebCore::BackForwardItemIdentifierType, WTF::ObjectIdentifierMainTh --Type <RET> for more, q to quit, c to continue without paging--bt readAccessTraits<unsigned long>, unsigned long> > >, WTF::HashTraits<std::variant<WebCore::PruningReason, WTF::UniqueRef<WebCore::CachedPage> > >, WTF::HashTableTraits, (WTF::ShouldValidateKey)1>::set<WebCore::PruningReason&> (this=0x7b8170598110 <WebCore::BackForwardCache::singleton()::globalBackForwardCache>, key=..., mapped=@0x7ffcdb2dbd54: WebCore::PruningReason::ReachedMaxSize) at WTF/Headers/wtf/HashMap.h:443 #28 0x00007b816caaf522 in WebCore::BackForwardCache::prune (this=0x7b8170598110 <WebCore::BackForwardCache::singleton()::globalBackForwardCache>, pruningReason=WebCore::PruningReason::ReachedMaxSize) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/history/BackForwardCache.cpp:641 #29 0x00007b816cab081f in WebCore::BackForwardCache::addIfCacheable (this=0x7b8170598110 <WebCore::BackForwardCache::singleton()::globalBackForwardCache>, item=..., page=0x7b814a0bc100) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/history/BackForwardCache.cpp:536 #30 0x00007b816d2194e0 in WebCore::FrameLoader::commitProvisionalLoad (this=0x7b814a065000) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/loader/FrameLoader.cpp:2326 #31 0x00007b816d1b1ecf in WebCore::DocumentLoader::commitIfReady (this=0x7b80fa1bc000) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/loader/DocumentLoader.cpp:424 #32 0x00007b816d1bb6e3 in WebCore::DocumentLoader::commitLoad (this=0x7b80fa1bc000, data=...) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/loader/DocumentLoader.cpp:1219 #33 0x00007b816d1bd4cd in WebCore::DocumentLoader::dataReceived (this=0x7b80fa1bc000, buffer=...) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/loader/DocumentLoader.cpp:1399 #34 0x00007b816d1bd232 in WebCore::DocumentLoader::dataReceived (this=0x7b80fa1bc000, resource=..., buffer=...) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/loader/DocumentLoader.cpp:1374 #35 0x00007b816d320b57 in WebCore::CachedRawResource::notifyClientsDataWasReceived (this=0x7b814a3ac8e0, buffer=...) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/loader/cache/CachedRawResource.cpp:144 #36 0x00007b816d320926 in WebCore::CachedRawResource::updateBuffer (this=0x7b814a3ac8e0, data=...) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/loader/cache/CachedRawResource.cpp:80 #37 0x00007b816d2a9ffa in WebCore::SubresourceLoader::didReceiveBuffer (this=0x7b814a497360, buffer=..., encodedDataLength=512, dataPayloadType=WebCore::DataPayloadBytes) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/loader/SubresourceLoader.cpp:577 #38 0x00007b816d2900cf in WebCore::ResourceLoader::didReceiveData (this=0x7b814a497360, buffer=..., encodedDataLength=512, dataPayloadType=WebCore::DataPayloadBytes) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebCore/loader/ResourceLoader.cpp:614 #39 0x00007b8166319dc6 in WebKit::WebResourceLoader::didReceiveData (this=0x7b814a51e000, data=..., encodedDataLength=512) at /home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:235 <snip> 2109499 1 lmoura 2025-04-07 12:38:41 -0700 Pull request: https://github.com/WebKit/WebKit/pull/43758 2109779 2 ews-feeder 2025-04-08 13:26:58 -0700 Committed 293431@main (aa0b90378a55): <https://commits.webkit.org/293431@main> Reviewed commits have been landed. Closing PR #43758 and removing active labels. 2109780 3 webkit-bug-importer 2025-04-08 13:27:24 -0700 <rdar://problem/148853084>