28336 2009-08-14 22:30:19 -0700 Can no longer --reset-results of a layout test directory 2009-08-17 17:49:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hyatt webkit-unassigned eric mrowe oldest_to_newest 140424 0 hyatt 2009-08-14 22:30:19 -0700 I get error spew when I try to reset results of a directory.... commenting out lines 997-1002 in run-webkit-tests fixes the issue. 140427 1 mrowe 2009-08-14 22:40:52 -0700 Seems like this could happen if the first test that is run happens to fail? 140431 2 eric 2009-08-14 23:03:37 -0700 I'll investigate on Monday. Away for the weekend. You're welcome to roll out the change if needed. 140829 3 34990 eric 2009-08-17 14:02:08 -0700 Created attachment 34990 Patch v1 140831 4 eric 2009-08-17 14:03:32 -0700 The problem was that I had assumed all modes of run-webkit-tests used the %counts dictionary. It turns out %counts is not used when --reset-results is true. I've fixed the code to ignore --exit-after-n-failures in the case of --reset-results. Sorry for the trouble Dave. 140832 5 mrowe 2009-08-17 14:06:05 -0700 The code still seems as though it will not do the right thing if $counts{match} is undefined. At the least it will emit a diagnostic. As I mentioned in an earlier comment, this look as though it could happen if the first tests fails. Am I missing something? 140834 6 eric 2009-08-17 14:11:46 -0700 You are correct it happens when the first test fails too. foo.html -> new (results generated in /Users/eseidel/Projects/WebKit2/LayoutTests/platform/mac) Use of uninitialized value in subtraction (-) at WebKitTools/Scripts/run-webkit-tests line 999. Exiting early after 1 failures. 1 tests run. I'll update the patch. 140836 7 34991 eric 2009-08-17 14:17:05 -0700 Created attachment 34991 Updated to fix first-test failure case too 140837 8 eric 2009-08-17 14:17:38 -0700 Thanks for the catch. I've updated the patch to handle the case where the first test fails as well. 140934 9 34991 eric 2009-08-17 17:49:20 -0700 Comment on attachment 34991 Updated to fix first-test failure case too Clearing flags on attachment: 34991 Committed r47402: <http://trac.webkit.org/changeset/47402> 140935 10 eric 2009-08-17 17:49:26 -0700 All reviewed patches have been landed. Closing bug. 34990 2009-08-17 14:02:08 -0700 2009-08-17 14:17:01 -0700 Patch v1 bug-28336-20090817140208.patch text/plain 1799 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3NDZjMGZiLi4yM2M5MzNmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDgt MTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbiBubyBsb25nZXIgLS1yZXNldC1yZXN1bHRz IG9mIGEgbGF5b3V0IHRlc3QgZGlyZWN0b3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yODMzNgorCisgICAgICAgIC0tcmVzZXQtcmVzdWx0cyBhbmQg LS1leGl0LWFmdGVyLW4tZmFpbHVyZXMgYXJlIGluY29tcGF0aWJsZS4KKworICAgICAgICAqIFNj cmlwdHMvcnVuLXdlYmtpdC10ZXN0czoKKwogMjAwOS0wOC0xNyAgRGF2aWQgS2lsemVyICA8ZGRr aWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzI4MzkzPiBj aGVjay13ZWJraXQtc3R5bGU6IGFkZCBjaGVjayBmb3IgdXNlIG9mIHN0ZDo6bWF4KCkvc3RkOjpt aW4oKSBpbnN0ZWFkIG9mIE1BWCgpL01JTigpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3Jp cHRzL3J1bi13ZWJraXQtdGVzdHMgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVz dHMKaW5kZXggZGUwYzRhNi4uODkwOGI5NSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9ydW4td2Via2l0LXRlc3RzCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10 ZXN0cwpAQCAtOTk0LDExICs5OTQsMTQgQEAgZm9yIG15ICR0ZXN0IChAdGVzdHMpIHsKIAogICAg IGNvdW50RmluaXNoZWRUZXN0KCR0ZXN0LCAkYmFzZSwgJHJlc3VsdCwgJGlzVGV4dCk7CiAKLSAg ICBteSAkZmFpbHVyZUNvdW50ID0gJGNvdW50IC0gJGNvdW50c3ttYXRjaH07ICMgSW5jbHVkZXMg bmV3IHRlc3RzLCB0aW1lb3V0cywgY3Jhc2hlcywgZXRjLgotICAgIGlmICgkZXhpdEFmdGVyTkZh aWx1cmVzICYmICRmYWlsdXJlQ291bnQgPj0gJGV4aXRBZnRlck5GYWlsdXJlcykgewotICAgICAg ICBwcmludCAiXG5FeGl0aW5nIGVhcmx5IGFmdGVyICRmYWlsdXJlQ291bnQgZmFpbHVyZXMuICAk Y291bnQgdGVzdHMgcnVuLiI7Ci0gICAgICAgIGNsb3NlRHVtcFRvb2woKTsKLSAgICAgICAgbGFz dDsKKyAgICAjIC0tcmVzZXQtcmVzdWx0cyBkb2VzIG5vdCBjaGVjayBwYXNzIHZzLiBmYWlsLCBz byBleGl0QWZ0ZXJORmFpbHVyZXMgbWFrZXMgbm8gc2Vuc2Ugd2l0aCAtLXJlc2V0UmVzdWx0cwor ICAgIGlmICgkZXhpdEFmdGVyTkZhaWx1cmVzICYmICEkcmVzZXRSZXN1bHRzKSB7CisgICAgICAg IG15ICRmYWlsdXJlQ291bnQgPSAkY291bnQgLSAkY291bnRze21hdGNofTsgIyBJbmNsdWRlcyBu ZXcgdGVzdHMsIHRpbWVvdXRzLCBjcmFzaGVzLCBldGMuCisgICAgICAgIGlmICgkZmFpbHVyZUNv dW50ID49ICRleGl0QWZ0ZXJORmFpbHVyZXMpIHsKKyAgICAgICAgICAgIHByaW50ICJcbkV4aXRp bmcgZWFybHkgYWZ0ZXIgJGZhaWx1cmVDb3VudCBmYWlsdXJlcy4gICRjb3VudCB0ZXN0cyBydW4u IjsKKyAgICAgICAgICAgIGNsb3NlRHVtcFRvb2woKTsKKyAgICAgICAgICAgIGxhc3Q7CisgICAg ICAgIH0KICAgICB9CiB9CiBwcmludGYgIlxuJTAuMmZzIHRvdGFsIHRlc3RpbmcgdGltZVxuIiwg KHRpbWUgLSAkb3ZlcmFsbFN0YXJ0VGltZSkgLiAiIjs= 34991 2009-08-17 14:17:05 -0700 2009-08-17 17:49:19 -0700 Updated to fix first-test failure case too bug-28336-20090817141704.patch text/plain 1953 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3NDZjMGZiLi4yM2M5MzNmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDgt MTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbiBubyBsb25nZXIgLS1yZXNldC1yZXN1bHRz IG9mIGEgbGF5b3V0IHRlc3QgZGlyZWN0b3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yODMzNgorCisgICAgICAgIC0tcmVzZXQtcmVzdWx0cyBhbmQg LS1leGl0LWFmdGVyLW4tZmFpbHVyZXMgYXJlIGluY29tcGF0aWJsZS4KKworICAgICAgICAqIFNj cmlwdHMvcnVuLXdlYmtpdC10ZXN0czoKKwogMjAwOS0wOC0xNyAgRGF2aWQgS2lsemVyICA8ZGRr aWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzI4MzkzPiBj aGVjay13ZWJraXQtc3R5bGU6IGFkZCBjaGVjayBmb3IgdXNlIG9mIHN0ZDo6bWF4KCkvc3RkOjpt aW4oKSBpbnN0ZWFkIG9mIE1BWCgpL01JTigpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3Jp cHRzL3J1bi13ZWJraXQtdGVzdHMgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVz dHMKaW5kZXggZGUwYzRhNi4uODljOThmZSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9ydW4td2Via2l0LXRlc3RzCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10 ZXN0cwpAQCAtOTk0LDExICs5OTQsMTUgQEAgZm9yIG15ICR0ZXN0IChAdGVzdHMpIHsKIAogICAg IGNvdW50RmluaXNoZWRUZXN0KCR0ZXN0LCAkYmFzZSwgJHJlc3VsdCwgJGlzVGV4dCk7CiAKLSAg ICBteSAkZmFpbHVyZUNvdW50ID0gJGNvdW50IC0gJGNvdW50c3ttYXRjaH07ICMgSW5jbHVkZXMg bmV3IHRlc3RzLCB0aW1lb3V0cywgY3Jhc2hlcywgZXRjLgotICAgIGlmICgkZXhpdEFmdGVyTkZh aWx1cmVzICYmICRmYWlsdXJlQ291bnQgPj0gJGV4aXRBZnRlck5GYWlsdXJlcykgewotICAgICAg ICBwcmludCAiXG5FeGl0aW5nIGVhcmx5IGFmdGVyICRmYWlsdXJlQ291bnQgZmFpbHVyZXMuICAk Y291bnQgdGVzdHMgcnVuLiI7Ci0gICAgICAgIGNsb3NlRHVtcFRvb2woKTsKLSAgICAgICAgbGFz dDsKKyAgICAjIC0tcmVzZXQtcmVzdWx0cyBkb2VzIG5vdCBjaGVjayBwYXNzIHZzLiBmYWlsLCBz byBleGl0QWZ0ZXJORmFpbHVyZXMgbWFrZXMgbm8gc2Vuc2Ugd2l0aCAtLXJlc2V0LXJlc3VsdHMu CisgICAgaWYgKCRleGl0QWZ0ZXJORmFpbHVyZXMgJiYgISRyZXNldFJlc3VsdHMpIHsKKyAgICAg ICAgbXkgJHBhc3NDb3VudCA9ICRjb3VudHN7bWF0Y2h9IHx8IDA7ICMgJGNvdW50c3ttYXRjaH0g d2lsbCBiZSB1bmRlZmluZWQgaWYgd2UndmUgbm90IHlldCBwYXNzZWQgYSB0ZXN0IChlLmcuIHRo ZSBmaXJzdCB0ZXN0IGZhaWxzKS4KKyAgICAgICAgbXkgJGZhaWx1cmVDb3VudCA9ICRjb3VudCAt ICRwYXNzQ291bnQ7ICMgIkZhaWx1cmUiIGhlcmUgaW5jbHVkZXMgbmV3IHRlc3RzLCB0aW1lb3V0 cywgY3Jhc2hlcywgZXRjLgorICAgICAgICBpZiAoJGZhaWx1cmVDb3VudCA+PSAkZXhpdEFmdGVy TkZhaWx1cmVzKSB7CisgICAgICAgICAgICBwcmludCAiXG5FeGl0aW5nIGVhcmx5IGFmdGVyICRm YWlsdXJlQ291bnQgZmFpbHVyZXMuICAkY291bnQgdGVzdHMgcnVuLiI7CisgICAgICAgICAgICBj bG9zZUR1bXBUb29sKCk7CisgICAgICAgICAgICBsYXN0OworICAgICAgICB9CiAgICAgfQogfQog cHJpbnRmICJcbiUwLjJmcyB0b3RhbCB0ZXN0aW5nIHRpbWVcbiIsICh0aW1lIC0gJG92ZXJhbGxT dGFydFRpbWUpIC4gIiI7