28334 2009-08-14 18:11:54 -0700 Optimize updateFillImages() to not add/remove clients every time 2009-08-15 21:41:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser mitz oldest_to_newest 140404 0 simon.fraser 2009-08-14 18:11:54 -0700 We should optimize the common cases in updateFillImages() to avoid adding/removing if the bgimage does not change. 140524 1 34915 simon.fraser 2009-08-15 21:10:09 -0700 Created attachment 34915 Patch 140525 2 34915 hyatt 2009-08-15 21:10:53 -0700 Comment on attachment 34915 Patch r=me 140529 3 simon.fraser 2009-08-15 21:41:10 -0700 Fixed in r47333 34915 2009-08-15 21:10:09 -0700 2009-08-15 21:10:53 -0700 Patch 28334_patch.txt text/plain 1543 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTk1YWExNi4uOTEyMmE0YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAwOS0wOC0xNSAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBPcHRpbWl6ZSB1cGRhdGVGaWxsSW1hZ2VzKCkgdG8gbm90IGFk ZC9yZW1vdmUgY2xpZW50cyBldmVyeSB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yODMzNAorCisgICAgICAgIE9wdGltaXplIHRoZSBjYXNlIHdo ZXJlIG9sZCBhbmQgbmV3IGp1c3QgaGF2ZSBhIHNpbmdsZSBsYXllciBwb2ludGluZyB0byB0aGUg c2FtZSAob3Igbm8pCisgICAgICAgIGltYWdlLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnVwZGF0ZUZpbGxJ bWFnZXMpOgorCisyMDA5LTA4LTE1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KIAogICAgICAgICBJ bXBsZW1lbnQgYW5pbWF0aW9ucyBvZiBtdWx0aXBsZSB0ZXh0LXNoYWRvd3MgYW5kIC13ZWJraXQt Ym94LXNoYWRvd3MuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3Qu Y3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAppbmRleCBlNTIyMGQ1Li4z M2NiYjBjIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCisr KyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKQEAgLTE2MTYsNiArMTYxNiwx MCBAQCB2b2lkIFJlbmRlck9iamVjdDo6c3R5bGVEaWRDaGFuZ2UoU3R5bGVEaWZmZXJlbmNlIGRp ZmYsIGNvbnN0IFJlbmRlclN0eWxlKikKIAogdm9pZCBSZW5kZXJPYmplY3Q6OnVwZGF0ZUZpbGxJ bWFnZXMoY29uc3QgRmlsbExheWVyKiBvbGRMYXllcnMsIGNvbnN0IEZpbGxMYXllciogbmV3TGF5 ZXJzKQogeworICAgIC8vIE9wdGltaXplIHRoZSBjb21tb24gY2FzZQorICAgIGlmIChvbGRMYXll cnMgJiYgIW9sZExheWVycy0+bmV4dCgpICYmIG5ld0xheWVycyAmJiAhbmV3TGF5ZXJzLT5uZXh0 KCkgJiYgKG9sZExheWVycy0+aW1hZ2UoKSA9PSBuZXdMYXllcnMtPmltYWdlKCkpKQorICAgICAg ICByZXR1cm47CisgICAgCiAgICAgLy8gR28gdGhyb3VnaCB0aGUgbmV3IGxheWVycyBhbmQgYWRk Q2xpZW50cyBmaXJzdCwgdG8gYXZvaWQgcmVtb3ZpbmcgYWxsIGNsaWVudHMgb2YgYW4gaW1hZ2Uu CiAgICAgZm9yIChjb25zdCBGaWxsTGF5ZXIqIGN1cnJOZXcgPSBuZXdMYXllcnM7IGN1cnJOZXc7 IGN1cnJOZXcgPSBjdXJyTmV3LT5uZXh0KCkpIHsKICAgICAgICAgaWYgKGN1cnJOZXctPmltYWdl KCkpCg==