283286 2024-11-18 01:43:46 -0800 [GTK][WPE][Skia] Add GPU synchronization primitives to NativeImage/ImageBuffer for Skia 2024-11-18 16:04:48 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 283292 279618 1 zimmermann zimmermann bugs-noreply oldest_to_newest 2075770 0 zimmermann 2024-11-18 01:43:46 -0800 For the planned threaded GPU rendering mode we need a way to mark a NativeImage/ImageBuffer "as done", to inject a fence in the GL command stream, that we can wait on at a later point in time to guarantee that all operations finished. Therefore I propose to add Skia specific functions to ImageBuffer(Backend)/NativeImageBackend: - finishAcceleratedRenderingAndCreateFence() Used to notify the underlying SkSurface, that it should flush all pending rendering operations and submit the work to the GPU. Afterwards inject a fence into the GL command stream, so that we we can wait upon completion at a later point, before attempting to use the ImageBuffer/NativeImage. - waitForAcceleratedRenderingFenceCompletion() Performs a 'serverWait()' operation on the GLFence, previously created by finishAcceleratedRenderingAndCreateFence(). This instructs to GPU to await completion of the previous rendering. finishAcceleratedRenderingAndCreateFence() will be used during DisplayList recording, whenever an ImageBuffer/NativeImage resource is used, upon entering the DisplayList::ResourceHeap cache. waitForAcceleratedRenderingFenceCompletion() will be used during DisplayList replaying, whenever an ImageBuffer/NativeImage resource is extracted from the DisplayList::ResourceHeap cache. 2075784 1 zimmermann 2024-11-18 02:24:33 -0800 Pull request: https://github.com/WebKit/WebKit/pull/36794 2075986 2 ews-feeder 2024-11-18 16:04:45 -0800 Committed 286767@main (774fd3dddd84): <https://commits.webkit.org/286767@main> Reviewed commits have been landed. Closing PR #36794 and removing active labels.