283253 2024-11-16 20:16:41 -0800 Refactor webkitscmpy.program.canonicalize.message to be more testable 2024-12-03 11:36:46 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gsnedders gsnedders webkit-bug-importer oldest_to_newest 2075631 0 gsnedders 2024-11-16 20:16:41 -0800 Currently it's a singular, big main function. We should split it up to call into a smaller `rewrite_message` which can be tested in isolation. https://github.com/WebKit/WebKit/pull/36498 added a lot of tests here, but it does so in the same way as the existing tests: with a huge amount of setup, relying on our git mock, rather than testing the unit we actually care about here: how we rewrite the message. 2075637 1 gsnedders 2024-11-16 20:40:24 -0800 Pull request: https://github.com/WebKit/WebKit/pull/36768 2077363 2 webkit-bug-importer 2024-11-23 20:17:13 -0800 <rdar://problem/140487902> 2078866 3 ews-feeder 2024-12-03 11:36:44 -0800 Committed 287298@main (d07c38a4698e): <https://commits.webkit.org/287298@main> Reviewed commits have been landed. Closing PR #36768 and removing active labels.