28324 2009-08-14 15:10:49 -0700 Add a test to verify that page cache can be enabled for a test 2009-08-14 18:24:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dimich dimich oldest_to_newest 140354 0 dimich 2009-08-14 15:10:49 -0700 The test verifies that override setting that enables page cache works correctly. It navigates forward and then back and checks that onload is not fired again but the timer continues firing. 140364 1 34877 dimich 2009-08-14 15:25:15 -0700 Created attachment 34877 Proposed patch 140389 2 34877 eric 2009-08-14 17:13:56 -0700 Comment on attachment 34877 Proposed patch Yay for trailblazing! The test makes sense to me. I assume you've tested to make sure it fails with: 30 layoutTestController.overridePreference("WebKitUsesPageCachePreferenceKey", 1); commented out. I'm not sure we have a test to verify that onload would be sent twice w/ the page cache off. That seems useful to test. Eventually we'll want to make this sort of thing into a framework, so that it's easy to test page-cache bugs. For example, we want to test what sort of things prevents a page from entering the cache. Ideally that will eventually be as easy as making a single function call in a test with a little HTML passed to it. :) But I dream... LGTM assuming you've tested with the page cache off to make sure it fails. 140408 3 dimich 2009-08-14 18:24:08 -0700 Landed http://trac.webkit.org/changeset/47306 Eric, I think your points are very good. I've landed the test so it is out there and tests things, however I will think if I can create some simple 'helper script' which can make it easy to write a page cache test! 34877 2009-08-14 15:25:15 -0700 2009-08-14 17:13:56 -0700 Proposed patch patch.txt text/plain 5173 dimich ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMWU2MGRiLi40NmUzNGVlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDgt MTQgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI4MzI0CisgICAgICAgIEZpcnN0IGV2ZXIgdGVzdCB1c2luZyBwYWdl IGNhY2hlIQorICAgICAgICBUaGUgdGVzdCB2ZXJpZmllcyB0aGF0IG92ZXJyaWRlIHNldHRpbmcg dGhhdCBlbmFibGVzIHBhZ2UgY2FjaGUgd29ya3MgY29ycmVjdGx5LgorICAgICAgICBJdCBuYXZp Z2F0ZXMgZm9yd2FyZCBhbmQgdGhlbiBiYWNrIGFuZCBjaGVja3MgdGhhdCBvbmxvYWQgaXMgbm90 IGZpcmVkIGFnYWluCisgICAgICAgIGJ1dCB0aGUgdGltZXIgY29udGludWVzIGZpcmluZy4KKwor ICAgICAgICAqIGZhc3QvaGFybmVzcy9yZXNvdXJjZXMvY2FjaGVkLXBhZ2UtMS5odG1sOiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L2hhcm5lc3MvcmVzb3VyY2VzL2NhY2hlZC1wYWdlLTIuaHRtbDog QWRkZWQuCisgICAgICAgICogZmFzdC9oYXJuZXNzL3VzZS1wYWdlLWNhY2hlLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZmFzdC9oYXJuZXNzL3VzZS1wYWdlLWNhY2hlLmh0bWw6IEFk ZGVkLgorCiAyMDA5LTA4LTE0ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAog ICAgICAgICBBZGRpbmcgdHdvIG1vcmUgdG8gdGhlIHNraXBwZWQgbGlzdC4KQEAgLTEyMiw3ICsx MzcsNyBAQAogICAgICAgICAqIGZhc3QvYmFja2dyb3VuZHMvbXVsdGlwbGUtYmFja2dyb3VuZHMt YXNzZXJ0LWV4cGVjdGVkLnR4dDogQWRkZWQuCiAgICAgICAgICogZmFzdC9iYWNrZ3JvdW5kcy9t dWx0aXBsZS1iYWNrZ3JvdW5kcy1hc3NlcnQuaHRtbDogQWRkZWQuCiAKLSAgICAyMDA5LTA4LTEz ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisyMDA5LTA4LTEzICBEYW4gQmVybnN0 ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwu CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXNvdXJjZXMvY2FjaGVk LXBhZ2UtMS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc291cmNlcy9jYWNoZWQt cGFnZS0xLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAwMC4uOWI2NmE2NQot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXNvdXJjZXMvY2Fj aGVkLXBhZ2UtMS5odG1sCkBAIC0wLDAgKzEsMjggQEAKKzxzY3JpcHQ+CisKK3ZhciBpbnRlcnZh bElkOworZnVuY3Rpb24gY2hlY2soKSB7CisgICAgLy8gVGhpcyBmbGFnIGlzIHNldCBieSBjYWNo ZWQtcGFnZS0yIHdoZW4gaXQgbG9hZHMuCisgICAgLy8gSWYgdGhlIHRpbWVyIGlzIGZpcmVkIGJl Zm9yZSBjYWNoZWQtcGFnZS0yIGxvYWRzLCBqdXN0IGJhaWwgYW5kIHdhaXQuCisgICAgaWYgKCF3 aW5kb3cub3BlbmVyLmNhbkV4aXQpCisgICAgICAgIHJldHVybjsKKworICAgIGNsZWFySW50ZXJ2 YWwoaW50ZXJ2YWxJZCk7CisgICAgd2luZG93Lm9wZW5lci5sb2coIkJhY2sgb24gcGFnZS0xLCB0 aW1lciBpcyBzdGlsbCBmaXJpbmcuIik7CisgICAgd2luZG93Lm9wZW5lci5sb2coIlBBU1MuIik7 CisgICAgd2luZG93Lm9wZW5lci5maW5pc2goKTsKK30KKworZnVuY3Rpb24gbG9hZE5leHQoKQor eworICAgIC8vIFZlcmlmeSB0aGF0IHRoaXMgb25sb2FkIGhhbmRsZXIgaXMgY2FsbGVkIG9ubHkg b25jZS4gT24gbmF2aWdhdGlvbiBiYWNrCisgICAgLy8gdGhpcyBwYWdlIHdpbGwgYmUgc2VydmVk IGZyb20gdGhlIGNhY2hlLCB3L28gZmlyaW5nIG9ubG9hZC4KKyAgICB3aW5kb3cub3BlbmVyLnJl cG9ydE9ubG9hZCgpOworCisgICAgaW50ZXJ2YWxJZCA9IHNldEludGVydmFsKGNoZWNrLCAxMCk7 CisKKyAgICB3aW5kb3cub3BlbmVyLmxvZygicGFnZS0xLCBhYm91dCB0byBuYXZpZ2F0ZSB0byBw YWdlLTIuIikKKyAgICBsb2NhdGlvbi5ocmVmID0gImNhY2hlZC1wYWdlLTIuaHRtbCI7Cit9Cis8 L3NjcmlwdD4KKzxib2R5IG9ubG9hZD0ibG9hZE5leHQoKSI+PC9ib2R5PgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc291cmNlcy9jYWNoZWQtcGFnZS0yLmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2VzL2NhY2hlZC1wYWdlLTIuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi5mMGQ1NDc4Ci0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Jlc291cmNlcy9jYWNoZWQtcGFnZS0yLmh0bWwK QEAgLTAsMCArMSw4IEBACis8c2NyaXB0PgorZnVuY3Rpb24gaW5pdCgpIHsKKyAgICB3aW5kb3cu b3BlbmVyLmNhbkV4aXQgPSB0cnVlOworICAgIHdpbmRvdy5vcGVuZXIubG9nKCdwYWdlLTIsIGFi b3V0IHRvIGdvIGJhY2sgdG8gcGFnZS0xJyk7CisgICAgaGlzdG9yeS5iYWNrKCk7Cit9Cis8L3Nj cmlwdD4KKzxib2R5IG9ubG9hZD0iaW5pdCgpIj48L2JvZHk+CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2hhcm5lc3MvdXNlLXBhZ2UtY2FjaGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9oYXJuZXNzL3VzZS1wYWdlLWNhY2hlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi4yYjRiZTk3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9oYXJuZXNzL3VzZS1wYWdlLWNhY2hlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDggQEAKK1RoaXMgdGVzdCB1c2VzIGxheW91dFRlc3RDb250cm9sbGVyLm92ZXJyaWRlUHJlZmVy ZW5jZSgiV2ViS2l0VXNlc1BhZ2VDYWNoZVByZWZlcmVuY2VLZXkiLCAxKTsgdG8gZW5hYmxlIGJh Y2stZm9yd2FyZCBXZWJLaXQgcGFnZSBjYWNoZSBmb3IgdGhlIGR1cmF0aW9uIG9mIHRoZSB0ZXN0 LiBUaGUgdGVzdCBlbmFibGVzIGNhY2hlLCBuYXZpZ2F0ZXMgdG8gcGFnZS0xLCB0aGVuIHRvIHBh Z2UtMiBhbmQgdGhlbiBkb2VzIGhpc3RvcnkuYmFjaygpIHRvIHBhZ2UtMS4gT24gbmF2aWdhdGlv biBiYWNrIHRvIHBhZ2UtMSwgdGVzdCB2ZXJpZmllcyB0aGF0IHByZXZpb3VzbHktaW5pdGlhbGl6 ZWQgdGltZXIgY29udGludWVzIHRvIGZpcmUgYW5kIG9ubG9hZCBpcyBub3QgY2FsbGVkIGFnYWlu LiBJZiB0ZXN0IGZhaWxzIGl0IGhhbmdzIG9yIG91dHB1dHMgJ0ZBSUwnIGJlbG93LgorCitvcGVu IHBhZ2UtMQorcGFnZS0xLCBhYm91dCB0byBuYXZpZ2F0ZSB0byBwYWdlLTIuCitwYWdlLTIsIGFi b3V0IHRvIGdvIGJhY2sgdG8gcGFnZS0xCitCYWNrIG9uIHBhZ2UtMSwgdGltZXIgaXMgc3RpbGwg ZmlyaW5nLgorUEFTUy4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3Vz ZS1wYWdlLWNhY2hlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvdXNlLXBhZ2UtY2Fj aGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi5iOTk5NWU2Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3VzZS1wYWdlLWNhY2hlLmh0 bWwKQEAgLTAsMCArMSw0NiBAQAorPGh0bWw+Cis8c2NyaXB0Pgord2luZG93LmZpbmlzaCA9IGZ1 bmN0aW9uKCkKK3sKKyAgICBpZiAobGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKword2luZG93LmxvZyA9IGZ1bmN0aW9u KG1lc3NhZ2UpIHsKKyAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVy SFRNTCArPSBtZXNzYWdlICsgIjxicj4iOworfQorCit3aW5kb3cuZmFpbHVyZSA9IGZ1bmN0aW9u KG1lc3NhZ2UpIHsKKyAgICBsb2coIkZBSUw6ICIgKyBtZXNzYWdlKTsKKyAgICBmaW5pc2goKTsK K30KKwordmFyIG9ubG9hZFJlcG9ydENvdW50ID0gMDsKK3dpbmRvdy5yZXBvcnRPbmxvYWQgPSBm dW5jdGlvbigpIHsKKyAgICBpZiAoKytvbmxvYWRSZXBvcnRDb3VudCA+IDEpCisgICAgICAgIGZh aWx1cmUoIk11bHRpcGxlIG9ubG9hZCBjYWxscyBvbiBwYWdlLTEuIik7Cit9CisKK2Z1bmN0aW9u IHRlc3QoKQoreworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy LnNldENhbk9wZW5XaW5kb3dzKCk7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm92ZXJy aWRlUHJlZmVyZW5jZSgiV2ViS2l0VXNlc1BhZ2VDYWNoZVByZWZlcmVuY2VLZXkiLCAxKTsKKyAg ICB9CisgICAgbG9nKCJvcGVuIHBhZ2UtMSIpOworICAgIHdpbmRvdy5vcGVuKCJyZXNvdXJjZXMv Y2FjaGVkLXBhZ2UtMS5odG1sIik7Cit9Cis8L3NjcmlwdD4KKworPGJvZHkgb25sb2FkPSJ0ZXN0 KCkiPgorPHA+VGhpcyB0ZXN0IHVzZXMgbGF5b3V0VGVzdENvbnRyb2xsZXIub3ZlcnJpZGVQcmVm ZXJlbmNlKCJXZWJLaXRVc2VzUGFnZUNhY2hlUHJlZmVyZW5jZUtleSIsIDEpOyB0byBlbmFibGUK K2JhY2stZm9yd2FyZCBXZWJLaXQgcGFnZSBjYWNoZSBmb3IgdGhlIGR1cmF0aW9uIG9mIHRoZSB0 ZXN0LgorVGhlIHRlc3QgZW5hYmxlcyBjYWNoZSwgbmF2aWdhdGVzIHRvIHBhZ2UtMSwgdGhlbiB0 byBwYWdlLTIgYW5kIHRoZW4gZG9lcyBoaXN0b3J5LmJhY2soKSB0byBwYWdlLTEuCitPbiBuYXZp Z2F0aW9uIGJhY2sgdG8gcGFnZS0xLCB0ZXN0IHZlcmlmaWVzIHRoYXQgcHJldmlvdXNseS1pbml0 aWFsaXplZCB0aW1lciBjb250aW51ZXMgdG8gZmlyZSBhbmQKK29ubG9hZCBpcyBub3QgY2FsbGVk IGFnYWluLgorSWYgdGVzdCBmYWlscyBpdCBoYW5ncyBvciBvdXRwdXRzICdGQUlMJyBiZWxvdy4K KzxkaXYgaWQ9InJlc3VsdCI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==