28321 2009-08-14 14:52:57 -0700 bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches 2009-09-08 12:34:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 28605 P2 Normal --- 1 eric webkit-unassigned abarth oldest_to_newest 140343 0 eric 2009-08-14 14:52:57 -0700 bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches bugzilla-tool properly detects when a pach has r+ or cq+ set by someone who does not have proper rights. However it doesn't know how to clean up the bug after that. It should clear flags which have been set erroneously. What makes this tricky is the current architecture is to do that lookups/validation inside the patch fetch function. Which is wrong. We should get all the patch information in one function and validate the patches separately. Or at least have some sort of validate=True flag which is passed to the fetch function. I have a partial patch on my machine, but I'll have to finish it later... 145497 1 eric 2009-09-08 12:34:06 -0700 Fixing this as part of bug 28605. *** This bug has been marked as a duplicate of bug 28605 ***