28318 2009-08-14 14:34:13 -0700 Failed assertion when bringing up Safari's error console 2009-08-14 18:15:07 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson simon.fraser simon.fraser oldest_to_newest 140339 0 atwilson 2009-08-14 14:34:13 -0700 Run safari bring up the error console (via the Develop menu) Get the following failed assertion: ASSERTION FAILED: m_clients.contains(renderer) (WebCore/css/CSSGradientValue.cpp:109 virtual WebCore::Image* WebCore::CSSGradientValue::image(WebCore::RenderObject*, const WebCore::IntSize&)) 140403 1 34882 simon.fraser 2009-08-14 18:08:56 -0700 Created attachment 34882 Patch I tried hard to get a testcase, but was not able to reproduce the problem. 140405 2 34882 hyatt 2009-08-14 18:13:25 -0700 Comment on attachment 34882 Patch r=me 140406 3 simon.fraser 2009-08-14 18:15:07 -0700 http://trac.webkit.org/changeset/47305 34882 2009-08-14 18:08:56 -0700 2009-08-14 18:13:24 -0700 Patch 28318_patch.txt text/plain 5129 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzU3MzdiNi4uMTA1Y2QyYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAwOS0wOC0xNCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggYW4gYXNzZXJ0aW9uIHdoZW4gYnJpbmdpbmcgdXAgdGhl IEluc3BlY3Rvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTI4MzE4CisgICAgICAgIAorICAgICAgICBUaGUgZml4IGZvciBidWcgMjgyOTUgYXNzdW1l ZCB0aGF0IGltYWdlIGNsaWVudHMgY291bnQgdGhlIG51bWJlciBvZiB0aW1lcworICAgICAgICBh ZGRDbGllbnQvcmVtb3ZlQ2xpZW50IGlzIGNhbGxlZC4gVGhhdCB3YXMgdHJ1ZSBmb3IgQ2FjaGVk UmVzb3VyY2UgY2xpZW50cywKKyAgICAgICAgYnV0IG5vdCBTdHlsZUdlbmVyYXRlZEltYWdlIGNs aWVudHMsIHdoaWNoIHBhc3MgdGhlIGNhbGwgb250byBDU1NJbWFnZUdlbmVyYXRvclZhbHVlLgor ICAgICAgICAKKyAgICAgICAgRml4IGJ5IG1ha2luZyBDU1NJbWFnZUdlbmVyYXRvclZhbHVlIGNv dW50IHRoZSBudW1iZXIgb2YgdGltZXMgYSBjbGllbnQgaXMKKyAgICAgICAgYWRkZWQvcmVtb3Zl ZC4KKworICAgICAgICAqIGNzcy9DU1NDYW52YXNWYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDU1NDYW52YXNWYWx1ZTo6Y2FudmFzQ2hhbmdlZCk6CisgICAgICAgIChXZWJDb3JlOjpDU1ND YW52YXNWYWx1ZTo6Y2FudmFzUmVzaXplZCk6CisgICAgICAgICogY3NzL0NTU0ltYWdlR2VuZXJh dG9yVmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZTo6 YWRkQ2xpZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkNTU0ltYWdlR2VuZXJhdG9yVmFsdWU6OnJl bW92ZUNsaWVudCk6CisgICAgICAgIChXZWJDb3JlOjpDU1NJbWFnZUdlbmVyYXRvclZhbHVlOjpn ZXRJbWFnZSk6CisgICAgICAgICogY3NzL0NTU0ltYWdlR2VuZXJhdG9yVmFsdWUuaDoKKwogMjAw OS0wOC0xNCAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9DU1ND YW52YXNWYWx1ZS5jcHAgYi9XZWJDb3JlL2Nzcy9DU1NDYW52YXNWYWx1ZS5jcHAKaW5kZXggY2Y4 Y2I0Mi4uMGMxYzNmOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9jc3MvQ1NTQ2FudmFzVmFsdWUuY3Bw CisrKyBiL1dlYkNvcmUvY3NzL0NTU0NhbnZhc1ZhbHVlLmNwcApAQCAtNDcsMTUgKzQ3LDE1IEBA IFN0cmluZyBDU1NDYW52YXNWYWx1ZTo6Y3NzVGV4dCgpIGNvbnN0CiB2b2lkIENTU0NhbnZhc1Zh bHVlOjpjYW52YXNDaGFuZ2VkKEhUTUxDYW52YXNFbGVtZW50KiwgY29uc3QgRmxvYXRSZWN0JiBj aGFuZ2VkUmVjdCkKIHsKICAgICBJbnRSZWN0IGltYWdlQ2hhbmdlUmVjdCA9IGVuY2xvc2luZ0lu dFJlY3QoY2hhbmdlZFJlY3QpOwotICAgIEhhc2hNYXA8UmVuZGVyT2JqZWN0KiwgSW50U2l6ZT46 OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IG1fY2xpZW50cy5lbmQoKTsKLSAgICBmb3IgKEhhc2hNYXA8 UmVuZGVyT2JqZWN0KiwgSW50U2l6ZT46OmNvbnN0X2l0ZXJhdG9yIGN1cnIgPSBtX2NsaWVudHMu YmVnaW4oKTsgY3VyciAhPSBlbmQ7ICsrY3VycikKKyAgICBSZW5kZXJPYmplY3RTaXplQ291bnRN YXA6OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IG1fY2xpZW50cy5lbmQoKTsKKyAgICBmb3IgKFJlbmRl ck9iamVjdFNpemVDb3VudE1hcDo6Y29uc3RfaXRlcmF0b3IgY3VyciA9IG1fY2xpZW50cy5iZWdp bigpOyBjdXJyICE9IGVuZDsgKytjdXJyKQogICAgICAgICBjdXJyLT5maXJzdC0+aW1hZ2VDaGFu Z2VkKHN0YXRpY19jYXN0PFdyYXBwZWRJbWFnZVB0cj4odGhpcyksICZpbWFnZUNoYW5nZVJlY3Qp OwogfQogCiB2b2lkIENTU0NhbnZhc1ZhbHVlOjpjYW52YXNSZXNpemVkKEhUTUxDYW52YXNFbGVt ZW50KikKIHsKLSAgICBIYXNoTWFwPFJlbmRlck9iamVjdCosIEludFNpemU+Ojpjb25zdF9pdGVy YXRvciBlbmQgPSBtX2NsaWVudHMuZW5kKCk7Ci0gICAgZm9yIChIYXNoTWFwPFJlbmRlck9iamVj dCosIEludFNpemU+Ojpjb25zdF9pdGVyYXRvciBjdXJyID0gbV9jbGllbnRzLmJlZ2luKCk7IGN1 cnIgIT0gZW5kOyArK2N1cnIpCisgICAgUmVuZGVyT2JqZWN0U2l6ZUNvdW50TWFwOjpjb25zdF9p dGVyYXRvciBlbmQgPSBtX2NsaWVudHMuZW5kKCk7CisgICAgZm9yIChSZW5kZXJPYmplY3RTaXpl Q291bnRNYXA6OmNvbnN0X2l0ZXJhdG9yIGN1cnIgPSBtX2NsaWVudHMuYmVnaW4oKTsgY3VyciAh PSBlbmQ7ICsrY3VycikKICAgICAgICAgY3Vyci0+Zmlyc3QtPmltYWdlQ2hhbmdlZChzdGF0aWNf Y2FzdDxXcmFwcGVkSW1hZ2VQdHI+KHRoaXMpKTsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9j c3MvQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZS5jcHAgYi9XZWJDb3JlL2Nzcy9DU1NJbWFnZUdlbmVy YXRvclZhbHVlLmNwcAppbmRleCA2ZTIzZDk1Li40Y2YwODczIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2Nzcy9DU1NJbWFnZUdlbmVyYXRvclZhbHVlLmNwcAorKysgYi9XZWJDb3JlL2Nzcy9DU1NJbWFn ZUdlbmVyYXRvclZhbHVlLmNwcApAQCAtNDksMjQgKzQ5LDQyIEBAIHZvaWQgQ1NTSW1hZ2VHZW5l cmF0b3JWYWx1ZTo6YWRkQ2xpZW50KFJlbmRlck9iamVjdCogcmVuZGVyZXIsIGNvbnN0IEludFNp emUmIHNpCiAgICAgcmVmKCk7CiAgICAgaWYgKCFzaXplLmlzRW1wdHkoKSkKICAgICAgICAgbV9z aXplcy5hZGQoc2l6ZSk7Ci0gICAgbV9jbGllbnRzLmFkZChyZW5kZXJlciwgc2l6ZSk7CisgICAg CisgICAgUmVuZGVyT2JqZWN0U2l6ZUNvdW50TWFwOjppdGVyYXRvciBpdCA9IG1fY2xpZW50cy5m aW5kKHJlbmRlcmVyKTsKKyAgICBpZiAoaXQgPT0gbV9jbGllbnRzLmVuZCgpKQorICAgICAgICBt X2NsaWVudHMuYWRkKHJlbmRlcmVyLCBTaXplQ291bnRQYWlyKHNpemUsIDEpKTsKKyAgICBlbHNl IHsKKyAgICAgICAgU2l6ZUNvdW50UGFpciYgc2l6ZUNvdW50ID0gaXQtPnNlY29uZDsKKyAgICAg ICAgKytzaXplQ291bnQuc2Vjb25kOworICAgIH0KIH0KIAogdm9pZCBDU1NJbWFnZUdlbmVyYXRv clZhbHVlOjpyZW1vdmVDbGllbnQoUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKIHsKLSAgICBJbnRT aXplIHNpemUgPSBtX2NsaWVudHMuZ2V0KHJlbmRlcmVyKTsKKyAgICBSZW5kZXJPYmplY3RTaXpl Q291bnRNYXA6Oml0ZXJhdG9yIGl0ID0gbV9jbGllbnRzLmZpbmQocmVuZGVyZXIpOworICAgIEFT U0VSVChpdCAhPSBtX2NsaWVudHMuZW5kKCkpOworCisgICAgU2l6ZUNvdW50UGFpciYgc2l6ZUNv dW50ID0gaXQtPnNlY29uZDsKKyAgICBJbnRTaXplIHNpemUgPSBzaXplQ291bnQuZmlyc3Q7CiAg ICAgaWYgKCFzaXplLmlzRW1wdHkoKSkgewogICAgICAgICBtX3NpemVzLnJlbW92ZShzaXplKTsK ICAgICAgICAgaWYgKCFtX3NpemVzLmNvbnRhaW5zKHNpemUpKQogICAgICAgICAgICAgbV9pbWFn ZXMucmVtb3ZlKHNpemUpOwogICAgIH0KLSAgICBtX2NsaWVudHMucmVtb3ZlKHJlbmRlcmVyKTsK KyAgICAKKyAgICBpZiAoIS0tc2l6ZUNvdW50LnNlY29uZCkKKyAgICAgICAgbV9jbGllbnRzLnJl bW92ZShyZW5kZXJlcik7CisKICAgICBkZXJlZigpOwogfQogCiBJbWFnZSogQ1NTSW1hZ2VHZW5l cmF0b3JWYWx1ZTo6Z2V0SW1hZ2UoUmVuZGVyT2JqZWN0KiByZW5kZXJlciwgY29uc3QgSW50U2l6 ZSYgc2l6ZSkKIHsKLSAgICBJbnRTaXplIG9sZFNpemUgPSBtX2NsaWVudHMuZ2V0KHJlbmRlcmVy KTsKKyAgICBSZW5kZXJPYmplY3RTaXplQ291bnRNYXA6Oml0ZXJhdG9yIGl0ID0gbV9jbGllbnRz LmZpbmQocmVuZGVyZXIpOworICAgIEFTU0VSVChpdCAhPSBtX2NsaWVudHMuZW5kKCkpOworCisg ICAgU2l6ZUNvdW50UGFpciYgc2l6ZUNvdW50ID0gaXQtPnNlY29uZDsKKyAgICBJbnRTaXplIG9s ZFNpemUgPSBzaXplQ291bnQuZmlyc3Q7CiAgICAgaWYgKG9sZFNpemUgIT0gc2l6ZSkgewogICAg ICAgICByZW1vdmVDbGllbnQocmVuZGVyZXIpOwogICAgICAgICBhZGRDbGllbnQocmVuZGVyZXIs IHNpemUpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZS5o IGIvV2ViQ29yZS9jc3MvQ1NTSW1hZ2VHZW5lcmF0b3JWYWx1ZS5oCmluZGV4IDY2MWZkMzcuLmMw NTNiZmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvY3NzL0NTU0ltYWdlR2VuZXJhdG9yVmFsdWUuaAor KysgYi9XZWJDb3JlL2Nzcy9DU1NJbWFnZUdlbmVyYXRvclZhbHVlLmgKQEAgLTU3LDggKzU3LDEx IEBAIHByb3RlY3RlZDoKICAgICBJbWFnZSogZ2V0SW1hZ2UoUmVuZGVyT2JqZWN0KiwgY29uc3Qg SW50U2l6ZSYpOwogICAgIHZvaWQgcHV0SW1hZ2UoY29uc3QgSW50U2l6ZSYsIFBhc3NSZWZQdHI8 SW1hZ2U+KTsKIAorICAgIHR5cGVkZWYgcGFpcjxJbnRTaXplLCBpbnQ+IFNpemVDb3VudFBhaXI7 CisgICAgdHlwZWRlZiBIYXNoTWFwPFJlbmRlck9iamVjdCosIFNpemVDb3VudFBhaXI+IFJlbmRl ck9iamVjdFNpemVDb3VudE1hcDsKKwogICAgIEhhc2hDb3VudGVkU2V0PEludFNpemU+IG1fc2l6 ZXM7IC8vIEEgY291bnQgb2YgaG93IG1hbnkgdGltZXMgYSBnaXZlbiBpbWFnZSBzaXplIGlzIGlu IHVzZS4KLSAgICBIYXNoTWFwPFJlbmRlck9iamVjdCosIEludFNpemU+IG1fY2xpZW50czsgLy8g QSBtYXAgZnJvbSBSZW5kZXJPYmplY3RzIHRvIGltYWdlIHNpemVzLgorICAgIFJlbmRlck9iamVj dFNpemVDb3VudE1hcCBtX2NsaWVudHM7IC8vIEEgbWFwIGZyb20gUmVuZGVyT2JqZWN0cyAod2l0 aCBlbnRyeSBjb3VudCkgdG8gaW1hZ2Ugc2l6ZXMuCiAgICAgSGFzaE1hcDxJbnRTaXplLCBSZWZQ dHI8SW1hZ2U+ID4gbV9pbWFnZXM7IC8vIEEgY2FjaGUgb2YgSW1hZ2Ugb2JqZWN0cyBieSBpbWFn ZSBzaXplLgogICAgIAogICAgIFJlZlB0cjxTdHlsZUdlbmVyYXRlZEltYWdlPiBtX2ltYWdlOwo=