<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>283172</bug_id>
          
          <creation_ts>2024-11-15 06:05:06 -0800</creation_ts>
          <short_desc>[Media] Avoid play() call during seek flow before the finishSeek() call</short_desc>
          <delta_ts>2025-02-13 09:31:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>285568</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Enrique Ocaña">eocanha</reporter>
          <assigned_to name="Enrique Ocaña">eocanha</assigned_to>
          <cc>jean-yves.avenard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2075348</commentid>
    <comment_count>0</comment_count>
    <who name="Enrique Ocaña">eocanha</who>
    <bug_when>2024-11-15 06:05:06 -0800</bug_when>
    <thetext>During the video playback states should ideally flow as play -&gt; pause -&gt; seek_start -&gt; seek_done -&gt; play, but randomly it is observed that the play event is being sent before finishing the seek (seek_done) i.e, play -&gt; pause -&gt; seek_start -&gt; play -&gt; seek_done. Ideally play call might be triggered continuously by the webapp when we are playing a video, so in our scenario between seek_start and seek_done we should avoid the play call.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1423</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2075349</commentid>
    <comment_count>1</comment_count>
    <who name="Enrique Ocaña">eocanha</who>
    <bug_when>2024-11-15 06:14:54 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/36695</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2076997</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-11-22 06:06:14 -0800</bug_when>
    <thetext>&lt;rdar://problem/140414465&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2078774</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-12-03 04:14:55 -0800</bug_when>
    <thetext>Committed 287274@main (71a7e0a09291): &lt;https://commits.webkit.org/287274@main&gt;

Reviewed commits have been landed. Closing PR #36695 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2085651</commentid>
    <comment_count>4</comment_count>
    <who name="Jean-Yves Avenard [:jya]">jean-yves.avenard</who>
    <bug_when>2025-01-07 17:57:16 -0800</bug_when>
    <thetext>This change is wrong.

as written in https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1423

 It breaks the spec. There&apos;s nothing in the spec that makes the play event being conditional of a seek having been completed.

https://html.spec.whatwg.org/multipage/media.html#internal-play-steps

if you call play() (even during a seek) and playback is allowed, the play event should be fired.

Found be investigating why Duolingo was now broken in Safari STP 210.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2085656</commentid>
    <comment_count>5</comment_count>
    <who name="Jean-Yves Avenard [:jya]">jean-yves.avenard</who>
    <bug_when>2025-01-07 18:17:05 -0800</bug_when>
    <thetext>Reopened Bugzilla.
Broke duolingo, calling play() during a seek() is allowed by the spec. And the play event should be fired even if the seek hasn&apos;t completed., tracking revert in https://bugs.webkit.org/show_bug.cgi?id=285568.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2094476</commentid>
    <comment_count>6</comment_count>
    <who name="Enrique Ocaña">eocanha</who>
    <bug_when>2025-02-13 09:31:35 -0800</bug_when>
    <thetext>After analyzing the spec and discussing it with the original https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1423 reporter, we&apos;ve concluded that the revert is fine and this bug should be resolved as invalid, since it&apos;s against the spec. Thanks for having taken the effort to prove your point, Jean-Yves.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>