28312 2009-08-14 12:39:14 -0700 [CURL] Crash in download handler for local files 2009-08-14 16:09:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED Curl P2 Normal --- 1 bfulgham bfulgham oldest_to_newest 140303 0 bfulgham 2009-08-14 12:39:14 -0700 When the CURL backend handle the 'download' of a local file, it does not perform the normal header processing for data received over the network. This means that the URL is not set properly, and the 'didReceiveResponse' processing is never performed. This was the cause of an earlier bug in the write callback, as evidenced by the following comment: // since the code in headerCallback will not have run for local files // the code to set the URL and fire didReceiveResponse is never run, // which means the ResourceLoader's response does not contain the URL. // Run the code here for local files to resolve the issue. // TODO: See if there is a better approach for handling this. I have resolved the current error in the same fashion, by dealing with this special case and manually firing the 'didReceiveResponse'. This specialized handling is now in its own function which cleans things up a bit. The current bug was demonstrated by LayoutTests/fast/encoding/char-encoding-mac.html. 140305 1 34868 bfulgham 2009-08-14 12:45:49 -0700 Created attachment 34868 Correct crash due to improper handling of local files. 140317 2 bfulgham 2009-08-14 13:16:33 -0700 The problem here is actually in the POST handler. The proper fix seems to be to add the 'didReceiveResponse' to the readCallback handler. 140348 3 bfulgham 2009-08-14 15:02:48 -0700 Further testing indicates the original patch actually was correct. 140375 4 bfulgham 2009-08-14 16:09:10 -0700 Landed in http://trac.webkit.org/changeset/47299. 34868 2009-08-14 12:45:49 -0700 2009-08-14 15:01:49 -0700 Correct crash due to improper handling of local files. curl_crash.patch text/plain 3783 bfulgham SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzI5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMDgtMTQgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IENvcnJlY3QgbGliY3VybCBjcmFzaCB3aGVuIGRvd25sb2FkaW5nIGxvY2FsIGZpbGVzLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgzMTIKKworICAg ICAgICBObyBuZXcgdGVzdHMuIFRlc3QgaXMgY292ZXJlZCBieSBmYXN0L2VuY29kaW5nL2NoYXIt ZW5jb2RpbmctbWFjLmh0bWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVz b3VyY2VIYW5kbGVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmhhbmRsZUxvY2FsUmVj ZWl2ZVJlc3BvbnNlKTogTmV3IHN0YXRpYyBmdW5jdGlvbiB0aGF0CisgICAgICAgICAgcGVyZm9y bXMgdGhlIGxvY2FsIHNldHRpbmcgb2YgdmFsaWQgVVJMIGFuZCBmaXJpbmcgZGlkUmVjZWl2ZVJl c3BvbnNlLgorICAgICAgICAgIFRoaXMgY29kZSB3YXMgbW92ZWQgZnJvbSB3cml0ZUNhbGxiYWNr LgorICAgICAgICAoV2ViQ29yZTo6d3JpdGVDYWxsYmFjayk6IE1vdmUgbG9jYWwgZmlsZSBoYW5k bGluZyB0byBzdGF0aWMgZnVuY3Rpb24KKyAgICAgICAgICAoYWJvdmUpIGFuZCB1c2UgdGhlIGZ1 bmN0aW9uIGluc3RlYWQuCisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZU1hbmFnZXI6 OmRvd25sb2FkVGltZXJDYWxsYmFjayk6IEFkZCBjaGVjaworICAgICAgICAgIGZvciByZXNwb25z ZUZpcmVkLCBhbmQgaGFuZGxlIGFzIGEgbG9jYWwgZmlsZSBpZiBpdCB3YXMgbm90LgorCiAyMDA5 LTA4LTE0ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVz b3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCShyZXZpc2lvbiA0NzIxOCkKKysr IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEwOSw2ICsxMDksMjMgQEAgUmVzb3VyY2VIYW5kbGVNYW5hZ2Vy KiBSZXNvdXJjZUhhbmRsZU1hbgogICAgIHJldHVybiBzaGFyZWRJbnN0YW5jZTsKIH0KIAorc3Rh dGljIHZvaWQgaGFuZGxlTG9jYWxSZWNlaXZlUmVzcG9uc2UgKENVUkwqIGhhbmRsZSwgUmVzb3Vy Y2VIYW5kbGUqIGpvYiwgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbCogZCkKK3sKKyAgICAvLyBzaW5j ZSB0aGUgY29kZSBpbiBoZWFkZXJDYWxsYmFjayB3aWxsIG5vdCBoYXZlIHJ1biBmb3IgbG9jYWwg ZmlsZXMKKyAgICAvLyB0aGUgY29kZSB0byBzZXQgdGhlIFVSTCBhbmQgZmlyZSBkaWRSZWNlaXZl UmVzcG9uc2UgaXMgbmV2ZXIgcnVuLAorICAgIC8vIHdoaWNoIG1lYW5zIHRoZSBSZXNvdXJjZUxv YWRlcidzIHJlc3BvbnNlIGRvZXMgbm90IGNvbnRhaW4gdGhlIFVSTC4KKyAgICAvLyBSdW4gdGhl IGNvZGUgaGVyZSBmb3IgbG9jYWwgZmlsZXMgdG8gcmVzb2x2ZSB0aGUgaXNzdWUuCisgICAgLy8g VE9ETzogU2VlIGlmIHRoZXJlIGlzIGEgYmV0dGVyIGFwcHJvYWNoIGZvciBoYW5kbGluZyB0aGlz LgorICAgICBjb25zdCBjaGFyKiBoZHI7CisgICAgIENVUkxjb2RlIGVyciA9IGN1cmxfZWFzeV9n ZXRpbmZvKGhhbmRsZSwgQ1VSTElORk9fRUZGRUNUSVZFX1VSTCwgJmhkcik7CisgICAgIEFTU0VS VChDVVJMRV9PSyA9PSBlcnIpOworICAgICBkLT5tX3Jlc3BvbnNlLnNldFVSTChLVVJMKGhkcikp OworICAgICBpZiAoZC0+Y2xpZW50KCkpCisgICAgICAgICBkLT5jbGllbnQoKS0+ZGlkUmVjZWl2 ZVJlc3BvbnNlKGpvYiwgZC0+bV9yZXNwb25zZSk7CisgICAgIGQtPm1fcmVzcG9uc2Uuc2V0UmVz cG9uc2VGaXJlZCh0cnVlKTsKK30KKworCiAvLyBjYWxsZWQgd2l0aCBkYXRhIGFmdGVyIGFsbCBo ZWFkZXJzIGhhdmUgYmVlbiBwcm9jZXNzZWQgdmlhIGhlYWRlckNhbGxiYWNrCiBzdGF0aWMgc2l6 ZV90IHdyaXRlQ2FsbGJhY2sodm9pZCogcHRyLCBzaXplX3Qgc2l6ZSwgc2l6ZV90IG5tZW1iLCB2 b2lkKiBkYXRhKQogewpAQCAtMTMzLDE5ICsxNTAsOCBAQCBzdGF0aWMgc2l6ZV90IHdyaXRlQ2Fs bGJhY2sodm9pZCogcHRyLCBzCiAgICAgaWYgKENVUkxFX09LID09IGVyciAmJiBodHRwQ29kZSA+ PSAzMDAgJiYgaHR0cENvZGUgPCA0MDApCiAgICAgICAgIHJldHVybiB0b3RhbFNpemU7CiAKLSAg ICAvLyBzaW5jZSB0aGUgY29kZSBpbiBoZWFkZXJDYWxsYmFjayB3aWxsIG5vdCBoYXZlIHJ1biBm b3IgbG9jYWwgZmlsZXMKLSAgICAvLyB0aGUgY29kZSB0byBzZXQgdGhlIFVSTCBhbmQgZmlyZSBk aWRSZWNlaXZlUmVzcG9uc2UgaXMgbmV2ZXIgcnVuLAotICAgIC8vIHdoaWNoIG1lYW5zIHRoZSBS ZXNvdXJjZUxvYWRlcidzIHJlc3BvbnNlIGRvZXMgbm90IGNvbnRhaW4gdGhlIFVSTC4KLSAgICAv LyBSdW4gdGhlIGNvZGUgaGVyZSBmb3IgbG9jYWwgZmlsZXMgdG8gcmVzb2x2ZSB0aGUgaXNzdWUu Ci0gICAgLy8gVE9ETzogU2VlIGlmIHRoZXJlIGlzIGEgYmV0dGVyIGFwcHJvYWNoIGZvciBoYW5k bGluZyB0aGlzLgotICAgIGlmICghZC0+bV9yZXNwb25zZS5yZXNwb25zZUZpcmVkKCkpIHsKLSAg ICAgICAgY29uc3QgY2hhciogaGRyOwotICAgICAgICBlcnIgPSBjdXJsX2Vhc3lfZ2V0aW5mbyho LCBDVVJMSU5GT19FRkZFQ1RJVkVfVVJMLCAmaGRyKTsKLSAgICAgICAgZC0+bV9yZXNwb25zZS5z ZXRVUkwoS1VSTChoZHIpKTsKLSAgICAgICAgaWYgKGQtPmNsaWVudCgpKQotICAgICAgICAgICAg ZC0+Y2xpZW50KCktPmRpZFJlY2VpdmVSZXNwb25zZShqb2IsIGQtPm1fcmVzcG9uc2UpOwotICAg ICAgICBkLT5tX3Jlc3BvbnNlLnNldFJlc3BvbnNlRmlyZWQodHJ1ZSk7Ci0gICAgfQorICAgIGlm ICghZC0+bV9yZXNwb25zZS5yZXNwb25zZUZpcmVkKCkpCisgICAgICAgaGFuZGxlTG9jYWxSZWNl aXZlUmVzcG9uc2UoaCwgam9iLCBkKTsKIAogICAgIGlmIChkLT5jbGllbnQoKSkKICAgICAgICAg ZC0+Y2xpZW50KCktPmRpZFJlY2VpdmVEYXRhKGpvYiwgc3RhdGljX2Nhc3Q8Y2hhcio+KHB0ciks IHRvdGFsU2l6ZSwgMCk7CkBAIC0zMzIsNiArMzM4LDEwIEBAIHZvaWQgUmVzb3VyY2VIYW5kbGVN YW5hZ2VyOjpkb3dubG9hZFRpbWUKICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIGlm IChDVVJMRV9PSyA9PSBtc2ctPmRhdGEucmVzdWx0KSB7CisKKyAgICAgICAgICAgIGlmICghZC0+ bV9yZXNwb25zZS5yZXNwb25zZUZpcmVkKCkpCisgICAgICAgICAgICAgICAgaGFuZGxlTG9jYWxS ZWNlaXZlUmVzcG9uc2UoaGFuZGxlLCBqb2IsIGQpOworCiAgICAgICAgICAgICBpZiAoZC0+Y2xp ZW50KCkpCiAgICAgICAgICAgICAgICAgZC0+Y2xpZW50KCktPmRpZEZpbmlzaExvYWRpbmcoam9i KTsKICAgICAgICAgfSBlbHNlIHsK