28307 2009-08-14 09:24:24 -0700 [Haiku] Fix RenderThemeHaiku build. 2009-08-14 13:52:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 0 simon.maxime webkit-unassigned eric leavengood oldest_to_newest 140248 0 simon.maxime 2009-08-14 09:24:24 -0700 The patch which introduced RenderThemeHaiku was wrong in some places. ( see: https://bugs.webkit.org/show_bug.cgi?id=28258#c5 ) Here is a patch to correct this. Regards, Maxime 140249 1 34846 simon.maxime 2009-08-14 09:31:19 -0700 Created attachment 34846 Patch v1 140316 2 34846 oliver 2009-08-14 13:14:22 -0700 Comment on attachment 34846 Patch v1 r=me 140323 3 34846 eric 2009-08-14 13:22:36 -0700 Comment on attachment 34846 Patch v1 Rejecting patch 34846 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 140326 4 34846 eric 2009-08-14 13:25:35 -0700 Comment on attachment 34846 Patch v1 Sorry, the commit-queue is dumb. There were 2 commits to the WebCore/ChangeLog between when the commit-queue updated and when it tried to commit. I'm about to teach it how to update itself before commit... bug 28316 140327 5 simon.maxime 2009-08-14 13:31:27 -0700 (In reply to comment #4) > (From update of attachment 34846 [details]) > Sorry, the commit-queue is dumb. There were 2 commits to the WebCore/ChangeLog > between when the commit-queue updated and when it tried to commit. I'm about > to teach it how to update itself before commit... bug 28316 Okay. I didn't understand why it could fail as there was nothing "exotic" in this patch. But indeed bugzilla-tool is still in a learning phase. ;) 140333 6 34846 eric 2009-08-14 13:52:16 -0700 Comment on attachment 34846 Patch v1 Clearing flags on attachment: 34846 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/haiku/RenderThemeHaiku.cpp M WebCore/platform/haiku/RenderThemeHaiku.h Committed r47296 M WebCore/ChangeLog M WebCore/platform/haiku/RenderThemeHaiku.cpp M WebCore/platform/haiku/RenderThemeHaiku.h r47296 = c0737da3bd221d15fd82b932dc33967859956e54 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47296 140334 7 eric 2009-08-14 13:52:20 -0700 All reviewed patches have been landed. Closing bug. 34846 2009-08-14 09:31:19 -0700 2009-08-14 13:52:16 -0700 Patch v1 bug-28307-20090814183115.patch text/plain 3476 simon.maxime ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWJkMzRlYi4uZDJkZDg4NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wOC0xNCAgTWF4aW1lIFNpbW9u ICA8c2ltb24ubWF4aW1lQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbSGFpa3VdIEZpeCBSZW5kZXJUaGVtZUhhaWt1IGJ1aWxkLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgzMDcKKwor ICAgICAgICAqIHBsYXRmb3JtL2hhaWt1L1JlbmRlclRoZW1lSGFpa3UuY3BwOiBJbmNsdWRlZCBS ZW5kZXJUaGVtZUhhaWt1LmgKKyAgICAgICAgaW5zdGVhZCBvZiBSZW5kZXJUaGVtZS5oLgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVIYWlrdTo6cGFpbnRDaGVja2JveCk6IFJlbW92ZWQg dGhlIHdyb25nICd2aXJ0dWFsJworICAgICAgICBiZWZvcmUgdGhlIGZ1bmN0aW9uLgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVIYWlrdTo6cGFpbnRSYWRpbyk6IFJlbW92ZWQgdGhlIHdy b25nICd2aXJ0dWFsJworICAgICAgICBiZWZvcmUgdGhlIGZ1bmN0aW9uLgorICAgICAgICAqIHBs YXRmb3JtL2hhaWt1L1JlbmRlclRoZW1lSGFpa3UuaDogQ29ycmVjdGVkIHdyb25nIGZ1bmN0aW9u IGRlZmluaXRpb25zLgorCiAyMDA5LTA4LTEzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BsYXRmb3JtL2hhaWt1L1JlbmRlclRoZW1lSGFpa3UuY3BwIGIvV2ViQ29y ZS9wbGF0Zm9ybS9oYWlrdS9SZW5kZXJUaGVtZUhhaWt1LmNwcAppbmRleCBlYTk2NzllLi40MzI3 Nzk1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2hhaWt1L1JlbmRlclRoZW1lSGFpa3Uu Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vaGFpa3UvUmVuZGVyVGhlbWVIYWlrdS5jcHAKQEAg LTI2LDcgKzI2LDcgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCi0jaW5jbHVkZSAiUmVu ZGVyVGhlbWUuaCIKKyNpbmNsdWRlICJSZW5kZXJUaGVtZUhhaWt1LmgiCiAKICNpbmNsdWRlICJH cmFwaGljc0NvbnRleHQuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgpAQCAtMTA3LDcg KzEwNyw3IEBAIHZvaWQgUmVuZGVyVGhlbWVIYWlrdTo6c3lzdGVtRm9udChpbnQgcHJvcElkLCBG b250RGVzY3JpcHRpb24mKSBjb25zdAogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAKLXZpcnR1 YWwgYm9vbCBSZW5kZXJUaGVtZUhhaWt1OjpwYWludENoZWNrYm94KFJlbmRlck9iamVjdCosIGNv bnN0IFJlbmRlck9iamVjdDo6UGFpbnRJbmZvJiBpbmZvLCBjb25zdCBJbnRSZWN0JiBpbnRSZWN0 KQorYm9vbCBSZW5kZXJUaGVtZUhhaWt1OjpwYWludENoZWNrYm94KFJlbmRlck9iamVjdCosIGNv bnN0IFJlbmRlck9iamVjdDo6UGFpbnRJbmZvJiBpbmZvLCBjb25zdCBJbnRSZWN0JiBpbnRSZWN0 KQogewogICAgIGlmIChpbmZvLmNvbnRleHQtPnBhaW50aW5nRGlzYWJsZWQoKSkKICAgICAgICAg cmV0dXJuIGZhbHNlOwpAQCAtMTM5LDcgKzEzOSw3IEBAIHZvaWQgUmVuZGVyVGhlbWVIYWlrdTo6 c2V0Q2hlY2tib3hTaXplKFJlbmRlclN0eWxlKiBzdHlsZSkgY29uc3QKICAgICAgICAgc3R5bGUt PnNldEhlaWdodChMZW5ndGgoc2l6ZSwgRml4ZWQpKTsKIH0KIAotdmlydHVhbCBib29sIFJlbmRl clRoZW1lSGFpa3U6OnBhaW50UmFkaW8oUmVuZGVyT2JqZWN0KiwgY29uc3QgUmVuZGVyT2JqZWN0 OjpQYWludEluZm8mIGluZm8sIGNvbnN0IEludFJlY3QmIGludFJlY3QpCitib29sIFJlbmRlclRo ZW1lSGFpa3U6OnBhaW50UmFkaW8oUmVuZGVyT2JqZWN0KiwgY29uc3QgUmVuZGVyT2JqZWN0OjpQ YWludEluZm8mIGluZm8sIGNvbnN0IEludFJlY3QmIGludFJlY3QpCiB7CiAgICAgaWYgKGluZm8u Y29udGV4dC0+cGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2hhaWt1L1JlbmRlclRoZW1lSGFpa3UuaCBiL1dlYkNv cmUvcGxhdGZvcm0vaGFpa3UvUmVuZGVyVGhlbWVIYWlrdS5oCmluZGV4IGFhMDQyM2EuLjdkYWVi YzQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vaGFpa3UvUmVuZGVyVGhlbWVIYWlrdS5o CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vaGFpa3UvUmVuZGVyVGhlbWVIYWlrdS5oCkBAIC0zMiw3 ICszMiw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBSZW5kZXJUaGVtZUhhaWt1 IDogcHVibGljIFJlbmRlclRoZW1lIHsKICAgICBwcml2YXRlOgogICAgICAgICBSZW5kZXJUaGVt ZUhhaWt1KCk7Ci0gICAgICAgIH5SZW5kZXJUaGVtZUhhaWt1KCk7CisgICAgICAgIHZpcnR1YWwg flJlbmRlclRoZW1lSGFpa3UoKTsKIAogICAgIHB1YmxpYzoKICAgICAgICAgc3RhdGljIFBhc3NS ZWZQdHI8UmVuZGVyVGhlbWU+IGNyZWF0ZSgpOwpAQCAtNTUsMTQgKzU1LDE0IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKICAgICAgICAgdmlydHVhbCB2b2lkIHN5c3RlbUZvbnQoaW50IHByb3BJZCwg Rm9udERlc2NyaXB0aW9uJikgY29uc3Q7CiAKICAgICBwcm90ZWN0ZWQ6Ci0gICAgICAgIHZpcnR1 YWwgcGFpbnRDaGVja2JveChSZW5kZXJPYmplY3QqLCBjb25zdCBSZW5kZXJPYmplY3Q6OlBhaW50 SW5mbyYsIGNvbnN0IEludFJlY3QmKTsKKyAgICAgICAgdmlydHVhbCBib29sIHBhaW50Q2hlY2ti b3goUmVuZGVyT2JqZWN0KiwgY29uc3QgUmVuZGVyT2JqZWN0OjpQYWludEluZm8mLCBjb25zdCBJ bnRSZWN0Jik7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBzZXRDaGVja2JveFNpemUoUmVuZGVyU3R5 bGUqKSBjb25zdDsKIAogICAgICAgICB2aXJ0dWFsIGJvb2wgcGFpbnRSYWRpbyhSZW5kZXJPYmpl Y3QqLCBjb25zdCBSZW5kZXJPYmplY3Q6OlBhaW50SW5mbyYsIGNvbnN0IEludFJlY3QmKTsKICAg ICAgICAgdmlydHVhbCB2b2lkIHNldFJhZGlvU2l6ZShSZW5kZXJTdHlsZSopIGNvbnN0OwogCiAg ICAgICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RNZW51TGlzdFN0eWxlKENTU1N0eWxlU2VsZWN0b3Iq LCBSZW5kZXJTdHlsZSosIEVsZW1lbnQqKSBjb25zdDsKLSAgICAgICAgdmlydHVhbCBib29sIFJl bmRlclRoZW1lSGFpa3U6OnBhaW50TWVudUxpc3QoUmVuZGVyT2JqZWN0KiwgY29uc3QgUmVuZGVy T2JqZWN0OjpQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7CisgICAgICAgIHZpcnR1YWwgYm9v bCBwYWludE1lbnVMaXN0KFJlbmRlck9iamVjdCosIGNvbnN0IFJlbmRlck9iamVjdDo6UGFpbnRJ bmZvJiwgY29uc3QgSW50UmVjdCYpOwogICAgIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmU=