282983 2024-11-12 05:23:03 -0800 REGRESSION(286456@main) [WebDriver] WebAutomationSessionProxy::evaluateJavaScriptFunction completionHandler should always be called 2024-11-12 12:16:15 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lmoura lmoura achristensen bburg webkit-bug-importer oldest_to_newest 2074488 0 lmoura 2024-11-12 05:23:03 -0800 286456@main made Messages::WebAutomationSessionProxy::EvaluateJavaScriptFunction use sendWithAsyncReply, but stored the completionHandler only if expectsImplicitCallbackArgument is true. This results in the sendWithAsyncReply completionHandler never being called if expectsImplicitCallbackArgument is false. For example, when using EvaluateJavaScriptFunction to get the page title. IIUC, the expectsImplicitCallbackArgument parameter is related to the actual JS function being evaluated having an implicit callback parameter to be called with the result of the evaluation. Something like a promise's "resolve" function, as handled by Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.js in fact. In this case, expectsImplicitCallbackArgument is not related to the IPC reply itself, which handles the communication inside the browser. The previous code also guarded the "callbackID" only if expectsImplicitCallbackArgument was true, but did not block as it called a given callbackID unconditionally on WebAutomationSessionProxy::didEvaluateJavaScriptFunction. Tentative patch incoming. 2074489 1 lmoura 2024-11-12 05:29:51 -0800 Pull request: https://github.com/WebKit/WebKit/pull/36524 2074594 2 ews-feeder 2024-11-12 12:15:52 -0800 Committed 286495@main (c64901beb5ef): <https://commits.webkit.org/286495@main> Reviewed commits have been landed. Closing PR #36524 and removing active labels. 2074595 3 webkit-bug-importer 2024-11-12 12:16:15 -0800 <rdar://problem/139741114>