28295 2009-08-13 22:31:51 -0700 Assertion when background-image changes from multiple to single image 2009-08-13 23:25:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser oldest_to_newest 140160 0 34810 simon.fraser 2009-08-13 22:31:51 -0700 Created attachment 34810 Testcase The attached testcase asserts. It changes the image background from using two images to one image. The assertion is: ASSERTION FAILED: m_clients.contains(client) (/Volumes/WebKit/WebKit.git/WebCore/loader/CachedResource.cpp:201 void WebCore::CachedResource::removeClient(WebCore::CachedResourceClient*)) from #0 0x0000000100da0fe4 in WebCore::CachedResource::removeClient (this=0x11adb5ca0, client=0x11adb6058) at /Volumes/WebKit/WebKit.git/WebCore/loader/CachedResource.cpp:201 #1 0x000000010158b031 in WebCore::StyleCachedImage::removeClient (this=0x118b02440, renderer=0x11adb6058) at /Volumes/WebKit/WebKit.git/WebCore/rendering/style/StyleCachedImage.cpp:84 #2 0x00000001014a691f in WebCore::RenderObject::arenaDelete (this=0x11adb6058, arena=0x118b1e660, base=0x11adb6058) at /Volumes/WebKit/WebKit.git/WebCore/rendering/RenderObject.cpp:1864 #3 0x00000001014a6bb3 in WebCore::RenderObject::destroy (this=0x11adb6058) at /Volumes/WebKit/WebKit.git/WebCore/rendering/RenderObject.cpp:1856 #4 0x0000000101457f3d in WebCore::RenderBoxModelObject::destroy (this=0x11adb6058) at /Volumes/WebKit/WebKit.git/WebCore/rendering/RenderBoxModelObject.cpp:75 #5 0x000000010144ef1e in WebCore::RenderBox::destroy (this=0x11adb6058) at /Volumes/WebKit/WebKit.git/WebCore/rendering/RenderBox.cpp:95 #6 0x000000010141de57 in WebCore::RenderBlock::destroy (this=0x11adb6058) at /Volumes/WebKit/WebKit.git/WebCore/rendering/RenderBlock.cpp:204 #7 0x00000001013b6ed7 in WebCore::Node::detach (this=0x11adad7e0) at /Volumes/WebKit/WebKit.git/WebCore/dom/Node.cpp:1165 ... 140166 1 34813 simon.fraser 2009-08-13 23:18:17 -0700 Created attachment 34813 Patch, testcase 140167 2 simon.fraser 2009-08-13 23:25:08 -0700 http://trac.webkit.org/changeset/47270 34810 2009-08-13 22:31:51 -0700 2009-08-13 22:31:51 -0700 Testcase mismatched-backgrounds-assert.html text/html 948 simon.fraser PCFET0NUWVBFPgoKPGh0bWwgbGFuZz0iZW4iPgo8aGVhZD4KICA8dGl0bGU+VGVzdCBtaXNtYXRj aGVkIGJhY2tncm91bmRzPC90aXRsZT4KICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlhPSJz Y3JlZW4iPgogICAgLmJveCB7CiAgICAgIGhlaWdodDogMTAwcHg7CiAgICAgIHdpZHRoOiAxMDBw eDsKICAgICAgbWFyZ2luOiAxMHB4OwogICAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsKICAg ICAgYmFja2dyb3VuZC1yZXBlYXQ6IG5vLXJlcGVhdDsKICAgIH0KICAgIAogICAgLyogTWlzbWF0 Y2hlZCBsYXllcnMgKi8KICAgICNib3ggewogICAgICBiYWNrZ3JvdW5kLWltYWdlOiB1cmwoJ3Jl cGVhdC9yZXNvdXJjZXMvZ3JhZGllbnQuZ2lmJyk7CiAgICB9CiAgICAKICAgICNib3guZmluYWwg ewogICAgICBiYWNrZ3JvdW5kLWltYWdlOiB1cmwoJ3JlcGVhdC9yZXNvdXJjZXMvZ3JhZGllbnQu Z2lmJyksIHVybCgncmVwZWF0L3Jlc291cmNlcy9ncmFkaWVudC5naWYnKTsKICAgIH0KCiAgPC9z dHlsZT4KCiAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4K CiAgICBmdW5jdGlvbiBydW5UZXN0KCkKICAgIHsKICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ2JveCcpLmNsYXNzTmFtZSA9ICdib3ggZmluYWwnOwogICAgICB3aW5kb3cuc2V0VGltZW91 dChmdW5jdGlvbigpIHsKICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm94Jykuc3R5 bGUuZGlzcGxheSA9ICdub25lJzsKICAgICAgfSkKICAgIH0KICAKICAgIHdpbmRvdy5hZGRFdmVu dExpc3RlbmVyKCdsb2FkJywgcnVuVGVzdCwgZmFsc2UpOwogICAgCiAgPC9zY3JpcHQ+CjwvaGVh ZD4KPGJvZHk+CgogIDxkaXYgaWQ9ImJveCIgY2xhc3M9ImJveCI+PC9kaXY+CgogIDxkaXYgaWQ9 InJlc3VsdCI+CiAgPC9kaXY+Cgo8L2JvZHk+CjwvaHRtbD4K 34813 2009-08-13 23:18:17 -0700 2009-08-13 23:20:32 -0700 Patch, testcase 28295_patch.txt text/plain 5056 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0M2E5NjFhLi41ZmY2ZWE5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDgt MTMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGxvZ2ljIGluIFJlbmRlck9i amVjdDo6dXBkYXRlRmlsbEltYWdlcygpIHRoYXQgbGVkIHRvIGluY29ycmVjdCBjbGllbnQKKyAg ICAgICAgY291bnRzIGlmIGFuIGltYWdlIHdhcyB1c2VkIHR3aWNlIGluIHRoZSBiYWNrZ3JvdW5k LWltYWdlIHByb3BlcnR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjgyOTUKKyAgICAgICAgCisgICAgICAgIFRlc3QgdGhhdCBjaGFuZ2VzIGJhY2tn cm91bmQtaW1hZ2UgZnJvbSBvbmUgcmVmZXJlbmNlIHRvIGFuIGltYWdlCisgICAgICAgIHRvIHR3 byByZWZlcmVuY2VzIHRvIHRoZSBzYW1lIGltYWdlLgorCisgICAgICAgICogZmFzdC9iYWNrZ3Jv dW5kcy9tdWx0aXBsZS1iYWNrZ3JvdW5kcy1hc3NlcnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2JhY2tncm91bmRzL211bHRpcGxlLWJhY2tncm91bmRzLWFzc2VydC5odG1s OiBBZGRlZC4KKwogICAgIDIwMDktMDgtMTMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvYmFja2dyb3VuZHMvbXVsdGlwbGUtYmFja2dyb3VuZHMtYXNzZXJ0LWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvYmFja2dyb3VuZHMvbXVsdGlwbGUtYmFja2dyb3Vu ZHMtYXNzZXJ0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li4wZjA2NzUwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9iYWNrZ3JvdW5k cy9tdWx0aXBsZS1iYWNrZ3JvdW5kcy1hc3NlcnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAK K1Rlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODI5NTsg c2hvdWxkIG5vdCBhc3NlcnQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2JhY2tncm91 bmRzL211bHRpcGxlLWJhY2tncm91bmRzLWFzc2VydC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9i YWNrZ3JvdW5kcy9tdWx0aXBsZS1iYWNrZ3JvdW5kcy1hc3NlcnQuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi40ZGE0OTQxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9iYWNrZ3JvdW5kcy9tdWx0aXBsZS1iYWNrZ3JvdW5kcy1hc3NlcnQuaHRtbApA QCAtMCwwICsxLDUyIEBACis8IURPQ1RZUEU+CisKKzxodG1sIGxhbmc9ImVuIj4KKzxoZWFkPgor ICA8dGl0bGU+VGVzdCBtaXNtYXRjaGVkIGJhY2tncm91bmRzPC90aXRsZT4KKyAgPHN0eWxlIHR5 cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVuIj4KKyAgICAuYm94IHsKKyAgICAgIGhlaWdodDog MTAwcHg7CisgICAgICB3aWR0aDogMTAwcHg7CisgICAgICBtYXJnaW46IDEwcHg7CisgICAgICBi b3JkZXI6IDFweCBzb2xpZCBibGFjazsKKyAgICAgIGJhY2tncm91bmQtcmVwZWF0OiBuby1yZXBl YXQ7CisgICAgfQorICAgIAorICAgIC8qIE1pc21hdGNoZWQgbGF5ZXJzICovCisgICAgI2JveCB7 CisgICAgICBiYWNrZ3JvdW5kLWltYWdlOiB1cmwoJ3JlcGVhdC9yZXNvdXJjZXMvd2hpdGUuZ2lm Jyk7CisgICAgfQorICAgIAorICAgICNib3guZmluYWwgeworICAgICAgYmFja2dyb3VuZC1pbWFn ZTogdXJsKCdyZXBlYXQvcmVzb3VyY2VzL3doaXRlLmdpZicpLCB1cmwoJ3JlcGVhdC9yZXNvdXJj ZXMvd2hpdGUuZ2lmJyk7CisgICAgfQorCisgIDwvc3R5bGU+CisKKyAgPHNjcmlwdCB0eXBlPSJ0 ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KKworICAgIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQo KTsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9CisK KyAgICBmdW5jdGlvbiBydW5UZXN0KCkKKyAgICB7CisgICAgICBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnYm94JykuY2xhc3NOYW1lID0gJ2JveCBmaW5hbCc7CisgICAgICB3aW5kb3cuc2V0VGlt ZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2JveCcp LnN0eWxlLmRpc3BsYXkgPSAnbm9uZSc7CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCisgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwor ICAgICAgfSwgMCk7CisgICAgfQorICAKKyAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9h ZCcsIHJ1blRlc3QsIGZhbHNlKTsKKyAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKworICA8 cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjgyOTUiPmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODI5NTwv YT47IHNob3VsZCBub3QgYXNzZXJ0LjwvcD4KKyAgPGRpdiBpZD0iYm94IiBjbGFzcz0iYm94Ij48 L2Rpdj4KKworPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MjkyYWMxLi41ZGQ5NGQ2IDEwMDY0NAotLS0gYS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBA CisyMDA5LTA4LTEzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBsb2dpYyBp biBSZW5kZXJPYmplY3Q6OnVwZGF0ZUZpbGxJbWFnZXMoKSB0aGF0IGxlZCB0byBpbmNvcnJlY3Qg Y2xpZW50CisgICAgICAgIGNvdW50cyBpZiBhbiBpbWFnZSB3YXMgdXNlZCB0d2ljZSBpbiB0aGUg YmFja2dyb3VuZC1pbWFnZSBwcm9wZXJ0eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI4Mjk1CisKKyAgICAgICAgVGVzdDogZmFzdC9iYWNrZ3JvdW5k cy9tdWx0aXBsZS1iYWNrZ3JvdW5kcy1hc3NlcnQuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnVwZGF0 ZUZpbGxJbWFnZXMpOgorICAgICAgICBTaW1wbGlmeSB0aGUgbG9naWMgdG8gY2FsbCBhZGRDbGll bnQoKS9yZW1vdmVDbGllbnQoKSBmb3IgZXZlcnkgYmFja2dyb3VuZAorICAgICAgICBpbWFnZSwg YnV0IGdvIHRocm91Z2ggdGhlIG5ldyBsYXllcnMgZmlyc3QgdG8gYXZvaWQgcmVtb3ZpbmcgYWxs IHRoZQorICAgICAgICBjbGllbnRzIG9mIGFuIGltYWdlLgorCiAyMDA5LTA4LTEzICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2Uu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwIGIvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAppbmRleCBhMzY3MjViLi5lNTIyMGQ1IDEwMDY0 NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCisrKyBiL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKQEAgLTE2MTYsMTUgKzE2MTYsMTYgQEAgdm9pZCBS ZW5kZXJPYmplY3Q6OnN0eWxlRGlkQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBS ZW5kZXJTdHlsZSopCiAKIHZvaWQgUmVuZGVyT2JqZWN0Ojp1cGRhdGVGaWxsSW1hZ2VzKGNvbnN0 IEZpbGxMYXllciogb2xkTGF5ZXJzLCBjb25zdCBGaWxsTGF5ZXIqIG5ld0xheWVycykKIHsKLSAg ICAvLyBGSVhNRTogVGhpcyB3aWxsIGJlIHNsb3cgd2hlbiBhIGxhcmdlIG51bWJlciBvZiBpbWFn ZXMgaXMgdXNlZC4gIEZpeCBieSB1c2luZyBhIGRpY3QuCi0gICAgZm9yIChjb25zdCBGaWxsTGF5 ZXIqIGN1cnJPbGQgPSBvbGRMYXllcnM7IGN1cnJPbGQ7IGN1cnJPbGQgPSBjdXJyT2xkLT5uZXh0 KCkpIHsKLSAgICAgICAgaWYgKGN1cnJPbGQtPmltYWdlKCkgJiYgKCFuZXdMYXllcnMgfHwgIW5l d0xheWVycy0+Y29udGFpbnNJbWFnZShjdXJyT2xkLT5pbWFnZSgpKSkpCi0gICAgICAgICAgICBj dXJyT2xkLT5pbWFnZSgpLT5yZW1vdmVDbGllbnQodGhpcyk7Ci0gICAgfQorICAgIC8vIEdvIHRo cm91Z2ggdGhlIG5ldyBsYXllcnMgYW5kIGFkZENsaWVudHMgZmlyc3QsIHRvIGF2b2lkIHJlbW92 aW5nIGFsbCBjbGllbnRzIG9mIGFuIGltYWdlLgogICAgIGZvciAoY29uc3QgRmlsbExheWVyKiBj dXJyTmV3ID0gbmV3TGF5ZXJzOyBjdXJyTmV3OyBjdXJyTmV3ID0gY3Vyck5ldy0+bmV4dCgpKSB7 Ci0gICAgICAgIGlmIChjdXJyTmV3LT5pbWFnZSgpICYmICghb2xkTGF5ZXJzIHx8ICFvbGRMYXll cnMtPmNvbnRhaW5zSW1hZ2UoY3Vyck5ldy0+aW1hZ2UoKSkpKQorICAgICAgICBpZiAoY3Vyck5l dy0+aW1hZ2UoKSkKICAgICAgICAgICAgIGN1cnJOZXctPmltYWdlKCktPmFkZENsaWVudCh0aGlz KTsKICAgICB9CisKKyAgICBmb3IgKGNvbnN0IEZpbGxMYXllciogY3Vyck9sZCA9IG9sZExheWVy czsgY3Vyck9sZDsgY3Vyck9sZCA9IGN1cnJPbGQtPm5leHQoKSkgeworICAgICAgICBpZiAoY3Vy ck9sZC0+aW1hZ2UoKSkKKyAgICAgICAgICAgIGN1cnJPbGQtPmltYWdlKCktPnJlbW92ZUNsaWVu dCh0aGlzKTsKKyAgICB9CiB9CiAKIHZvaWQgUmVuZGVyT2JqZWN0Ojp1cGRhdGVJbWFnZShTdHls ZUltYWdlKiBvbGRJbWFnZSwgU3R5bGVJbWFnZSogbmV3SW1hZ2UpCg==