28288 2009-08-13 17:10:12 -0700 Qt: Font Sizes are wrong for font families including monospace 2009-10-20 05:19:53 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 eric webkit-unassigned abecsi ossy zoltan oldest_to_newest 140105 0 eric 2009-08-13 17:10:12 -0700 Qt: Font Sizes are wrong for font families including monospace fast/css/getComputedStyle/computed-style-font-family-monospace.html expected actual diff pretty diff fast/css/getComputedStyle/computed-style-font-family.html expected actual diff pretty diff I expect the way qt fonts work is just different from other ports and the fix that I made in bug 19161 just doesn't work for Qt. I'll skip these tests for now so that the Qt bot is green. Someone in Qt-land will need to look at this. 140107 1 eric 2009-08-13 17:14:19 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/qt/Skipped Committed r47254 M LayoutTests/platform/qt/Skipped M LayoutTests/ChangeLog r47254 = 890728473e778c7105daeecb9d385b028ef68d65 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47254 141069 2 abecsi 2009-08-18 04:49:54 -0700 This issue seems to be related to default font size settings in qwebsettings.cpp and DumpRenderTree.cpp. There also seems to be a little fray because of the different default values given in these source files. QtWebKit uses 14px font size for both regular and monospace fonts in qwebsettings.cpp but DumpRenderTree.cpp uses 13px for both, whereas the gtk and mac ports use 16px for regular fonts and 13px for monospace, so the test obviously fails on Qt. 156127 3 41498 abecsi 2009-10-20 05:07:50 -0700 Created attachment 41498 Enable previously disabled passing fast/css tests after r48873 landed. 156128 4 ossy 2009-10-20 05:17:41 -0700 (In reply to comment #3) > Created an attachment (id=41498) [details] > Enable previously disabled passing fast/css tests after r48873 landed. Sending LayoutTests/ChangeLog Sending LayoutTests/platform/qt/Skipped .. Committed revision 49849. 156130 5 zoltan 2009-10-20 05:19:53 -0700 Patch landed. Closing bug. 41498 2009-10-20 05:07:50 -0700 2009-10-20 05:13:40 -0700 Enable previously disabled passing fast/css tests after r48873 landed. fast_css.patch text/plain 1264 abecsi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyNTJiNWUzLi5jY2M0N2Q5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTAt MjAgIEFuZHJhcyBCZWNzaSAgPGJlY3NpLmFuZHJhc0BzdHVkLnUtc3plZ2VkLmh1PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRW5hYmxlIHBy ZXZpb3VzbHkgZGlzYWJsZWQgZmFzdC9jc3MgdGVzdHMgYWZ0ZXIgcjQ4ODczIGxhbmRlZCB3aGlj aAorICAgICAgICBmaXhlZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjgyODgKKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKIDIwMDktMTAtMjAgIFhh biBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFNraXAgcGx1Z2lucy9wcml2 YXRlLWJyb3dzaW5nLW1vZGUuaHRtbCwgc2luY2Ugb3VyIHBsdWdpbgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Nr aXBwZWQKaW5kZXggYTUwZDk4My4uNTFiOTMyMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBA IC00ODc4LDExICs0ODc4LDYgQEAgbG9hZGVyL2dvLWJhY2stdG8tZGlmZmVyZW50LXdpbmRvdy1z aXplLmh0bWwKICMgVGhpcyBwb3J0IGRvZXNuJ3Qgc3VwcG9ydCBHZW9sb2NhdGlvbi4KIGZhc3Qv ZG9tL0dlb2xvY2F0aW9uCiAKLSMgU3RhcnRlZCBmYWlsaW5nIGFmdGVyIGh0dHA6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzQ3MjI5Ci0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yODI4OAotZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS9jb21wdXRlZC1zdHls ZS1mb250LWZhbWlseS1tb25vc3BhY2UuaHRtbAotZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS9j b21wdXRlZC1zdHlsZS1mb250LWZhbWlseS5odG1sCi0KICMgTWlzc2luZyBEUlQgYWJpbGl0eSB0 byB0cmFjayB3b3JrZXIgdGhyZWFkIGNvdW50cwogZmFzdC93b3JrZXJzL2RlZGljYXRlZC13b3Jr ZXItbGlmZWN5Y2xlLmh0bWwKIGZhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLWZyYW1lLWxpZmVj eWNsZS5odG1sCg==