28286 2009-08-13 16:16:30 -0700 bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected 2009-12-15 02:39:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth kbr webkit.review.bot oldest_to_newest 140092 0 eric 2009-08-13 16:16:30 -0700 bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected the commit-queue script I'm running keeps a log locally. But bugzilla-tool/commit-queue is not smart enough to know how to upload that log to the bug when a failure occurs. it will also need to split out just the relevant sections of the log. Adding these logs to bugs would clear up a lot of confusion around the commit-queue. 171771 1 eric 2009-12-15 02:21:52 -0800 For now we're going to upload the failure logs to app engine instead of the bug. We could change things to upload them to the bug as well at a later date. 171774 2 44854 eric 2009-12-15 02:26:01 -0800 Created attachment 44854 Patch 171775 3 webkit.review.bot 2009-12-15 02:30:14 -0800 style-queue ran check-webkit-style on attachment 44854 without any errors. 171776 4 44854 abarth 2009-12-15 02:30:55 -0800 Comment on attachment 44854 Patch Nice! One step closer to real ultimate power. 171777 5 eric 2009-12-15 02:39:27 -0800 Committed r52147: <http://trac.webkit.org/changeset/52147> 44854 2009-12-15 02:26:01 -0800 2009-12-15 02:31:14 -0800 Patch bug-28286-20091215022559.patch text/plain 3235 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5MjgyY2MwLi5kOWY3ZDIxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMDktMTIt MTUgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJ1Z3ppbGxhLXRvb2wvY29tbWl0LXF1ZXVlIG5l ZWRzIHRvIHVwbG9hZCBmYWlsdXJlIGxvZ3Mgd2hlbiBwYXRjaGVzIGFyZSByZWplY3RlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgyODYKKworICAg ICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL2luZGV4Lmh0bWw6CisgICAgICAgICAtIFNob3cgW3Jl c3VsdHNdIGxpbmtzIGlmIGEgcmVzdWx0cyBsb2cgd2FzIHVwbG9hZGVkLgorICAgICAgICAqIFF1 ZXVlU3RhdHVzU2VydmVyL3F1ZXVlX3N0YXR1cy5weToKKyAgICAgICAgIC0gRW1wdHkgZmlsZSB1 cGxvYWRzIGFwcGVhciBhcyB1IiIgYW5kIEJsb2IgZG9lcyBub3QgaGFuZGxlIHVuaWNvZGUsIHNv IGNvbnZlcnQgdG8gc3RyKCkuCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3F1 ZXVlcy5weToKKyAgICAgICAgIC0gUG9zdCB0byB0aGUgc3RhdHVzIGJvdCB3aGVuIGEgcGF0Y2gg ZmFpbHMgYW5kIGluY2x1ZGUgdGhlIGZhaWx1cmUgbG9nIGFzIGEgcmVzdWx0cyBmaWxlLgorCisy MDA5LTEyLTE1ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgogCiAgICAgICAgIHF1ZXVlIHN1Yi1jb21tYW5kcyBuZWVkIC0t c3RhdHVzLWhvc3Qgc28gdGhleSBjYW4gcmVwb3J0IHN0YXR1cwpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvaW5kZXguaHRtbCBiL1dlYktpdFRvb2xzL1F1ZXVlU3Rh dHVzU2VydmVyL2luZGV4Lmh0bWwKaW5kZXggZmJkNTFmYi4uMDBkMDY1MyAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvaW5kZXguaHRtbAorKysgYi9XZWJLaXRUb29s cy9RdWV1ZVN0YXR1c1NlcnZlci9pbmRleC5odG1sCkBAIC0xOSw2ICsxOSwxMSBAQAogICAgICAg ICA8dHI+CiAgICAgICAgICAgICA8dGQgY2xhc3M9J3N0YXR1c19kYXRlJz57eyByZWNlbnRfc3Rh dHVzLmRhdGV8dGltZXNpbmNlIH19IGFnbzwvdGQ+CiAgICAgICAgICAgICA8dGQgY2xhc3M9InJl Y2VudF9zdGF0dXMiPnt7IHJlY2VudF9zdGF0dXMubWVzc2FnZXxmb3JjZV9lc2NhcGV8dXJsaXpl fHdlYmtpdF9saW5raWZ5fHNhZmUgfX08L3RkPgorICAgICAgICAgICAgPHRkIGNsYXNzPSJyZXN1 bHRzX2xpbmsiPgorICAgICAgICAgICAgeyUgaWYgcmVjZW50X3N0YXR1cy5yZXN1bHRzX2ZpbGUg JX0KKyAgICAgICAgICAgICAgICBbPGEgaHJlZj0iL3Jlc3VsdHMve3sgcmVjZW50X3N0YXR1cy5r ZXkuaWQgfX0iPnJlc3VsdHM8L2E+XQorICAgICAgICAgICAgeyUgZW5kaWYgJX0KKyAgICAgICAg ICAgIDwvdGQ+CiAgICAgICAgIDwvdHI+CiAgICAgICAgIHslIGVuZGZvciAlfQogICAgIDwvdGFi bGU+CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9xdWV1ZV9zdGF0 dXMucHkgYi9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9xdWV1ZV9zdGF0dXMucHkKaW5k ZXggNjUxOTdiYi4uZmM0NTdhYiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNT ZXJ2ZXIvcXVldWVfc3RhdHVzLnB5CisrKyBiL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVy L3F1ZXVlX3N0YXR1cy5weQpAQCAtMTQ1LDcgKzE0NSw3IEBAIGNsYXNzIFVwZGF0ZVN0YXR1cyh3 ZWJhcHAuUmVxdWVzdEhhbmRsZXIpOgogICAgICAgICBxdWV1ZV9zdGF0dXMuYWN0aXZlX3BhdGNo X2lkID0gc2VsZi5faW50X2Zyb21fcmVxdWVzdCgncGF0Y2hfaWQnKQogICAgICAgICBxdWV1ZV9z dGF0dXMubWVzc2FnZSA9IHNlbGYucmVxdWVzdC5nZXQoJ3N0YXR1cycpCiAgICAgICAgIHJlc3Vs dHNfZmlsZSA9IHNlbGYucmVxdWVzdC5nZXQoInJlc3VsdHNfZmlsZSIpCi0gICAgICAgIHF1ZXVl X3N0YXR1cy5yZXN1bHRzX2ZpbGUgPSBkYi5CbG9iKHJlc3VsdHNfZmlsZSkKKyAgICAgICAgcXVl dWVfc3RhdHVzLnJlc3VsdHNfZmlsZSA9IGRiLkJsb2Ioc3RyKHJlc3VsdHNfZmlsZSkpCiAgICAg ICAgIHF1ZXVlX3N0YXR1cy5wdXQoKQogICAgICAgICBzZWxmLnJlZGlyZWN0KCcvJykKIApkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3F1ZXVlcy5weSBi L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWV1ZXMucHkKaW5kZXggMWU0 YjMzMS4uYzE0Mjc2OSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2Nv bW1hbmRzL3F1ZXVlcy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFu ZHMvcXVldWVzLnB5CkBAIC0xNDcsNyArMTQ3LDkgQEAgY2xhc3MgQ29tbWl0UXVldWUoQWJzdHJh Y3RRdWV1ZSwgU3RlcFNlcXVlbmNlRXJyb3JIYW5kbGVyKToKIAogICAgIEBjbGFzc21ldGhvZAog ICAgIGRlZiBoYW5kbGVfc2NyaXB0X2Vycm9yKGNscywgdG9vbCwgc3RhdGUsIHNjcmlwdF9lcnJv cik6Ci0gICAgICAgIHRvb2wuYnVncy5yZWplY3RfcGF0Y2hfZnJvbV9jb21taXRfcXVldWUoc3Rh dGVbInBhdGNoIl1bImlkIl0sIHNjcmlwdF9lcnJvci5tZXNzYWdlX3dpdGhfb3V0cHV0KCkpCisg ICAgICAgIHBhdGNoID0gc3RhdGVbInBhdGNoIl0KKyAgICAgICAgdG9vbC5zdGF0dXNfYm90LnVw ZGF0ZV9zdGF0dXMoY2xzLm5hbWUsICJwYXRjaCAlcyBmYWlsZWQ6ICVzIiAlIChwYXRjaFsnaWQn XSwgc2NyaXB0X2Vycm9yLm1lc3NhZ2UpLCBwYXRjaCwgU3RyaW5nSU8oc2NyaXB0X2Vycm9yLm91 dHB1dCkpCisgICAgICAgIHRvb2wuYnVncy5yZWplY3RfcGF0Y2hfZnJvbV9jb21taXRfcXVldWUo cGF0Y2hbImlkIl0sIHNjcmlwdF9lcnJvci5tZXNzYWdlX3dpdGhfb3V0cHV0KCkpCiAKIAogY2xh c3MgQWJzdHJhY3RSZXZpZXdRdWV1ZShBYnN0cmFjdFF1ZXVlLCBQZXJzaXN0ZW50UGF0Y2hDb2xs ZWN0aW9uRGVsZWdhdGUsIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlcik6Cg==