28273 2009-08-13 12:23:08 -0700 [QT] revert the temporary S60 RVCT elftran workaround in qwebview.h when the right symbol is exported from Qt lib. 2009-12-14 02:00:28 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P2 Minor --- 27065 1 yongjun.zhang webkit-unassigned commit-queue hausmann koshuin laszlo.gombos norbert.leser webkit.review.bot oldest_to_newest 139966 0 yongjun.zhang 2009-08-13 12:23:08 -0700 A temporary fix is introduced in https://bugs.webkit.org/show_bug.cgi?id=28181; it should be reverted when the right symbol is exported. 162753 1 laszlo.gombos 2009-11-11 18:26:31 -0800 Is this fix in Qt 4.6 now ? Is it time to revert ? 167121 2 hausmann 2009-11-29 15:59:57 -0800 (In reply to comment #1) > Is this fix in Qt 4.6 now ? Is it time to revert ? Yes, it's fixed in Qt 4.6 and the fix is part of Qt 4.6.0: http://qt.gitorious.org/qt/qt/commit/8d0b487437e731ff3f5f97779002a4ffb48d92ec Unfortunately we missed this revert in WebKit for 4.6.0, but we should still do it in the trunk of course :) 171139 3 44746 hausmann 2009-12-12 16:19:37 -0800 Created attachment 44746 Patch 171140 4 webkit.review.bot 2009-12-12 16:22:50 -0800 style-queue ran check-webkit-style on attachment 44746 without any errors. 171176 5 44746 commit-queue 2009-12-13 01:31:49 -0800 Comment on attachment 44746 Patch Clearing flags on attachment: 44746 Committed r52065: <http://trac.webkit.org/changeset/52065> 171177 6 commit-queue 2009-12-13 01:31:54 -0800 All reviewed patches have been landed. Closing bug. 171319 7 hausmann 2009-12-14 02:00:28 -0800 I was talking rubbish: Of course we can include this in 4.6.x, as it doesn not affect the number of exported symbols at all. Cherry-picked as commit 488a95f395a49bdd781d878891b45c61b450404a 44746 2009-12-12 16:19:37 -0800 2009-12-13 01:31:49 -0800 Patch bug-28273-20091213011935.patch text/plain 1582 hausmann ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnZpZXcuaCBiL1dlYktpdC9xdC9BcGkvcXdl YnZpZXcuaAppbmRleCBkNzkxMGQ5Li5mNjgxZmJjIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBp L3F3ZWJ2aWV3LmgKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vidmlldy5oCkBAIC00OSwxMiArNDks NyBAQCBjbGFzcyBRV0VCS0lUX0VYUE9SVCBRV2ViVmlldyA6IHB1YmxpYyBRV2lkZ2V0IHsKICAg ICBRX1BST1BFUlRZKHFyZWFsIHRleHRTaXplTXVsdGlwbGllciBSRUFEIHRleHRTaXplTXVsdGlw bGllciBXUklURSBzZXRUZXh0U2l6ZU11bHRpcGxpZXIgREVTSUdOQUJMRSBmYWxzZSkKICAgICBR X1BST1BFUlRZKHFyZWFsIHpvb21GYWN0b3IgUkVBRCB6b29tRmFjdG9yIFdSSVRFIHNldFpvb21G YWN0b3IpCiAKLS8vIEZJWE1FOiB0ZW1wb3Jhcnkgd29yayBhcm91bmQgZm9yIGVsZnRyYW4gaXNz dWUgdGhhdCBpdCBjb3VsZG4ndCBmaW5kIHRoZSBRUGFpbnRlcjo6c3RhdGljTWV0YU9iamVjdAot Ly8gc3ltYm9sIGZyb20gUXQgbGliOyBpdCBzaG91bGQgYmUgcmV2ZXJ0ZWQgYWZ0ZXIgdGhlIHJp Z2h0IHN5bWJvbCBpcyBleHBvcnRlZC4gIAotLy8gU2VlIGJ1ZzogaHR0cDovL3F0Lm5va2lhLmNv bS9kZXZlbG9wZXIvdGFzay10cmFja2VyL2luZGV4X2h0bWw/bWV0aG9kPWVudHJ5JmlkPTI1ODg5 MwotI2lmIGRlZmluZWQoUV9RRE9DKSB8fCAhZGVmaW5lZChRX09TX1NZTUJJQU4pCiAgICAgUV9Q Uk9QRVJUWShRUGFpbnRlcjo6UmVuZGVySGludHMgcmVuZGVySGludHMgUkVBRCByZW5kZXJIaW50 cyBXUklURSBzZXRSZW5kZXJIaW50cykKLSNlbmRpZgogICAgIFFfRkxBR1MoUVBhaW50ZXI6OlJl bmRlckhpbnRzKQogcHVibGljOgogICAgIGV4cGxpY2l0IFFXZWJWaWV3KFFXaWRnZXQqIHBhcmVu dCA9IDApOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFu Z2VMb2cKaW5kZXggNTM2OWU1Yy4uM2MxYmFmOCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5n ZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MTIgIFNpbW9uIEhhdXNtYW5uICA8aGF1c21hbm5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFJlLWVuYWJsZSBRV2ViVmll dzo6cmVuZGVySGludHMgcHJvcGVydHkgZm9yIFF0IGZvciBTeW1iaWFuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4MjczCisKKyAgICAgICAgVGhl IGJ1ZyBpbiBRdCdzIG1vYyB0aGF0IHRyaWdnZXJlZCBhIGxpbmtpbmcgZXJyb3Igd2hlbiBkZWNs YXJpbmcgdGhpcworICAgICAgICBwcm9wZXJ0eSBoYXMgYmVlbiBmaXhlZCBhbmQgd2UgY2FuIHJl bW92ZSB0aGUgd29ya2Fyb3VuZC4KKworICAgICAgICAqIEFwaS9xd2Vidmlldy5oOgorCiAyMDA5 LTEyLTExICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkIGJ1aWxkIGZpeCBmb3IgUXQgdmVyc2lvbnMgPCA0LjYuCg==